From nobody Mon Feb 9 20:35:15 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109565+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109565+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1697101867; cv=none; d=zohomail.com; s=zohoarc; b=Lx2P47MLyOm7eGZSZlJwU6o+3g+ctuAKTui2SjNs5/tRYJWdM9POVx957Yabm1EVmyYsqV9pcihhh+SeUmWjrHLSgBj23yzDR9lU//E2+MSF9xKM6OR9SzT2gEgDxlh9Jlo4S69zNQQJKUuB8Zo4MX3A3TD/OVIA44QckjQ8svg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697101867; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=4FtgdtxajTHa8SlLU9SBIoGbDcTxydGZRly5sHTTr0A=; b=PzHOepqm39CU7Y31EuYepakzpNzq8qRNavjq59y+gLsnwID59diBaYDri/jotUT/FAzJJNGsW17kTb3s1zOgSDHM3T5ilfZa9yQ85hkevHaWlIOmC/n/RPhS7c74yq1evgPUxnKhnysN1XNkCMbwTs09BEFZyKVlkVHx9Q6yhac= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109565+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1697101867874945.7335913893878; Thu, 12 Oct 2023 02:11:07 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=4FtgdtxajTHa8SlLU9SBIoGbDcTxydGZRly5sHTTr0A=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1697101867; v=1; b=fWpcqslTQa+c3Ym4vnKO3+/EmehnaezwRzA1OGFSGTCxKERMO1gwmQu0L8K8emA4yTgDVcgO l47sown8HcApAvjpyxVu+FUjgDBn3jncdIZq6aNhv7gCj5iUZ6X0FHq6VURIwU1UGEu64WHeiZz c8jynLGfoE/Bm1iHh89hfG7I= X-Received: by 127.0.0.2 with SMTP id QFMlYY1788612xxQNFXeR6KM; Thu, 12 Oct 2023 02:11:07 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.7114.1697101866946270629 for ; Thu, 12 Oct 2023 02:11:07 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-652-l0pdlC_LPwmKwlOl8QVSDg-1; Thu, 12 Oct 2023 05:11:02 -0400 X-MC-Unique: l0pdlC_LPwmKwlOl8QVSDg-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 85E8780349A; Thu, 12 Oct 2023 09:11:02 +0000 (UTC) X-Received: from lacos-laptop-9.usersys.redhat.com (unknown [10.39.192.186]) by smtp.corp.redhat.com (Postfix) with ESMTP id 83D7340C6F79; Thu, 12 Oct 2023 09:11:01 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Abner Chang , Ard Biesheuvel , Daniel Schaefer , Leif Lindholm Subject: [edk2-devel] [PATCH 3/5] EmbeddedPkg/TemplateRealTimeClockLib: drop LibRtcVirtualNotifyEvent Date: Thu, 12 Oct 2023 11:10:55 +0200 Message-Id: <20231012091057.108728-4-lersek@redhat.com> In-Reply-To: <20231012091057.108728-1-lersek@redhat.com> References: <687bbaf5-3c2b-6d27-44a5-d19541ce97bd@redhat.com> <20231012091057.108728-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: REcBZQogs6QmuVnOIp8FZh6Yx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1697101869683100018 Content-Type: text/plain; charset="utf-8"; x-default="true" The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their SetVirtualAddressMap() notification functions. In particular, TemplateRealTimeClockLib *itself* doesn't even use LibRtcVirtualNotifyEvent() -- the function is defined with an empty body, clearly in an understandable, but misguided, attempt, to conform to the (bogus) library interface. Remove the function. Build-tested only (with "EmbeddedPkg.dsc"). Cc: Abner Chang Cc: Ard Biesheuvel Cc: Daniel Schaefer Cc: Leif Lindholm Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4564 Signed-off-by: Laszlo Ersek --- EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c | 24 -----= --------------- 1 file changed, 24 deletions(-) diff --git a/EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.= c b/EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c index cb5025914e3f..4e0f52ef7bce 100644 --- a/EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c +++ b/EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c @@ -133,27 +133,3 @@ LibRtcInitialize ( // return EFI_SUCCESS; } - -/** - Fixup internal data so that EFI can be call in virtual mode. - Call the passed in Child Notify event and convert any pointers in - lib to virtual mode. - - @param[in] Event The Event that is being processed - @param[in] Context Event Context -**/ -VOID -EFIAPI -LibRtcVirtualNotifyEvent ( - IN EFI_EVENT Event, - IN VOID *Context - ) -{ - // - // Only needed if you are going to support the OS calling RTC functions = in virtual mode. - // You will need to call EfiConvertPointer (). To convert any stored phy= sical addresses - // to virtual address. After the OS transitions to calling in virtual mo= de, all future - // runtime calls will be made in virtual mode. - // - return; -} -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109565): https://edk2.groups.io/g/devel/message/109565 Mute This Topic: https://groups.io/mt/101914680/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076= /xyzzy [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-