From nobody Mon Feb 9 20:46:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109564+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109564+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1697101866; cv=none; d=zohomail.com; s=zohoarc; b=KnEVdh9Gdeux8gINoVsT1oUSMa4AZEtLUtS1HvgduBQnE3KqCmyFSW7XPoFlMuXkc/OZlNKfpteniOjzb/ArEDN062LEu0kik64ub4B5iBbVuJbxQ7C2CbLW8aNve8dIf51JkETrzvVY0L7VULsnZ6z3A2OE1T4cqG9o1xdK6I8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697101866; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=4Twk+r2suV1LDyOGWK0yVRUbijtIhguZUd01hrCugbU=; b=RInW1Ti+XU3G9WHbYOAmEb5+OICDEde+sjOLTXMHP5tmgJJqzh5emoiPY5BbH5IVZdPqGSvAvVdmJgp2LXbUkWCSd0pgGDkLAdGRfzZVXXn0TpHzRZy8gd8L1UYoTVQ0DcteGlYf/kKOmJoP1jHc4HgIbnpcqFkrmA5ONRbqpB4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109564+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1697101866650357.72540638003807; Thu, 12 Oct 2023 02:11:06 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=4Twk+r2suV1LDyOGWK0yVRUbijtIhguZUd01hrCugbU=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1697101866; v=1; b=lJguTdkSYaJyUaO+oovyeYlEG7bmAFUwfEILBDI4h5tyOJzdiFAArbI35Udt+AwjEaSQa2+q VE9ylreKWvFUh+QGMYv1Kk7bj3UP/yQCvgH49sDXOP0/enZFbIZt51PYFwl7BWCW4SB3XxuFflq oDIZ/ySWmGq+w/NuwWSxB8iU= X-Received: by 127.0.0.2 with SMTP id QquMYY1788612xEUrEAEEZ5K; Thu, 12 Oct 2023 02:11:06 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.7112.1697101865687076195 for ; Thu, 12 Oct 2023 02:11:05 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-467-BEsVCQ7fOWybbQL0i-FFfQ-1; Thu, 12 Oct 2023 05:11:01 -0400 X-MC-Unique: BEsVCQ7fOWybbQL0i-FFfQ-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 411F73C0F236; Thu, 12 Oct 2023 09:11:01 +0000 (UTC) X-Received: from lacos-laptop-9.usersys.redhat.com (unknown [10.39.192.186]) by smtp.corp.redhat.com (Postfix) with ESMTP id 848C840C6F7F; Thu, 12 Oct 2023 09:11:00 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Ard Biesheuvel , Leif Lindholm Subject: [edk2-devel] [PATCH 2/5] ArmPlatformPkg/PL031RealTimeClockLib: hide LibRtcVirtualNotifyEvent Date: Thu, 12 Oct 2023 11:10:54 +0200 Message-Id: <20231012091057.108728-3-lersek@redhat.com> In-Reply-To: <20231012091057.108728-1-lersek@redhat.com> References: <687bbaf5-3c2b-6d27-44a5-d19541ce97bd@redhat.com> <20231012091057.108728-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 9Hp2ndeQwi3vSnKAVfOZOjCrx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1697101867752100011 Content-Type: text/plain; charset="utf-8"; x-default="true" The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their SetVirtualAddressMap() notification functions. Rename LibRtcVirtualNotifyEvent() to VirtualNotifyEvent(), and make it static, in preparation for removing the LibRtcVirtualNotifyEvent() declaration from the lib class header later. Build- and boot-tested with ArmVirtQemu. Cc: Ard Biesheuvel Cc: Leif Lindholm Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4564 Signed-off-by: Laszlo Ersek Reviewed-by: Sami Mujawar --- ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c | 5 += ++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeCloc= kLib.c b/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib= .c index ec7feaeedcf8..9e852696d2fd 100644 --- a/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c +++ b/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c @@ -274,9 +274,10 @@ LibSetWakeupTime ( @param[in] Event The Event that is being processed @param[in] Context Event Context **/ +STATIC VOID EFIAPI -LibRtcVirtualNotifyEvent ( +VirtualNotifyEvent ( IN EFI_EVENT Event, IN VOID *Context ) @@ -346,7 +347,7 @@ LibRtcInitialize ( Status =3D gBS->CreateEventEx ( EVT_NOTIFY_SIGNAL, TPL_NOTIFY, - LibRtcVirtualNotifyEvent, + VirtualNotifyEvent, NULL, &gEfiEventVirtualAddressChangeGuid, &mRtcVirtualAddrChangeEvent -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109564): https://edk2.groups.io/g/devel/message/109564 Mute This Topic: https://groups.io/mt/101914679/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076= /xyzzy [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-