From nobody Mon Feb 9 19:30:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109562+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109562+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1697101863; cv=none; d=zohomail.com; s=zohoarc; b=QdYiEJsNPXampkgMYgWP4ogpDqDrGbYaE1KE5196NCJxQ/X2Be+KSU8U299mwTK/P/ZNptuvmRCEAJd2FSR+V9Gaz5GLbsKqTxUjfDG1dUxxqWxDAcYhYHgPq1QrJJxdQ+c3Wc6sraDFfQ52a4Ixe/04wOj/HFSkzeMKJPdWrjg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697101863; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=SLLtJkfE6EvAIwRXC/5x+jk5xDkdKaav2VGHW+coJL8=; b=ZSBmBCAmXHr+x9r9XYDthL3z7IPbtsHRWonQxO2nwvb712jLX17n5ax5OCLVovpoaqkMX4Qn5U4ei4yWc1alRmiAlEkPWeeN4nEsbaYcmSkIWfEMsW+g5CtWm+ENwmpdPktTlRz7gfmnSVpJ9mU8kXXgG6v8gEKwi5nll0YkxqY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109562+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1697101863685975.7795993906242; Thu, 12 Oct 2023 02:11:03 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=SLLtJkfE6EvAIwRXC/5x+jk5xDkdKaav2VGHW+coJL8=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1697101863; v=1; b=bRUyiCb0pBd0I9gmktCMiAtAfQ96ZdPTsZr0gNxwcw2WEgVdlzDnNbGBm3tROh2PcS2I0SQG Kzjq61JPBg/T78IyItP3TFQc7wX/F5aTemcf79g4fOMBi31HPxpGjQSkzF19ZrRHdHe2J+lura1 senX8FR0rL1IihnrUsyW+erE= X-Received: by 127.0.0.2 with SMTP id CEnpYY1788612xuFpdX7xdEF; Thu, 12 Oct 2023 02:11:03 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.7214.1697101862743993948 for ; Thu, 12 Oct 2023 02:11:02 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-142-az58jJ95MUivKaDsni18Tw-1; Thu, 12 Oct 2023 05:11:00 -0400 X-MC-Unique: az58jJ95MUivKaDsni18Tw-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 421621C06EC6; Thu, 12 Oct 2023 09:11:00 +0000 (UTC) X-Received: from lacos-laptop-9.usersys.redhat.com (unknown [10.39.192.186]) by smtp.corp.redhat.com (Postfix) with ESMTP id A773A40C6F7F; Thu, 12 Oct 2023 09:10:59 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Ray Ni Subject: [edk2-devel] [PATCH 1/5] PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: rename LibRtcVirtualNotifyEvent Date: Thu, 12 Oct 2023 11:10:53 +0200 Message-Id: <20231012091057.108728-2-lersek@redhat.com> In-Reply-To: <20231012091057.108728-1-lersek@redhat.com> References: <687bbaf5-3c2b-6d27-44a5-d19541ce97bd@redhat.com> <20231012091057.108728-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: oeW7nZlk2AyXz3uxYFFD07bGx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1697101865645100005 Content-Type: text/plain; charset="utf-8"; x-default="true" PcatRealTimeClockRuntimeDxe seems to have copied the interface name LibRtcVirtualNotifyEvent() from EmbeddedPkg's RealTimeClockLib class. That's not right, for two reasons: - PcatRealTimeClockRuntimeDxe doesn't consume "EmbeddedPkg.dec" in the first place, - in EmbeddedPkg, the RealTimeClockLib class API LibRtcVirtualNotifyEvent() is about to be eliminated (it's a bogus API). Rename the LibRtcVirtualNotifyEvent() function to VirtualNotifyEvent(), and make it static. Tested with booting OVMF. Cc: Ray Ni Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4564 Signed-off-by: Laszlo Ersek Reviewed-by: Sami Mujawar Tested-by: Sami Mujawar --- PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c b/PcAt= ChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c index b600df487952..ca0cad9b0198 100644 --- a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c +++ b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c @@ -122,9 +122,10 @@ PcRtcEfiSetWakeupTime ( @param[in] Event The Event that is being processed @param[in] Context Event Context **/ +STATIC VOID EFIAPI -LibRtcVirtualNotifyEvent ( +VirtualNotifyEvent ( IN EFI_EVENT Event, IN VOID *Context ) @@ -220,7 +221,7 @@ InitializePcRtc ( Status =3D gBS->CreateEventEx ( EVT_NOTIFY_SIGNAL, TPL_NOTIFY, - LibRtcVirtualNotifyEvent, + VirtualNotifyEvent, NULL, &gEfiEventVirtualAddressChangeGuid, &mVirtualAddrChangeEvent -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109562): https://edk2.groups.io/g/devel/message/109562 Mute This Topic: https://groups.io/mt/101914676/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076= /xyzzy [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-