From nobody Mon Feb 9 12:15:15 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109557+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109557+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1697101826; cv=none; d=zohomail.com; s=zohoarc; b=en6XAG/rZN/GKk3q3FKuyQ6AKxDCNhAN2QPmC4n9E4F0LqVGCE8VE7t5fITgXS/o7PQsuU+Ft1AwpB9xmCWRICPTR0JTVVnDWPbPQ4DMWWmOWXqOcYInxX98U7bjwCudTLYUteQd2Aq5D5NVWLq+TLM2BoWgfYI+nc1zDcqmNZI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697101826; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=asG8vasis1U2cLr6M/edICoPUP6unHTuobJcMOJOW/8=; b=WhsI/UE8fN2TMyXMgPrUg4app30O6EtK6lYczzvRqi8fAvPryRvrjJCMQSw1FPK12KbZpwX9GrsaYmuRgJ+balm/RHCC3WzXCYPKlA4Z95R/CjFfgI9OC665gkrX4lZRpWm8jYYQov7ws34tHalHDFfS9X3ASVgR5HWIPMHqn0U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109557+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1697101826570170.31092989826766; Thu, 12 Oct 2023 02:10:26 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=asG8vasis1U2cLr6M/edICoPUP6unHTuobJcMOJOW/8=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1697101826; v=1; b=jklKVv16++3RjcdRi6oTBqeLWOhk1b7jNm/LZP0qvx5fsDXoKiKHODiGrOic55s7CPe+byvg OTfeo8e4y424qzHoCM44m0eQ/ynLVvJEg7EEWd34SOOA1FDGHg08ucxHcJ50gKqzQDrDDIdxY6q RXENulXvoO2w50ZcDZZGKIe8= X-Received: by 127.0.0.2 with SMTP id AAQsYY1788612x8gsOfhdGx0; Thu, 12 Oct 2023 02:10:26 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.7203.1697101825610919617 for ; Thu, 12 Oct 2023 02:10:25 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-606-WNZlyLI4PYiE9XWBxLso2Q-1; Thu, 12 Oct 2023 05:10:16 -0400 X-MC-Unique: WNZlyLI4PYiE9XWBxLso2Q-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0897B800045; Thu, 12 Oct 2023 09:10:16 +0000 (UTC) X-Received: from lacos-laptop-9.usersys.redhat.com (unknown [10.39.192.186]) by smtp.corp.redhat.com (Postfix) with ESMTP id 067A940C6F79; Thu, 12 Oct 2023 09:10:14 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Leif Lindholm , Ling Jia , Peng Xie , Yiqi Shu Subject: [edk2-devel] [edk2-platforms PATCH 18/19] FT2000-4Pkg/RealTimeClockLib: hide LibRtcVirtualNotifyEvent Date: Thu, 12 Oct 2023 11:09:49 +0200 Message-Id: <20231012090950.108577-19-lersek@redhat.com> In-Reply-To: <20231012090950.108577-1-lersek@redhat.com> References: <687bbaf5-3c2b-6d27-44a5-d19541ce97bd@redhat.com> <20231012090950.108577-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Ned1MMXqwEIeY19Qnwj6whf7x1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1697101827588100013 Content-Type: text/plain; charset="utf-8"; x-default="true" The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their SetVirtualAddressMap() notification functions. Rename LibRtcVirtualNotifyEvent() to VirtualNotifyEvent(), and make it static, in preparation for removing the LibRtcVirtualNotifyEvent() declaration from the lib class header later. Build-tested only (with "DurianPkg.dsc"). Cc: Leif Lindholm Cc: Ling Jia Cc: Peng Xie Cc: Yiqi Shu Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4564 Signed-off-by: Laszlo Ersek --- Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib.c | = 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeC= lockLib.c b/Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeCl= ockLib.c index 1c88958e3bb7..5c3d0cdccff8 100644 --- a/Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib= .c +++ b/Silicon/Phytium/FT2000-4Pkg/Library/RealTimeClockLib/RealTimeClockLib= .c @@ -307,9 +307,10 @@ LibSetWakeupTime ( @param[in] Context Event Context =20 **/ +STATIC VOID EFIAPI -LibRtcVirtualNotifyEvent ( +VirtualNotifyEvent ( IN EFI_EVENT Event, IN VOID *Context ) @@ -452,7 +453,7 @@ LibRtcInitialize ( Status =3D gBS->CreateEventEx ( EVT_NOTIFY_SIGNAL, TPL_NOTIFY, - LibRtcVirtualNotifyEvent, + VirtualNotifyEvent, NULL, &gEfiEventVirtualAddressChangeGuid, &mRtcVirtualAddrChangeEvent -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109557): https://edk2.groups.io/g/devel/message/109557 Mute This Topic: https://groups.io/mt/101914669/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076= /xyzzy [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-