From nobody Mon Feb 9 19:06:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109555+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109555+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1697101820; cv=none; d=zohomail.com; s=zohoarc; b=QqOWB9kAl4CtTz1N4abspCMD/CcRqOK6aIxJxgm1+hHtcNyQXOj3O7RsrTMfO1GwOzmLTmrHZmTXFqos6rjJW8nmNARNK5McLngI9ZvmZMvABcJ3+c889Bo7XzpwUxPryQgQM4Bb4IL4TIcmCzCHpYqAGLIub5H5w7niC+dZc0k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697101820; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=vmBJn2ilIbCSPUgUplLO6ir60U1N0/4wXZTT54/695M=; b=nuaQyOU996ivmaNuUoyEL5sxc54ypuUZMr9FcWdSONODtH3PuE9pj1j9+1GCAoVJ8r+/sVD6OFkqTu+2TI1mItsJgVTLNRWsqADVhPIuahDjs5rw5xlYLZ0w0e469EfCwP+IB6eFO5MlpRIxLrdB60e6WIkPNxVvmceivQ+99Ek= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109555+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1697101820942829.9128475964658; Thu, 12 Oct 2023 02:10:20 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=vmBJn2ilIbCSPUgUplLO6ir60U1N0/4wXZTT54/695M=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1697101820; v=1; b=twJ6Ig9LrH2JS+NX0EnmEedC9CxuzjXmn/0HSBz9sA1vjL+0maOItYKrH1gurvmzfrxFMj0O yFEBqSZ52PtZRPzJAXCC2VAFuMpzssKMQJHiAndaYlaCMN4es5NGjMria9eEPA8zgfxWXnwccsx fnOWrTZ/XCYK0b7StCKe20kk= X-Received: by 127.0.0.2 with SMTP id JK2hYY1788612xFYotVm0u35; Thu, 12 Oct 2023 02:10:20 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.7089.1697101819918631966 for ; Thu, 12 Oct 2023 02:10:20 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-640-P1w769sRPMuEf05A5hePJQ-1; Thu, 12 Oct 2023 05:10:15 -0400 X-MC-Unique: P1w769sRPMuEf05A5hePJQ-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B81B28030CB; Thu, 12 Oct 2023 09:10:14 +0000 (UTC) X-Received: from lacos-laptop-9.usersys.redhat.com (unknown [10.39.192.186]) by smtp.corp.redhat.com (Postfix) with ESMTP id B634840C6F79; Thu, 12 Oct 2023 09:10:13 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Ard Biesheuvel , Leif Lindholm , Masami Hiramatsu , Meenakshi Aggarwal Subject: [edk2-devel] [edk2-platforms PATCH 17/19] NXP/Pcf8563RealTimeClockLib: hide LibRtcVirtualNotifyEvent Date: Thu, 12 Oct 2023 11:09:48 +0200 Message-Id: <20231012090950.108577-18-lersek@redhat.com> In-Reply-To: <20231012090950.108577-1-lersek@redhat.com> References: <687bbaf5-3c2b-6d27-44a5-d19541ce97bd@redhat.com> <20231012090950.108577-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Ku5kZ6XXL5wqwPb6h0PsE4k2x1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1697101821524100002 Content-Type: text/plain; charset="utf-8"; x-default="true" The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their SetVirtualAddressMap() notification functions. Rename LibRtcVirtualNotifyEvent() to VirtualNotifyEvent(), and make it static, in preparation for removing the LibRtcVirtualNotifyEvent() declaration from the lib class header later. Build-tested only (with "DeveloperBox.dsc"). Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Masami Hiramatsu Cc: Meenakshi Aggarwal Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4564 Signed-off-by: Laszlo Ersek --- Silicon/NXP/Library/Pcf8563RealTimeClockLib/Pcf8563RealTimeClockLib.c | 5 = +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Silicon/NXP/Library/Pcf8563RealTimeClockLib/Pcf8563RealTimeClo= ckLib.c b/Silicon/NXP/Library/Pcf8563RealTimeClockLib/Pcf8563RealTimeClockL= ib.c index b79ea89fea0f..ac68c0396776 100644 --- a/Silicon/NXP/Library/Pcf8563RealTimeClockLib/Pcf8563RealTimeClockLib.c +++ b/Silicon/NXP/Library/Pcf8563RealTimeClockLib/Pcf8563RealTimeClockLib.c @@ -339,9 +339,10 @@ I2cMasterRegistrationEvent ( @param[in] Event The Event that is being processed @param[in] Context Event Context **/ +STATIC VOID EFIAPI -LibRtcVirtualNotifyEvent ( +VirtualNotifyEvent ( IN EFI_EVENT Event, IN VOID *Context ) @@ -394,7 +395,7 @@ LibRtcInitialize ( // Register for the virtual address change event // Status =3D gBS->CreateEventEx (EVT_NOTIFY_SIGNAL, TPL_NOTIFY, - LibRtcVirtualNotifyEvent, NULL, + VirtualNotifyEvent, NULL, &gEfiEventVirtualAddressChangeGuid, &mRtcVirtualAddrChangeEvent); ASSERT_EFI_ERROR (Status); -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109555): https://edk2.groups.io/g/devel/message/109555 Mute This Topic: https://groups.io/mt/101914667/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076= /xyzzy [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-