From nobody Mon Feb 9 19:53:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109558+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109558+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1697101827; cv=none; d=zohomail.com; s=zohoarc; b=hBgG1oeJ7cGQ/z9IuFRJDapCjjbGezxqU9ZBVhMwXNePPosVCfLd9RZCqvC7NfYPV4KmocnLoW9jYjVlz+i8VYseziZZZcoLF48IrRnZ2g+0pHE5Mn60oYVJpono1sdp7Kpl7bukIQtS7n8Ieki09UPKHmqpRBgIGqJI9+CWs7s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697101827; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=cjafZA75drEoe6qDeZzA2lBUfEXlm+hLxpZFKPPozSU=; b=NQ9PU7CmTtVxQTlPq+Emz0oMf0uHs819AgepJXgV3UkZ6ppCmrbeTAytRwZtBHjr+88Cj0/rXffJLLGEhDcAUA6FuRKC/6Ea2dW1JtJY4aZuJhzh0Y9uf6VjR05drHr1k+wG+wCrP48uLP+AejL6gm8G1NtVM14PfruooYKB7rk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109558+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1697101827180524.4811488110034; Thu, 12 Oct 2023 02:10:27 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=cjafZA75drEoe6qDeZzA2lBUfEXlm+hLxpZFKPPozSU=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1697101826; v=1; b=HqwCQhk3Lu2h15fv+t0V8sgcaSsOA2BcjfITICYxK196SLtMhAJMNTGQKZpQy8yA7fZGXVeh BWwfhjEj7A8MdKVxFDCC5jBc3Sjcam6w8VYhLG1cq/ioXyQZO38HoRUQuyav2Vw1/zTH2WvhIuL yrcRs2qwQMfv77y+k7/VdPFA= X-Received: by 127.0.0.2 with SMTP id bliKYY1788612xCA3LQfqGnX; Thu, 12 Oct 2023 02:10:26 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.7095.1697101826311188439 for ; Thu, 12 Oct 2023 02:10:26 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-153-2qoPcJREMLqH5U76uHRt_g-1; Thu, 12 Oct 2023 05:10:13 -0400 X-MC-Unique: 2qoPcJREMLqH5U76uHRt_g-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 73844811E7E; Thu, 12 Oct 2023 09:10:13 +0000 (UTC) X-Received: from lacos-laptop-9.usersys.redhat.com (unknown [10.39.192.186]) by smtp.corp.redhat.com (Postfix) with ESMTP id B713740C6F79; Thu, 12 Oct 2023 09:10:12 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Leif Lindholm , Marcin Wojtas Subject: [edk2-devel] [edk2-platforms PATCH 16/19] Armada7k8k/RealTimeClockLib: hide LibRtcVirtualNotifyEvent Date: Thu, 12 Oct 2023 11:09:47 +0200 Message-Id: <20231012090950.108577-17-lersek@redhat.com> In-Reply-To: <20231012090950.108577-1-lersek@redhat.com> References: <687bbaf5-3c2b-6d27-44a5-d19541ce97bd@redhat.com> <20231012090950.108577-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: gakDZFo23Iy7kR4soYEiosgix1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1697101827612100014 Content-Type: text/plain; charset="utf-8"; x-default="true" The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their SetVirtualAddressMap() notification functions. Rename LibRtcVirtualNotifyEvent() to VirtualNotifyEvent(), and make it static, in preparation for removing the LibRtcVirtualNotifyEvent() declaration from the lib class header later. Also hoist the function definition above the reference. Build-tested only, with the following platforms: - Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc - Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc - Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc - Platform/SolidRun/Cn913xCEx7Eval/Cn913xCEx7Eval.dsc ("Platform/Marvell/Cn913xDb/Cn913xDbA.dsc" fails to build regardless: "build" complains that "Silicon/Marvell/OcteonTx/DeviceTree/T91/$(PLATFORM_NAME).inf" is missing, and as far as I can see, not even the "Silicon/Marvell/OcteonTx/DeviceTree" directory exists.) Cc: Leif Lindholm Cc: Marcin Wojtas Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4564 Signed-off-by: Laszlo Ersek Reviewed-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.c | 5= 2 ++++++++++---------- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeCl= ockLib.c b/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeCloc= kLib.c index 49c9385d53d6..d538b030b111 100644 --- a/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.c +++ b/Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.c @@ -205,6 +205,31 @@ LibSetWakeupTime ( return EFI_SUCCESS; } =20 +/** + Fixup internal data so that EFI can be call in virtual mode. + Call the passed in Child Notify event and convert any pointers in + lib to virtual mode. + + @param[in] Event The Event that is being processed + @param[in] Context Event Context +**/ +STATIC +VOID +EFIAPI +VirtualNotifyEvent ( + IN EFI_EVENT Event, + IN VOID *Context + ) +{ + // + // Only needed if you are going to support the OS calling RTC functions = in virtual mode. + // You will need to call EfiConvertPointer (). To convert any stored phy= sical addresses + // to virtual address. After the OS transistions to calling in virtual m= ode, all future + // runtime calls will be made in virtual mode. + // + EfiConvertPointer (0x0, (VOID**)&mArmadaRtcBase); +} + /** This is the declaration of an EFI image entry point. This can be the ent= ry point to an application written to this specification, an EFI boot service driver, or an EFI run= time driver. @@ -285,7 +310,7 @@ LibRtcInitialize ( Status =3D gBS->CreateEventEx ( EVT_NOTIFY_SIGNAL, TPL_NOTIFY, - LibRtcVirtualNotifyEvent, + VirtualNotifyEvent, NULL, &gEfiEventVirtualAddressChangeGuid, &mRtcVirtualAddrChangeEvent @@ -304,28 +329,3 @@ ErrSetMem: =20 return Status; } - - -/** - Fixup internal data so that EFI can be call in virtual mode. - Call the passed in Child Notify event and convert any pointers in - lib to virtual mode. - - @param[in] Event The Event that is being processed - @param[in] Context Event Context -**/ -VOID -EFIAPI -LibRtcVirtualNotifyEvent ( - IN EFI_EVENT Event, - IN VOID *Context - ) -{ - // - // Only needed if you are going to support the OS calling RTC functions = in virtual mode. - // You will need to call EfiConvertPointer (). To convert any stored phy= sical addresses - // to virtual address. After the OS transistions to calling in virtual m= ode, all future - // runtime calls will be made in virtual mode. - // - EfiConvertPointer (0x0, (VOID**)&mArmadaRtcBase); -} -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109558): https://edk2.groups.io/g/devel/message/109558 Mute This Topic: https://groups.io/mt/101914670/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076= /xyzzy [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-