From nobody Tue Feb 10 04:13:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109556+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109556+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1697101823; cv=none; d=zohomail.com; s=zohoarc; b=UvEEvj85k/TkqGwEF7fKoVZ1t7ZTje2tbEQj22HgCr/Mjhy5hYJZMeXRUpgsJWZWHpBpxi8OHoZ9jWZ0Y9h5/1RAVY42FEOLNrZ8SqMt/FIxp+FQ52qloSPqGqJWe+bCuw/dKmb8+U17/iFnP8zwQtZJEnrKTUMYEPtBBXMO+qc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697101823; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=aguQRVWrp5iugCcNkmXcosEKn+JU2vDxARCkig5U25I=; b=krYHBY1gauczmQEZvx3o4J+Zv5WAMREgL6uSnOz8uZ+LvMuOh7fsa2+P1jZW3RKHh5kgR3mv1MCSprgu+AIMMQlzUH0AEh3g36w7RBiZQd0AeGJ4OX5wbP9U+6FiEu0ingY3f0LIJZQZ3eyt+cFNvOz0JPYXBQA3eKEC89txmMg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109556+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1697101823563483.60173389801105; Thu, 12 Oct 2023 02:10:23 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=aguQRVWrp5iugCcNkmXcosEKn+JU2vDxARCkig5U25I=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1697101823; v=1; b=aJlaptD8VVrpKkL0lsbgJvMet/air0gcU6AXKhnnPZSYZowQTr6xlB6gksn8Qs9yoRUlu1Mo NqB5JGaXCU92l+SE7QyedtBucgPIwfQ65WXaumyVXFUoAaRrhfGc6LgupTPzxPa2BSuPPKHySog 6pAMtGs1Hi+ZVdzH19gnQVDo= X-Received: by 127.0.0.2 with SMTP id s6JRYY1788612xSnFWTvJ7AR; Thu, 12 Oct 2023 02:10:23 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.7201.1697101822666487032 for ; Thu, 12 Oct 2023 02:10:22 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-556-5gg8Ox_AMT-vzKKFUIJEVQ-1; Thu, 12 Oct 2023 05:10:10 -0400 X-MC-Unique: 5gg8Ox_AMT-vzKKFUIJEVQ-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5459C38145A1; Thu, 12 Oct 2023 09:10:10 +0000 (UTC) X-Received: from lacos-laptop-9.usersys.redhat.com (unknown [10.39.192.186]) by smtp.corp.redhat.com (Postfix) with ESMTP id 52BB040C6F7F; Thu, 12 Oct 2023 09:10:09 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Chuong Tran , Leif Lindholm , Nhi Pham , Rebecca Cran Subject: [edk2-devel] [edk2-platforms PATCH 13/19] JadePkg/PCF85063RealTimeClockLib: hide LibRtcVirtualNotifyEvent Date: Thu, 12 Oct 2023 11:09:44 +0200 Message-Id: <20231012090950.108577-14-lersek@redhat.com> In-Reply-To: <20231012090950.108577-1-lersek@redhat.com> References: <687bbaf5-3c2b-6d27-44a5-d19541ce97bd@redhat.com> <20231012090950.108577-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: LnhaUYG9kda4ZVKU3F9R9gJqx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1697101825527100011 Content-Type: text/plain; charset="utf-8"; x-default="true" The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their SetVirtualAddressMap() notification functions. Rename LibRtcVirtualNotifyEvent() to VirtualNotifyEvent(), and make it static, in preparation for removing the LibRtcVirtualNotifyEvent() declaration from the lib class header later. Build-tested only (with "Jade.dsc"). Cc: Chuong Tran Cc: Leif Lindholm Cc: Nhi Pham Cc: Rebecca Cran Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4564 Signed-off-by: Laszlo Ersek Reviewed-by: Nhi Pham --- Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063RealTimeC= lockLib.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85= 063RealTimeClockLib.c b/Platform/Ampere/JadePkg/Library/PCF85063RealTimeClo= ckLib/PCF85063RealTimeClockLib.c index ef8c71e92c18..1df781364bbc 100644 --- a/Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063Real= TimeClockLib.c +++ b/Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063Real= TimeClockLib.c @@ -201,9 +201,10 @@ LibSetWakeupTime ( @param[in] Event The Event that is being processed @param[in] Context Event Context **/ +STATIC VOID EFIAPI -LibRtcVirtualNotifyEvent ( +VirtualNotifyEvent ( IN EFI_EVENT Event, IN VOID *Context ) @@ -246,7 +247,7 @@ LibRtcInitialize ( Status =3D gBS->CreateEventEx ( EVT_NOTIFY_SIGNAL, TPL_NOTIFY, - LibRtcVirtualNotifyEvent, + VirtualNotifyEvent, NULL, &gEfiEventVirtualAddressChangeGuid, &mVirtualAddressChangeEvent -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109556): https://edk2.groups.io/g/devel/message/109556 Mute This Topic: https://groups.io/mt/101914668/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076= /xyzzy [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-