From nobody Mon Feb 9 19:53:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109551+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109551+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1697101814; cv=none; d=zohomail.com; s=zohoarc; b=is+I91KNXIL2LE918lk1DeQ/XfXU0/mIns1r4/atzTp6GzkkRHJeZByyqqTrHJOH0nzOvtGGoViAt3kyutNhfgkGYXOjbISBNcmlutBLT/wvyJ8aBbHI66T3ioPVDZp5UP0j59nqs4OWlyCMs8sTtnrcuVMM4D8bZcKNx5VSK8g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697101814; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=BmGvnL+WoZaRJwDc2be5/WuE3eaCEsw1pJn9xR9DGXQ=; b=P+s22kxmrZBOJ30qiZV+q7UKF6kYDuANKeIpqxf03f9qbE+QX4noNpBdT7Q6DVeTqbDzZigqNusc1G6qK/H+HdO7rfFueysVhbolI0xEKOmYLH50S4/E+HmY2rn4fx/+fvaOSXTCqcKfMvyBSQcNKAKupN2gKH65pFBgATox+Fk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109551+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1697101814616614.7746057523831; Thu, 12 Oct 2023 02:10:14 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=BmGvnL+WoZaRJwDc2be5/WuE3eaCEsw1pJn9xR9DGXQ=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1697101814; v=1; b=ZHdUKlxLWxNVPEDYNoHh+iYx8SPxBknHqgV/lxohKZZ4vhW3o9fVG+aY0g6XXzf5Pvutp/sZ tu5Ra08CvrHcIm41MFR+YvgNX4aUv40WF8/xE80l6emkgRHZViizE027Ef7OKNfXcPOe0Xcd4is BRo9Ky+d7tim77t9MoEm+Taw= X-Received: by 127.0.0.2 with SMTP id RlQRYY1788612xB6fLE9635k; Thu, 12 Oct 2023 02:10:14 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.7082.1697101813713915445 for ; Thu, 12 Oct 2023 02:10:13 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-664-BuzzhtD-OmiXIm47GoZK7A-1; Thu, 12 Oct 2023 05:10:09 -0400 X-MC-Unique: BuzzhtD-OmiXIm47GoZK7A-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 10BE13C1476B; Thu, 12 Oct 2023 09:10:09 +0000 (UTC) X-Received: from lacos-laptop-9.usersys.redhat.com (unknown [10.39.192.186]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0E7C440C6F79; Thu, 12 Oct 2023 09:10:07 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Chuong Tran , Leif Lindholm , Nhi Pham , Rebecca Cran Subject: [edk2-devel] [edk2-platforms PATCH 12/19] AmpereAltraPkg/Ac01PcieLib: fix compilation error Date: Thu, 12 Oct 2023 11:09:43 +0200 Message-Id: <20231012090950.108577-13-lersek@redhat.com> In-Reply-To: <20231012090950.108577-1-lersek@redhat.com> References: <687bbaf5-3c2b-6d27-44a5-d19541ce97bd@redhat.com> <20231012090950.108577-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: TRG3KPcETShmie3O014dMKc7x1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1697101815710100013 Content-Type: text/plain; charset="utf-8"; x-default="true" Commit 380b4b40c60d ("AmpereAltraPkg: Update Ampere specific platform PCIe core", 2023-03-29) removed the DEBUG macro call from Ac01PcieCoreUpdateLink() that was the only reader of "Val". Since then, Val has only been set, but never read. This triggers "-Werror=3Dunused-but-set-variable". Found when trying to build "Jade.dsc". Keep the MmioRead32() call, so that the PCIe config space sees the same behavior as before, but explicitly throw away the result. Cc: Chuong Tran Cc: Leif Lindholm Cc: Nhi Pham Cc: Rebecca Cran Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4564 Signed-off-by: Laszlo Ersek Reviewed-by: Nhi Pham --- Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c b= /Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c index 3c1fe5e35ca2..fa00c1e36999 100644 --- a/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c +++ b/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c @@ -1747,7 +1747,6 @@ Ac01PcieCoreUpdateLink ( PHYSICAL_ADDRESS CfgBase; UINT8 PcieIndex; UINT32 Index; - UINT32 Val; =20 *IsNextRoundNeeded =3D FALSE; *FailedPcieCount =3D 0; @@ -1767,7 +1766,7 @@ Ac01PcieCoreUpdateLink ( if (Pcie->Active && !Pcie->LinkUp) { if (PcieLinkUpCheck (Pcie)) { Pcie->LinkUp =3D TRUE; - Val =3D MmioRead32 (CfgBase + PCIE_CAPABILITY_BASE + LINK_CONTROL_= LINK_STATUS_REG); + (VOID)MmioRead32 (CfgBase + PCIE_CAPABILITY_BASE + LINK_CONTROL_LI= NK_STATUS_REG); =20 // Doing link checking and recovery if needed Ac01PcieCoreQoSLinkCheckRecovery (RootComplex, PcieIndex); -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109551): https://edk2.groups.io/g/devel/message/109551 Mute This Topic: https://groups.io/mt/101914660/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076= /xyzzy [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-