From nobody Sat May 18 16:18:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109520+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109520+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1697014661; cv=none; d=zohomail.com; s=zohoarc; b=NMKDzWX1qpvRh0iAoWDZGblExRSZG3oorNuCw1qfdxrmP6k8AHR+FDNIXuO7vkzDx0nBB6v5xUxO0lWa6CnFjr1TOskg72mYoanwHvHaaoxPT4WWkcY07QmHCDbNZ4UT89gRu2s41k2yRSd6pyYW0A3RuFoLOAUWU5M+8dq8am8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697014661; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Sender:Subject:Subject:To:To:Message-Id; bh=7jUGZOmbh/PSowE8gkA8+IXDHBzM9vK6qbk5cOevStk=; b=NhHFINCs4+YZsGFNM8LuzpfcBcIojxEUpailURxo8dy7k4R07XMICYAkWqZguP+LGGwgBz5mw+ZuHkOgjhJAOX1nwCBMYQRUZxdQ/ZCAZ29s6hJnyuSUbLjxJTYnvnM9RKqUX5V6UglI3/JqYn7T1O4O4hKGgzpqNb7eBqrCoCM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109520+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1697014661444870.6886895082066; Wed, 11 Oct 2023 01:57:41 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=VnMqi2/3dgjXFWtAyK6eCLobmohdgYzXqZ88x8+KP4M=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1697014661; v=1; b=YuraWgIx9sPDTRIHToYsySpGhMjOiXxzBvkVzHpH6L9S+D7qycNpYZ+hOii2d8U1HYOm45Bo EQFKaRYclzF/MC+Ref5M1Xm6vJaG/Xp7+r8u+6cYG6hlSUFPa9qipqIjo6bRdRCSN4Hl3e7FKZX gqgvvNTXi4B6PufHamfK2m3M= X-Received: by 127.0.0.2 with SMTP id AqP7YY1788612xSzWCBEz2XH; Wed, 11 Oct 2023 01:57:41 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.12342.1697014659927073961 for ; Wed, 11 Oct 2023 01:57:40 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10859"; a="387456242" X-IronPort-AV: E=Sophos;i="6.03,214,1694761200"; d="scan'208";a="387456242" X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2023 01:57:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10859"; a="819611047" X-IronPort-AV: E=Sophos;i="6.03,214,1694761200"; d="scan'208";a="819611047" X-Received: from shwdeopenlab705.ccr.corp.intel.com ([10.239.55.100]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2023 01:57:35 -0700 From: "Yuanhao Xie" To: devel@edk2.groups.io Cc: Yuanhao Xie , Eric Dong , Rahul Kumar , Gerd Hoffmann , Ray Ni Subject: [edk2-devel] [PATCH] UefiCpuPkg/CpuDxe: Eliminate the unused variable. Date: Wed, 11 Oct 2023 16:57:19 +0800 Message-Id: <20231011085719.1134-1-yuanhao.xie@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yuanhao.xie@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: OiInwUJuWsyOIHhtGva0fUaGx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1697014663221100001 Content-Type: text/plain; charset="utf-8" This change does not introduce any functional modifications. Recover the modification that was accidentally performanced during cherry-pick commit 1f78add. 1. Remove the unused variable. 2. reinstate the comment message. Signed-off-by: Yuanhao Xie Cc: Eric Dong Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Ray Ni --- UefiCpuPkg/CpuDxe/CpuDxe.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.c b/UefiCpuPkg/CpuDxe/CpuDxe.c index c5ac624f9e..a6497c91fb 100644 --- a/UefiCpuPkg/CpuDxe/CpuDxe.c +++ b/UefiCpuPkg/CpuDxe/CpuDxe.c @@ -15,15 +15,20 @@ // // Global Variables // -BOOLEAN InterruptState =3D FALSE; -EFI_HANDLE mCpuHandle =3D NULL; -BOOLEAN mIsFlushingGCD; -BOOLEAN mIsAllocatingPageTable =3D FALSE; -UINT64 mValidMtrrAddressMask; -UINT64 mValidMtrrBitsMask; -UINT64 mTimerPeriod =3D 0; -UINT32 mCpuTargetCState =3D 0; -EFI_CPU_ARCH_PROTOCOL gCpu =3D { +BOOLEAN InterruptState =3D FALSE; +EFI_HANDLE mCpuHandle =3D NULL; +BOOLEAN mIsFlushingGCD; +BOOLEAN mIsAllocatingPageTable =3D FALSE; +UINT64 mTimerPeriod =3D 0; +UINT32 mCpuTargetCState =3D 0; + +// +// A new writeble pagetable for non-smm. +// SystemMemory range is RW in this page table. +// +UINTN mWritablePageTable; + +EFI_CPU_ARCH_PROTOCOL gCpu =3D { CpuFlushCpuDataCache, CpuEnableInterrupt, CpuDisableInterrupt, --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109520): https://edk2.groups.io/g/devel/message/109520 Mute This Topic: https://groups.io/mt/101892967/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-