From nobody Mon Feb 9 12:08:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109410+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109410+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1696810079; cv=none; d=zohomail.com; s=zohoarc; b=OKTMO8fD35zIsnBWhJbBY9k/mjwIJKCT4XAJ2QnHAH1m1SAbcQPD4jvs3eMXrTYlaYENlExGkKc8KUS5LTpiOl51NvAJqxpObpuXzzXvMcm1l4cqf/r98p17Cr70eLb43f6ug9PapdwAzlldRyBR3WeBErbWNBxM/gaYqtIAJxQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1696810079; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=5YEimUe3Aawn0TH7xS/A89t0dGnUWsfMN/QILFVwvgc=; b=WCA1LYh8IKLsp9AIhuf83yYPwB4nzRgRZPsSKTW08lRi3IixDwm1f2QFoUUPxawuw5AInOkClI3y023ObMPOjf560GmR7XoEC73TP5lnazEtuWTa1cBqXwO0EpqScHhrD0rKDUU8zEBYRDyvyPC6wdEx9pgvdUC0Tg6qEKUX39E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109410+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1696810079673895.6563956544983; Sun, 8 Oct 2023 17:07:59 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=21hIuuFl2eMWgGJA4gdM9rqgBbPmEGQXZ6zYRvl3pC4=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1696810079; v=1; b=ihFsCrv4DNZETSqqazH3tTlOtYjxnaeI0X93IRSQ+SGSocjCZUJwA7jv5QkaSq/jUuSDeuSp Za7geCYkxUMjgCoOx7sxqJgfBZQCgRW/Me2o34zHEwdfFQP6e+M1OypwpKOkamYmfbHPRIt2L/D LES/GKJsRtpX6a2YZJFPo46Q= X-Received: by 127.0.0.2 with SMTP id wIGZYY1788612xeiR404abG5; Sun, 08 Oct 2023 17:07:59 -0700 X-Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by mx.groups.io with SMTP id smtpd.web11.50033.1696810078394531929 for ; Sun, 08 Oct 2023 17:07:58 -0700 X-Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-578b4981526so2485595a12.0 for ; Sun, 08 Oct 2023 17:07:58 -0700 (PDT) X-Gm-Message-State: vG8DeqgayoX4FIAMi8Z6f0Ghx1787277AA= X-Google-Smtp-Source: AGHT+IHZjfd/nNsL/fnanmNd9SzFEIhDq9DJfj49e+iygX0omgBG9JOcnXxsF8u6tvDn4HfDyFvxXg== X-Received: by 2002:a05:6a21:788d:b0:16b:79c2:877f with SMTP id bf13-20020a056a21788d00b0016b79c2877fmr6544209pzc.53.1696810077666; Sun, 08 Oct 2023 17:07:57 -0700 (PDT) X-Received: from localhost.localdomain ([50.46.253.1]) by smtp.gmail.com with ESMTPSA id t20-20020a62ea14000000b0068fcc7f6b00sm5048320pfh.74.2023.10.08.17.07.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Oct 2023 17:07:57 -0700 (PDT) From: "Taylor Beebe" To: devel@edk2.groups.io Cc: Jian J Wang , Liming Gao , Dandan Bi Subject: [edk2-devel] [PATCH v5 05/28] MdeModulePkg: Copy PEI PCD Database Into New Buffer Date: Sun, 8 Oct 2023 17:07:17 -0700 Message-ID: <20231009000742.1792-6-taylor.d.beebe@gmail.com> In-Reply-To: <20231009000742.1792-1-taylor.d.beebe@gmail.com> References: <20231009000742.1792-1-taylor.d.beebe@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,taylor.d.beebe@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1696810080265100013 Content-Type: text/plain; charset="utf-8" HOB memory should not be written to in DXE phase. This patch copies the PCD database from PEI into a new buffer so updates to dynamic PCDs don't write to HOB memory. Signed-off-by: Taylor Beebe Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi --- MdeModulePkg/Universal/PCD/Dxe/Service.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/PCD/Dxe/Service.c b/MdeModulePkg/Univer= sal/PCD/Dxe/Service.c index 1ae06a639c43..0feb11142545 100644 --- a/MdeModulePkg/Universal/PCD/Dxe/Service.c +++ b/MdeModulePkg/Universal/PCD/Dxe/Service.c @@ -885,15 +885,17 @@ BuildPcdDxeDataBase ( // be NULL. If it is NULL, we just copy over the DXE Default // Value to PCD Database. // - PeiDatabase =3D (PEI_PCD_DATABASE *)GET_GUID_HOB_DATA (GuidHob); + PeiDatabase =3D AllocateCopyPool ((UINTN)GET_GUID_HOB_DATA_SIZE (GuidH= ob), GET_GUID_HOB_DATA (GuidHob)); + ASSERT (PeiDatabase !=3D NULL); =20 // // Get next one that stores full PEI data // GuidHob =3D GetNextGuidHob (&gPcdDataBaseHobGuid, GET_NEXT_HOB (GuidHo= b)); if (GuidHob !=3D NULL) { - mPeiPcdDbBinary =3D (PEI_PCD_DATABASE *)GET_GUID_HOB_DATA (GuidHob); mPeiPcdDbSize =3D (UINTN)GET_GUID_HOB_DATA_SIZE (GuidHob); + mPeiPcdDbBinary =3D (PEI_PCD_DATABASE *)AllocateCopyPool (mPeiPcdDbS= ize, GET_GUID_HOB_DATA (GuidHob)); + ASSERT (mPeiPcdDbBinary !=3D NULL); } =20 // --=20 2.42.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109410): https://edk2.groups.io/g/devel/message/109410 Mute This Topic: https://groups.io/mt/101843346/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-