From nobody Sun May 19 03:38:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109233+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109233+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1696027700; cv=none; d=zohomail.com; s=zohoarc; b=WQhaOLB/OgvH9GOkZ/fsi6jODJXmHEZB48WJNOOn6WuZaBRBvQ3ddyR+Fjuw3rgZnEvjYyG1w9aSC8fDZbgBd026NsTGkgUQwqrU+wC9iPxH5r8Bq4GTMjsfzFZToSyC6AUBUfSO0vFx44HXoH0SWNLhDSQbErl3ym7r58MTucI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1696027700; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=sRUyYMSDmAjvEbQhxwyN0E9CffYZeFYQCVNZLywSqJk=; b=LCrJ95Fa7b8fl5v0GkD4Wi43++jS4Pwg7v4OYjo5tLuBXlmWd3k0WALhW0RMAL25D9KsR6i+FE6kiMxlfys/df7glq8dCXy06KTf0FMNxMwid7CUnq3KcdRoCDUR0F03Rv6DJdUQ8GHgEfs8qtk8Oh0i5Tm5Tw6+KN8xi4e68+g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109233+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1696027700877144.23384426453208; Fri, 29 Sep 2023 15:48:20 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=ymU314LEElon5/ObwKUGqOA6od8XJPYMHsAGbn06Cog=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1696027700; v=1; b=d01hc+sHQYv8DJxRwexsU3SNC85jQUFlv4PS+jWd28kxs6HRfxCpYpyGHuSpI56XUSLTmrzv vAMfPvWV8JJ7Xyj38sgl4pu1d596egTcRmQ6ssy9zkZUmR+diZbEmMzC0dSlnGiN2eS5k6v9BRf dEuEugVOmu1kievvHjSxEw0I= X-Received: by 127.0.0.2 with SMTP id H2SuYY1788612xiKWGNRzBcv; Fri, 29 Sep 2023 15:48:20 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.31335.1696027694105857953 for ; Fri, 29 Sep 2023 15:48:14 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10848"; a="361779495" X-IronPort-AV: E=Sophos;i="6.03,188,1694761200"; d="scan'208";a="361779495" X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2023 15:48:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10848"; a="726728055" X-IronPort-AV: E=Sophos;i="6.03,188,1694761200"; d="scan'208";a="726728055" X-Received: from nldesimo-desk.amr.corp.intel.com ([10.241.240.72]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2023 15:48:12 -0700 From: "Nate DeSimone" To: devel@edk2.groups.io Cc: Andrew Fish , Ray Ni , Michael D Kinney Subject: [edk2-devel] [PATCH v1] EmulatorPkg: Update MMTimerThread() signature Date: Fri, 29 Sep 2023 15:47:54 -0700 Message-Id: <20230929224754.1950-1-nathaniel.l.desimone@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ctK6WUeUCOjObuaJXXYgufFSx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1696027703030100003 Content-Type: text/plain; charset="utf-8" In the early 2000s as part of the x64 transition the definition for LPTIMECALLBACK changed from (UINT, UINT, DWORD, DWORD, DWORD) to (UINT, UINT, DWORD_PTR, DWORD_PTR, DWORD_PTR). However, the MMTimerThread() function was never updated to the new signature. Since the implementation does not use the last three parameters, this issue has not been caught until now. Cc: Andrew Fish Cc: Ray Ni Cc: Michael D Kinney Signed-off-by: Nate DeSimone --- EmulatorPkg/Win/Host/WinThunk.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/EmulatorPkg/Win/Host/WinThunk.c b/EmulatorPkg/Win/Host/WinThun= k.c index 42044f2912..12f4f252a2 100644 --- a/EmulatorPkg/Win/Host/WinThunk.c +++ b/EmulatorPkg/Win/Host/WinThunk.c @@ -271,11 +271,11 @@ volatile BOOLEAN mInterruptEnabled =3D FALSE; VOID CALLBACK MMTimerThread ( - UINT wTimerID, - UINT msg, - DWORD dwUser, - DWORD dw1, - DWORD dw2 + UINT wTimerID, + UINT msg, + DWORD_PTR dwUser, + DWORD_PTR dw1, + DWORD_PTR dw2 ) { UINT32 CurrentTick; --=20 2.39.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109233): https://edk2.groups.io/g/devel/message/109233 Mute This Topic: https://groups.io/mt/101668165/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-