From nobody Mon Feb 9 22:59:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109223+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109223+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1696024768; cv=none; d=zohomail.com; s=zohoarc; b=Jrx4bWuPD88sjC4ZZWbE1DhgsYxn3u81Nz+E+WsD+/mK6CymnPf4ab4DaDse1OaBPELwkpQVi8b72BxSkeDf6WnHllSYtygtQ2ds6XnbVoyf8QoA97lTJEyKOUpg+d48aWoDKkY5wTtpAGkxrtMcKc5uRArDJJv9UwWFPRziFZw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1696024768; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=PVBobnRyx+rgz04s1ZXnp0dJ/WxIp5uOc1NrL0o2hF0=; b=cH2gO0Nuu31ic1D5gx5fDS1vWcjH5VzgeEpecanthSq5kgDZolCmcAjBslwStN0siDxPEswx2h73Pe9edDa23VYupItt14M8p4X3Xx9vvCS7mI96w57FTBA167NHjK1SgExaAA4QUPCbDrqN2JlSrAoIQggtYoXP3O1OfTLYShI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109223+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1696024768457465.8968239167841; Fri, 29 Sep 2023 14:59:28 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=6uYWSUzWqyA6pJlwdNWKNwteP9+q49gy6OOb6KFJUuI=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1696024768; v=1; b=mAMy+sWpMqoaRNZoVWk47TPezdhcLJAdRyulprGSAysvdd+d/UcY2cDmSy7u3qvBieOnKwdK EZrO/2WEsMKaTb5uIvyzoivYPIKuFGhPWHmta+3h/xfgix4ZdVnEeR1mqG+DCFEdG/30sdD8gqi lzaiqiqYsNOKuGNwUzwqFia0= X-Received: by 127.0.0.2 with SMTP id o8QxYY1788612xD5ECSwvtBU; Fri, 29 Sep 2023 14:59:28 -0700 X-Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by mx.groups.io with SMTP id smtpd.web10.30359.1696024767354344852 for ; Fri, 29 Sep 2023 14:59:27 -0700 X-Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2c17de836fbso92225861fa.1 for ; Fri, 29 Sep 2023 14:59:27 -0700 (PDT) X-Gm-Message-State: jdjq38vA3WkzxaQBr2JHtbjBx1787277AA= X-Google-Smtp-Source: AGHT+IFq1EgwkU9IdIzccJ9z3BJUNOSJzDTLtRUzUW4WWN27nQZEYTffssBdZMbC2kXmL0KA5/uObg== X-Received: by 2002:a2e:93d6:0:b0:2c0:2ab7:9ab5 with SMTP id p22-20020a2e93d6000000b002c02ab79ab5mr4630600ljh.12.1696024765528; Fri, 29 Sep 2023 14:59:25 -0700 (PDT) X-Received: from localhost.localdomain ([185.9.78.108]) by smtp.gmail.com with ESMTPSA id y24-20020a2ebb98000000b002bfe8537f37sm890178lje.33.2023.09.29.14.59.24 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 29 Sep 2023 14:59:25 -0700 (PDT) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH 7/9] RedfishClientPkg: fix memory leak Date: Sat, 30 Sep 2023 00:59:13 +0300 Message-Id: <20230929215915.46616-8-mike.maslenkin@gmail.com> In-Reply-To: <20230929215915.46616-1-mike.maslenkin@gmail.com> References: <20230929215915.46616-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1696024769964100031 Content-Type: text/plain; charset="utf-8" This patch fixes leak in RedfishExternalResourceResourceFeatureCallback function. Signed-off-by: Mike Maslenkin Reviewed-by: Abner Chang --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c b/RedfishC= lientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c index 32dca964aa0a..9b336d3de479 100644 --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c @@ -718,6 +718,7 @@ RedfishExternalResourceResourceFeatureCallback ( Private->Uri =3D RedfishGetUri (ResourceUri); if (Private->Uri =3D=3D NULL) { ASSERT (FALSE); + FreePool (ResourceUri); return EFI_OUT_OF_RESOURCES; } =20 @@ -727,6 +728,7 @@ RedfishExternalResourceResourceFeatureCallback ( } =20 FreePool (Private->Uri); + FreePool (ResourceUri); return Status; } =20 --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109223): https://edk2.groups.io/g/devel/message/109223 Mute This Topic: https://groups.io/mt/101667467/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-