From nobody Sun Feb 8 12:38:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109109+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109109+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1695795433; cv=none; d=zohomail.com; s=zohoarc; b=HbV8/DTJDP3F2fhLhW8N/YIjeKncGSKSQObGGjqsgA22jKQvU2j+H410kLt6Yuo4pVlDcLpxdj9JxCUOyHIxuGBLzm+pA/2r4j0iYIdxmKv9s1CehXUyYuK7hC3D5rKUFEmi9+FU6qcwsjVv/DAA6pJ4OUxfuE+5BImqUh0sin0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695795433; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Kw3nsGdpBb79osv5XuMzM3YqlsyYPQBqv7HutxIppM0=; b=VVN+7EgSvhuMKmSM3DrSfaAgppO9J9J0bFQBGPVtlLCXrSpdvylpQc+tWTfwA8XgHbXK/I+pp+6CSh4qMD1r4tOO1I0978SbVGG8B1WfmZ7UuONSWU2OQF3Fg5uf4AjpFqAUJbebrLQ6CNNLTgH38hUmuPdzC9D63LWgOm8ESu0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109109+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1695795433328707.0861520686528; Tue, 26 Sep 2023 23:17:13 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=N2d+RSTBBrVuRtispSUtX876LDv53N//poBqeDcY9vE=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1695795433; v=1; b=cYmhzjikUkmEQAgKeqZM5NSbwTGp3dwT27uaoNA4xV1/FlMdBbxElG+TdwHPkh2DsXe5pa34 0ns+P55LvWCVBnda3S8aDSHuLW7u8wZ4+Ty2bfts88qJzshceVX3GnpUaiUpuAaBNVmTBgiZCL4 UUof3W9jsYzjoAO54jPZPCRs= X-Received: by 127.0.0.2 with SMTP id LqUhYY1788612xXnoH3YzlP8; Tue, 26 Sep 2023 23:17:13 -0700 X-Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) by mx.groups.io with SMTP id smtpd.web11.11916.1695795432389389929 for ; Tue, 26 Sep 2023 23:17:12 -0700 X-Received: by mail-io1-f51.google.com with SMTP id ca18e2360f4ac-79fb70402a7so245310339f.0 for ; Tue, 26 Sep 2023 23:17:12 -0700 (PDT) X-Gm-Message-State: Git8EBdOYBOoGKNVlUFNfWZYx1787277AA= X-Google-Smtp-Source: AGHT+IHZUsD7m0SvVIMxqR1qyuowp2ZhjnNakqNEMlAAVBCFO6Obrlvw/IW/fRVXh9M2FB9XRMb0NA== X-Received: by 2002:a6b:dd07:0:b0:783:4e11:76d7 with SMTP id f7-20020a6bdd07000000b007834e1176d7mr937971ioc.21.1695795431478; Tue, 26 Sep 2023 23:17:11 -0700 (PDT) X-Received: from user-Latitude-5420.dc1.ventanamicro.com ([106.51.83.242]) by smtp.gmail.com with ESMTPSA id o23-20020a6b5a17000000b007836c7e8dccsm2571625iob.17.2023.09.26.23.17.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 23:17:11 -0700 (PDT) From: "Ranbir Singh" To: devel@edk2.groups.io, rsingh@ventanamicro.com Cc: Hao A Wu , Ray Ni , Veeresh Sangolli Subject: [edk2-devel] [PATCH v1 2/5] MdeModulePkg/Bus/Pci/PciBusDxe: Fix MISSING_BREAK Coverity issues Date: Wed, 27 Sep 2023 11:46:58 +0530 Message-Id: <20230927061701.451202-3-rsingh@ventanamicro.com> In-Reply-To: <20230927061701.451202-1-rsingh@ventanamicro.com> References: <20230927061701.451202-1-rsingh@ventanamicro.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rsingh@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1695795434219100010 Content-Type: text/plain; charset="utf-8" From: Ranbir Singh The function UpdatePciInfo has switch-case code in which there are fall through from case 32: to case 64:. While this is seeemingly intentional, it is not evident to any static analyzer tool. Just adding // No break; here as this is an intentional fallthrough. as explicit comment in between makes a reader as well as Coverity happy. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4239 Cc: Hao A Wu Cc: Ray Ni Co-authored-by: Veeresh Sangolli Signed-off-by: Ranbir Singh Signed-off-by: Ranbir Singh --- MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c b/MdeMod= ulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c index 6594b8eae83f..eda97285ee18 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c @@ -1428,6 +1428,9 @@ UpdatePciInfo ( switch (Ptr->AddrSpaceGranularity) { case 32: PciIoDevice->PciBar[BarIndex].BarType =3D PciBarTypeMem3= 2; + // + // No break; here as this is an intentional fall through. + // case 64: PciIoDevice->PciBar[BarIndex].BarTypeFixed =3D TRUE; break; @@ -1440,6 +1443,9 @@ UpdatePciInfo ( switch (Ptr->AddrSpaceGranularity) { case 32: PciIoDevice->PciBar[BarIndex].BarType =3D PciBarTypePMem= 32; + // + // No break; here as this is an intentional fall through. + // case 64: PciIoDevice->PciBar[BarIndex].BarTypeFixed =3D TRUE; break; --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109109): https://edk2.groups.io/g/devel/message/109109 Mute This Topic: https://groups.io/mt/101612808/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-