From nobody Sun Feb 8 02:26:13 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109103+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109103+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1695794773; cv=none; d=zohomail.com; s=zohoarc; b=SjZ43tgnR8Kr7AQjRa9jbXYXrHCiIbtDINglX668K+v/L4iuP0QyNpMEnx/4+4Lio4dN8oQAi+a3SSAIT9aRLb1FpqLK1ZXm+MMZKPlJzbJC4ySHskEfbz5SPAFZ6AsxiKqak+SbxZ+U731ijFwtcTb7Qd1PGnPl9PGd2YRVSDo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695794773; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=UC/8hM5mugPcQRzRSuOAhlE1bfhFT5FnjQSL28wu5t0=; b=gBIfzuGT9nOOagx5PocN7FnA6klaUtQN2Q+F9OGaw0EuHv88fm4I+3B2/mOOiVf1s3Kpr1aC4PMi0402ej5ptThzgPCaSXbxErAvieJfcDBcxoJ865d6i33ErG/SEzo8IlbPZ120a4oacYyQAh/WhhPhYRq/6R1lbdnKB5PHJB0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109103+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 169579477330384.0749791792772; Tue, 26 Sep 2023 23:06:13 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=jrQ4k8PZ6y5t+266dUd5q2W32JUO/QP9tthQC/lDXEo=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1695794773; v=1; b=HdU34UoZ4w6+O8MMr0H7Qdyxvof//V0q6zGUQPMAXI1A0mCV3uF84R+uXxVYh4KD4DEshY/n XKvtmU0kPQu8pfIF3YZD9GloP5POCUaSBZGQ1/kMq4u0Lr0o7a1TamXbqhsUdk7h3Lwuhijx+qd foSFcUqf3CtOKXOFs+NFDms4= X-Received: by 127.0.0.2 with SMTP id WRxBYY1788612xsTe9f0hi5j; Tue, 26 Sep 2023 23:06:13 -0700 X-Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by mx.groups.io with SMTP id smtpd.web11.11801.1695794772448640883 for ; Tue, 26 Sep 2023 23:06:12 -0700 X-Received: by mail-io1-f43.google.com with SMTP id ca18e2360f4ac-79fa2dbd793so303654339f.2 for ; Tue, 26 Sep 2023 23:06:12 -0700 (PDT) X-Gm-Message-State: JJ9OXzCdMmHGUMl13kzgXRgQx1787277AA= X-Google-Smtp-Source: AGHT+IFMP8OiD5PlF0ZCH3xA85czSBHbLRa1cB/5TsGIjQ1McKUomQTdbfclDMcxN5ApWzmuTrZ1vQ== X-Received: by 2002:a05:6e02:1bc5:b0:34c:bc10:2573 with SMTP id x5-20020a056e021bc500b0034cbc102573mr1500692ilv.3.1695794771552; Tue, 26 Sep 2023 23:06:11 -0700 (PDT) X-Received: from user-Latitude-5420.dc1.ventanamicro.com ([106.51.83.242]) by smtp.gmail.com with ESMTPSA id gj8-20020a0566386a0800b0042b39b2289asm3856707jab.102.2023.09.26.23.06.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 23:06:11 -0700 (PDT) From: "Ranbir Singh" To: devel@edk2.groups.io, rsingh@ventanamicro.com Cc: Dandan Bi , Liming Gao , Veeresh Sangolli Subject: [edk2-devel] [PATCH v2 2/5] MdeModulePkg/Core/Dxe: Fix MISSING_BREAK Coverity issue Date: Wed, 27 Sep 2023 11:35:58 +0530 Message-Id: <20230927060601.443693-3-rsingh@ventanamicro.com> In-Reply-To: <20230927060601.443693-1-rsingh@ventanamicro.com> References: <20230927060601.443693-1-rsingh@ventanamicro.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rsingh@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1695794775161100011 Content-Type: text/plain; charset="utf-8" From: Ranbir Singh The function CoreIsSchedulable has switch-case code in which case EFI_DEP_BEFORE: case EFI_DEP_AFTER: has a comment that // For a well-formed Dependency Expression, the code should never get here. It also has an ASSERT (FALSE); but this is applicable only in DEBUG mode. Seemingly, for RELEASE mode, code should not be allowed to fall through to case EFI_DEP_SOR: which is below the above two. Hence, add return FALSE at the end. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4219 Cc: Dandan Bi Cc: Liming Gao Co-authored-by: Veeresh Sangolli Signed-off-by: Ranbir Singh Signed-off-by: Ranbir Singh --- MdeModulePkg/Core/Dxe/Dispatcher/Dependency.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Core/Dxe/Dispatcher/Dependency.c b/MdeModulePkg/C= ore/Dxe/Dispatcher/Dependency.c index acbf68b700fb..9799ec9ca097 100644 --- a/MdeModulePkg/Core/Dxe/Dispatcher/Dependency.c +++ b/MdeModulePkg/Core/Dxe/Dispatcher/Dependency.c @@ -265,6 +265,8 @@ CoreIsSchedulable ( // DEBUG ((DEBUG_DISPATCH, " RESULT =3D FALSE (Unexpected BEFORE or = AFTER opcode)\n")); ASSERT (FALSE); + return FALSE; + case EFI_DEP_SOR: // // These opcodes can only appear once as the first opcode. If it = is found --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109103): https://edk2.groups.io/g/devel/message/109103 Mute This Topic: https://groups.io/mt/101612677/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-