From nobody Sat Feb 7 10:14:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109102+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109102+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1695794771; cv=none; d=zohomail.com; s=zohoarc; b=JZPaQx2+1ch68MOtIkLLV5lfPgU1iBJtHT9psv+dS0D8ytcddJjV2IyV3yLzXpkEF7YZ3131wNJ1WpuD4jzUHx/668uzCj4cA/+LYrZ/yAy8StnH7D6RxeLuL6WnOTWulKwTQMEjNZIr+pOfOdIcfSTPApVRm9/2A5H17p/wZxo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695794771; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=I+HYI9to3wuRX09tnplF2ScWHMjKGxxnn0LhuZKcpVM=; b=GVKu+wUeLvoQSBiuZHWbUzYD36ru+Mqr4I62adXQAkBRVm5/OleXlRYaxPtH2MMAcjj8AsvWPsyRhDHtSkx3tH3pgkhE3sIYjeX6THBRtwSG/G3ZvOaLf3t83ADNDVMZhXNQY14uLalt/VrCzVuMFr+WZOJFzAiQ5WypEZQD2RE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109102+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1695794771016908.1833929896978; Tue, 26 Sep 2023 23:06:11 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=/gGwruDnCPyiwmpXjl4IIQN83yU8kalRU2osix9FDLo=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1695794770; v=1; b=EXu418CgPSm2l+pwqhr7wu4uNivocefM4XEpT/rqnDKPWiOUhs/5XDt4+Y0sBgic3DYE9HaH h2eY5UGRJcjpXD6IZpXSLL49rd5mNocqYjLzCcFc6ZfGi2knAMuIKNg9qMU+fTjKpcKl8TqHI0d J17ABwXDkqi4+tqGYeg/vEc4= X-Received: by 127.0.0.2 with SMTP id egdLYY1788612xCVyMYp8Ja4; Tue, 26 Sep 2023 23:06:10 -0700 X-Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by mx.groups.io with SMTP id smtpd.web11.11800.1695794770022119417 for ; Tue, 26 Sep 2023 23:06:10 -0700 X-Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-79fe87cd74eso63749139f.3 for ; Tue, 26 Sep 2023 23:06:09 -0700 (PDT) X-Gm-Message-State: aD6zAehjCsR4utbdPQli63U8x1787277AA= X-Google-Smtp-Source: AGHT+IGUn7mU8L6JoMlRx76gqvgyEF7nF+Sw1QHruhs7BscmBQ918K/wnbCrS5fy3HR37qJboRO+4g== X-Received: by 2002:a05:6602:39a:b0:79f:da3d:c47f with SMTP id f26-20020a056602039a00b0079fda3dc47fmr1375767iov.13.1695794769060; Tue, 26 Sep 2023 23:06:09 -0700 (PDT) X-Received: from user-Latitude-5420.dc1.ventanamicro.com ([106.51.83.242]) by smtp.gmail.com with ESMTPSA id gj8-20020a0566386a0800b0042b39b2289asm3856707jab.102.2023.09.26.23.06.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 23:06:08 -0700 (PDT) From: "Ranbir Singh" To: devel@edk2.groups.io, rsingh@ventanamicro.com Cc: Dandan Bi , Liming Gao , Veeresh Sangolli Subject: [edk2-devel] [PATCH v2 1/5] MdeModulePkg/Core/Dxe: Fix FORWARD_NULL Coverity issues Date: Wed, 27 Sep 2023 11:35:57 +0530 Message-Id: <20230927060601.443693-2-rsingh@ventanamicro.com> In-Reply-To: <20230927060601.443693-1-rsingh@ventanamicro.com> References: <20230927060601.443693-1-rsingh@ventanamicro.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rsingh@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1695794772430100007 Content-Type: text/plain; charset="utf-8" From: Ranbir Singh The functions CoreConvertSpace and CoreAllocateSpace in MdeModulePkg/Core/Dxe/Gcd/Gcd.c has ASSERT (FALSE); at lines 755 and 1155 which gets hit when Operation neither include GCD_MEMORY_SPACE_OPERATION nor include GCD_IO_SPACE_OPERATION but this comes into play only in DEBUG mode. In Release mode, the code continues to proceed in this undesirable case with Map variable still set to NULL and hence dereferencing "Map" will lead to CRASH. It is safer to add a debug message in this scenario and return from the function with EFI_INVALID_PARAMETER; The existing ASSERT may be retained or may be deleted whatever is deemed more appropriate. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4219 Cc: Dandan Bi Cc: Liming Gao Co-authored-by: Veeresh Sangolli Signed-off-by: Ranbir Singh Signed-off-by: Ranbir Singh --- MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c b/MdeModulePkg/Core/Dxe/Gcd/Gc= d.c index 792cd2e0af23..39fa2adf9366 100644 --- a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c +++ b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c @@ -752,7 +752,9 @@ CoreConvertSpace ( CoreAcquireGcdIoLock (); Map =3D &mGcdIoSpaceMap; } else { + DEBUG ((DEBUG_GCD, " Status =3D %r\n", EFI_INVALID_PARAMETER)); ASSERT (FALSE); + return EFI_INVALID_PARAMETER; } =20 // @@ -1152,7 +1154,9 @@ CoreAllocateSpace ( CoreAcquireGcdIoLock (); Map =3D &mGcdIoSpaceMap; } else { + DEBUG ((DEBUG_GCD, " Status =3D %r\n", EFI_INVALID_PARAMETER)); ASSERT (FALSE); + return EFI_INVALID_PARAMETER; } =20 Found =3D FALSE; --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109102): https://edk2.groups.io/g/devel/message/109102 Mute This Topic: https://groups.io/mt/101612676/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-