From nobody Sun Feb 8 19:56:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109068+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109068+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1695728382; cv=none; d=zohomail.com; s=zohoarc; b=ka7CArFZZWiEdb6v3k1ifZ4fwNxtOnPVbsXlO19aN5p2tGWaa4aR9Ruj3WwYtEDQemRbPytSHVH0NdcB1E1Qp9qEYvBv+M/anXDp6UJWkO93AIU/iuvdKYTezUd/Td6hbeWyZmwX+XLdKnvar6pZXYExBzOrWdYKLxiChpQqScU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695728382; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=JGdRVhDbcM9iTnYAsehvIYAMNtIZmmkLOXCmhtL9Xc8=; b=FsNIfYEhyKBLA473dHLksYUvgTtgHVQKggpru4Ty8Shj9jh0ScRO9+sCdXBNnIQ3oiMy0M99Dfky9OjTL1OJXVWXJ+miwBLaEkHs6zKUpN3xW3/7cAWU2a4YQc147dgCUfN7ficYRO59nBCzId93sJoh32b0LTraDYxH5v8eHkg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109068+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1695728382370572.6961223084032; Tue, 26 Sep 2023 04:39:42 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=sLzDH0RUyF7f+j1yxSx5oyVGt2/zzmmIVthqKWqga9c=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe; s=20140610; t=1695728382; v=1; b=ShTuQI/LBFQF+n4pvfn8c28SPBNnUq1OxGkT+ZBGIVWVTAyoh1n5qSS7of9NkWPWcWwGiZ39 Qdk7PB5sNcAAM/vUh0Mbt+b/MwTddDXS6eXe9JHT8rSlZvo/sTrFDVF0qNKq+kVgUGpsSvhuVY0 hU3fKXcFChDKO/bnywYG06FM= X-Received: by 127.0.0.2 with SMTP id 9ZcgYY1788612xtzHjRmUewa; Tue, 26 Sep 2023 04:39:42 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.16623.1695728378396479540 for ; Tue, 26 Sep 2023 04:39:41 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="366603654" X-IronPort-AV: E=Sophos;i="6.03,177,1694761200"; d="scan'208";a="366603654" X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 04:39:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="995802156" X-IronPort-AV: E=Sophos;i="6.03,177,1694761200"; d="scan'208";a="995802156" X-Received: from sh1gapp1009.ccr.corp.intel.com ([10.239.189.219]) by fmsmga006.fm.intel.com with ESMTP; 26 Sep 2023 04:39:39 -0700 From: "Wu, Jiaxin" To: devel@edk2.groups.io Cc: Eric Dong , Ray Ni , Zeng Star , Rahul Kumar , Gerd Hoffmann Subject: [edk2-devel] [PATCH v1 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Reduce the times of BSP and AP sync for exit Date: Tue, 26 Sep 2023 19:39:34 +0800 Message-Id: <20230926113934.8548-3-jiaxin.wu@intel.com> In-Reply-To: <20230926113934.8548-1-jiaxin.wu@intel.com> References: <20230926113934.8548-1-jiaxin.wu@intel.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jiaxin.wu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: iwCcp6ppNYtsxnNKcOKW5gwcx1787277AA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1695728383632100009 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" After review, there are unnecessary steps for BSP and AP sync for exit. This patch is to reduce one round BSP and AP sync for exit so as to improve SMM performance: WaitForAllAPs <- ReleaseBsp ReleaseAllAPs -> WaitForBsp Cc: Eric Dong Cc: Ray Ni Cc: Zeng Star Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Jiaxin Wu --- UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 44 +++++++++++++++++++------------= ---- 1 file changed, 24 insertions(+), 20 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxe= Smm/MpService.c index e96c7f51d6..5a42a5dd12 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c @@ -665,11 +665,13 @@ BSPHandler ( // *mSmmMpSyncData->AllCpusInSync =3D TRUE; ApCount =3D LockdownSemaphore (mSmmMpSyncData->= Counter) - 1; =20 // - // Wait for all APs to get ready for programming MTRRs + // Wait for all APs: + // 1. Make sure all Aps have set the Present. + // 2. Get ready for programming MTRRs. // WaitForAllAPs (ApCount); =20 if (SmmCpuFeaturesNeedConfigureMtrrs ()) { // @@ -768,16 +770,16 @@ BSPHandler ( // Notify all APs to exit // *mSmmMpSyncData->InsideSmm =3D FALSE; ReleaseAllAPs (); =20 - // - // Wait for all APs to complete their pending tasks - // - WaitForAllAPs (ApCount); - if (SmmCpuFeaturesNeedConfigureMtrrs ()) { + // + // Wait for all APs to complete their pending tasks + // + WaitForAllAPs (ApCount); + // // Signal APs to restore MTRRs // ReleaseAllAPs (); =20 @@ -789,23 +791,23 @@ BSPHandler ( =20 // // Wait for all APs to complete MTRR programming // WaitForAllAPs (ApCount); + + // + // Signal APs to Reset states/semaphore for this processor + // + ReleaseAllAPs (); } =20 // // Stop source level debug in BSP handler, the code below will not be // debugged. // InitializeDebugAgent (DEBUG_AGENT_INIT_EXIT_SMI, NULL, NULL); =20 - // - // Signal APs to Reset states/semaphore for this processor - // - ReleaseAllAPs (); - // // Perform pending operations for hot-plug // SmmCpuUpdate (); =20 @@ -941,10 +943,12 @@ APHandler ( *(mSmmMpSyncData->CpuData[CpuIndex].Present) =3D TRUE; =20 if ((SyncMode =3D=3D SmmCpuSyncModeTradition) || SmmCpuFeaturesNeedConfi= gureMtrrs ()) { // // Notify BSP of arrival at this point + // 1. Set the Present. + // 2. Get ready for programming MTRRs. // ReleaseBsp (mSmmMpSyncData->CpuData[BspIndex].Run); } =20 if (SmmCpuFeaturesNeedConfigureMtrrs ()) { @@ -1033,21 +1037,21 @@ APHandler ( // // Restore OS MTRRs // SmmCpuFeaturesReenableSmrr (); MtrrSetAllMtrrs (&Mtrrs); - } =20 - // - // Notify BSP the readiness of this AP to Reset states/semaphore for thi= s processor - // - ReleaseBsp (mSmmMpSyncData->CpuData[BspIndex].Run); + // + // Notify BSP the readiness of this AP to Reset states/semaphore for t= his processor + // + ReleaseBsp (mSmmMpSyncData->CpuData[BspIndex].Run); =20 - // - // Wait for the signal from BSP to Reset states/semaphore for this proce= ssor - // - WaitForBsp (mSmmMpSyncData->CpuData[CpuIndex].Run); + // + // Wait for the signal from BSP to Reset states/semaphore for this pro= cessor + // + WaitForBsp (mSmmMpSyncData->CpuData[CpuIndex].Run); + } =20 // // Reset states/semaphore for this processor // *(mSmmMpSyncData->CpuData[CpuIndex].Present) =3D FALSE; --=20 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109068): https://edk2.groups.io/g/devel/message/109068 Mute This Topic: https://groups.io/mt/101593530/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-