[edk2-devel] [PATCH v2 5/7] DynamicTablesPkg.ci.yaml: Add debug macro exception

Michael Kubacki posted 7 patches 5 months, 2 weeks ago
[edk2-devel] [PATCH v2 5/7] DynamicTablesPkg.ci.yaml: Add debug macro exception
Posted by Michael Kubacki 5 months, 2 weeks ago
From: Michael Kubacki <michael.kubacki@microsoft.com>

Adds a CI YAML entry to acknowledge a case where custom strings
contain print specifiers for a single debug macro.

Cc: Sami Mujawar <Sami.Mujawar@arm.com>
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
Cc: Pierre Gondois <pierre.gondois@arm.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
index 5addf8626841..1d41d44bbf33 100644
--- a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
+++ b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
@@ -130,5 +130,13 @@
                                      # should be ignore
         "AdditionalIncludePaths": [] # Additional paths to spell check
                                      # (wildcards supported)
+    },
+
+    "DebugMacroCheck": {
+      "StringSubstitutions": {
+          # DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
+          # Reason: Debug format strings are dynamically set.
+          "Parser[Index].Format": "%d"
+      }
     }
 }
-- 
2.42.0.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108605): https://edk2.groups.io/g/devel/message/108605
Mute This Topic: https://groups.io/mt/101341656/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 5/7] DynamicTablesPkg.ci.yaml: Add debug macro exception
Posted by Sami Mujawar 5 months, 1 week ago
Hi Michael,

I would prefer to have the debug macro checks enabled in DynamicTablesPkg to catch any issues. 

Please do not disable this feature for this package.

Regards,

Sami Mujawar

On 13/09/2023, 18:08, "mikuback@linux.microsoft.com <mailto:mikuback@linux.microsoft.com>" <mikuback@linux.microsoft.com <mailto:mikuback@linux.microsoft.com>> wrote:


From: Michael Kubacki <michael.kubacki@microsoft.com <mailto:michael.kubacki@microsoft.com>>


Adds a CI YAML entry to acknowledge a case where custom strings
contain print specifiers for a single debug macro.


Cc: Sami Mujawar <Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com>>
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com <mailto:Alexei.Fedorov@arm.com>>
Cc: Pierre Gondois <pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com <mailto:michael.kubacki@microsoft.com>>
---
DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 8 ++++++++
1 file changed, 8 insertions(+)


diff --git a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
index 5addf8626841..1d41d44bbf33 100644
--- a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
+++ b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
@@ -130,5 +130,13 @@
# should be ignore
"AdditionalIncludePaths": [] # Additional paths to spell check
# (wildcards supported)
+ },
+
+ "DebugMacroCheck": {
+ "StringSubstitutions": {
+ # DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
+ # Reason: Debug format strings are dynamically set.
+ "Parser[Index].Format": "%d"
+ }
}
}
-- 
2.42.0.windows.2







-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108642): https://edk2.groups.io/g/devel/message/108642
Mute This Topic: https://groups.io/mt/101341656/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-