[edk2-devel] [PATCH v2 4/7] ArmVirtPkg.ci.yaml: Add debug macro exception

Michael Kubacki posted 7 patches 9 months ago
[edk2-devel] [PATCH v2 4/7] ArmVirtPkg.ci.yaml: Add debug macro exception
Posted by Michael Kubacki 9 months ago
From: Michael Kubacki <michael.kubacki@microsoft.com>

Adds a CI YAML entry to acknowledge a case where a macro is expanded
that contains a print specifier.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 ArmVirtPkg/ArmVirtPkg.ci.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml
index 1e799dc4e194..506b0e72f0bb 100644
--- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
+++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
@@ -125,5 +125,13 @@
         ],           # words to extend to the dictionary for this package
         "IgnoreStandardPaths": [],   # Standard Plugin defined paths that should be ignore
         "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported)
+    },
+
+    "DebugMacroCheck": {
+      "StringSubstitutions": {
+          # DynamicTablesPkg/Include/ConfigurationManagerObject.h
+          # Reason: Expansion of macro that contains a print specifier.
+          "FMT_CM_OBJECT_ID": "0x%lx"
+      }
     }
 }
-- 
2.42.0.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108604): https://edk2.groups.io/g/devel/message/108604
Mute This Topic: https://groups.io/mt/101341655/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 4/7] ArmVirtPkg.ci.yaml: Add debug macro exception
Posted by Ard Biesheuvel 9 months ago
On Wed, 13 Sept 2023 at 19:07, <mikuback@linux.microsoft.com> wrote:
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> Adds a CI YAML entry to acknowledge a case where a macro is expanded
> that contains a print specifier.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  ArmVirtPkg/ArmVirtPkg.ci.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> index 1e799dc4e194..506b0e72f0bb 100644
> --- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
> +++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> @@ -125,5 +125,13 @@
>          ],           # words to extend to the dictionary for this package
>          "IgnoreStandardPaths": [],   # Standard Plugin defined paths that should be ignore
>          "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported)
> +    },
> +
> +    "DebugMacroCheck": {
> +      "StringSubstitutions": {
> +          # DynamicTablesPkg/Include/ConfigurationManagerObject.h
> +          # Reason: Expansion of macro that contains a print specifier.
> +          "FMT_CM_OBJECT_ID": "0x%lx"
> +      }
>      }
>  }
> --
> 2.42.0.windows.2
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108608): https://edk2.groups.io/g/devel/message/108608
Mute This Topic: https://groups.io/mt/101341655/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 4/7] ArmVirtPkg.ci.yaml: Add debug macro exception
Posted by Michael Kubacki 8 months, 3 weeks ago
Thanks Ard. I still need a Reviewed-by on this patch to complete the series.

On 9/13/2023 1:10 PM, Ard Biesheuvel wrote:
> On Wed, 13 Sept 2023 at 19:07, <mikuback@linux.microsoft.com> wrote:
>>
>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> Adds a CI YAML entry to acknowledge a case where a macro is expanded
>> that contains a print specifier.
>>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Acked-by: Ard Biesheuvel <ardb@kernel.org>
> 
>> ---
>>   ArmVirtPkg/ArmVirtPkg.ci.yaml | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml
>> index 1e799dc4e194..506b0e72f0bb 100644
>> --- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
>> +++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
>> @@ -125,5 +125,13 @@
>>           ],           # words to extend to the dictionary for this package
>>           "IgnoreStandardPaths": [],   # Standard Plugin defined paths that should be ignore
>>           "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported)
>> +    },
>> +
>> +    "DebugMacroCheck": {
>> +      "StringSubstitutions": {
>> +          # DynamicTablesPkg/Include/ConfigurationManagerObject.h
>> +          # Reason: Expansion of macro that contains a print specifier.
>> +          "FMT_CM_OBJECT_ID": "0x%lx"
>> +      }
>>       }
>>   }
>> --
>> 2.42.0.windows.2
>>
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108809): https://edk2.groups.io/g/devel/message/108809
Mute This Topic: https://groups.io/mt/101341655/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 4/7] ArmVirtPkg.ci.yaml: Add debug macro exception
Posted by Ard Biesheuvel 8 months, 3 weeks ago
On Mon, 18 Sept 2023 at 22:35, Michael Kubacki
<mikuback@linux.microsoft.com> wrote:
>
> Thanks Ard. I still need a Reviewed-by on this patch to complete the series.
>

Actually, you don't but I suppose there is some difference of
interpretation here.

In the Linux community (where these tags originated), an ack from a
maintainer means 'no objections, feel free to apply this to code that
I maintain'. In this case, I am not 100% sure what the change means,
so I am not comfortable claiming that I reviewed it, but given that
this is your area of expertise rather than mine, I trust that you know
what you are doing. Hence the acked-by.

In other cases, I may rely on another person's expertise and their
reviewed-by to decide whether or not to merge something, rather than
review it myself. In this case, the acked-by is implied by the fact
that I decided to merge the PR (and therefore somewhat redundant). But
it comes down to the same thing.

If there is a Tianocore rule that says every patch needs a reviewed-by
from a maintainer, we should probably fix that. It is *not* the job of
a maintainer to review everything (and this wouldn't scale to begin
with) - rather, it is their job to ensure that everything that gets
merged has been reviewed sufficiently, either by themselves or by
other people they have confidence in.



> On 9/13/2023 1:10 PM, Ard Biesheuvel wrote:
> > On Wed, 13 Sept 2023 at 19:07, <mikuback@linux.microsoft.com> wrote:
> >>
> >> From: Michael Kubacki <michael.kubacki@microsoft.com>
> >>
> >> Adds a CI YAML entry to acknowledge a case where a macro is expanded
> >> that contains a print specifier.
> >>
> >> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> >> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> >> Cc: Sami Mujawar <sami.mujawar@arm.com>
> >> Cc: Gerd Hoffmann <kraxel@redhat.com>
> >> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> >
> > Acked-by: Ard Biesheuvel <ardb@kernel.org>
> >
> >> ---
> >>   ArmVirtPkg/ArmVirtPkg.ci.yaml | 8 ++++++++
> >>   1 file changed, 8 insertions(+)
> >>
> >> diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> >> index 1e799dc4e194..506b0e72f0bb 100644
> >> --- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
> >> +++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> >> @@ -125,5 +125,13 @@
> >>           ],           # words to extend to the dictionary for this package
> >>           "IgnoreStandardPaths": [],   # Standard Plugin defined paths that should be ignore
> >>           "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported)
> >> +    },
> >> +
> >> +    "DebugMacroCheck": {
> >> +      "StringSubstitutions": {
> >> +          # DynamicTablesPkg/Include/ConfigurationManagerObject.h
> >> +          # Reason: Expansion of macro that contains a print specifier.
> >> +          "FMT_CM_OBJECT_ID": "0x%lx"
> >> +      }
> >>       }
> >>   }
> >> --
> >> 2.42.0.windows.2
> >>
> >
> >
> > 
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108845): https://edk2.groups.io/g/devel/message/108845
Mute This Topic: https://groups.io/mt/101341655/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 4/7] ArmVirtPkg.ci.yaml: Add debug macro exception
Posted by Leif Lindholm 8 months, 3 weeks ago
On 2023-09-19 15:46, Ard Biesheuvel wrote:
> On Mon, 18 Sept 2023 at 22:35, Michael Kubacki
> <mikuback@linux.microsoft.com> wrote:
>>
>> Thanks Ard. I still need a Reviewed-by on this patch to complete the series.
> 
> Actually, you don't but I suppose there is some difference of
> interpretation here.
> 
> In the Linux community (where these tags originated), an ack from a
> maintainer means 'no objections, feel free to apply this to code that
> I maintain'. In this case, I am not 100% sure what the change means,
> so I am not comfortable claiming that I reviewed it, but given that
> this is your area of expertise rather than mine, I trust that you know
> what you are doing. Hence the acked-by.
> 
> In other cases, I may rely on another person's expertise and their
> reviewed-by to decide whether or not to merge something, rather than
> review it myself. In this case, the acked-by is implied by the fact
> that I decided to merge the PR (and therefore somewhat redundant). But
> it comes down to the same thing.
> 
> If there is a Tianocore rule that says every patch needs a reviewed-by
> from a maintainer, we should probably fix that. It is *not* the job of
> a maintainer to review everything (and this wouldn't scale to begin
> with) - rather, it is their job to ensure that everything that gets
> merged has been reviewed sufficiently, either by themselves or by
> other people they have confidence in.

I was under the impression we had this conversation a few years ago and 
agreed a maintainer Ack was sufficient. Have we failed to document that 
fact?

/
     Leif

>> On 9/13/2023 1:10 PM, Ard Biesheuvel wrote:
>>> On Wed, 13 Sept 2023 at 19:07, <mikuback@linux.microsoft.com> wrote:
>>>>
>>>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>>>
>>>> Adds a CI YAML entry to acknowledge a case where a macro is expanded
>>>> that contains a print specifier.
>>>>
>>>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>>>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>>>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>>>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>>>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>>
>>> Acked-by: Ard Biesheuvel <ardb@kernel.org>
>>>
>>>> ---
>>>>    ArmVirtPkg/ArmVirtPkg.ci.yaml | 8 ++++++++
>>>>    1 file changed, 8 insertions(+)
>>>>
>>>> diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml
>>>> index 1e799dc4e194..506b0e72f0bb 100644
>>>> --- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
>>>> +++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
>>>> @@ -125,5 +125,13 @@
>>>>            ],           # words to extend to the dictionary for this package
>>>>            "IgnoreStandardPaths": [],   # Standard Plugin defined paths that should be ignore
>>>>            "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported)
>>>> +    },
>>>> +
>>>> +    "DebugMacroCheck": {
>>>> +      "StringSubstitutions": {
>>>> +          # DynamicTablesPkg/Include/ConfigurationManagerObject.h
>>>> +          # Reason: Expansion of macro that contains a print specifier.
>>>> +          "FMT_CM_OBJECT_ID": "0x%lx"
>>>> +      }
>>>>        }
>>>>    }
>>>> --
>>>> 2.42.0.windows.2
>>>>
>>>
>>>
>>>
>>>
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108846): https://edk2.groups.io/g/devel/message/108846
Mute This Topic: https://groups.io/mt/101341655/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 4/7] ArmVirtPkg.ci.yaml: Add debug macro exception
Posted by Michael Kubacki 8 months, 3 weeks ago
On 9/19/2023 10:52 AM, Leif Lindholm wrote:
> On 2023-09-19 15:46, Ard Biesheuvel wrote:
>> On Mon, 18 Sept 2023 at 22:35, Michael Kubacki
>> <mikuback@linux.microsoft.com> wrote:
>>>
>>> Thanks Ard. I still need a Reviewed-by on this patch to complete the 
>>> series.
>>
>> Actually, you don't but I suppose there is some difference of
>> interpretation here.
>>
>> In the Linux community (where these tags originated), an ack from a
>> maintainer means 'no objections, feel free to apply this to code that
>> I maintain'. In this case, I am not 100% sure what the change means,
>> so I am not comfortable claiming that I reviewed it, but given that
>> this is your area of expertise rather than mine, I trust that you know
>> what you are doing. Hence the acked-by.
>>
>> In other cases, I may rely on another person's expertise and their
>> reviewed-by to decide whether or not to merge something, rather than
>> review it myself. In this case, the acked-by is implied by the fact
>> that I decided to merge the PR (and therefore somewhat redundant). But
>> it comes down to the same thing.
>>
>> If there is a Tianocore rule that says every patch needs a reviewed-by
>> from a maintainer, we should probably fix that. It is *not* the job of
>> a maintainer to review everything (and this wouldn't scale to begin
>> with) - rather, it is their job to ensure that everything that gets
>> merged has been reviewed sufficiently, either by themselves or by
>> other people they have confidence in.
> 
> I was under the impression we had this conversation a few years ago and 
> agreed a maintainer Ack was sufficient. Have we failed to document that 
> fact?
> 

I looked here:
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

It would be great if we could explicitly state the process around each 
tag either there or linked from there.

Thanks,
Michael

> /
>      Leif
> 
>>> On 9/13/2023 1:10 PM, Ard Biesheuvel wrote:
>>>> On Wed, 13 Sept 2023 at 19:07, <mikuback@linux.microsoft.com> wrote:
>>>>>
>>>>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>>>>
>>>>> Adds a CI YAML entry to acknowledge a case where a macro is expanded
>>>>> that contains a print specifier.
>>>>>
>>>>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>>>>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>>>>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>>>>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>>>>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>>>
>>>> Acked-by: Ard Biesheuvel <ardb@kernel.org>
>>>>
>>>>> ---
>>>>>    ArmVirtPkg/ArmVirtPkg.ci.yaml | 8 ++++++++
>>>>>    1 file changed, 8 insertions(+)
>>>>>
>>>>> diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml 
>>>>> b/ArmVirtPkg/ArmVirtPkg.ci.yaml
>>>>> index 1e799dc4e194..506b0e72f0bb 100644
>>>>> --- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
>>>>> +++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
>>>>> @@ -125,5 +125,13 @@
>>>>>            ],           # words to extend to the dictionary for 
>>>>> this package
>>>>>            "IgnoreStandardPaths": [],   # Standard Plugin defined 
>>>>> paths that should be ignore
>>>>>            "AdditionalIncludePaths": [] # Additional paths to spell 
>>>>> check (wildcards supported)
>>>>> +    },
>>>>> +
>>>>> +    "DebugMacroCheck": {
>>>>> +      "StringSubstitutions": {
>>>>> +          # DynamicTablesPkg/Include/ConfigurationManagerObject.h
>>>>> +          # Reason: Expansion of macro that contains a print 
>>>>> specifier.
>>>>> +          "FMT_CM_OBJECT_ID": "0x%lx"
>>>>> +      }
>>>>>        }
>>>>>    }
>>>>> -- 
>>>>> 2.42.0.windows.2
>>>>>
>>>>
>>>>
>>>>
>>>>
>>
>>
>>
>>
>>
> 
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108848): https://edk2.groups.io/g/devel/message/108848
Mute This Topic: https://groups.io/mt/101341655/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 4/7] ArmVirtPkg.ci.yaml: Add debug macro exception
Posted by Michael D Kinney 8 months, 3 weeks ago
My understanding is single patch is deemed accepted by one of the following 
responses:

1) Maintainer provides Reviewed-by
2) Non-Maintainer provides Reviewed-by, and later a Maintainer provides
   Acked-by to indicate they accept the review performed by someone else.

An Acked-by alone by Maintainer is not sufficient.
An Acked-by alone by non-Maintainer is not sufficient.

If Maintainers/Reviewers are not processing patch in a reasonable
period of time, Stewards may act as backup Maintainers for that patch.

I would be concerned about a process that allows a patch to be
merged with only an Acked-by from a Maintainer with zero reviews.

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Leif
> Lindholm
> Sent: Tuesday, September 19, 2023 7:53 AM
> To: devel@edk2.groups.io; ardb@kernel.org; Michael Kubacki
> <mikuback@linux.microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Andrew Fish <afish@apple.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>; Gerd Hoffmann
> <kraxel@redhat.com>
> Subject: Re: [edk2-devel] [PATCH v2 4/7] ArmVirtPkg.ci.yaml: Add debug
> macro exception
> 
> On 2023-09-19 15:46, Ard Biesheuvel wrote:
> > On Mon, 18 Sept 2023 at 22:35, Michael Kubacki
> > <mikuback@linux.microsoft.com> wrote:
> >>
> >> Thanks Ard. I still need a Reviewed-by on this patch to complete
> the series.
> >
> > Actually, you don't but I suppose there is some difference of
> > interpretation here.
> >
> > In the Linux community (where these tags originated), an ack from a
> > maintainer means 'no objections, feel free to apply this to code
> that
> > I maintain'. In this case, I am not 100% sure what the change means,
> > so I am not comfortable claiming that I reviewed it, but given that
> > this is your area of expertise rather than mine, I trust that you
> know
> > what you are doing. Hence the acked-by.
> >
> > In other cases, I may rely on another person's expertise and their
> > reviewed-by to decide whether or not to merge something, rather than
> > review it myself. In this case, the acked-by is implied by the fact
> > that I decided to merge the PR (and therefore somewhat redundant).
> But
> > it comes down to the same thing.
> >
> > If there is a Tianocore rule that says every patch needs a reviewed-
> by
> > from a maintainer, we should probably fix that. It is *not* the job
> of
> > a maintainer to review everything (and this wouldn't scale to begin
> > with) - rather, it is their job to ensure that everything that gets
> > merged has been reviewed sufficiently, either by themselves or by
> > other people they have confidence in.
> 
> I was under the impression we had this conversation a few years ago
> and
> agreed a maintainer Ack was sufficient. Have we failed to document
> that
> fact?
> 
> /
>      Leif
> 
> >> On 9/13/2023 1:10 PM, Ard Biesheuvel wrote:
> >>> On Wed, 13 Sept 2023 at 19:07, <mikuback@linux.microsoft.com>
> wrote:
> >>>>
> >>>> From: Michael Kubacki <michael.kubacki@microsoft.com>
> >>>>
> >>>> Adds a CI YAML entry to acknowledge a case where a macro is
> expanded
> >>>> that contains a print specifier.
> >>>>
> >>>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> >>>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> >>>> Cc: Sami Mujawar <sami.mujawar@arm.com>
> >>>> Cc: Gerd Hoffmann <kraxel@redhat.com>
> >>>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> >>>
> >>> Acked-by: Ard Biesheuvel <ardb@kernel.org>
> >>>
> >>>> ---
> >>>>    ArmVirtPkg/ArmVirtPkg.ci.yaml | 8 ++++++++
> >>>>    1 file changed, 8 insertions(+)
> >>>>
> >>>> diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml
> b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> >>>> index 1e799dc4e194..506b0e72f0bb 100644
> >>>> --- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
> >>>> +++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> >>>> @@ -125,5 +125,13 @@
> >>>>            ],           # words to extend to the dictionary for
> this package
> >>>>            "IgnoreStandardPaths": [],   # Standard Plugin defined
> paths that should be ignore
> >>>>            "AdditionalIncludePaths": [] # Additional paths to
> spell check (wildcards supported)
> >>>> +    },
> >>>> +
> >>>> +    "DebugMacroCheck": {
> >>>> +      "StringSubstitutions": {
> >>>> +          #
> DynamicTablesPkg/Include/ConfigurationManagerObject.h
> >>>> +          # Reason: Expansion of macro that contains a print
> specifier.
> >>>> +          "FMT_CM_OBJECT_ID": "0x%lx"
> >>>> +      }
> >>>>        }
> >>>>    }
> >>>> --
> >>>> 2.42.0.windows.2
> >>>>
> >>>
> >>>
> >>>
> >>>
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108847): https://edk2.groups.io/g/devel/message/108847
Mute This Topic: https://groups.io/mt/101341655/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v2 4/7] ArmVirtPkg.ci.yaml: Add debug macro exception
Posted by Michael D Kinney 8 months, 3 weeks ago
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com >

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
> Kubacki
> Sent: Monday, September 18, 2023 3:35 PM
> To: devel@edk2.groups.io; Leif Lindholm <quic_llindhol@quicinc.com>; Sami
> Mujawar <sami.mujawar@arm.com>; Gerd Hoffmann <kraxel@redhat.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Subject: Re: [edk2-devel] [PATCH v2 4/7] ArmVirtPkg.ci.yaml: Add debug
> macro exception
> 
> Thanks Ard. I still need a Reviewed-by on this patch to complete the
> series.
> 
> On 9/13/2023 1:10 PM, Ard Biesheuvel wrote:
> > On Wed, 13 Sept 2023 at 19:07, <mikuback@linux.microsoft.com> wrote:
> >>
> >> From: Michael Kubacki <michael.kubacki@microsoft.com>
> >>
> >> Adds a CI YAML entry to acknowledge a case where a macro is expanded
> >> that contains a print specifier.
> >>
> >> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> >> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> >> Cc: Sami Mujawar <sami.mujawar@arm.com>
> >> Cc: Gerd Hoffmann <kraxel@redhat.com>
> >> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> >
> > Acked-by: Ard Biesheuvel <ardb@kernel.org>
> >
> >> ---
> >>   ArmVirtPkg/ArmVirtPkg.ci.yaml | 8 ++++++++
> >>   1 file changed, 8 insertions(+)
> >>
> >> diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml
> b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> >> index 1e799dc4e194..506b0e72f0bb 100644
> >> --- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
> >> +++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> >> @@ -125,5 +125,13 @@
> >>           ],           # words to extend to the dictionary for this
> package
> >>           "IgnoreStandardPaths": [],   # Standard Plugin defined paths
> that should be ignore
> >>           "AdditionalIncludePaths": [] # Additional paths to spell check
> (wildcards supported)
> >> +    },
> >> +
> >> +    "DebugMacroCheck": {
> >> +      "StringSubstitutions": {
> >> +          # DynamicTablesPkg/Include/ConfigurationManagerObject.h
> >> +          # Reason: Expansion of macro that contains a print specifier.
> >> +          "FMT_CM_OBJECT_ID": "0x%lx"
> >> +      }
> >>       }
> >>   }
> >> --
> >> 2.42.0.windows.2
> >>
> >
> >
> >
> >
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108812): https://edk2.groups.io/g/devel/message/108812
Mute This Topic: https://groups.io/mt/101341655/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-