[edk2-devel] [PATCH 2/3] OvmfPkg/RiscVVirt/README: explain the "acpi=off" machine property

Laszlo Ersek posted 3 patches 10 months ago
[edk2-devel] [PATCH 2/3] OvmfPkg/RiscVVirt/README: explain the "acpi=off" machine property
Posted by Laszlo Ersek 10 months ago
"acpi=off" is arguably unusual with UEFI guest OSes; add a note to explain
it. Original explanation by Drew Jones.

Cc: Andrei Warkentin <andrei.warkentin@intel.com>
Cc: Andrew Jones <ajones@ventanamicro.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 OvmfPkg/RiscVVirt/README.md | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/OvmfPkg/RiscVVirt/README.md b/OvmfPkg/RiscVVirt/README.md
index 193e4afe8dee..1dba1a26af2d 100644
--- a/OvmfPkg/RiscVVirt/README.md
+++ b/OvmfPkg/RiscVVirt/README.md
@@ -70,6 +70,11 @@ Below example shows how to boot openSUSE Tumbleweed E20.
         -device virtio-blk-device,drive=hd0 \
         -drive file=openSUSE-Tumbleweed-RISC-V-E20-efi.riscv64.raw,format=raw,id=hd0
 
+    Note: the `acpi=off` machine property is specified because Linux guest
+    support for ACPI (that is, the ACPI consumer side) is a work in progress.
+    Currently, `acpi=off` is recommended unless you are developing ACPI support
+    yourself.
+
 ## Test with your own OpenSBI binary
 Using the above QEMU command line, **RISCV_VIRT_CODE.fd** is launched by the
 OpenSBI binary that is bundled with QEMU. You can build your own OpenSBI binary



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108577): https://edk2.groups.io/g/devel/message/108577
Mute This Topic: https://groups.io/mt/101334265/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH 2/3] OvmfPkg/RiscVVirt/README: explain the "acpi=off" machine property
Posted by Andrew Jones 10 months ago
On Wed, Sep 13, 2023 at 12:55:50PM +0200, Laszlo Ersek wrote:
> "acpi=off" is arguably unusual with UEFI guest OSes; add a note to explain
> it. Original explanation by Drew Jones.
> 
> Cc: Andrei Warkentin <andrei.warkentin@intel.com>
> Cc: Andrew Jones <ajones@ventanamicro.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  OvmfPkg/RiscVVirt/README.md | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/OvmfPkg/RiscVVirt/README.md b/OvmfPkg/RiscVVirt/README.md
> index 193e4afe8dee..1dba1a26af2d 100644
> --- a/OvmfPkg/RiscVVirt/README.md
> +++ b/OvmfPkg/RiscVVirt/README.md
> @@ -70,6 +70,11 @@ Below example shows how to boot openSUSE Tumbleweed E20.
>          -device virtio-blk-device,drive=hd0 \
>          -drive file=openSUSE-Tumbleweed-RISC-V-E20-efi.riscv64.raw,format=raw,id=hd0
>  
> +    Note: the `acpi=off` machine property is specified because Linux guest
> +    support for ACPI (that is, the ACPI consumer side) is a work in progress.
> +    Currently, `acpi=off` is recommended unless you are developing ACPI support
> +    yourself.
> +
>  ## Test with your own OpenSBI binary
>  Using the above QEMU command line, **RISCV_VIRT_CODE.fd** is launched by the
>  OpenSBI binary that is bundled with QEMU. You can build your own OpenSBI binary
>

Reviewed-by: Andrew Jones <ajones@ventanamicro.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108638): https://edk2.groups.io/g/devel/message/108638
Mute This Topic: https://groups.io/mt/101334265/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 2/3] OvmfPkg/RiscVVirt/README: explain the "acpi=off" machine property
Posted by Ard Biesheuvel 10 months ago
On Wed, 13 Sept 2023 at 12:56, Laszlo Ersek <lersek@redhat.com> wrote:
>
> "acpi=off" is arguably unusual with UEFI guest OSes; add a note to explain
> it. Original explanation by Drew Jones.
>

Out of curiosity: how is this different from the -no-acpi QEMU command
line option?


> Cc: Andrei Warkentin <andrei.warkentin@intel.com>
> Cc: Andrew Jones <ajones@ventanamicro.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  OvmfPkg/RiscVVirt/README.md | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/OvmfPkg/RiscVVirt/README.md b/OvmfPkg/RiscVVirt/README.md
> index 193e4afe8dee..1dba1a26af2d 100644
> --- a/OvmfPkg/RiscVVirt/README.md
> +++ b/OvmfPkg/RiscVVirt/README.md
> @@ -70,6 +70,11 @@ Below example shows how to boot openSUSE Tumbleweed E20.
>          -device virtio-blk-device,drive=hd0 \
>          -drive file=openSUSE-Tumbleweed-RISC-V-E20-efi.riscv64.raw,format=raw,id=hd0
>
> +    Note: the `acpi=off` machine property is specified because Linux guest
> +    support for ACPI (that is, the ACPI consumer side) is a work in progress.
> +    Currently, `acpi=off` is recommended unless you are developing ACPI support
> +    yourself.
> +
>  ## Test with your own OpenSBI binary
>  Using the above QEMU command line, **RISCV_VIRT_CODE.fd** is launched by the
>  OpenSBI binary that is bundled with QEMU. You can build your own OpenSBI binary
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108580): https://edk2.groups.io/g/devel/message/108580
Mute This Topic: https://groups.io/mt/101334265/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 2/3] OvmfPkg/RiscVVirt/README: explain the "acpi=off" machine property
Posted by Laszlo Ersek 10 months ago
On 9/13/23 13:02, Ard Biesheuvel wrote:
> On Wed, 13 Sept 2023 at 12:56, Laszlo Ersek <lersek@redhat.com> wrote:
>>
>> "acpi=off" is arguably unusual with UEFI guest OSes; add a note to explain
>> it. Original explanation by Drew Jones.
>>
> 
> Out of curiosity: how is this different from the -no-acpi QEMU command
> line option?

They are the same thing:

https://www.qemu.org/docs/master/about/deprecated.html#no-acpi-since-8-0

"The -no-acpi setting has been turned into a machine property. Use
-machine acpi=off instead."

That is, "-no-acpi" has been deprecated since QEMU 8.0.

Cheers
Laszlo

> 
> 
>> Cc: Andrei Warkentin <andrei.warkentin@intel.com>
>> Cc: Andrew Jones <ajones@ventanamicro.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Sunil V L <sunilvl@ventanamicro.com>
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>  OvmfPkg/RiscVVirt/README.md | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/OvmfPkg/RiscVVirt/README.md b/OvmfPkg/RiscVVirt/README.md
>> index 193e4afe8dee..1dba1a26af2d 100644
>> --- a/OvmfPkg/RiscVVirt/README.md
>> +++ b/OvmfPkg/RiscVVirt/README.md
>> @@ -70,6 +70,11 @@ Below example shows how to boot openSUSE Tumbleweed E20.
>>          -device virtio-blk-device,drive=hd0 \
>>          -drive file=openSUSE-Tumbleweed-RISC-V-E20-efi.riscv64.raw,format=raw,id=hd0
>>
>> +    Note: the `acpi=off` machine property is specified because Linux guest
>> +    support for ACPI (that is, the ACPI consumer side) is a work in progress.
>> +    Currently, `acpi=off` is recommended unless you are developing ACPI support
>> +    yourself.
>> +
>>  ## Test with your own OpenSBI binary
>>  Using the above QEMU command line, **RISCV_VIRT_CODE.fd** is launched by the
>>  OpenSBI binary that is bundled with QEMU. You can build your own OpenSBI binary
>>
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108598): https://edk2.groups.io/g/devel/message/108598
Mute This Topic: https://groups.io/mt/101334265/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 2/3] OvmfPkg/RiscVVirt/README: explain the "acpi=off" machine property
Posted by Sunil V L 10 months ago
On Wed, Sep 13, 2023 at 01:02:07PM +0200, Ard Biesheuvel wrote:
> On Wed, 13 Sept 2023 at 12:56, Laszlo Ersek <lersek@redhat.com> wrote:
> >
> > "acpi=off" is arguably unusual with UEFI guest OSes; add a note to explain
> > it. Original explanation by Drew Jones.
> >
> 
> Out of curiosity: how is this different from the -no-acpi QEMU command
> line option?
> 
Hi Ard,

no-acpi switch is a legacy option which is deprecated. We should use
acpi machine parameter only.

REF: https://www.mail-archive.com/qemu-devel@nongnu.org/msg943298.html

Thanks,
Sunil


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108581): https://edk2.groups.io/g/devel/message/108581
Mute This Topic: https://groups.io/mt/101334265/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-