From nobody Fri Oct 18 09:19:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+108564+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108564+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1694579239; cv=none; d=zohomail.com; s=zohoarc; b=QcB4xa7PR6Ai5kIGfA3q6FK5zBbd1PmNXWpUoWrus/IrB5mhj7vuPq9o81jEiZVPaOinSYb0rSGB87Wa/Oe6G5o9WLinlq+7foDMATPUO5Xmd0SS3x8Ef0n+gQkxy5RJLyA6GN3uW96ZhzCCM/R1ROCclvjlArTf9w1ROmxNcO4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1694579239; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=2PNHGMQHVBoVKNs1Z63QC2EFsnoOY8hSCm/BxJLdr+Y=; b=hb8qA4lIKw7s5dSQfY1NKWQqFybxVMBJWoXK1XIwChEWO8j4SOqrAA6930unCLmQ9ohk5BTpy/bZuGSeKAx7H+mmnHlfJB802qj09AoxS5VetLe+VXEPlERRQJrTJqhFUS2/h+hU3STX/aiMi4kOc2IUAWQBX00a1bQfaFqbMbk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108564+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1694579239650434.46553735322993; Tue, 12 Sep 2023 21:27:19 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=M584Y1pzEEesuidvvyaa+HXgrI8fEWOIi4MKSDyTaAo=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1694579239; v=1; b=ps2Ttu6pUAkW54MsBzv42N5vshOPm6xYxp4a8qNcQxMp9Miqu+hC8Oxh3jPoNV2/pIg6Ix1k gKWwxKkLtXML0FQfbUidUqEN07C6SQLBx9GIaDfYl63vk4DWREPBrB/zk81YSSwvpHeFtz6UP6s RIWYoaOWdCz3VtW2KL41ZFVc= X-Received: by 127.0.0.2 with SMTP id eMP4YY1788612xr31v1gIGo3; Tue, 12 Sep 2023 21:27:19 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.4645.1694579216558329653 for ; Tue, 12 Sep 2023 21:27:18 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10831"; a="363595453" X-IronPort-AV: E=Sophos;i="6.02,142,1688454000"; d="scan'208";a="363595453" X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2023 21:27:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10831"; a="859093646" X-IronPort-AV: E=Sophos;i="6.02,142,1688454000"; d="scan'208";a="859093646" X-Received: from shwdeopenlab705.ccr.corp.intel.com ([10.239.55.100]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2023 21:27:16 -0700 From: "Yuanhao Xie" To: devel@edk2.groups.io Cc: Yuanhao Xie , Eric Dong , Rahul Kumar , Gerd Hoffmann , Ray Ni Subject: [edk2-devel] [PATCH 08/16] UefiCpuPkg/MtrrLib: Update MtrrGetFixedMtrr(). Date: Wed, 13 Sep 2023 12:26:31 +0800 Message-Id: <20230913042639.2066-9-yuanhao.xie@intel.com> In-Reply-To: <20230913042639.2066-1-yuanhao.xie@intel.com> References: <20230913042639.2066-1-yuanhao.xie@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yuanhao.xie@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: swTcLi2yQsrC7LoqeGhrz0HOx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1694579240176100017 Content-Type: text/plain; charset="utf-8" IsMtrrSupported() return true when either fixed mtrr supported or variable mtrr suppored. In this case, rather than checking whether MTRR is supported or not, we should specifically check for fixed MTRR support. Signed-off-by: Yuanhao Xie Cc: Eric Dong Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Ray Ni --- UefiCpuPkg/Library/MtrrLib/MtrrLib.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/UefiCpuPkg/Library/MtrrLib/MtrrLib.c b/UefiCpuPkg/Library/Mtrr= Lib/MtrrLib.c index c9440f01ef..b63c4b1c26 100644 --- a/UefiCpuPkg/Library/MtrrLib/MtrrLib.c +++ b/UefiCpuPkg/Library/MtrrLib/MtrrLib.c @@ -468,7 +468,10 @@ MtrrGetFixedMtrr ( OUT MTRR_FIXED_SETTINGS *FixedSettings ) { - if (!IsMtrrSupported ()) { + BOOLEAN FixedMtrrSupported; + + MtrrLibIsMtrrSupported (&FixedMtrrSupported, NULL); + if (!FixedMtrrSupported) { return FixedSettings; } =20 --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108564): https://edk2.groups.io/g/devel/message/108564 Mute This Topic: https://groups.io/mt/101331026/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-