From nobody Mon Sep 16 20:05:59 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+108558+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108558+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1694579224; cv=none; d=zohomail.com; s=zohoarc; b=S4Nb0VRjwlWJovJTFokSV8MBw0VZYVopQ5X8/yM03Srbe5XNzmgqBXhF4MODcfSOmO+yO0sqe9xfiLhu+JS6hjCRQDJE1wFcK+rtV7WWbjAYup+OdNZgN5X9Cx0mM3JVJTZv/mGrfn4p72TsuieUQHRvz0QsVuJidXxRKEFS2Qo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1694579224; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Amead3WCSHrcivbXVgKMS5syMJxkNsyJCJHJzCSMA/U=; b=YERdubdMmAIyboFgQ8T0vQGP19cZlABMe9PsoZb+dmhp2L/IplCFzIZeZjRNBWsC0JfUxTd+d0JjL3QGZ1VhZQ1YfxFTs+ENy5GEritZ88dDcoFfEMrRwUmB3AMzw8wsBRjWaS073X7otqk9T+mNB1ucjQ88JfkcizVHXfBqLjA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108558+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1694579224337236.33722080770178; Tue, 12 Sep 2023 21:27:04 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=+nYXdl2Guo5FV57SOYD464EKFIfabJM1FmG1nltvBSY=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1694579224; v=1; b=ATh1mNuXu2RzlIl11DBLM3p8jl+EtPf3Mk+0SnVr/dUOYGnw3GFIp4O92bLb4Sp+/nZaSv/Q EJU3uPEVQ6lEL39SHUAx9KGqNxzDvuXR8zUE1NpzuC1AGKP3FKEydnSmEilRXgxQaNwK7h09eQr D1xzd/xOxCyp1WpPhJByBVIY= X-Received: by 127.0.0.2 with SMTP id URObYY1788612xFYXbjzW260; Tue, 12 Sep 2023 21:27:04 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.4645.1694579216558329653 for ; Tue, 12 Sep 2023 21:27:03 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10831"; a="363595405" X-IronPort-AV: E=Sophos;i="6.02,142,1688454000"; d="scan'208";a="363595405" X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2023 21:27:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10831"; a="859093614" X-IronPort-AV: E=Sophos;i="6.02,142,1688454000"; d="scan'208";a="859093614" X-Received: from shwdeopenlab705.ccr.corp.intel.com ([10.239.55.100]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2023 21:27:01 -0700 From: "Yuanhao Xie" To: devel@edk2.groups.io Cc: Ray Ni , Eric Dong , Rahul Kumar , Gerd Hoffmann Subject: [edk2-devel] [PATCH 02/16] UefiCpuPkg/MtrrUnitTest: Update the Unit Test for IsMtrrSupported(). Date: Wed, 13 Sep 2023 12:26:25 +0800 Message-Id: <20230913042639.2066-3-yuanhao.xie@intel.com> In-Reply-To: <20230913042639.2066-1-yuanhao.xie@intel.com> References: <20230913042639.2066-1-yuanhao.xie@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yuanhao.xie@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: y1pRqoFbCar6TsvtkIfFS06ux1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1694579225823100003 Content-Type: text/plain; charset="utf-8" The previous implementation returns FALSE if either fixed MTRR is unsupported or the number of variable MTRRs is 0. The correct behavior is to return FALSE only when both fixed MTRR is unsupported and the number of variable MTRRs is 0. Signed-off-by: Ray Ni Cc: Eric Dong Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/UefiCpuPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c b/UefiCp= uPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c index 1409ae27bb..ac18d9d25d 100644 --- a/UefiCpuPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c +++ b/UefiCpuPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c @@ -399,7 +399,7 @@ UnitTestIsMtrrSupported ( SystemParameter.VariableMtrrCount =3D 0; SystemParameter.FixedMtrrSupported =3D TRUE; InitializeMtrrRegs (&SystemParameter); - UT_ASSERT_FALSE (IsMtrrSupported ()); + UT_ASSERT_TRUE (IsMtrrSupported ()); =20 // // MTRR capability on in CPUID leaf, but no fixed MTRRs. @@ -408,7 +408,7 @@ UnitTestIsMtrrSupported ( SystemParameter.VariableMtrrCount =3D 7; SystemParameter.FixedMtrrSupported =3D FALSE; InitializeMtrrRegs (&SystemParameter); - UT_ASSERT_FALSE (IsMtrrSupported ()); + UT_ASSERT_TRUE (IsMtrrSupported ()); =20 // // MTRR capability on in CPUID leaf with both variable and fixed MTRRs. --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108558): https://edk2.groups.io/g/devel/message/108558 Mute This Topic: https://groups.io/mt/101331018/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-