From nobody Wed May 15 10:26:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+108367+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108367+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1694075682559697.6101284131714; Thu, 7 Sep 2023 01:34:42 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=OlUpMZbsLGAq53/MEZS34xnGXzF8p7bWJIpfwS/7C88=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Authentication-Results:ARC-Message-Signature:From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694075682; v=1; b=t8j8BLW5iLtYz9MJSp4rx3VnBha/WT3MpyP5srgbkrJxKJSLOz+mecEyH23X0OPcNxOYaSIf 4nnyAz1MaNcsIvlr8K3R3+y/cAKKeFAzkOnn1uZxQMSm70mvtSVRyAz6w2+/I8c+xMiXnF8n2GZ zy3qxnZPD0FW1kibMvthbd18= X-Received: by 127.0.0.2 with SMTP id 9cjGYY1788612xfoAjkPlLg0; Thu, 07 Sep 2023 01:34:42 -0700 X-Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by mx.groups.io with SMTP id smtpd.web11.8569.1694075681120639367 for ; Thu, 07 Sep 2023 01:34:41 -0700 X-Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4RhCGS233Tz4K2V; Thu, 7 Sep 2023 08:34:40 +0000 (UTC) (envelope-from corvink@FreeBSD.org) X-Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RhCGS1Jymz3RyN; Thu, 7 Sep 2023 08:34:40 +0000 (UTC) (envelope-from corvink@FreeBSD.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1694075680; a=rsa-sha256; cv=none; b=E2xHKATCF9fj1DOxzlZf2C0upvxbm/1Mx2iYn4jW6mJtJvspMwF1tk02k9TEh+8ZaCXL30 b/zbprN6r1eGPBlUU/nw+JAxhGqbzEGhDwPI6kwZpw9wFMgJe+kG83f2vEBLfgV7vR6//o GmKv2kee1FLLUAPtfK0smL5P3+umv8n3ESYrEkJEzEhRCRda+bNbMVSLWsrGg5cE9Qno6h 0p5rO4V2K1CErUvwK7AoIenbZErR/0reudPZnG5RnX4ogj5Ox9H/hGuivoTw+aK/jsdUg0 VArdClH9nzUgt5izjF+GyMMqG3RO2MytieRYhLoRXkXAifIr/mxNRxjrftzllQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694075680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0S+QAdNBYYwvvr62O8dYjCsRpYGmAVnNwHr4LRj13Kc=; b=onFRxImzAr2eIeSDZXnCwp4BOp1aqomcX99bEqzlloSNAd4qW14guTnu8yrU9q7K/TMcfP ZpW+9JgWpS+2AoVrV2mE+7QtdHcIShyABqlEu/+jA0uYpK/UgvCFdnJVSmtqDT1slWsBt/ N7qqKlTSuUTEpvQ67+QKih2li6uQQcBEWzEUXgM03XxnenMwGxVt0GE0/u7v+UCgKYXYGR tHTiPZJhS6W2yJ7bo8EtJ5yWUV8q5o+I+cpT6pRrMqrigBqNP8Q2ezs9O+cjVybgJqYLs3 sntuFKMlP16qPHC657Bl6hhwmLqNGicdUAPKw4Q88Dc/BbT6GgTd3NjB4buXPg== X-Received: from corvink-nb.beckhoff.com (unknown [195.226.174.194]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: corvink) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RhCGR145vz168h; Thu, 7 Sep 2023 08:34:39 +0000 (UTC) (envelope-from corvink@FreeBSD.org) From: =?UTF-8?B?Q29ydmluIEvDtmhuZQ==?= To: devel@edk2.groups.io Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Rebecca Cran , Peter Grehan Subject: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: don't exit early if RSDP is not found in memory Date: Thu, 7 Sep 2023 10:34:00 +0200 Message-ID: <20230907083429.82300-2-corvink@FreeBSD.org> In-Reply-To: <20230907083429.82300-1-corvink@FreeBSD.org> References: <20230907083429.82300-1-corvink@FreeBSD.org> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,corvink@FreeBSD.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: OUteZjEawEMLDM4bdx7i5G39x1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1694075682757100002 Content-Type: text/plain; charset="utf-8" If OVMF fails to find the RSDP in memory, it should fall back installing the statically provided ACPI tables. Signed-off-by: Corvin K=C3=B6hne Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Rebecca Cran Cc: Peter Grehan Reviewed-by: Rebecca Cran --- OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c b/OvmfPkg/Bhyve/A= cpiPlatformDxe/AcpiPlatform.c index fb926a8bd803..57b1e7a99666 100644 --- a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c +++ b/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c @@ -259,19 +259,17 @@ InstallAcpiTables ( BHYVE_BIOS_PHYSICAL_END, &Rsdp ); - if (EFI_ERROR (Status)) { - return Status; - } - - Status =3D InstallAcpiTablesFromRsdp ( - AcpiTable, - Rsdp - ); if (!EFI_ERROR (Status)) { - return EFI_SUCCESS; + Status =3D InstallAcpiTablesFromRsdp ( + AcpiTable, + Rsdp + ); + if (!EFI_ERROR (Status)) { + return EFI_SUCCESS; + } } =20 - if (Status !=3D EFI_NOT_FOUND) { + if (EFI_ERROR (Status)) { DEBUG ( ( DEBUG_WARN, @@ -280,7 +278,6 @@ InstallAcpiTables ( Status ) ); - return Status; } =20 Status =3D InstallOvmfFvTables (AcpiTable); --=20 2.42.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108367): https://edk2.groups.io/g/devel/message/108367 Mute This Topic: https://groups.io/mt/101210702/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-