From nobody Wed May 15 07:29:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+108322+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108322+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1693996456; cv=none; d=zohomail.com; s=zohoarc; b=ei01efvGhqc3Ra/4IkTSLXSKTf6QMbczzr9pH1fBfn8oicWAenS71aU90PUxwvs7eJYFCb3e+g8J/ywcpwFv5kwtsnVnxHYmrTpJDayR08C9F9oOZP05TfyQzz+zWyZsd6EzuJICFxUyTsOjKvrjx9Bh2XX1+YCWbNoFPHEH86A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1693996456; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=2w7cvn/ijob3+Pp+hbR+w2eFu5AgRWJjpyInXp37SXs=; b=QN/HFtZsdCPbWHKieBIB3q/5SbIVo86r4BlgNiTu5lRdFC1BoohLUYDfTDfwC2WayO4f8ZAuqLZxKvGm55s4abj8Z8MeNvoh8EOxx7gvcuTTMwILyIvogJWyOho3SqbOmcgeMdja0M6sTZ01JPbqkP2oLisVckahYeVH6CgzZbY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108322+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1693996456095163.08219036263608; Wed, 6 Sep 2023 03:34:16 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=vTMiNvdLCUBDR5yBJcosKdUDE21xuM8/yJCNbsav0eM=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1693996455; v=1; b=eNrDgYZPYhz9vq0iwP09SN21KK/3Dht4qAAOO9kKWvhhF1UsFnLcDtV/YDjwY3Q3uqCUILBB Ild0GX3h3IPpg1RKP5AULPllziPyU5sW9RDmorbGu/Px5ccOTJsIQQAqSbzvmgGIi5cVhBj1TIY KsHYI2Mpid04lTv5xJ8dvs5I= X-Received: by 127.0.0.2 with SMTP id CebeYY1788612xIREdO7pQwg; Wed, 06 Sep 2023 03:34:15 -0700 X-Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mx.groups.io with SMTP id smtpd.web10.5460.1693996454927644580 for ; Wed, 06 Sep 2023 03:34:15 -0700 X-Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-31f4a286ae1so2253491f8f.3 for ; Wed, 06 Sep 2023 03:34:14 -0700 (PDT) X-Gm-Message-State: LyzWWQooqVIs27YbmXKpJAu3x1787277AA= X-Google-Smtp-Source: AGHT+IH0RYy7TzQQ56Q6oNmwCeBdE7TcMDa2UGxnzD91jBfce6aPa7yW4S7YNj5Uhjbo3dkUkH/3EA== X-Received: by 2002:adf:fec3:0:b0:31c:5c77:48ec with SMTP id q3-20020adffec3000000b0031c5c7748ecmr1863710wrs.62.1693996452958; Wed, 06 Sep 2023 03:34:12 -0700 (PDT) X-Received: from Michaels-iMac.lan ([193.219.99.195]) by smtp.gmail.com with ESMTPSA id x18-20020adfec12000000b0031989784d96sm20121686wrn.76.2023.09.06.03.34.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 03:34:12 -0700 (PDT) From: "Mike Beaton" To: devel@edk2.groups.io Cc: Eric Dong , Liming Gao , Samer El-Haj-Mahmoud , Ard Biesheuvel , Dandan Bi , Mike Beaton Subject: [edk2-devel] [PATCH v3] MdeModulePkg/HiiDatabase: Fix incorrect AllocateCopyPool size Date: Wed, 6 Sep 2023 11:33:39 +0100 Message-ID: <20230906103338.3320-2-mjsbeaton@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mjsbeaton@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1693996456457100002 Content-Type: text/plain; charset="utf-8" AsciiStrLen was one byte too short (though with alignment up from an odd si= ze would probably always have had the required space in practice). AsciiStrSize matches usage elsewhere in this file and in the codebase. Signed-off-by: Mike Beaton --- MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c b= /MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c index 96e05d4cf9..f67b7760f0 100644 --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c @@ -1987,7 +1987,7 @@ GetNameFromId ( NULL ); if (BestLanguage =3D=3D NULL) { - BestLanguage =3D AllocateCopyPool (AsciiStrLen ("en-US"), "en-US"); + BestLanguage =3D AllocateCopyPool (AsciiStrSize ("en-US"), "en-US"); ASSERT (BestLanguage !=3D NULL); } =20 --=20 2.41.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108322): https://edk2.groups.io/g/devel/message/108322 Mute This Topic: https://groups.io/mt/101189764/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-