From nobody Sun Feb 8 18:29:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+108159+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108159+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1693437553; cv=none; d=zohomail.com; s=zohoarc; b=HCSs0uYVbj9oRPg1Wq8g/7533Hmjtdj/LdPhwK+OVlmWcRjJYV2U4CC5z4w4PU+aKX/Z/6bPFJ/I4zr02zzmIsTo4iWtqMOPvEH5f8XuT0UcZ53A7r6hKUFWQbx9GB6bZUmjeczN2Cd9+E1XBDKZjfpM07INZY5cXXEskAIf1ek= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1693437553; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=8w8Y+vQhOa+cW+/TYSJgrrbg3qihMoO46c3lcFpDXk0=; b=bmnxe7rzC4YMJ4YUjcOIIxw5kbt+BLHdx2Z6hdbNGwVxDUZBge69AgaNNQwU3MZtjlizA7JGOprIyyK3z0hC0qJR8uU0dihPtJYem7kpRUpnuYIDn8cX+5lizLTt/I6rUXFmAj5KwSC6ep3t8LB7n9ODyJq1LvsHMTX27qUKocc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+108159+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1693437553518116.74030889513551; Wed, 30 Aug 2023 16:19:13 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=HyN2pgdMNobHWXyV/vk0rzLbLDzWXLWA2OWxrPkXqFA=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1693437553; v=1; b=hfUbBJfR5KcqSNfipCxTbh/vDuM2OjYiCGwH7Ew87gsQTY1iaygK2ROet5fpo+1lp1KtIFwk lL1984BaIsCCl1wc09HBmyY0YykbFluEBrpvSYvg+NnV86FWlpU6s1GvhOdo4t3ZokznxUg2KdQ vwno7IMGfb1w2myk96Swg3X0= X-Received: by 127.0.0.2 with SMTP id 20XTYY1788612xhJD8iW9qTI; Wed, 30 Aug 2023 16:19:13 -0700 X-Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mx.groups.io with SMTP id smtpd.web11.4944.1693437547132133643 for ; Wed, 30 Aug 2023 16:19:07 -0700 X-Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-686be3cbea0so976893b3a.0 for ; Wed, 30 Aug 2023 16:19:07 -0700 (PDT) X-Gm-Message-State: ca1ymFnqNiiLQIXTMXSbJICUx1787277AA= X-Google-Smtp-Source: AGHT+IHQjgW+ErqFT63U8gp7q8EMK+4vM+YehDjpNPr/zgOioX+py5t5xf4ENqSQa+mbPXSp/ja6Tg== X-Received: by 2002:a05:6a20:3d8b:b0:149:729c:d065 with SMTP id s11-20020a056a203d8b00b00149729cd065mr1453895pzi.14.1693437546390; Wed, 30 Aug 2023 16:19:06 -0700 (PDT) X-Received: from localhost.localdomain ([50.46.253.1]) by smtp.gmail.com with ESMTPSA id x16-20020a62fb10000000b0064398fe3451sm102550pfm.217.2023.08.30.16.19.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Aug 2023 16:19:06 -0700 (PDT) From: "Taylor Beebe" To: devel@edk2.groups.io Cc: Jian J Wang , Liming Gao , Dandan Bi Subject: [edk2-devel] [PATCH v3 05/26] MdeModulePkg: Copy PEI PCD Database Into New Buffer Date: Wed, 30 Aug 2023 16:18:13 -0700 Message-ID: <20230830231851.779-6-taylor.d.beebe@gmail.com> In-Reply-To: <20230830231851.779-1-taylor.d.beebe@gmail.com> References: <20230830231851.779-1-taylor.d.beebe@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,taylor.d.beebe@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1693437554937100049 Content-Type: text/plain; charset="utf-8" HOB memory should not be written to in DXE phase. This patch copies the PCD database from PEI into a new buffer so updates to dynamic PCDs don't write to HOB memory. Signed-off-by: Taylor Beebe Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi --- MdeModulePkg/Universal/PCD/Dxe/Service.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/PCD/Dxe/Service.c b/MdeModulePkg/Univer= sal/PCD/Dxe/Service.c index 1ae06a639c43..0feb11142545 100644 --- a/MdeModulePkg/Universal/PCD/Dxe/Service.c +++ b/MdeModulePkg/Universal/PCD/Dxe/Service.c @@ -885,15 +885,17 @@ BuildPcdDxeDataBase ( // be NULL. If it is NULL, we just copy over the DXE Default // Value to PCD Database. // - PeiDatabase =3D (PEI_PCD_DATABASE *)GET_GUID_HOB_DATA (GuidHob); + PeiDatabase =3D AllocateCopyPool ((UINTN)GET_GUID_HOB_DATA_SIZE (GuidH= ob), GET_GUID_HOB_DATA (GuidHob)); + ASSERT (PeiDatabase !=3D NULL); =20 // // Get next one that stores full PEI data // GuidHob =3D GetNextGuidHob (&gPcdDataBaseHobGuid, GET_NEXT_HOB (GuidHo= b)); if (GuidHob !=3D NULL) { - mPeiPcdDbBinary =3D (PEI_PCD_DATABASE *)GET_GUID_HOB_DATA (GuidHob); mPeiPcdDbSize =3D (UINTN)GET_GUID_HOB_DATA_SIZE (GuidHob); + mPeiPcdDbBinary =3D (PEI_PCD_DATABASE *)AllocateCopyPool (mPeiPcdDbS= ize, GET_GUID_HOB_DATA (GuidHob)); + ASSERT (mPeiPcdDbBinary !=3D NULL); } =20 // --=20 2.42.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108159): https://edk2.groups.io/g/devel/message/108159 Mute This Topic: https://groups.io/mt/101064077/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-