From nobody Tue Feb 10 03:40:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+107964+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+107964+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1692756595; cv=none; d=zohomail.com; s=zohoarc; b=SnXitxPH8P63+gUCWHcam3qZAIC/1W9sDiOB2HOojg+yivlkEFuFUnmEAUvLmaaXCIVMZ+9te12eRyqv/HeC2gMXCvVPgO2Ip3iNP472fGoqLSu80wo58d3h2k0aGJdoFisDD/6o2uDFB2QcoDNdylIIpkcSBVqIREQIaBbjxeI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1692756595; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=SeFehpLueDKndDa8gnRJHqY44F4Owviv5PaCpOs83+g=; b=m8A9dIgvn3jC75105/H3uhLFEjEELoDtLdUlfWXS8PvoLbQV5RBfn9R56EvhKrX0M76uTWTxbY/ewol/FYpkp1s+uXs+VfYKWEAGBBhVEjfutHOi5dEO6hjq+2r0KR413qRGGyogEm5u8T52eVEyeooF54IDEzIVx3FYIOhu6Ks= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+107964+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1692756595086667.5129822775185; Tue, 22 Aug 2023 19:09:55 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=6LbMZorJ9PZTxUSgjXcVB2kkd46v9/2223vn5D+s6IE=; c=relaxed/simple; d=groups.io; h=From:To:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1692756594; v=1; b=xaW++ZjzW3QZy5KSoQbeLV+JZK9SqVXiKFeEee6Fmf/P21TXYAt79eUJ5RvJLnz8+dfx7if6 M9efUrQqRCan405EYZvhDSZX1nq0esm4aPCYQsQFpK9TZE9PYSpd9RklcUddArfImEpxAzWliRG m7NMwg6XqiXAwK3OWhuvz0JU= X-Received: by 127.0.0.2 with SMTP id Uqr7YY1788612xhsNuH0SW6E; Tue, 22 Aug 2023 19:09:54 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.2908.1692756591336687618 for ; Tue, 22 Aug 2023 19:09:51 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 693A014BF for ; Tue, 22 Aug 2023 19:10:31 -0700 (PDT) X-Received: from beelzebub.ast.arm.com (abhsin07-ThinkStation-P720.austin.arm.com [10.118.30.31]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A36013F7C5 for ; Tue, 22 Aug 2023 19:09:50 -0700 (PDT) From: "Abhimanyu Singh" To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH v2 3/6] uefi-sct/SctPkg: TCG MORLOCK SetVariable Test Date: Tue, 22 Aug 2023 21:09:44 -0500 Message-Id: <20230823020947.124395-4-Abhi.Singh@arm.com> In-Reply-To: <20230823020947.124395-1-Abhi.Singh@arm.com> References: <20230823020947.124395-1-Abhi.Singh@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,Abhi.Singh@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: XNGhBnSnaaxng2JtLtDLFWJvx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1692756596117100021 Content-Type: text/plain; charset="utf-8" SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4419 -Implement MemoryOverwriteRequestControlLockSetVariable test cases -Add Assertions 9 through 18 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest Cc: G Edhaya Chandran Cc: Barton Gao Cc: Carolyn Gjertsen Signed-off-by: Abhi Singh Change-Id: I23ba7256441354f497ecdc96a394df5ba5cae8df --- uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteReques= t/BlackBoxTest/Guid.h | 50 +++ uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteReques= t/BlackBoxTest/TCGMemoryOverwriteRequestBBTestMain.h | 8 + uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteReques= t/BlackBoxTest/Guid.c | 20 + uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteReques= t/BlackBoxTest/TCGMemoryOverwriteRequestBBTestFunction.c | 405 ++++++++++++= ++++++++ 4 files changed, 483 insertions(+) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOve= rwriteRequest/BlackBoxTest/Guid.h b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Runti= meServices/TCGMemoryOverwriteRequest/BlackBoxTest/Guid.h index 84175504579c..29be47393385 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteR= equest/BlackBoxTest/Guid.h +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteR= equest/BlackBoxTest/Guid.h @@ -49,6 +49,36 @@ Abstract: #define EFI_TEST_TCGMORTESTFUNCTION_ASSERTION_008_GUID \ { 0x5f0b42ef, 0x3cec, 0x46ad, {0xbc, 0x5b, 0xc3, 0x7a, 0x1d, 0x45, 0x41, 0= x29 }} =20 +#define EFI_TEST_TCGMORTESTFUNCTION_ASSERTION_009_GUID \ +{ 0x9665c8d9, 0x267c, 0x4393, {0xa4, 0x72, 0x10, 0x54, 0x43, 0x56, 0x20, 0= x21 }} + +#define EFI_TEST_TCGMORTESTFUNCTION_ASSERTION_010_GUID \ +{ 0xce655812, 0xcc40, 0x42b0, {0x80, 0xd1, 0xa7, 0x26, 0xdb, 0x14, 0x9e, 0= xa8 }} + +#define EFI_TEST_TCGMORTESTFUNCTION_ASSERTION_011_GUID \ +{ 0xd34348ad, 0x5d46, 0x4961, {0x91, 0x3e, 0xb1, 0xf2, 0xc5, 0xe7, 0x0f, 0= x7d }} + +#define EFI_TEST_TCGMORTESTFUNCTION_ASSERTION_012_GUID \ +{ 0x838311e0, 0x419a, 0x4c92, {0x90, 0x60, 0xbf, 0x94, 0x59, 0xd3, 0xc3, 0= x59 }} + +#define EFI_TEST_TCGMORTESTFUNCTION_ASSERTION_013_GUID \ +{ 0x12998a9c, 0xc863, 0x4572, {0x80, 0x6c, 0xb6, 0x40, 0x97, 0x91, 0x89, 0= x7f }} + +#define EFI_TEST_TCGMORTESTFUNCTION_ASSERTION_014_GUID \ +{ 0xebd4ba26, 0x44c3, 0x464a, {0x88, 0xe3, 0x3b, 0x44, 0x94, 0x88, 0xbb, 0= xb8 }} + +#define EFI_TEST_TCGMORTESTFUNCTION_ASSERTION_015_GUID \ +{ 0x00920c8e, 0x241d, 0x4da0, {0x8b, 0x59, 0xc3, 0xad, 0xe0, 0xd6, 0x4e, 0= xc9 }} + +#define EFI_TEST_TCGMORTESTFUNCTION_ASSERTION_016_GUID \ +{ 0x169a43cc, 0x23fa, 0x4887, {0x8b, 0x4f, 0x11, 0xb2, 0xa0, 0x88, 0x4f, 0= x63 }} + +#define EFI_TEST_TCGMORTESTFUNCTION_ASSERTION_017_GUID \ +{ 0x7c11d0ab, 0x7a84, 0x482b, {0xb7, 0x5a, 0xd7, 0x72, 0x6c, 0x3e, 0xae, 0= x0e }} + +#define EFI_TEST_TCGMORTESTFUNCTION_ASSERTION_018_GUID \ +{ 0xbbaa52b6, 0x5576, 0x4acd, {0xb9, 0x5f, 0x86, 0x22, 0x5e, 0xfc, 0xb0, 0= x31 }} + extern EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid001; =20 extern EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid002; @@ -64,3 +94,23 @@ extern EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAs= sertionGuid006; extern EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid007; =20 extern EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid008; + +extern EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid009; + +extern EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid010; + +extern EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid011; + +extern EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid012; + +extern EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid013; + +extern EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid014; + +extern EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid015; + +extern EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid016; + +extern EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid017; + +extern EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid018; diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOve= rwriteRequest/BlackBoxTest/TCGMemoryOverwriteRequestBBTestMain.h b/uefi-sct= /SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteRequest/BlackBo= xTest/TCGMemoryOverwriteRequestBBTestMain.h index 46c2c2faa388..553959762be8 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteR= equest/BlackBoxTest/TCGMemoryOverwriteRequestBBTestMain.h +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteR= equest/BlackBoxTest/TCGMemoryOverwriteRequestBBTestMain.h @@ -49,6 +49,7 @@ typedef struct _RESET_DATA { #define MOR_BIT_HIGH 0x1 =20 #define MOR_LOCK_DATA_UNLOCKED 0x0 +#define MOR_LOCK_DATA_LOCKED_WITHOUT_KEY 0x1 =20 =20 // @@ -92,6 +93,13 @@ TCGMemoryOverwriteRequestControlSetVariable ( IN RESET_DATA *ResetData ); =20 +EFI_STATUS +TCGMemoryOverwriteRequestControlLockSetVariable ( + IN EFI_STANDARD_TEST_LIBRARY_PROTOCOL *StandardLib, + IN EFI_TEST_RECOVERY_LIBRARY_PROTOCOL *RecoveryLib, + IN RESET_DATA *ResetData + ); + // ***********************************************************************= ***** // Entry GUIDs for Test // ***********************************************************************= ***** diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOve= rwriteRequest/BlackBoxTest/Guid.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Runti= meServices/TCGMemoryOverwriteRequest/BlackBoxTest/Guid.c index 07bc98b8d764..8574b51af6e4 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteR= equest/BlackBoxTest/Guid.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteR= equest/BlackBoxTest/Guid.c @@ -43,3 +43,23 @@ EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertion= Guid006 =3D EFI_TEST_TCGMO EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid007 =3D EFI_TE= ST_TCGMORTESTFUNCTION_ASSERTION_007_GUID; =20 EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid008 =3D EFI_TE= ST_TCGMORTESTFUNCTION_ASSERTION_008_GUID; + +EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid009 =3D EFI_TE= ST_TCGMORTESTFUNCTION_ASSERTION_009_GUID; + +EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid010 =3D EFI_TE= ST_TCGMORTESTFUNCTION_ASSERTION_010_GUID; + +EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid011 =3D EFI_TE= ST_TCGMORTESTFUNCTION_ASSERTION_011_GUID; + +EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid012 =3D EFI_TE= ST_TCGMORTESTFUNCTION_ASSERTION_012_GUID; + +EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid013 =3D EFI_TE= ST_TCGMORTESTFUNCTION_ASSERTION_013_GUID; + +EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid014 =3D EFI_TE= ST_TCGMORTESTFUNCTION_ASSERTION_014_GUID; + +EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid015 =3D EFI_TE= ST_TCGMORTESTFUNCTION_ASSERTION_015_GUID; + +EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid016 =3D EFI_TE= ST_TCGMORTESTFUNCTION_ASSERTION_016_GUID; + +EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid017 =3D EFI_TE= ST_TCGMORTESTFUNCTION_ASSERTION_017_GUID; + +EFI_GUID gTCGMemoryOverwriteRequestTestFunctionAssertionGuid018 =3D EFI_TE= ST_TCGMORTESTFUNCTION_ASSERTION_018_GUID; diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOve= rwriteRequest/BlackBoxTest/TCGMemoryOverwriteRequestBBTestFunction.c b/uefi= -sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteRequest/Bla= ckBoxTest/TCGMemoryOverwriteRequestBBTestFunction.c index 40842f2b064e..5b6adbe550c7 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteR= equest/BlackBoxTest/TCGMemoryOverwriteRequestBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteR= equest/BlackBoxTest/TCGMemoryOverwriteRequestBBTestFunction.c @@ -39,6 +39,8 @@ Abstract: =20 #define LOCK_SET_VARIABLE_TEST 3 =20 +#define LOCK_UNLOCKED_STATE_TEST 4 + =20 /** * Entry point for TCG Platform Reset Attack Mitigation MemoryOverwrite E= FI Variables Function Test. @@ -137,6 +139,15 @@ BBTestTCGMemoryOverwriteRequestFunctionTest ( return Status; } } + if (ResetData->CheckpointStep =3D=3D LOCK_SET_VARIABLE_TEST) { + // + // Test Checkpoint LOCK_SET_VARIABLE_TEST + // + TCGMemoryOverwriteRequestControlLockSetVariable (StandardLib, Recovery= Lib, ResetData); + if(EFI_ERROR(Status)) { + return Status; + } + } // // After all Checkpoints have run // @@ -610,3 +621,397 @@ TCGMemoryOverwriteRequestControlSetVariable ( =20 return EFI_SUCCESS; } + + +/** + * MemoryOverwriteRequestControlLock SetVariable() with different variati= ons + * of only a single invalid parameter being passed, with the rest being v= alid parameters + * @param StandardLib A pointer to EFI_STANDARD_TEST_LIBRARY_PROTOCOL + * instance. + * @param RecoveryLib A pointer to EFI_TEST_RECOVERY_LIBRARY_PROTOCOL + * instance. + * @param ResetData A pointer to the ResetData buffer which is used = throughout the + * test + * @return EFI_SUCCESS Successfully. + * @return Other value Something failed. + */ +EFI_STATUS +TCGMemoryOverwriteRequestControlLockSetVariable ( + IN EFI_STANDARD_TEST_LIBRARY_PROTOCOL *StandardLib, + IN EFI_TEST_RECOVERY_LIBRARY_PROTOCOL *RecoveryLib, + IN RESET_DATA *ResetData + ) +{ + EFI_STATUS Status; + EFI_TEST_ASSERTION Result; + UINTN DataSize; + UINT8 MemoryOverwriteRequestControlLockDa= ta; + UINT32 Attributes; + + if (ResetData->Step =3D=3D 0) { + goto INITIAL_RESET; + } else if (ResetData->Step =3D=3D 1) { + goto MORLOCK_SET_VARIABLE; + } + +INITIAL_RESET: + // + // Reset MORLock variable by performing a cold reset + // + + ResetData->Step =3D 1; + ResetData->CheckpointStep =3D LOCK_SET_VARIABLE_TEST; + + Status =3D RecoveryLib->WriteResetRecord ( + RecoveryLib, + sizeof (RESET_DATA), + (UINT8*)ResetData + ); + if (EFI_ERROR(Status)) { + StandardLib->RecordAssertion ( + StandardLib, + EFI_TEST_ASSERTION_FAILED, + gTestGenericFailureGuid, + L"TestRecoveryLib - WriteResetRecord", + L"%a:%d:Status - %r", + __FILE__, + (UINTN)__LINE__, + Status + ); + return Status; + } + + SctPrint (L"System will cold reset after 1 second..."); + gtBS->Stall (1000000); + gtRT->ResetSystem ( + EfiResetCold, + EFI_SUCCESS, + 0, + NULL + ); + +MORLOCK_SET_VARIABLE: + // + // reset step count and Update Checkpoint to LOCK_UNLOCKED_STATE_TEST + // + + ResetData->Step =3D 0; + ResetData->CheckpointStep =3D LOCK_UNLOCKED_STATE_TEST; + + Status =3D RecoveryLib->WriteResetRecord ( + RecoveryLib, + sizeof (RESET_DATA), + (UINT8*)ResetData + ); + if (EFI_ERROR(Status)) { + StandardLib->RecordAssertion ( + StandardLib, + EFI_TEST_ASSERTION_FAILED, + gTestGenericFailureGuid, + L"TestRecoveryLib - WriteResetRecord", + L"%a:%d:Status - %r", + __FILE__, + (UINTN)__LINE__, + Status + ); + return Status; + } + + // MORLOCK SetVariable to Locked without Key with valid GUID, variable n= ame, Data, and DataSize + // except for invalid attributes value =3D=3D 0 + // verify SetVariable returns EFI_WRITE_PROTECTED and GetVariable return= s a Data Value =3D=3D 0 + DataSize =3D sizeof(MemoryOverwriteRequestControlLockData); + Attributes =3D 0; + MemoryOverwriteRequestControlLockData =3D MOR_LOCK_DATA_LOCKED_WITHOUT_K= EY; + + Status =3D gtRT->SetVariable ( + L"MemoryOverwriteRequestControlLock", // Variable= Name + &gEfiMemoryOverwriteRequestControlLockGuid, // VendorGu= id + Attributes, // Attribut= es + DataSize, // DataSize + &MemoryOverwriteRequestControlLockData // Data + ); + if (Status =3D=3D EFI_WRITE_PROTECTED) { + Result =3D EFI_TEST_ASSERTION_PASSED; + } else { + Result =3D EFI_TEST_ASSERTION_FAILED; + } + + StandardLib->RecordAssertion ( + StandardLib, + Result, + gTCGMemoryOverwriteRequestTestFunctionAssertionGuid009, + L"MemoryOverwriteRequestControlLock - SetVariable() with= Attributes =3D=3D 0 returns EFI_WRITE_PROTECTED", + L"%a:%d:Status - %r", + __FILE__, + (UINTN)__LINE__, + Status + ); + + // now change attributes to valid before GetVariable to check that MORLO= CK value is still 0x00 or unlocked + DataSize =3D sizeof(MemoryOverwriteRequestControlLockData); + Attributes =3D TCG_MOR_VARIABLE_ATTRIBUTES; + + Status =3D gtRT->GetVariable ( + L"MemoryOverwriteRequestControlLock", // Variable= Name + &gEfiMemoryOverwriteRequestControlLockGuid, // VendorGu= id + &Attributes, // Attribut= es + &DataSize, // DataSize + &MemoryOverwriteRequestControlLockData // Data + ); + if (EFI_ERROR (Status) || (MemoryOverwriteRequestControlLockData !=3D MO= R_LOCK_DATA_UNLOCKED)) { + Result =3D EFI_TEST_ASSERTION_FAILED; + } else { + Result =3D EFI_TEST_ASSERTION_PASSED; + } + + StandardLib->RecordAssertion ( + StandardLib, + Result, + gTCGMemoryOverwriteRequestTestFunctionAssertionGuid010, + L"MemoryOverwriteRequestControlLock - Lock value remains= Unlocked", + L"%a:%d:Status - %r", + __FILE__, + (UINTN)__LINE__, + Status + ); + + // MORLOCK SetVariable with valid GUID, variable name, Data, and Attribu= tes + // except for invalid DataSize =3D=3D 0 + // verify SetVariable returns EFI_WRITE_PROTECTED and GetVariable return= s a Data Value =3D=3D 0 + DataSize =3D 0; + Attributes =3D TCG_MOR_VARIABLE_ATTRIBUTES; + MemoryOverwriteRequestControlLockData =3D MOR_LOCK_DATA_LOCKED_WITHOUT_K= EY; + + Status =3D gtRT->SetVariable ( + L"MemoryOverwriteRequestControlLock", // Variable= Name + &gEfiMemoryOverwriteRequestControlLockGuid, // VendorGu= id + Attributes, // Attribut= es + DataSize, // DataSize + &MemoryOverwriteRequestControlLockData // Data + ); + if (Status =3D=3D EFI_WRITE_PROTECTED) { + Result =3D EFI_TEST_ASSERTION_PASSED; + } else { + Result =3D EFI_TEST_ASSERTION_FAILED; + } + + StandardLib->RecordAssertion ( + StandardLib, + Result, + gTCGMemoryOverwriteRequestTestFunctionAssertionGuid011, + L"MemoryOverwriteRequestControlLock - SetVariable() with= DataSize =3D=3D 0 returns EFI_WRITE_PROTECTED", + L"%a:%d:Status - %r", + __FILE__, + (UINTN)__LINE__, + Status + ); + + // change datasize to valid value before GetVariable + DataSize =3D sizeof(MemoryOverwriteRequestControlLockData); + Attributes =3D TCG_MOR_VARIABLE_ATTRIBUTES; + + // now check that MORLOCK value is still 0x00 or Unlocked + Status =3D gtRT->GetVariable ( + L"MemoryOverwriteRequestControlLock", // Variable= Name + &gEfiMemoryOverwriteRequestControlLockGuid, // VendorGu= id + &Attributes, // Attribut= es + &DataSize, // DataSize + &MemoryOverwriteRequestControlLockData // Data + ); + if (EFI_ERROR (Status) || (MemoryOverwriteRequestControlLockData !=3D MO= R_LOCK_DATA_UNLOCKED)) { + Result =3D EFI_TEST_ASSERTION_FAILED; + } else { + Result =3D EFI_TEST_ASSERTION_PASSED; + } + + StandardLib->RecordAssertion ( + StandardLib, + Result, + gTCGMemoryOverwriteRequestTestFunctionAssertionGuid012, + L"MemoryOverwriteRequestControlLock - Lock value remains= Unlocked", + L"%a:%d:Status - %r", + __FILE__, + (UINTN)__LINE__, + Status + ); + + // MORLOCK SetVariable with valid GUID, variable name, DataSize, and Att= ributes + // except for Data =3D=3D NULL + // verify SetVariable returns EFI_INVALID_PARAMETER and GetVariable retu= rns a Data Value =3D=3D 0 + DataSize =3D sizeof(MemoryOverwriteRequestControlLockData); + Attributes =3D TCG_MOR_VARIABLE_ATTRIBUTES; + + Status =3D gtRT->SetVariable ( + L"MemoryOverwriteRequestControlLock", // Variable= Name + &gEfiMemoryOverwriteRequestControlLockGuid, // VendorGu= id + Attributes, // Attribut= es + DataSize, // DataSize + NULL // Data + ); + if (Status =3D=3D EFI_INVALID_PARAMETER) { + Result =3D EFI_TEST_ASSERTION_PASSED; + } else { + Result =3D EFI_TEST_ASSERTION_FAILED; + } + + StandardLib->RecordAssertion ( + StandardLib, + Result, + gTCGMemoryOverwriteRequestTestFunctionAssertionGuid013, + L"MemoryOverwriteRequestControlLock - SetVariable() with= Data parameter as NULL returns EFI_WRITE_PROTECTED", + L"%a:%d:Status - %r", + __FILE__, + (UINTN)__LINE__, + Status + ); + + // now check that MORLOCK value is still =3D 0x00 or Unlocked + Status =3D gtRT->GetVariable ( + L"MemoryOverwriteRequestControlLock", // Variable= Name + &gEfiMemoryOverwriteRequestControlLockGuid, // VendorGu= id + &Attributes, // Attribut= es + &DataSize, // DataSize + &MemoryOverwriteRequestControlLockData // Data + ); + if (EFI_ERROR (Status) || (MemoryOverwriteRequestControlLockData !=3D MO= R_LOCK_DATA_UNLOCKED)) { + Result =3D EFI_TEST_ASSERTION_FAILED; + } else { + Result =3D EFI_TEST_ASSERTION_PASSED; + } + + StandardLib->RecordAssertion ( + StandardLib, + Result, + gTCGMemoryOverwriteRequestTestFunctionAssertionGuid014, + L"MemoryOverwriteRequestControlLock - Lock value remains= Unlocked", + L"%a:%d:Status - %r", + __FILE__, + (UINTN)__LINE__, + Status + ); + + // MORLOCK SetVariable to Lock without key with valid GUID, variable nam= e, Data, and DataSize + // except for invalid Attributes !=3D NV+BS+RT + // this test will use invalid Attributes =3D=3D NV + BS + // verify SetVariable returns EFI_INVALID_PARAMETER and GetVariable retu= rns a Data Value =3D=3D 0 + DataSize =3D sizeof(MemoryOverwriteRequestControlLockData); + Attributes =3D EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCE= SS; + MemoryOverwriteRequestControlLockData =3D MOR_LOCK_DATA_LOCKED_WITHOUT_K= EY; + + Status =3D gtRT->SetVariable ( + L"MemoryOverwriteRequestControlLock", // Variable= Name + &gEfiMemoryOverwriteRequestControlLockGuid, // VendorGu= id + Attributes, // Attribut= es + DataSize, // DataSize + &MemoryOverwriteRequestControlLockData // Data + ); + if (Status =3D=3D EFI_INVALID_PARAMETER) { + Result =3D EFI_TEST_ASSERTION_PASSED; + } else { + Result =3D EFI_TEST_ASSERTION_FAILED; + } + + StandardLib->RecordAssertion ( + StandardLib, + Result, + gTCGMemoryOverwriteRequestTestFunctionAssertionGuid015, + L"MemoryOverwriteRequestControlLock - SetVariable() with= Attributes =3D=3D NV returns EFI_INVALID_PARAMETER", + L"%a:%d:Status - %r", + __FILE__, + (UINTN)__LINE__, + Status + ); + + // change attributes value to valid NV+BS+RT for GetVariable + DataSize =3D sizeof(MemoryOverwriteRequestControlLockData); + Attributes =3D TCG_MOR_VARIABLE_ATTRIBUTES; + + // now check that MORLOCK value is =3D 0x00 or unlocked + Status =3D gtRT->GetVariable ( + L"MemoryOverwriteRequestControlLock", // Variable= Name + &gEfiMemoryOverwriteRequestControlLockGuid, // VendorGu= id + &Attributes, // Attribut= es + &DataSize, // DataSize + &MemoryOverwriteRequestControlLockData // Data + ); + if (EFI_ERROR (Status) || (MemoryOverwriteRequestControlLockData !=3D MO= R_LOCK_DATA_UNLOCKED)) { + Result =3D EFI_TEST_ASSERTION_FAILED; + } else { + Result =3D EFI_TEST_ASSERTION_PASSED; + } + + StandardLib->RecordAssertion ( + StandardLib, + Result, + gTCGMemoryOverwriteRequestTestFunctionAssertionGuid016, + L"MemoryOverwriteRequestControlLock - Lock value remains= Unlocked", + L"%a:%d:Status - %r", + __FILE__, + (UINTN)__LINE__, + Status + ); + + // MORLOCK SetVariable to Locked without key with valid GUID, variable n= ame, Data, and Attributes + // except for invalid DataSize !=3D 1 && !=3D 8 + // this test will use invalid DataSize =3D=3D 5 + // verify SetVariable returns EFI_INVALID_PARAMETER and GetVariable retu= rns a Data Value =3D=3D 0 + DataSize =3D 5; + Attributes =3D TCG_MOR_VARIABLE_ATTRIBUTES; + MemoryOverwriteRequestControlLockData =3D MOR_LOCK_DATA_LOCKED_WITHOUT_K= EY; + + Status =3D gtRT->SetVariable ( + L"MemoryOverwriteRequestControlLock", // Variable= Name + &gEfiMemoryOverwriteRequestControlLockGuid, // VendorGu= id + Attributes, // Attribut= es + DataSize, // DataSize + &MemoryOverwriteRequestControlLockData // Data + ); + if (Status =3D=3D EFI_INVALID_PARAMETER) { + Result =3D EFI_TEST_ASSERTION_PASSED; + } else { + Result =3D EFI_TEST_ASSERTION_FAILED; + } + + StandardLib->RecordAssertion ( + StandardLib, + Result, + gTCGMemoryOverwriteRequestTestFunctionAssertionGuid017, + L"MemoryOverwriteRequestControlLock - SetVariable() with= DataSize =3D=3D 5 returns EFI_INVALID_PARAMETER", + L"%a:%d:Status - %r", + __FILE__, + (UINTN)__LINE__, + Status + ); + + // change datasize to valid value for GetVariable + DataSize =3D sizeof(MemoryOverwriteRequestControlLockData); + Attributes =3D TCG_MOR_VARIABLE_ATTRIBUTES; + + // now check that MORLOCK value is 0x00 or unlocked + Status =3D gtRT->GetVariable ( + L"MemoryOverwriteRequestControlLock", // Variable= Name + &gEfiMemoryOverwriteRequestControlLockGuid, // VendorGu= id + &Attributes, // Attribut= es + &DataSize, // DataSize + &MemoryOverwriteRequestControlLockData // Data + ); + if (EFI_ERROR (Status) || (MemoryOverwriteRequestControlLockData !=3D MO= R_LOCK_DATA_UNLOCKED)) { + Result =3D EFI_TEST_ASSERTION_FAILED; + } else { + Result =3D EFI_TEST_ASSERTION_PASSED; + } + + StandardLib->RecordAssertion ( + StandardLib, + Result, + gTCGMemoryOverwriteRequestTestFunctionAssertionGuid018, + L"MemoryOverwriteRequestControlLock - Lock value remains= Unlocked", + L"%a:%d:Status - %r", + __FILE__, + (UINTN)__LINE__, + Status + ); + + return EFI_SUCCESS; +} --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107964): https://edk2.groups.io/g/devel/message/107964 Mute This Topic: https://groups.io/mt/100907772/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-