From nobody Tue Feb 10 04:13:01 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+106759+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+106759+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1688959040; cv=none; d=zohomail.com; s=zohoarc; b=Rven8J3gNaTJLzfn6Zv7annIooNHWTnuWc7X28DY/DG0nofgjgjoHwRkisc/A4nvOuZoJz5EwqbBwp8TvCO102tIGVYFhSCeHvqF6WzvKBZbc5plHSSwaEejbbaPY4kxVvZAyZYzCB/YoliVAp4UdbK2ociAD49GgpsJorHGTO0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1688959040; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=IzF1V8mLlU5qOOcf81LStHxnc6/VBqAw6dOl1gT1HXk=; b=Mdh8zXWkLDf54xfx7Z1PBi0+MEg0Lxi/GgbjfGPTo3RjrNpAMUxT/gQdicVTGjDLcpg3EF4jiSUF59OO0I1ZvWhfynJRUt7hW0NniG56T3FEVIY32mL4k77TDtmoVwNSiwEArkKxlChOvgq6V3oGKJ+uNbGm/pBFVkP8plpaouY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+106759+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1688959040581384.93333140604284; Sun, 9 Jul 2023 20:17:20 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id pR3LYY1788612xuVVQLYIXfj; Sun, 09 Jul 2023 20:17:20 -0700 X-Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.32065.1688959036830470108 for ; Sun, 09 Jul 2023 20:17:19 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10766"; a="430319075" X-IronPort-AV: E=Sophos;i="6.01,193,1684825200"; d="scan'208";a="430319075" X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2023 20:17:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10766"; a="834113163" X-IronPort-AV: E=Sophos;i="6.01,193,1684825200"; d="scan'208";a="834113163" X-Received: from shwdesfp01.ccr.corp.intel.com ([10.239.158.151]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2023 20:17:17 -0700 From: "Zhiguang Liu" To: devel@edk2.groups.io Cc: Zhiguang Liu , Eric Dong , Ray Ni , Rahul Kumar , Gerd Hoffmann Subject: [edk2-devel] [PATCH 2/4] UefiCpuPkg/SecCore: Remove AP waking Vector logic in SecCore Date: Mon, 10 Jul 2023 11:17:04 +0800 Message-Id: <20230710031706.1329-3-zhiguang.liu@intel.com> In-Reply-To: <20230710031706.1329-1-zhiguang.liu@intel.com> References: <20230710031706.1329-1-zhiguang.liu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhiguang.liu@intel.com X-Gm-Message-State: 9QDXCU7blN7C8UjATzGufRR8x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1688959040; bh=tXNwnLssggKMvsmZ42GvObPb8bcVGpGACZ7c4fyP/jU=; h=Cc:Date:From:Reply-To:Subject:To; b=vu3U4ePPOL/a2blww3KIslg9UOPd02So3YjQXDXhgYg8VRlPBqGbBwvo67ApPa9AHPn cNlrC1jcvESKK64Mgf2oDHUlvSuhOn4pQrGWvY/k8a663syYUs7czG5+AsVy/7+UPQHtG YrL8t/fD8D6ZzImWR/0CkGoTGsrhDO6sCKU= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1688959042249100011 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4494 There are two part of AP waking Vector logic in SecCore. The first one working with GenFv to find a free 4K aligned space, use the 4K aligned address as AP waking Vector and jump to 4G-30h, and finally jump to ApStartup.. The second one hard code uses 4G-1000h as AP waking Vector and jump to ApStartup. Both usages are no longer used. Remove them. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Zhiguang Liu --- UefiCpuPkg/SecCore/Ia32/ResetVec.nasmb | 36 +++----------------------- 1 file changed, 3 insertions(+), 33 deletions(-) diff --git a/UefiCpuPkg/SecCore/Ia32/ResetVec.nasmb b/UefiCpuPkg/SecCore/Ia= 32/ResetVec.nasmb index 1dfc4efe4c..df5f439c4e 100644 --- a/UefiCpuPkg/SecCore/Ia32/ResetVec.nasmb +++ b/UefiCpuPkg/SecCore/Ia32/ResetVec.nasmb @@ -24,18 +24,6 @@ USE16 =20 ORG 0h =20 -; -; 0xFFFFF000 -; -; We enter here with CS:IP =3D 0xFF00:0x0000. Do a far-jump to change CS t= o 0xF000 -; and IP to ApStartup. -; -ApVector: - mov di, "AP" - jmp 0xF000:0xF000+ApStartup - - TIMES 0xFC0-($-$$) nop - ; ; This should be at 0xFFFFFFC0 ; @@ -45,14 +33,7 @@ ApVector: ; ReservedData: DD 0eeeeeeeeh, 0eeeeeeeeh =20 - TIMES 0xFD0-($-$$) nop -; -; This is located at 0xFFFFFFD0 -; - mov di, "PA" - jmp ApStartup - - TIMES 0xFE0-($-$$) nop + TIMES 0x20-($-$$) nop ; ; Pointer to the entry point of the PEI core ; It is located at 0xFFFFFFE0, and is fixed up by some build tool @@ -70,7 +51,7 @@ ASM_PFX(InterruptHandler): jmp $ iret =20 - TIMES 0xFF0-($-$$) nop + TIMES 0x30-($-$$) nop ; ; For IA32, the reset vector must be at 0xFFFFFFF0, i.e., 4G-16 byte ; Execution starts here upon power-on/platform-reset. @@ -78,7 +59,6 @@ ASM_PFX(InterruptHandler): ResetHandler: nop nop -ApStartup: ; ; Jmp Rel16 instruction ; Use machine code directly in case of the assembler optimization @@ -90,17 +70,7 @@ ApStartup: DB 0e9h DW -3 =20 - - TIMES 0xFF8-($-$$) nop -; -; Ap reset vector segment address is at 0xFFFFFFF8 -; This will be fixed up by some build tool, -; so if the value 1..8 appears in the final FD image, -; tool failure occurs -; -ApSegAddress: dd 12345678h - - TIMES 0xFFC-($-$$) nop + TIMES 0x3C-($-$$) nop ; ; BFV Base is at 0xFFFFFFFC ; This will be fixed up by some build tool, --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106759): https://edk2.groups.io/g/devel/message/106759 Mute This Topic: https://groups.io/mt/100051789/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-