From nobody Tue Feb 10 16:22:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+106323+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+106323+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1687703978; cv=none; d=zohomail.com; s=zohoarc; b=TH25a88mdJkwS/lWhWS7JZUFuto3tiyrja8YfBf0X3d40uTzaAuqFA8gmset57J5RO47gEwnlgBPAptte0+ar1BlyhRbVQaAWqSA7lMwXxbtN3rexa7PTpI8Yoj94zikpdaeinBbVV9tVyI2HmQxfjl82y1pb6XpBNLZKhSdHAg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1687703978; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=kLCX1bBMkcI7ZWbnoZtW5Yv2z17avFF/bg6Y6QRTOQ8=; b=JonLMNkRz8kA9L4b/4ciu98KhNmYfklfDRHxuSFkNYdowptM7MrhY9xD/Lx09BUzLHdkSGRFC9Lg+EYMKXuHo8y9ROgpBwIvnqDMd09f5F4IHWDZSIAI5aG88jQA4IO8ZO7rKb6p4HuTdVPLAODlBbkOyA88uZoN7oCQOiugmHA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+106323+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1687703978297349.0229089511538; Sun, 25 Jun 2023 07:39:38 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id hhFqYY1788612xatwOwukbtw; Sun, 25 Jun 2023 07:39:38 -0700 X-Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.12565.1687703974569737167 for ; Sun, 25 Jun 2023 07:39:37 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10752"; a="363624303" X-IronPort-AV: E=Sophos;i="6.01,157,1684825200"; d="scan'208";a="363624303" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2023 07:39:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10752"; a="785871770" X-IronPort-AV: E=Sophos;i="6.01,157,1684825200"; d="scan'208";a="785871770" X-Received: from shwdeopenlab705.ccr.corp.intel.com ([10.239.55.55]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2023 07:39:35 -0700 From: "Yuanhao Xie" To: devel@edk2.groups.io Cc: Gerd Hoffmann , Eric Dong , Ray Ni , Rahul Kumar , Tom Lendacky , Yuanhao Xie Subject: [edk2-devel] [Patch V2 1/6] UefiCpuPkg: Refactor the logic for placing APs in HltLoop. Date: Sun, 25 Jun 2023 22:39:15 +0800 Message-Id: <20230625143920.57095-2-yuanhao.xie@intel.com> In-Reply-To: <20230625143920.57095-1-yuanhao.xie@intel.com> References: <20230625143920.57095-1-yuanhao.xie@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yuanhao.xie@intel.com X-Gm-Message-State: vULthHuJCdxfvezvaSl4gAbRx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1687703978; bh=P/FTOj5jL2J2boF+hjYq1JVtume1xrkRw/UqMY8wIVM=; h=Cc:Date:From:Reply-To:Subject:To; b=W0t6C45K0er6f/q9g32judhOn740u2nZppRL1G5VdUgKKtsunMTZ5ihV/7Jl79pLgHx c/rFDDsVz5D0cxbXaUSljv/y2PJutHRbzhST68ezPQh0J/9058lHejlsQ15gQIZwV1BSg 2Dvw7n0koaDpyl18Q46rb8gFa09F1DF9H48= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1687703979415100007 Content-Type: text/plain; charset="utf-8" Refactor the logic for placing APs in HltLoop into a separate function. Cc: Gerd Hoffmann Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Tom Lendacky Signed-off-by: Yuanhao Xie --- UefiCpuPkg/Library/MpInitLib/MpLib.c | 35 ++++++++++++++++++++++++--------= --- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpIn= itLib/MpLib.c index f1f2840714..9560b39220 100644 --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c @@ -636,6 +636,28 @@ InitializeApData ( SetApState (&CpuMpData->CpuData[ProcessorNumber], CpuStateIdle); } =20 +/** + This function place APs in Halt loop. + + @param[in] CpuMpData Pointer to CPU MP Data +**/ +VOID +PlaceAPInHltLoop ( + IN CPU_MP_DATA *CpuMpData + ) +{ + while (TRUE) { + DisableInterrupts (); + if (CpuMpData->UseSevEsAPMethod) { + SevEsPlaceApHlt (CpuMpData); + } else { + CpuSleep (); + } + + CpuPause (); + } +} + /** This function will be called from AP reset code if BSP uses WakeUpAP. =20 @@ -812,19 +834,10 @@ ApWakeupFunction ( // Place AP is specified loop mode // if (CpuMpData->ApLoopMode =3D=3D ApInHltLoop) { + PlaceAPInHltLoop (CpuMpData); // - // Place AP in HLT-loop + // Never run here // - while (TRUE) { - DisableInterrupts (); - if (CpuMpData->UseSevEsAPMethod) { - SevEsPlaceApHlt (CpuMpData); - } else { - CpuSleep (); - } - - CpuPause (); - } } =20 while (TRUE) { --=20 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106323): https://edk2.groups.io/g/devel/message/106323 Mute This Topic: https://groups.io/mt/99769824/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-