From nobody Sun May 5 17:57:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105693+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105693+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1685947078; cv=none; d=zohomail.com; s=zohoarc; b=d4pyOXT6WNiEtPWWuw8jV7EOJzE9qq3IFnNVzjElmY67Vjq25loz+zjsmOe8latTAKFmyaCyuKTPF0DBf6TLUg/uz+iecK9xjLYuvgeRj1FBcamODIj9NMSQdA6T6nXClcXeY+t7mnmKnqQ5CnRLkdGrqjekrkW/YZlmIMJDRZo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1685947078; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=rfOf70b5FFV0HBSS3IMrN/ZnJs25NlHXhQmc2ALP87s=; b=OsDWV61raZBRg4X0Ou1F3AtBd4Gn1ioWecnmk8F8Vfk8Hgr0MdRw0zDhY8tLBKLnFXrb7KZPFNE2m5pfHuznvzVhTsw4CpVYBrmuzJNEMNahlWwUW4PwN7cwB/gOHyXrmrm4JBj1S155vNxf8yDSuFkj0aGPcobJPMUzK20mlbg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105693+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1685947078371927.1584044728108; Sun, 4 Jun 2023 23:37:58 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 59SqYY1788612xzkhAb0Qfda; Sun, 04 Jun 2023 23:37:58 -0700 X-Received: from muminek.juszkiewicz.com.pl (muminek.juszkiewicz.com.pl [213.251.184.221]) by mx.groups.io with SMTP id smtpd.web11.1405.1685947075928982320 for ; Sun, 04 Jun 2023 23:37:56 -0700 X-Received: from localhost (localhost [127.0.0.1]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTP id 1FC1D260BC5; Mon, 5 Jun 2023 08:37:54 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at juszkiewicz.com.pl X-Received: from muminek.juszkiewicz.com.pl ([127.0.0.1]) by localhost (muminek.juszkiewicz.com.pl [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xL-wdpHmhiU4; Mon, 5 Jun 2023 08:37:52 +0200 (CEST) X-Received: from applejack.lan (83.21.93.182.ipv4.supernova.orange.pl [83.21.93.182]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTPSA id 613B52606B8; Mon, 5 Jun 2023 08:37:50 +0200 (CEST) From: "Marcin Juszkiewicz" To: devel@edk2.groups.io Cc: Sami Mujawar , Ard Biesheuvel , Leif Lindholm , Marcin Juszkiewicz Subject: [edk2-devel] [PATCH v2 1/8] ArmPkg: fix reading of first nibbles in ArmCpuInfo Date: Mon, 5 Jun 2023 08:37:36 +0200 Message-Id: <20230605063743.405487-3-marcin.juszkiewicz@linaro.org> In-Reply-To: <20230605063743.405487-1-marcin.juszkiewicz@linaro.org> References: <20230605063743.405487-1-marcin.juszkiewicz@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org X-Gm-Message-State: Yo84ytp9b0265ZonguxAzOWJx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1685947078; bh=2gg1FsYIuHUgcH7RgjDxAU8GIyY/9V8+cQ1I6o16LQ8=; h=Cc:Date:From:Reply-To:Subject:To; b=lhwoUHixQy8ae78OrOsx8EyQiZ7vbJO+vpE2gkJmQYtnndOs4SaHz0M8ITmzUMw9JU3 J66DEa+AmljBwv45itZXlaDsE5sojvwMtgfw0WW97/JptLmzf5NK7If+TFIBH5WgSPw6W Pa9u3Si3Wrl8UIKidZzYHJojiv+kOv1ucmU= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1685947079190100004 Content-Type: text/plain; charset="utf-8" First nibbles of DFR0/ISAR1/ISAR2/MMRF2/PFR0 system registers were read in wrong way -- second one was used instead. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c b/ArmPkg/Applicatio= n/ArmCpuInfo/ArmCpuInfo.c index deea90fbdfbf..3f0a49649790 100644 --- a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c +++ b/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c @@ -107,7 +107,7 @@ HandleAa64Dfr0 ( CONST CHAR8 *Bits; =20 Bits =3D "3:0 "; - Value =3D (Aa64Dfr0 >> 4) & 0xf; + Value =3D Aa64Dfr0 & 0xf; switch (Value) { case b0110: Description =3D "Armv8 debug architecture"; @@ -637,7 +637,7 @@ HandleAa64Isar1 ( CONST CHAR8 *Bits; =20 Bits =3D "3:0 "; - Value =3D (Aa64Isar1 >> 4) & 0xf; + Value =3D Aa64Isar1 & 0xf; switch (Value) { case b0000: Description =3D "DC CVAP not implemented."; @@ -954,7 +954,7 @@ HandleAa64Isar2 ( CONST CHAR8 *Bits; =20 Bits =3D "3:0 "; - Value =3D (Aa64Isar2 >> 4) & 0xf; + Value =3D Aa64Isar2 & 0xf; switch (Value) { case b0000: Description =3D "FEAT_WFxT not implemented."; @@ -1637,7 +1637,7 @@ HandleAa64Mmfr2 ( CONST CHAR8 *Bits; =20 Bits =3D "3:0 "; - Value =3D (Aa64Mmfr2) & 0xf; + Value =3D Aa64Mmfr2 & 0xf; switch (Value) { case b0000: Description =3D "FEAT_TTCNP not implemented."; @@ -1906,7 +1906,7 @@ HandleAa64Pfr0 ( CONST CHAR8 *Bits; =20 Bits =3D "3:0 "; - Value =3D (Aa64Pfr0) & 0xf; + Value =3D Aa64Pfr0 & 0xf; switch (Value) { case b0001: Description =3D "EL0 in AArch64 only"; --=20 2.40.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105693): https://edk2.groups.io/g/devel/message/105693 Mute This Topic: https://groups.io/mt/99335288/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 5 17:57:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105692+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105692+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1685947077; cv=none; d=zohomail.com; s=zohoarc; b=OQQrsF20FkmJB3/B91FnwHkOyAjIvvlDNMV4l65KUkZqNBOXI3x6Bu8fX5fjWDH5HDDVS/q5QZbilq2mH/+y+7o7Uv2OFZZktnKDXO7j36L537/0DOFO/WH7Wm2bx96EOJgFKHDY27r37WuapXkXNyZDbehzrpeuwsrolXtBgxY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1685947077; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=G5dfIexLF5fMDrB7ETatnt/vtYIqOM8wrDl3NuX9IQc=; b=F9740y7r4SfAGGZb2omfrv0zF1mzOKlFhR01khnR6lPnwYrp/7BwXPLdjPgLM53G0y/q20ireYsCkGQth+Bz3UdG0Wa5NGgpG1vuxMCoZwpPfUdJbA4SB/MH0jvUgwf25ApGore0oTmfcnCg0QZ5cPPqhj2+fA7B4ypWGDoCrpg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105692+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1685947077511124.65418959572673; Sun, 4 Jun 2023 23:37:57 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id c1L0YY1788612xjS100eTfRq; Sun, 04 Jun 2023 23:37:57 -0700 X-Received: from muminek.juszkiewicz.com.pl (muminek.juszkiewicz.com.pl [213.251.184.221]) by mx.groups.io with SMTP id smtpd.web11.1404.1685947075921792213 for ; Sun, 04 Jun 2023 23:37:56 -0700 X-Received: from localhost (localhost [127.0.0.1]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTP id 6F145260202; Mon, 5 Jun 2023 08:37:52 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at juszkiewicz.com.pl X-Received: from muminek.juszkiewicz.com.pl ([127.0.0.1]) by localhost (muminek.juszkiewicz.com.pl [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k2KKxfkcKNcQ; Mon, 5 Jun 2023 08:37:50 +0200 (CEST) X-Received: from applejack.lan (83.21.93.182.ipv4.supernova.orange.pl [83.21.93.182]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTPSA id EF93426069C; Mon, 5 Jun 2023 08:37:49 +0200 (CEST) From: "Marcin Juszkiewicz" To: devel@edk2.groups.io Cc: Sami Mujawar , Ard Biesheuvel , Leif Lindholm , Marcin Juszkiewicz Subject: [edk2-devel] [PATCH v2 1/1] ArmPkg: add SMC defines for SiP service calls Date: Mon, 5 Jun 2023 08:37:35 +0200 Message-Id: <20230605063743.405487-2-marcin.juszkiewicz@linaro.org> In-Reply-To: <20230605063743.405487-1-marcin.juszkiewicz@linaro.org> References: <20230605063743.405487-1-marcin.juszkiewicz@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org X-Gm-Message-State: YWY59MS3JNXicluxjx48e6UEx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1685947077; bh=wVXDiNUFJwCpbIBNKmibsPXWF7aOXs5RaZXE9R6h3vg=; h=Cc:Date:From:Reply-To:Subject:To; b=Tx9RLH9ijMiQH2ZveEgQcIl2rW3mJGVVV30qoTwdWYxrQu+6TssEgznY4+XWlWIqXS0 2W4zHJb8JX233uJRZ0MIC9HgvVuwuPKSvHaDo62sQ3YZwvhgr7TprLX+0T7HBIr41TehQ uZ/P/MTdJEc0EZbrjK5TIvbRlW/x+sMxlMY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1685947079175100003 Content-Type: text/plain; charset="utf-8" They are useful for those platforms where SMC SiP calls exist. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h b/ArmPkg/Include/I= ndustryStandard/ArmStdSmc.h index 374b9ded7f5f..616c650d07c8 100644 --- a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h +++ b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h @@ -244,4 +244,13 @@ #define TRNG_STATUS_INVALID_PARAMETER (INT32)(-2) #define TRNG_STATUS_NO_ENTROPY (INT32)(-3) =20 +/* + * SMC64 SiP Service Calls + */ + +#define SMC_FASTCALL 0x80000000 +#define SMC64_FUNCTION (SMC_FASTCALL | 0x40000000) +#define SMC_SIP_FUNCTION (SMC64_FUNCTION | 0x02000000) +#define SMC_SIP_FUNCTION_ID(n) (SMC_SIP_FUNCTION | (n)) + #endif // ARM_STD_SMC_H_ --=20 2.40.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105692): https://edk2.groups.io/g/devel/message/105692 Mute This Topic: https://groups.io/mt/99335287/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 5 17:57:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105694+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105694+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1685947078; cv=none; d=zohomail.com; s=zohoarc; b=O/Kq74i+YhrgbMhq87uSBjmxtvFtKKoVu4VBE74pxGmEkr+EF/4aTlG0jJoSNDJqUDqvRiTx8My5HkJ7hza6woO+0C19jGJxbdpQqCvsAyiiXVYxST2RJ9im8OMPlLSFeYlm7FudKuSOKzxkKOTAh93rGPgZHEkxEc6gaTXrI3M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1685947078; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=HWKTmhqEZK9Vy71+lKVVj6iGcSlyQPrIZl2JrumXxyw=; b=BtbXScVpMbg2KJCiXClVbgPfSwjcKcAw6hyyN02rG36tOGuu0I7U6l75T+0HLSwP+dhWfP9FUn/ccIxJQnrw7CT5AJFn1FONGhYyNlea9oxAZSXUxMyhMHkqTbUeRLaRWX7ZWKoBtayLZQCNVAvcu/b8nVdvlnhBOD6Fjl+5vHo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105694+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1685947078083260.42989600707006; Sun, 4 Jun 2023 23:37:58 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id yDpSYY1788612x6qSuBtilJp; Sun, 04 Jun 2023 23:37:57 -0700 X-Received: from muminek.juszkiewicz.com.pl (muminek.juszkiewicz.com.pl [213.251.184.221]) by mx.groups.io with SMTP id smtpd.web10.1369.1685947075966977610 for ; Sun, 04 Jun 2023 23:37:56 -0700 X-Received: from localhost (localhost [127.0.0.1]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTP id 50C832606B8; Mon, 5 Jun 2023 08:37:54 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at juszkiewicz.com.pl X-Received: from muminek.juszkiewicz.com.pl ([127.0.0.1]) by localhost (muminek.juszkiewicz.com.pl [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JPVnf9Eg1hLl; Mon, 5 Jun 2023 08:37:52 +0200 (CEST) X-Received: from applejack.lan (83.21.93.182.ipv4.supernova.orange.pl [83.21.93.182]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTPSA id C7B03260AD9; Mon, 5 Jun 2023 08:37:50 +0200 (CEST) From: "Marcin Juszkiewicz" To: devel@edk2.groups.io Cc: Sami Mujawar , Ard Biesheuvel , Leif Lindholm , Marcin Juszkiewicz Subject: [edk2-devel] [PATCH v2 2/8] ArmPkg: shorten register field in ArmCpuInfo Date: Mon, 5 Jun 2023 08:37:37 +0200 Message-Id: <20230605063743.405487-4-marcin.juszkiewicz@linaro.org> In-Reply-To: <20230605063743.405487-1-marcin.juszkiewicz@linaro.org> References: <20230605063743.405487-1-marcin.juszkiewicz@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org X-Gm-Message-State: 0fRlQXRVb5IufGrVpz8qezywx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1685947077; bh=m8q8bu3rszAXIyqDOKyc4L3LoMTOAOuHCi+VB94/C40=; h=Cc:Date:From:Reply-To:Subject:To; b=Mpsn0k2wa4KNuC5HV9piwtuO0Z3hfHrrBSNBuNvVVJ6rV0xrjhpVK6DuHQHCSkrIyjP LLyWVwdBig8cwkS5jlGqIY/3Op3CCSsEfsAWwUiGoqjSVwrckHG82bRzZbtYGdgdeA4gz HZeEfQ+fo9dxIF9cWOpA4pELT9e1iS2C3Bs= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1685947079201100005 Content-Type: text/plain; charset="utf-8" It is hard to fit in 80 columns so let drop extra spaces and ID_AA64 prefix from system register names. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 36 +++++++++++----------- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c b/ArmPkg/Applicatio= n/ArmCpuInfo/ArmCpuInfo.c index 3f0a49649790..982714ef6ca0 100644 --- a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c +++ b/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c @@ -53,7 +53,7 @@ PrintText ( CONST CHAR8 *Description ) { - AsciiPrint (" %-16a | %5a | %5a | %a\n", Field, Bits, Value, Description= ); + AsciiPrint ("%-5a | %5a | %5a | %a\n", Field, Bits, Value, Description); } =20 /** @@ -88,7 +88,7 @@ PrintSpacer ( VOID ) { - AsciiPrint ("------------------|-------|-------|------------------------= ----------------------\n"); + AsciiPrint ("------|-------|-------|------------------------------------= ----------\n"); } =20 /** @@ -102,7 +102,7 @@ HandleAa64Dfr0 ( ) { UINT64 Value; - STATIC CONST CHAR8 RegName[] =3D "ID_AA64DFR0"; + STATIC CONST CHAR8 RegName[] =3D "DFR0"; CONST CHAR8 *Description; CONST CHAR8 *Bits; =20 @@ -362,7 +362,7 @@ HandleAa64Isar0 ( ) { UINT64 Value; - STATIC CONST CHAR8 RegName[] =3D "ID_AA64ISAR0"; + STATIC CONST CHAR8 RegName[] =3D "ISAR0"; CONST CHAR8 *Description; CONST CHAR8 *Bits; =20 @@ -632,7 +632,7 @@ HandleAa64Isar1 ( ) { UINT64 Value; - STATIC CONST CHAR8 RegName[] =3D "ID_AA64ISAR1"; + STATIC CONST CHAR8 RegName[] =3D "ISAR1"; CONST CHAR8 *Description; CONST CHAR8 *Bits; =20 @@ -949,7 +949,7 @@ HandleAa64Isar2 ( ) { UINT64 Value; - STATIC CONST CHAR8 RegName[] =3D "ID_AA64ISAR2"; + STATIC CONST CHAR8 RegName[] =3D "ISAR2"; CONST CHAR8 *Description; CONST CHAR8 *Bits; =20 @@ -1091,7 +1091,7 @@ HandleAa64Mmfr0 ( ) { UINT64 Value; - STATIC CONST CHAR8 RegName[] =3D "ID_AA64MMFR0"; + STATIC CONST CHAR8 RegName[] =3D "MMFR0"; CONST CHAR8 *Description; CONST CHAR8 *Bits; =20 @@ -1164,11 +1164,11 @@ HandleAa64Mmfr0 ( // If mixed-endian is present, check whether supported at EL0 if (((Aa64Mmfr0 >> 8) & 0xf) !=3D b0000 ) { if (((Aa64Mmfr0 >> 16) & 0xf) =3D=3D b0000 ) { - PrintValues ("ID_AA64MMFR0", "19:16", b0000, "No mixed-endian suppor= t at EL0."); + PrintValues ("MMFR0", "19:16", b0000, "No mixed-endian support at EL= 0."); } =20 if (((Aa64Mmfr0 >> 16) & 0xf) =3D=3D b0001 ) { - PrintValues ("ID_AA64MMFR0", "19:16", b0001, "Mixed-endian support a= t EL0."); + PrintValues ("MMFR0", "19:16", b0001, "Mixed-endian support at EL0."= ); } } =20 @@ -1363,7 +1363,7 @@ HandleAa64Mmfr1 ( ) { UINT64 Value; - STATIC CONST CHAR8 RegName[] =3D "ID_AA64MMFR1"; + STATIC CONST CHAR8 RegName[] =3D "MMFR1"; CONST CHAR8 *Description; CONST CHAR8 *Bits; =20 @@ -1480,12 +1480,12 @@ HandleAa64Mmfr1 ( (((Aa64Pfr0 >> 28) & 0xf) =3D=3D b0010)) { if (((Aa64Mmfr1 >> 24) & 0xf) =3D=3D b0000 ) { - PrintValues ("ID_AA64MMFR1", "27:24", b0000, "The PE never generates= an SError interrupt due to"); + PrintValues ("MMFR1", "27:24", b0000, "The PE never generates an SEr= ror interrupt due to"); PrintText ("", "", "", "an External abort on a speculative read."); } =20 if (((Aa64Mmfr1 >> 24) & 0xf) =3D=3D b0001 ) { - PrintValues ("ID_AA64MMFR1", "27:24", b0001, "The PE might generate = an SError interrupt due to"); + PrintValues ("MMFR1", "27:24", b0001, "The PE might generate an SErr= or interrupt due to"); PrintText ("", "", "", "an External abort on a speculative read."); } } @@ -1632,7 +1632,7 @@ HandleAa64Mmfr2 ( ) { UINT64 Value; - STATIC CONST CHAR8 RegName[] =3D "ID_AA64MMFR2"; + STATIC CONST CHAR8 RegName[] =3D "MMFR2"; CONST CHAR8 *Description; CONST CHAR8 *Bits; =20 @@ -1901,7 +1901,7 @@ HandleAa64Pfr0 ( ) { UINT64 Value; - STATIC CONST CHAR8 RegName[] =3D "ID_AA64PFR0"; + STATIC CONST CHAR8 RegName[] =3D "PFR0"; CONST CHAR8 *Description; CONST CHAR8 *Bits; =20 @@ -2059,7 +2059,7 @@ HandleAa64Pfr0 ( PrintValues (RegName, Bits, Value, Description); if (Value =3D=3D b0001) { if (((Aa64Pfr1 >> 12) & 0xf) =3D=3D b0001 ) { - PrintValues ("ID_AA64PRF1", "15:12", b0001, "FEAT_RASv1p1 implemente= d."); + PrintValues ("PRF1", "15:12", b0001, "FEAT_RASv1p1 implemented."); } } =20 @@ -2199,11 +2199,11 @@ HandleAa64Pfr0 ( PrintValues (RegName, Bits, Value, Description); if (Value =3D=3D b0001) { if (((Aa64Pfr1 >> 32) & 0xf) =3D=3D b0001 ) { - PrintValues ("ID_AA64PRF1", "35:32", b0001, "FEAT_CSV2_1p1 implement= ed."); + PrintValues ("PRF1", "35:32", b0001, "FEAT_CSV2_1p1 implemented."); } =20 if (((Aa64Pfr1 >> 32) & 0xf) =3D=3D b0010 ) { - PrintValues ("ID_AA64PRF1", "35:32", b0010, "FEAT_CSV2_1p2 implement= ed."); + PrintValues ("PRF1", "35:32", b0010, "FEAT_CSV2_1p2 implemented."); } } =20 @@ -2235,7 +2235,7 @@ HandleAa64Pfr1 ( ) { UINT64 Value; - STATIC CONST CHAR8 RegName[] =3D "ID_AA64PFR1"; + STATIC CONST CHAR8 RegName[] =3D "PFR1"; CONST CHAR8 *Description; CONST CHAR8 *Bits; =20 --=20 2.40.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105694): https://edk2.groups.io/g/devel/message/105694 Mute This Topic: https://groups.io/mt/99335289/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 5 17:57:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105696+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105696+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1685947079; cv=none; d=zohomail.com; s=zohoarc; b=DDPpaPI1UPz6Ce8zCaR+S10jXIWDnrqe8cafpSRvbENwO4l2bsPiDh0kjKzvxJzS6v7QQ5oopZ+yXrX7+QPnPaA2+fNeZerWD7K8N5+xmkZy3FY7S+FzLhTlepY/6E4oj+ryRhyow26zq5WTfkqJM6hXFs0Qit6puTkFoqHUVJc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1685947079; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=LVCjNOk/aEKCYRWci3f3YdmuGYke5+bsITesHBPWoQY=; b=RZIo0J8vp7UF8NGyvwPOtbTVM67fqLGZHX5ToCv3BDeY68qgGQGo1JC5CH4XZ8LrMFq4hT0DBMachh3IndiPbgQ6eJwBsyXT1Vp+epxEnTGzEUT4sIFQNyn14opYs9+FXbwnKv7li3Gk1g8hG25RfMnH/ck4HjnJ4PFGOOq8pRY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105696+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1685947079219804.1796588681717; Sun, 4 Jun 2023 23:37:59 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id JhdBYY1788612xHJI3uIcKSl; Sun, 04 Jun 2023 23:37:58 -0700 X-Received: from muminek.juszkiewicz.com.pl (muminek.juszkiewicz.com.pl [213.251.184.221]) by mx.groups.io with SMTP id smtpd.web11.1407.1685947077440015994 for ; Sun, 04 Jun 2023 23:37:57 -0700 X-Received: from localhost (localhost [127.0.0.1]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTP id E53D4260AD9; Mon, 5 Jun 2023 08:37:55 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at juszkiewicz.com.pl X-Received: from muminek.juszkiewicz.com.pl ([127.0.0.1]) by localhost (muminek.juszkiewicz.com.pl [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fFaUjk3LjStv; Mon, 5 Jun 2023 08:37:54 +0200 (CEST) X-Received: from applejack.lan (83.21.93.182.ipv4.supernova.orange.pl [83.21.93.182]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTPSA id 49C2D260B30; Mon, 5 Jun 2023 08:37:51 +0200 (CEST) From: "Marcin Juszkiewicz" To: devel@edk2.groups.io Cc: Sami Mujawar , Ard Biesheuvel , Leif Lindholm , Marcin Juszkiewicz Subject: [edk2-devel] [PATCH v2 3/8] ArmPkg: add functions to read SVE/SME info Date: Mon, 5 Jun 2023 08:37:38 +0200 Message-Id: <20230605063743.405487-5-marcin.juszkiewicz@linaro.org> In-Reply-To: <20230605063743.405487-1-marcin.juszkiewicz@linaro.org> References: <20230605063743.405487-1-marcin.juszkiewicz@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org X-Gm-Message-State: Dd7aADnDDL68lJoygBSVxGtEx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1685947078; bh=H75Xf1bQP7Ug/l3b7NU9DHzGw+3TrT/DuwCktH70JVU=; h=Cc:Date:From:Reply-To:Subject:To; b=ftiA/9krC6Tfo2kTEJ5lD+GU/jtJao/SuG1AJQMx16xXriWnIuVFC2u1go5YCCvjSfR +NK162LnrJIP8yg3u1XQBl90sNGMTtUuiImJudFqfDbwlIhE5dzYG8h2pN9tyyultaovx QtnI1wMwE+QvR5fsvG/uZQRrO25vO5FGEVk= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1685947081195100022 Content-Type: text/plain; charset="utf-8" ID_AA64ZFR0_EL1 and ID_AA64SMFR0_EL1 system registers are needed for ArmCpuInfo application to show state of SVE/SME support. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/Library/ArmLib/ArmBaseLib.inf | 5 +++++ ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h | 12 ++++++++++++ ArmPkg/Library/ArmLib/AArch64/AArch64Support.S | 10 ++++++++++ 3 files changed, 27 insertions(+) diff --git a/ArmPkg/Library/ArmLib/ArmBaseLib.inf b/ArmPkg/Library/ArmLib/A= rmBaseLib.inf index e37d85bee471..8b5eda337fe3 100644 --- a/ArmPkg/Library/ArmLib/ArmBaseLib.inf +++ b/ArmPkg/Library/ArmLib/ArmBaseLib.inf @@ -48,3 +48,8 @@ [Packages] =20 [FeaturePcd.ARM] gArmTokenSpaceGuid.PcdNormalMemoryNonshareableOverride + +# to access ID_AA64ZFR0_EL1 and ID_AA64SMFR0_EL1 system registers +# we need to enable SME +[BuildOptions] + GCC:*_*_AARCH64_ASM_FLAGS =3D -march=3Darmv8-a+sme diff --git a/ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h b/ArmPkg/Library/Ar= mLib/AArch64/AArch64Lib.h index 6380a019ddc5..2fd256f4acc8 100644 --- a/ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h +++ b/ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h @@ -102,4 +102,16 @@ ArmReadIdAA64Pfr1 ( VOID ); =20 +UINTN +EFIAPI +ArmReadIdAA64Smfr0 ( + VOID + ); + +UINTN +EFIAPI +ArmReadIdAA64Zfr0 ( + VOID + ); + #endif // AARCH64_LIB_H_ diff --git a/ArmPkg/Library/ArmLib/AArch64/AArch64Support.S b/ArmPkg/Librar= y/ArmLib/AArch64/AArch64Support.S index a7111e51882c..c996fa8dbbc3 100644 --- a/ArmPkg/Library/ArmLib/AArch64/AArch64Support.S +++ b/ArmPkg/Library/ArmLib/AArch64/AArch64Support.S @@ -524,4 +524,14 @@ ASM_FUNC(ArmReadIdAA64Pfr1) mrs x0, ID_AA64PFR1_EL1 ret =20 + +ASM_FUNC(ArmReadIdAA64Smfr0) + mrs x0, ID_AA64SMFR0_EL1 + ret + + +ASM_FUNC(ArmReadIdAA64Zfr0) + mrs x0, ID_AA64ZFR0_EL1 + ret + ASM_FUNCTION_REMOVE_IF_UNREFERENCED --=20 2.40.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105696): https://edk2.groups.io/g/devel/message/105696 Mute This Topic: https://groups.io/mt/99335291/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 5 17:57:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105697+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105697+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1685947080; cv=none; d=zohomail.com; s=zohoarc; b=NCMY8y9OUisbI3e8t8CPGSp1tD9IOG4//8sYA93JiwTGrO4lMYUZ13c/E2o4affMvij+goyTLatOO4YQu9w/6KRut9F2alxwHyHEcU8SACQ6tVsfnYJLMN9BWDbwdOBqbAyMsVuZ3zD+C0XEyDik6pQHKKAZ5C4eNcUMiqZF7f8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1685947080; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=4LXvtinv7b7KkDIoGkNTzgCaxi1wG5t3824gpgKRWk0=; b=nTONLBFQiZ/G4ZvnMrhTC+mXQnFUbpVKMLbnzgxkqFDwpeugQWRoUq3WQqd22maYPcw3Hd6FtO/5nzjIHNUlWR+HNKZL7O7EKaXU+kL3Yj4AVfohjPjoJAlTMmihsUmwINt+aqyKm38X3K6r53qigN1LKTz60KmOPmV42GC+Ggo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105697+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1685947080633540.6374315468818; Sun, 4 Jun 2023 23:38:00 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id waiKYY1788612x20wbkXpqKl; Sun, 04 Jun 2023 23:38:00 -0700 X-Received: from muminek.juszkiewicz.com.pl (muminek.juszkiewicz.com.pl [213.251.184.221]) by mx.groups.io with SMTP id smtpd.web11.1408.1685947078509780112 for ; Sun, 04 Jun 2023 23:37:58 -0700 X-Received: from localhost (localhost [127.0.0.1]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTP id 1E2E1260B30; Mon, 5 Jun 2023 08:37:56 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at juszkiewicz.com.pl X-Received: from muminek.juszkiewicz.com.pl ([127.0.0.1]) by localhost (muminek.juszkiewicz.com.pl [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id leClSJBfo2QF; Mon, 5 Jun 2023 08:37:54 +0200 (CEST) X-Received: from applejack.lan (83.21.93.182.ipv4.supernova.orange.pl [83.21.93.182]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTPSA id B14E1260B3C; Mon, 5 Jun 2023 08:37:51 +0200 (CEST) From: "Marcin Juszkiewicz" To: devel@edk2.groups.io Cc: Sami Mujawar , Ard Biesheuvel , Leif Lindholm , Marcin Juszkiewicz Subject: [edk2-devel] [PATCH v2 4/8] ArmPkg: skip empty system registers in ArmCpuInfo Date: Mon, 5 Jun 2023 08:37:39 +0200 Message-Id: <20230605063743.405487-6-marcin.juszkiewicz@linaro.org> In-Reply-To: <20230605063743.405487-1-marcin.juszkiewicz@linaro.org> References: <20230605063743.405487-1-marcin.juszkiewicz@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org X-Gm-Message-State: KMEginPs0fmyI2NwqNnRbOTzx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1685947080; bh=Q2X3Kp9hZQoF7y9pF4ifOZmpVrWNDVAN5+ED670zLAQ=; h=Cc:Date:From:Reply-To:Subject:To; b=W485fjj8Xw3PiwxDtM2vXsk/PspFku7qnBreRyrAuNAiSebAoc9+8nA+IjtX4uvqC3w eHy+iOgb2SEoF6bOUG3U1v2OyiFSC/Q4swS7XCNDHimQ3yeZnOPW7jAXjqnvBGFyxyOyn LMoIow8X85dr1M+Cb+BB/xdxxlf+8hBqWHQ= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1685947081201100023 Content-Type: text/plain; charset="utf-8" If system register is empty (value =3D=3D 0) then do not display information from it. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 35 +++++++++++++++------- 1 file changed, 25 insertions(+), 10 deletions(-) diff --git a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c b/ArmPkg/Applicatio= n/ArmCpuInfo/ArmCpuInfo.c index 982714ef6ca0..9d0d164774ff 100644 --- a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c +++ b/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c @@ -2407,23 +2407,38 @@ UefiMain ( =20 HandleAa64Mmfr0 (Aa64Mmfr0); PrintSpacer (); - HandleAa64Mmfr1 (Aa64Mmfr1, Aa64Pfr0); - PrintSpacer (); - HandleAa64Mmfr2 (Aa64Mmfr2); =20 - PrintSpacer (); + if (Aa64Mmfr1) { + HandleAa64Mmfr1 (Aa64Mmfr1, Aa64Pfr0); + PrintSpacer (); + } + + if (Aa64Mmfr2) { + HandleAa64Mmfr2 (Aa64Mmfr2); + PrintSpacer (); + } + HandleAa64Pfr0 (Aa64Pfr0, Aa64Pfr1); PrintSpacer (); - HandleAa64Pfr1 (Aa64Pfr1); =20 - PrintSpacer (); + if (Aa64Pfr1) { + HandleAa64Pfr1 (Aa64Pfr1); + PrintSpacer (); + } + HandleAa64Isar0 (Aa64Isar0); PrintSpacer (); - HandleAa64Isar1 (Aa64Isar1); - PrintSpacer (); - HandleAa64Isar2 (Aa64Isar2); =20 - PrintSpacer (); + if (Aa64Isar1) { + HandleAa64Isar1 (Aa64Isar1); + PrintSpacer (); + } + + if (Aa64Isar2) { + HandleAa64Isar2 (Aa64Isar2); + PrintSpacer (); + } + HandleAa64Dfr0 (Aa64Dfr0); =20 return EFI_SUCCESS; --=20 2.40.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105697): https://edk2.groups.io/g/devel/message/105697 Mute This Topic: https://groups.io/mt/99335292/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 5 17:57:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105698+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105698+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1685947080; cv=none; d=zohomail.com; s=zohoarc; b=dbdPW7eMaB+3n9HhwT+4+UelPEQcmktFL6MzDisXL7ZzU8lR6tf+WT6dnqK5okY69z/2QOXwZEPa12hcY/xZ21CxxQgoaT4jV3Uiz7gpouqaB3hcuNiblZHkAfz9rXCFWz3Y30d2QGjrxJfHvkPfeVciRzYqfmYNOa2nbYNpsPQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1685947080; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=ijRW84L+Lir7i3zKTRAeFuOrUP+wMjxOYoqvOQZy9Y4=; b=mpnU/VzQXnI85tHB9bXVtg7JDfJFtdzJp2FigIb6EeZ3uwq3Dw9/K4eZFzQOGA8GTy5O7Zwj2QZjaX55b436nc5+yvXGKUU0vW3TRc83GNTI8Phmn6fM7g09Nlounq01jHh3NPP0iyotoEM80NQC5UTOSUR0srxgsjWglMsipC0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105698+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 168594708092952.581120552034804; Sun, 4 Jun 2023 23:38:00 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id Q3jmYY1788612x5qucRfodqS; Sun, 04 Jun 2023 23:38:00 -0700 X-Received: from muminek.juszkiewicz.com.pl (muminek.juszkiewicz.com.pl [213.251.184.221]) by mx.groups.io with SMTP id smtpd.web10.1372.1685947079137035778 for ; Sun, 04 Jun 2023 23:37:59 -0700 X-Received: from localhost (localhost [127.0.0.1]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTP id ADEEC260B3C; Mon, 5 Jun 2023 08:37:57 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at juszkiewicz.com.pl X-Received: from muminek.juszkiewicz.com.pl ([127.0.0.1]) by localhost (muminek.juszkiewicz.com.pl [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KPiFseyUQ22U; Mon, 5 Jun 2023 08:37:56 +0200 (CEST) X-Received: from applejack.lan (83.21.93.182.ipv4.supernova.orange.pl [83.21.93.182]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTPSA id 25767260B92; Mon, 5 Jun 2023 08:37:52 +0200 (CEST) From: "Marcin Juszkiewicz" To: devel@edk2.groups.io Cc: Sami Mujawar , Ard Biesheuvel , Leif Lindholm , Marcin Juszkiewicz Subject: [edk2-devel] [PATCH v2 5/8] ArmPkg: format output in one place in ArmCpuInfo Date: Mon, 5 Jun 2023 08:37:40 +0200 Message-Id: <20230605063743.405487-7-marcin.juszkiewicz@linaro.org> In-Reply-To: <20230605063743.405487-1-marcin.juszkiewicz@linaro.org> References: <20230605063743.405487-1-marcin.juszkiewicz@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org X-Gm-Message-State: c7pFcGJmqGWb4XXm05cg2mzmx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1685947080; bh=FE3dc03yXMCTmv6nJ7EraKzy065Oy4agA9wjzewnHsw=; h=Cc:Date:From:Reply-To:Subject:To; b=LGU+rWuZakO8uloXS2TgG/gVN7Uzm7PowcALkwcUjUi81ws84n7yIhAYz1LDePb4t1S eLNniJAzbtWcEWixIXjLks4BRgg5NjSeAziobU7kjQ1j8N0YfgPg8ZuZYyJ/RAupFB58b sRHAxEdH9OSCJabZ62hj7BXtroQ9EqsE9O0= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1685947081189100021 Content-Type: text/plain; charset="utf-8" Having two places with same formatting is error-prone. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c b/ArmPkg/Applicatio= n/ArmCpuInfo/ArmCpuInfo.c index 9d0d164774ff..c2ed6b93d968 100644 --- a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c +++ b/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c @@ -77,7 +77,7 @@ PrintValues ( "1000", "1001", "1010", "1011", "1100", "1101", "1110", "1111" }; =20 - AsciiPrint (" %-16a | %5a | %5a | %a\n", Field, Bits, Nibbles[Value & 0x= f], Description); + PrintText (Field, Bits, Nibbles[Value & 0xf], Description); } =20 /** --=20 2.40.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105698): https://edk2.groups.io/g/devel/message/105698 Mute This Topic: https://groups.io/mt/99335293/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 5 17:57:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105699+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105699+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1685947081; cv=none; d=zohomail.com; s=zohoarc; b=a7AsYyDCZqJOjLnyKJAtHPvHdBL6/ckC+nuC6FNow0iM6XtUACYKGA1aP2m3gk0fk3cc7bsEAQpJYewFnVAH+W3353kbrzLafh/sveHrZfBGPAfxg6FJ1JJiVjKGeqppbyQNfq8JzqCRR4BpozlMWLf/qQNlqVqZtTBoEOkttZU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1685947081; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=hBMPn2MOCT+Qej4/EHtp2YmSYkeARlH3jI955lCyOKA=; b=etWlmDC5AbKZsUNNck7FCC2HhBVyJ3Wp1twNNrlnEy8QQyD10vcc2Ai1HACPQvCQII6Mx4Y9MsxqYFdHd9AB2Jb7M47qxntoCPIrq/R40RRQjN6Q7Q/udovnlIeszH9ByceIl+5tihc+JRvX3/N1IdPCnvcpMs1f6/uPPHpz6GU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105699+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1685947081016721.3201502333585; Sun, 4 Jun 2023 23:38:01 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id zZyvYY1788612xkV0GKY4I9U; Sun, 04 Jun 2023 23:38:00 -0700 X-Received: from muminek.juszkiewicz.com.pl (muminek.juszkiewicz.com.pl [213.251.184.221]) by mx.groups.io with SMTP id smtpd.web10.1373.1685947079352378158 for ; Sun, 04 Jun 2023 23:37:59 -0700 X-Received: from localhost (localhost [127.0.0.1]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTP id E62FA260B92; Mon, 5 Jun 2023 08:37:57 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at juszkiewicz.com.pl X-Received: from muminek.juszkiewicz.com.pl ([127.0.0.1]) by localhost (muminek.juszkiewicz.com.pl [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KVpUDITLQ6fo; Mon, 5 Jun 2023 08:37:56 +0200 (CEST) X-Received: from applejack.lan (83.21.93.182.ipv4.supernova.orange.pl [83.21.93.182]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTPSA id 993ED26069C; Mon, 5 Jun 2023 08:37:52 +0200 (CEST) From: "Marcin Juszkiewicz" To: devel@edk2.groups.io Cc: Sami Mujawar , Ard Biesheuvel , Leif Lindholm , Marcin Juszkiewicz Subject: [edk2-devel] [PATCH v2 6/8] ArmPkg: handle SVE/SME in ArmCpuInfo Date: Mon, 5 Jun 2023 08:37:41 +0200 Message-Id: <20230605063743.405487-8-marcin.juszkiewicz@linaro.org> In-Reply-To: <20230605063743.405487-1-marcin.juszkiewicz@linaro.org> References: <20230605063743.405487-1-marcin.juszkiewicz@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org X-Gm-Message-State: zzvt826l1TAP4liXsXY3MU0qx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1685947080; bh=tM/UMWfgxQqppEoMT6pnfipj/vEHQv8L7cxOwcuafkU=; h=Cc:Date:From:Reply-To:Subject:To; b=QMIu9RguRlDBeHtYDf2Ebxz7M9Dp6SlgBkPe2LTuBebhbyByR0iAT4Dh7rTej4+5iO0 YZcYVDuJ514JSsl5RwdVq8Fl8VBRBVJdv3/qQuzms7R8YM4KShnTorvW7X0LHUD/YAJwX JCtWHjQdXQx0HcOezKjuBDAFJPxYPQHCzFI= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1685947083183100032 Content-Type: text/plain; charset="utf-8" If cpu supports SVE or SME then display information of supported features. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 344 +++++++++++++++++++++ 1 file changed, 344 insertions(+) diff --git a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c b/ArmPkg/Applicatio= n/ArmCpuInfo/ArmCpuInfo.c index c2ed6b93d968..ab1cc70933e1 100644 --- a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c +++ b/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c @@ -2353,6 +2353,333 @@ HandleAa64Pfr1 ( // 63:40 are reserved } =20 +/** + Handle ID_AA64SMFR0_EL1 system register. + + @param[in] Aa64Smfr0, value of ID_AA64SMFR0_EL1 system register +**/ +VOID +HandleAa64Smfr0 ( + CONST UINT64 Aa64Smfr0 + ) +{ + UINT64 Value; + STATIC CONST CHAR8 RegName[] =3D "SMFR0"; + CONST CHAR8 *Description; + CONST CHAR8 *Bits; + + // 31:0 reserved + + Bits =3D " 32"; + Value =3D (Aa64Smfr0 >> 32) & 0x1; + switch (Value) { + case 0: + Description =3D "SME F32F32 not implemented."; + break; + case 1: + Description =3D "SME F32F32 implemented."; + break; + default: + Description =3D "unknown"; + break; + } + + PrintValues (RegName, Bits, Value, Description); + + // 33 reserved + + Bits =3D " 34"; + Value =3D (Aa64Smfr0 >> 34) & 0x1; + switch (Value) { + case 0: + Description =3D "SME B16F32 not implemented."; + break; + case 1: + Description =3D "SME B16F32 implemented."; + break; + default: + Description =3D "unknown"; + break; + } + + PrintValues (RegName, Bits, Value, Description); + + Bits =3D " 35"; + Value =3D (Aa64Smfr0 >> 35) & 0x1; + switch (Value) { + case 0: + Description =3D "SME F16F32 not implemented."; + break; + case 1: + Description =3D "SME F16F32 implemented."; + break; + default: + Description =3D "unknown"; + break; + } + + PrintValues (RegName, Bits, Value, Description); + + Bits =3D "39:36"; + Value =3D (Aa64Smfr0 >> 36) & 0xf; + switch (Value) { + case b0000: + Description =3D "SME I8I32 not implemented."; + break; + case b1111: + Description =3D "SME I8I32 implemented."; + break; + default: + Description =3D "unknown"; + break; + } + + PrintValues (RegName, Bits, Value, Description); + + // 47:40 reserved + + Bits =3D " 48"; + Value =3D (Aa64Smfr0 >> 48) & 0x1; + switch (Value) { + case 0: + Description =3D "SME F64F64 not implemented."; + break; + case 1: + Description =3D "SME F64F64 implemented."; + break; + default: + Description =3D "unknown"; + break; + } + + PrintValues (RegName, Bits, Value, Description); + + // 51:49 reserved + + Bits =3D "55:52"; + Value =3D (Aa64Smfr0 >> 52) & 0xf; + switch (Value) { + case b0000: + Description =3D "SME I16I64 not implemented"; + break; + case b1111: + Description =3D "SME I16I64 implemented"; + break; + default: + Description =3D "unknown"; + break; + } + + PrintValues (RegName, Bits, Value, Description); + + Bits =3D "59:56"; + Value =3D (Aa64Smfr0 >> 56) & 0xf; + switch (Value) { + case b0000: + Description =3D "Mandatory SME instructions are implemented."; + break; + default: + Description =3D "unknown"; + break; + } + + PrintValues (RegName, Bits, Value, Description); + + // 62:60 reserved + + Bits =3D " 63"; + Value =3D (Aa64Smfr0 >> 63) & 0x1; + switch (Value) { + case 0: + Description =3D "SME_FA64 not implemented."; + break; + case 1: + Description =3D "SME_FA64 implemented."; + break; + default: + Description =3D "unknown"; + break; + } + + PrintValues (RegName, Bits, Value, Description); +} + +/** + Handle ID_AA64ZFR0_EL1 system register. + + @param[in] Aa64Zfr0, value of ID_AA64ZFR0_EL1 system register +**/ +VOID +HandleAa64Zfr0 ( + CONST UINT64 Aa64Zfr0 + ) +{ + UINT64 Value; + STATIC CONST CHAR8 RegName[] =3D "ZFR0"; + CONST CHAR8 *Description; + CONST CHAR8 *Bits; + + Bits =3D "3:0 "; + Value =3D Aa64Zfr0 & 0xf; + switch (Value) { + case b0000: + Description =3D "FEAT_SVE implemented."; + break; + case b0001: + Description =3D "FEAT_SVE2 implemented."; + break; + default: + Description =3D "unknown"; + break; + } + + PrintValues (RegName, Bits, Value, Description); + + Bits =3D "7:4 "; + Value =3D (Aa64Zfr0 >> 4) & 0xf; + switch (Value) { + case b0000: + Description =3D "FEAT_SVE_AES not implemented."; + break; + case b0001: + Description =3D "FEAT_SVE_AES implemented."; + break; + case b0010: + Description =3D "FEAT_SVE_AES and FEAT_SVE_PMULL128 implemented."; + break; + default: + Description =3D "unknown"; + break; + } + + PrintValues (RegName, Bits, Value, Description); + + // 15:8 reserved + + Bits =3D "19:16"; + Value =3D (Aa64Zfr0 >> 16) & 0xf; + switch (Value) { + case b0000: + Description =3D "FEAT_SVE_BitPerm not implemented."; + break; + case b0001: + Description =3D "FEAT_SVE_BitPerm implemented."; + break; + default: + Description =3D "unknown"; + break; + } + + PrintValues (RegName, Bits, Value, Description); + + Bits =3D "23:20"; + Value =3D (Aa64Zfr0 >> 20) & 0xf; + switch (Value) { + case b0000: + Description =3D "SVE BFloat16 not implemented."; + break; + case b0001: + Description =3D "FEAT_BF16 SVE implemented."; + break; + case b0010: + Description =3D "FEAT_EBF16 SVE implemented."; + break; + default: + Description =3D "unknown"; + break; + } + + PrintValues (RegName, Bits, Value, Description); + + // 31:24 reserved + + Bits =3D "35:32"; + Value =3D (Aa64Zfr0 >> 32) & 0xf; + switch (Value) { + case b0000: + Description =3D "FEAT_SVE_SHA3 not implemented."; + break; + case b0001: + Description =3D "FEAT_SVE_SHA3 implemented."; + break; + default: + Description =3D "unknown"; + break; + } + + PrintValues (RegName, Bits, Value, Description); + + // 39:36 reserved + + Bits =3D "43:40"; + Value =3D (Aa64Zfr0 >> 40) & 0xf; + switch (Value) { + case b0000: + Description =3D "FEAT_SVE_SM4 not implemented."; + break; + case b0001: + Description =3D "FEAT_SVE_SM4 implemented."; + break; + default: + Description =3D "unknown"; + break; + } + + PrintValues (RegName, Bits, Value, Description); + + Bits =3D "47:44"; + Value =3D (Aa64Zfr0 >> 44) & 0xf; + switch (Value) { + case b0000: + Description =3D "FEAT_I8MM SVE not implemented."; + break; + case b0001: + Description =3D "FEAT_I8MM SVE implemented."; + break; + default: + Description =3D "unknown"; + break; + } + + PrintValues (RegName, Bits, Value, Description); + + // 51:48 reserved + + Bits =3D "55:52"; + Value =3D (Aa64Zfr0 >> 52) & 0xf; + switch (Value) { + case b0000: + Description =3D "FEAT_F32MM SVE not implemented"; + break; + case b0001: + Description =3D "FEAT_F32MM SVE implemented"; + break; + default: + Description =3D "unknown"; + break; + } + + PrintValues (RegName, Bits, Value, Description); + + Bits =3D "59:56"; + Value =3D (Aa64Zfr0 >> 56) & 0xf; + switch (Value) { + case b0000: + Description =3D "FEAT_F64MM SVE not implemented"; + break; + case b0001: + Description =3D "FEAT_F64MM SVE implemented"; + break; + default: + Description =3D "unknown"; + break; + } + + PrintValues (RegName, Bits, Value, Description); + + // 63:60 reserved +} + /** The user Entry Point for Application. The user code starts with this fun= ction as the real entry point for the application. @@ -2380,6 +2707,8 @@ UefiMain ( UINT64 Aa64Mmfr2; UINT64 Aa64Pfr0; UINT64 Aa64Pfr1; + UINT64 Aa64Smfr0; + UINT64 Aa64Zfr0; =20 Aa64Dfr0 =3D ArmReadIdAA64Dfr0 (); Aa64Isar0 =3D ArmReadIdAA64Isar0 (); @@ -2390,6 +2719,8 @@ UefiMain ( Aa64Mmfr2 =3D ArmReadIdAA64Mmfr2 (); Aa64Pfr0 =3D ArmReadIdAA64Pfr0 (); Aa64Pfr1 =3D ArmReadIdAA64Pfr1 (); + Aa64Smfr0 =3D ArmReadIdAA64Smfr0 (); + Aa64Zfr0 =3D ArmReadIdAA64Zfr0 (); =20 AsciiPrint ("ID_AA64MMFR0_EL1 =3D 0x%016lx\n", Aa64Mmfr0); AsciiPrint ("ID_AA64MMFR1_EL1 =3D 0x%016lx\n", Aa64Mmfr1); @@ -2400,6 +2731,8 @@ UefiMain ( AsciiPrint ("ID_AA64ISAR1_EL1 =3D 0x%016lx\n", Aa64Isar1); AsciiPrint ("ID_AA64ISAR2_EL1 =3D 0x%016lx\n", Aa64Isar2); AsciiPrint ("ID_AA64DFR0_EL1 =3D 0x%016lx\n", Aa64Dfr0); + AsciiPrint ("ID_AA64SMFR0_EL1 =3D 0x%016lx\n", Aa64Smfr0); + AsciiPrint ("ID_AA64ZFR0_EL1 =3D 0x%016lx\n", Aa64Zfr0); AsciiPrint ("\n"); =20 PrintText ("Register", "Bits", "Value", "Feature"); @@ -2440,6 +2773,17 @@ UefiMain ( } =20 HandleAa64Dfr0 (Aa64Dfr0); + PrintSpacer (); + + if (Aa64Smfr0) { + HandleAa64Smfr0 (Aa64Smfr0); + PrintSpacer (); + } + + if (Aa64Zfr0) { + HandleAa64Zfr0 (Aa64Zfr0); + PrintSpacer (); + } =20 return EFI_SUCCESS; } --=20 2.40.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105699): https://edk2.groups.io/g/devel/message/105699 Mute This Topic: https://groups.io/mt/99335294/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 5 17:57:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105700+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105700+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1685947082; cv=none; d=zohomail.com; s=zohoarc; b=a5eNq7cZtIf5hru2BuBXhiyujT3Np5x9z7eYCyYZwToxr3RKpUWQgbSCxBH7hizsbobbmFCrUJYVJ+EnZwiBwFu72p6MR36eO1hMC9NiATotMmRCehOXjMKrtPa6DzG2Eqs8sf9V+I/lHM/W5jK2lSdKB8UpN2ocbr6dO6KyGEg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1685947082; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=aCLwJHioqxjqVXl00lNSwmkuPX6GZQ/SC0ptPH1hS2I=; b=grknFXCkHTd992rBhyBapgp7rTlXk6EUkK7LgfuIprvOb79Z5lVY1bFLT7hYW8AKnKw393BCCchY0zidFojJhhBu0/XgMGpFq37JxSlYzp58rJ4BF2la0KKJzQjZ7P2xKZhRoLrZBP3ayxxkFmt3bg0oyG3KDqJ48JeN0q4G97s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105700+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1685947082832946.9992516019075; Sun, 4 Jun 2023 23:38:02 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id Yd5wYY1788612x2Ww3q3TT9a; Sun, 04 Jun 2023 23:38:02 -0700 X-Received: from muminek.juszkiewicz.com.pl (muminek.juszkiewicz.com.pl [213.251.184.221]) by mx.groups.io with SMTP id smtpd.web11.1409.1685947081006476877 for ; Sun, 04 Jun 2023 23:38:01 -0700 X-Received: from localhost (localhost [127.0.0.1]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTP id 8181426069C; Mon, 5 Jun 2023 08:37:59 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at juszkiewicz.com.pl X-Received: from muminek.juszkiewicz.com.pl ([127.0.0.1]) by localhost (muminek.juszkiewicz.com.pl [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UfgPb-PfkGl5; Mon, 5 Jun 2023 08:37:57 +0200 (CEST) X-Received: from applejack.lan (83.21.93.182.ipv4.supernova.orange.pl [83.21.93.182]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTPSA id 1216E260B91; Mon, 5 Jun 2023 08:37:53 +0200 (CEST) From: "Marcin Juszkiewicz" To: devel@edk2.groups.io Cc: Sami Mujawar , Ard Biesheuvel , Leif Lindholm , Marcin Juszkiewicz Subject: [edk2-devel] [PATCH v2 7/8] ArmPkg: cleaning output of ArmCpuInfo Date: Mon, 5 Jun 2023 08:37:42 +0200 Message-Id: <20230605063743.405487-9-marcin.juszkiewicz@linaro.org> In-Reply-To: <20230605063743.405487-1-marcin.juszkiewicz@linaro.org> References: <20230605063743.405487-1-marcin.juszkiewicz@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org X-Gm-Message-State: BZLID76eOllzIJqTSJ2NfrRfx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1685947082; bh=Xw6HzEUuJYQHqIyQiJab0H0RD3BiXwQDjxYigSixdSQ=; h=Cc:Date:From:Reply-To:Subject:To; b=Xel6YKFe3Kpqdmgg4NtM4An3068kpqxA/paYcFgjsUErqdP8Mp3N3tsi8a38jMd8K7k CsBzrYrVpb7aUYiD6rQnWYYaYasTmQyMlJg0ocASvyrSxYl5qyfOdGySIJrYGrH1D1wOS 6mSsCY5VgubZbPbWeeIzYa4EaXd3RDppmqk= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1685947083201100034 Content-Type: text/plain; charset="utf-8" There is no point of having double spaces. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 24 +++++++++++----------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c b/ArmPkg/Applicatio= n/ArmCpuInfo/ArmCpuInfo.c index ab1cc70933e1..caaab4ec4313 100644 --- a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c +++ b/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c @@ -659,7 +659,7 @@ HandleAa64Isar1 ( Value =3D (Aa64Isar1 >> 4) & 0xf; switch (Value) { case b0000: - Description =3D "Address Authentication (APA) not implemented."; + Description =3D "Address Authentication (APA) not implemented."; break; case b0001: Description =3D "FEAT_PAuth implemented."; @@ -690,7 +690,7 @@ HandleAa64Isar1 ( Value =3D (Aa64Isar1 >> 8) & 0xf; switch (Value) { case b0000: - Description =3D "Address Authentication (API) not implemented."; + Description =3D "Address Authentication (API) not implemented."; break; case b0001: Description =3D "FEAT_PAuth implemented."; @@ -1005,7 +1005,7 @@ HandleAa64Isar2 ( Value =3D (Aa64Isar2 >> 12) & 0xf; switch (Value) { case b0000: - Description =3D "Address Authentication (APA3) not implemented."; + Description =3D "Address Authentication (APA3) not implemented."; break; case b0001: Description =3D "FEAT_PAuth implemented."; @@ -1099,25 +1099,25 @@ HandleAa64Mmfr0 ( Value =3D Aa64Mmfr0 & 0xf; switch (Value) { case b0000: - Description =3D "32 Bits (4GB) of physical address range supported.= "; + Description =3D "32 Bits (4GB) of physical address range supported."; break; case b0001: - Description =3D "36 Bits (64GB) of physical address range supported= ."; + Description =3D "36 Bits (64GB) of physical address range supported.= "; break; case b0010: - Description =3D "40 Bits (1TB) of physical address range supported.= "; + Description =3D "40 Bits (1TB) of physical address range supported."; break; case b0011: - Description =3D "42 Bits (4TB) of physical address range supported.= "; + Description =3D "42 Bits (4TB) of physical address range supported."; break; case b0100: - Description =3D "44 Bits (16TB) of physical address range supported= ."; + Description =3D "44 Bits (16TB) of physical address range supported.= "; break; case b0101: - Description =3D "48 Bits (256TB) of physical address range supporte= d."; + Description =3D "48 Bits (256TB) of physical address range supported= ."; break; case b0110: - Description =3D "52 Bits (4PB) of physical address range supported.= "; + Description =3D "52 Bits (4PB) of physical address range supported."; break; default: Description =3D "unknown"; @@ -1982,7 +1982,7 @@ HandleAa64Pfr0 ( Description =3D "Floating-point implemented."; break; case b0001: - Description =3D "Floating-point with half-precision support (FEAT_F= P16)."; + Description =3D "Floating-point with half-precision support (FEAT_FP= 16)."; break; case b1111: Description =3D "Floating-point not implemented."; @@ -2001,7 +2001,7 @@ HandleAa64Pfr0 ( Description =3D "Advanced SIMD implemented."; break; case b0001: - Description =3D "Advanced SIMD with half precision support (FEAT_FP= 16)."; + Description =3D "Advanced SIMD with half precision support (FEAT_FP1= 6)."; break; case b1111: Description =3D "Advanced SIMD not implemented."; --=20 2.40.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105700): https://edk2.groups.io/g/devel/message/105700 Mute This Topic: https://groups.io/mt/99335295/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 5 17:57:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105701+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105701+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1685947082; cv=none; d=zohomail.com; s=zohoarc; b=BOYUnlLaViVI0xxZ3dicZO4HBTrZ4AAGx+/DHNlMWIqFTY01F0dJ5C6iZHZcaipchDBst07Tkxot0beKsyOvg0jktpH01TYQzSl6MaKPqX/VW+vP9xLtlM52SWeqZprKNMwlvEbtky8rpbXldoYdRWU/0ZxHMmajlGd1B+6m09s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1685947082; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=KYUSkiS9SFn/1C8teaxIJFqnt61HSCsRi12EfbZ1tik=; b=Yi7N77PqflGNofXSgtZkWvS81iqtE3s7WExdEe9cuB8NFroib7215JQC2keRbfc6hIkw6Tok6ZRlOVfHJm49Aeaj0PsZmi3955kZhzqrGIbFIj+vcKoPAXroW37YdawbftbYwhAP3bsA3fCTniThvq48/nVFpEnN6wKQP+LphQo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105701+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1685947082465675.5617344807578; Sun, 4 Jun 2023 23:38:02 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id dF9NYY1788612xE9w3BZ6GC3; Sun, 04 Jun 2023 23:38:02 -0700 X-Received: from muminek.juszkiewicz.com.pl (muminek.juszkiewicz.com.pl [213.251.184.221]) by mx.groups.io with SMTP id smtpd.web11.1410.1685947081044866376 for ; Sun, 04 Jun 2023 23:38:01 -0700 X-Received: from localhost (localhost [127.0.0.1]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTP id A5E92260B91; Mon, 5 Jun 2023 08:37:59 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at juszkiewicz.com.pl X-Received: from muminek.juszkiewicz.com.pl ([127.0.0.1]) by localhost (muminek.juszkiewicz.com.pl [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uWj0ppzTSk1c; Mon, 5 Jun 2023 08:37:58 +0200 (CEST) X-Received: from applejack.lan (83.21.93.182.ipv4.supernova.orange.pl [83.21.93.182]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTPSA id 799C5260BC3; Mon, 5 Jun 2023 08:37:53 +0200 (CEST) From: "Marcin Juszkiewicz" To: devel@edk2.groups.io Cc: Sami Mujawar , Ard Biesheuvel , Leif Lindholm , Marcin Juszkiewicz Subject: [edk2-devel] [PATCH v2 8/8] ArmPkg: show stage2 granule support on Neoverse-N1 Date: Mon, 5 Jun 2023 08:37:43 +0200 Message-Id: <20230605063743.405487-10-marcin.juszkiewicz@linaro.org> In-Reply-To: <20230605063743.405487-1-marcin.juszkiewicz@linaro.org> References: <20230605063743.405487-1-marcin.juszkiewicz@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org X-Gm-Message-State: XU3361BiAawegkNg6JV9em72x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1685947082; bh=Eg78TzxhNmS86W24VwGzBd9xy3crHZpXNKAxd3zT/G4=; h=Cc:Date:From:Reply-To:Subject:To; b=lCSoQp1AQqQI+wWG7hfMF5rUa1MpWHiEQjCsI4iW0wxMnBQgZdWlnhd8bNSRBfIj2MC UlpaDsfwJVcy2jr9IqrOEQZO0n/XkXSHebf+mmbvrJ9nDqp3l/8fGF9QgHy9KIRSTw1Nm P3Dsd5xyPzHzNXEKc4r0645QHpHA/ypOHdw= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1685947083178100031 Content-Type: text/plain; charset="utf-8" N1 uses '0000' values which mean: Support for 4KB granule at stage 2 is identified in the ID_AA64MMFR0_EL1.TGran{4,16,64} field. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c b/ArmPkg/Applicatio= n/ArmCpuInfo/ArmCpuInfo.c index caaab4ec4313..a97236f59352 100644 --- a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c +++ b/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c @@ -1210,6 +1210,13 @@ HandleAa64Mmfr0 ( Bits =3D "43:40"; Value =3D (Aa64Mmfr0 >> 40) & 0xf; switch (Value) { + case b0000: + if (((Aa64Mmfr0 >> 28) & 0xf) =3D=3D b0000) { + Description =3D " 4KB granule supported at stage 2."; + } else { + Description =3D "unknown"; + } + break; case b0001: Description =3D " 4KB granule not supported at stage 2."; break; @@ -1248,6 +1255,13 @@ HandleAa64Mmfr0 ( Bits =3D "35:32"; Value =3D (Aa64Mmfr0 >> 32) & 0xf; switch (Value) { + case b0000: + if (((Aa64Mmfr0 >> 20) & 0xf) =3D=3D b0001) { + Description =3D "16KB granule supported at stage 2."; + } else { + Description =3D "unknown"; + } + break; case b0001: Description =3D "16KB granule not supported at stage 2."; break; @@ -1283,6 +1297,13 @@ HandleAa64Mmfr0 ( Bits =3D "39:36"; Value =3D (Aa64Mmfr0 >> 36) & 0xf; switch (Value) { + case b0000: + if (((Aa64Mmfr0 >> 24) & 0xf) =3D=3D b0000) { + Description =3D "64KB granule supported at stage 2."; + } else { + Description =3D "unknown"; + } + break; case b0001: Description =3D "64KB granule not supported at stage 2."; break; --=20 2.40.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105701): https://edk2.groups.io/g/devel/message/105701 Mute This Topic: https://groups.io/mt/99335296/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-