From nobody Mon Sep 16 18:52:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+105245+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1684935549839104.89916019743578; Wed, 24 May 2023 06:39:09 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id fE6UYY1788612xkg3eOgQfLD; Wed, 24 May 2023 06:39:09 -0700 X-Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.44]) by mx.groups.io with SMTP id smtpd.web10.9079.1684935548452695144 for ; Wed, 24 May 2023 06:39:09 -0700 X-Received: from AS9PR06CA0463.eurprd06.prod.outlook.com (2603:10a6:20b:49a::14) by GVXPR08MB7677.eurprd08.prod.outlook.com (2603:10a6:150:3f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29; Wed, 24 May 2023 13:39:02 +0000 X-Received: from AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49a:cafe::1a) by AS9PR06CA0463.outlook.office365.com (2603:10a6:20b:49a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.15 via Frontend Transport; Wed, 24 May 2023 13:39:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+105245+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT027.mail.protection.outlook.com (100.127.140.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.15 via Frontend Transport; Wed, 24 May 2023 13:39:02 +0000 X-Received: ("Tessian outbound 5154e9d36775:v136"); Wed, 24 May 2023 13:39:02 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: c97272e1e347f9b7 X-CR-MTA-TID: 64aa7808 X-Received: from cc007dc5e5d6.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C2E42FFC-96F8-4762-86FB-85DF808FCE43.1; Wed, 24 May 2023 13:38:56 +0000 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cc007dc5e5d6.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 24 May 2023 13:38:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dpdqi/v2ZRSIAReErD+b+pvhLRip1jb5MMidLeY0HZvYPj/34URl1twgfapwMaS0frsb7ay2+oaYKagtwrcydCAMfbZnhTshccTdBx75l4g/rY/h39UNO4qHeoci81xXJCEWzF30wJ4lsAIU1CJYlu9xMgty2TiMjvDAu65YJZ3hgqPwvVgNnhWGURf+W/EdCRSucbx4Xk58tAJr0Y5AbICoUuK4qnjHhSAskfeOIMmxycUBkcZxti5kCBUc4nexvhS+I/ik7yHSkMGzSKg4LgMHUN/ce5CBgx+I32DbziCBbG5g7bBrBLNO1iaMNcm6sskqGgr9/VthQfG2gyuC0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d47QiyIrfXmRuofG8VmKwt4egKsZ6zD27tJQL3mHK1Y=; b=mijoHdXcHtUTl9WYgVKxmIKlUg9Zp96akmfcfHySGCWqXiTUyJuHr8vjIz2yi95Q8+4c3Kfv/nA31CAz5vSCkWq4bvqqX/DQ/himSBpA9wJ3/QFjeQeyfr3qIhL1XjahUAoX8ecn2O72Z07SmVK8cbu3SNwhCFFmDNMZqhjD3/+OTkexRRs/P2n/AKC255kE2zCn9+kjRnCUcpdPRc+T8uDfuv1+IgyV6gsBxO9zwqyIPxQkuDKRCsP22SnfBYnlqV4SecagbeTVJKYm6DyVROaCDVtXylt01D7LVW8lr5hSYHWXCYrYnDj3tp728nJ2JBAH01nWvBvKpVPuXzJubA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AS9PR05CA0094.eurprd05.prod.outlook.com (2603:10a6:20b:498::9) by PAWPR08MB9638.eurprd08.prod.outlook.com (2603:10a6:102:2e0::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Wed, 24 May 2023 13:38:45 +0000 X-Received: from AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:498:cafe::8) by AS9PR05CA0094.outlook.office365.com (2603:10a6:20b:498::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.15 via Frontend Transport; Wed, 24 May 2023 13:38:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT059.mail.protection.outlook.com (100.127.140.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6433.14 via Frontend Transport; Wed, 24 May 2023 13:38:45 +0000 X-Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 24 May 2023 13:38:43 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 24 May 2023 13:38:43 +0000 X-Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Wed, 24 May 2023 13:38:42 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , , Subject: [edk2-devel] [PATCH v2 04/11] ArmPkg: Fix Non-Boolean comparison in ArmGicEnableDistributor Date: Wed, 24 May 2023 14:38:33 +0100 Message-ID: <20230524133840.28612-5-sami.mujawar@arm.com> In-Reply-To: <20230524133840.28612-1-sami.mujawar@arm.com> References: <20230524133840.28612-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT059:EE_|PAWPR08MB9638:EE_|AM7EUR03FT027:EE_|GVXPR08MB7677:EE_ X-MS-Office365-Filtering-Correlation-Id: 79f39ac7-2573-4a5c-7a2a-08db5c5c3c8a x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: lKkHaS+mO+/xOvPkmEo+PYybdAn8Q2hIdQHFrcCKrsqntwAgF+UcE9Br2Bs4VVaQnZ3O15Q0AeAG78ZQKWko88hl7MuN1IFCEgDpu9+1mzIVeRwSaGbKe09AxdTkN7CcS3McTEw94pCD0pIFJL8AsBqfKccSD4fdztKDOv7koMYyglKFF7qq1gP5UQNfhIM0xRuJ4mxv4B9kUVzNiZ+AKofDQmQJ3U2wNbZsZX9Qbf6t32Nsot6AENoA6y/LGtocAfVq08cSG6iZIYh7LUkm5zqELslYTZn5ifFNELkOmD2LYtel2fWSE2Yho70p+g4AzjmCcOdOIXXAKtaLdYsJnxZfWDH0Jjk3sIHtZV0s1F2dap3G9iak7TXTtztxkmj6wjCkCslrGoQHdR4VjYhlpHp0T4Qn4fKG0F2BTLkcWxrdnnrh43luUYbIAjKiCXbSXLCtzC8JYNu7Zqe3RiAx0A/hNX24khYa4YD1bhJrPOtIuzCMNzk17se0U7U8iZLbryCiieMYMoi2yRt0DqWkhZ82lwDQQCZ/Hk80oXENwx1zXnDOWTuj8cA+FhC556+1MfnkCscyBD0o4tf4R7VG7BrFSqcLyOuUbXg4no61U4H/D9dxH47XPHX33JQDTOfoBcNMnU7qiz/tyPkRKEM6Eycf1B8rwecoDaqvoEiPWa/q0WRU/4dV4rBf01bGYrpYuewwyCXn8Ies5PChVL5Lo0UXAsYerxM65fwGEpFPWhY= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(39860400002)(376002)(346002)(451199021)(36840700001)(46966006)(316002)(966005)(6916009)(70206006)(4326008)(70586007)(426003)(336012)(478600001)(8936002)(82310400005)(54906003)(8676002)(7696005)(6666004)(86362001)(41300700001)(5660300002)(26005)(44832011)(36756003)(36860700001)(83380400001)(82740400003)(356005)(47076005)(81166007)(1076003)(186003)(2906002)(2616005)(40480700001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9638 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: fb46669e-8718-4de5-51fc-08db5c5c3260 X-Microsoft-Antispam-Message-Info: oBIpqfdtf4zaeIot5ntzjbyWYs0nE5i61f2tQ5cUnHvFBgido50hBwbQrio14iXbotozv05ifR1e3qDG/pNxu1k+ZqzRVChbVjTL63g+b0JJ61JvOOMMXBUUJo0Y1KCATJGy5dJdNUS0uR8OL8WF5kQB5xa1xH4n7kFdjdsvjEU3fQ64Ggw2bI7jhe6uS5+lFSvSreRhgHB2c7mu3+vGjW1EOC9oNWIurJGQvk/QiGmePyt7Rqwvfieka5AXJCiVEpTEj/hT7n3ejK5pYcEQECvDvsoXXcVFiY7AFFer7Q5lDCTunJ75v2KooF4/zjAv2KNe4uvbM6LZ09OAH+y2LMit7PYl6fYHqBWZsPsmOao1IekOeVJysSKDezddkHVP5Bvady++9jqh9qW9apaJoNBTQwAkjpWOuOW5iOckF+s2eplHqEh8p6Lq/t2kWU1rRY+KlXPF5Ce5rjm8xti23oUPtjsgAIpw9aJdAwXwG+JY1AkEomgBbMZ+eWLrHER29PtxlVIUb/QBhHPMWO3R+r0Ci4PsveKqR9/z3qM8MFl//vzKKyT1qho2LUy5FS2TQaaVuync2lYC+lqHrx+RRATCQ6UHlZLG2Xl89vdW8LYL6v3kjZpnvTvTvpdzK7urv7Nws5Fma7vq+1lA2ZpKQ0OHMMEPX+WsNVlUJXpCPisZRdmH17/LX7vWSPp1p2by2aukPXlYbuW7lX09VL2JVYOZmd2j3FlXNV/fYosiN/I= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2023 13:39:02.4262 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 79f39ac7-2573-4a5c-7a2a-08db5c5c3c8a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7677 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: 7JZFdlGO29vGUPfH6KaWibIAx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1684935549; bh=GXAm1pvCMm/paZ/b4pjv8M+qIk+4aqjN7iD1wUtpBzY=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=PQxCUElQMlmZLu6c+w7VJOuKq70tc5FU5DiuYj3QebaywAevlzwg9RBwrgBu4EfDpvm t9Yw4XvhDi83f9NH8gk2WNitGGfeZxRjxqdd+8aGh7SN6WW67JP2/4OcrbBSxALsVt6Wx jDRkX1Z7DFKjgkDP/iXs4DJhgZLAfObhpgs= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1684935550875100030 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" According to edk2 coding standard specification, Non-Boolean comparisons must use a compare operator (=3D=3D, !=3D, >, < >=3D, <=3D). See Section 5.7.2.1 at https://edk2-docs.gitbook.io/ edk-ii-c-coding-standards-specification/5_source_files/ 57_c_programming Therefore, fix the comparison in ArmGicEnableDistributor() Signed-off-by: Sami Mujawar --- Notes: v2: - Improve coding style by using temporary variable [Ard] - Updated based on review feedback [Sami] - Ref: https://edk2.groups.io/g/devel/message/105189 ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c b/ArmPkg/Drivers/ArmGi= c/ArmGicNonSecLib.c index 38bbf2e9f81527b2545a0116120ceee56af17808..1a6ad48d1ff6c3eb5c8c375606c= 1600e42db42d6 100644 --- a/ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c +++ b/ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c @@ -17,6 +17,7 @@ ArmGicEnableDistributor ( ) { ARM_GIC_ARCH_REVISION Revision; + UINT32 GicDistributorCtl; =20 /* * Enable GIC distributor in Non-Secure world. @@ -26,7 +27,8 @@ ArmGicEnableDistributor ( if (Revision =3D=3D ARM_GIC_ARCH_REVISION_2) { MmioWrite32 (GicDistributorBase + ARM_GIC_ICDDCR, 0x1); } else { - if (MmioRead32 (GicDistributorBase + ARM_GIC_ICDDCR) & ARM_GIC_ICDDCR_= ARE) { + GicDistributorCtl =3D MmioRead32 (GicDistributorBase + ARM_GIC_ICDDCR); + if ((GicDistributorCtl & ARM_GIC_ICDDCR_ARE) !=3D 0) { MmioOr32 (GicDistributorBase + ARM_GIC_ICDDCR, 0x2); } else { MmioOr32 (GicDistributorBase + ARM_GIC_ICDDCR, 0x1); --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105245): https://edk2.groups.io/g/devel/message/105245 Mute This Topic: https://groups.io/mt/99108682/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-