[edk2-devel] [PATCH 2/2] ArmPkg/SmbiosMiscDxe: Remove redundant assign for SmbiosHandle

Minh Nguyen via groups.io posted 2 patches 1 year ago
[edk2-devel] [PATCH 2/2] ArmPkg/SmbiosMiscDxe: Remove redundant assign for SmbiosHandle
Posted by Minh Nguyen via groups.io 1 year ago
This helps to remove redundant assign for SmbiosHandle.

Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Minh Nguyen <minhnguyen1@os.amperecomputing.com>
---
 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
index 7250da02b3ac..313129460d9c 100644
--- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
+++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
@@ -213,8 +213,6 @@ SmbiosMiscGetLinkTypeHandle (
     return;
   }
 
-  SmbiosHandle = SMBIOS_HANDLE_PI_RESERVED;
-
   for (Index = 0; Index < (*HandleCount); Index++) {
     Status = mSmbiosMiscSmbios->GetNext (
                                   mSmbiosMiscSmbios,
-- 
2.39.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104981): https://edk2.groups.io/g/devel/message/104981
Mute This Topic: https://groups.io/mt/98948708/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 2/2] ArmPkg/SmbiosMiscDxe: Remove redundant assign for SmbiosHandle
Posted by Sami Mujawar 1 year ago
Hi Minh,

Thank you for this patch.

This fix looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 16/05/2023 08:08 am, Minh Nguyen wrote:
> This helps to remove redundant assign for SmbiosHandle.
>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Minh Nguyen <minhnguyen1@os.amperecomputing.com>
> ---
>   ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
> index 7250da02b3ac..313129460d9c 100644
> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
> @@ -213,8 +213,6 @@ SmbiosMiscGetLinkTypeHandle (
>       return;
>     }
>   
> -  SmbiosHandle = SMBIOS_HANDLE_PI_RESERVED;
> -
>     for (Index = 0; Index < (*HandleCount); Index++) {
>       Status = mSmbiosMiscSmbios->GetNext (
>                                     mSmbiosMiscSmbios,


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104916): https://edk2.groups.io/g/devel/message/104916
Mute This Topic: https://groups.io/mt/98922256/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-