From nobody Fri Oct 25 15:41:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+104808+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+104808+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=quicinc.com ARC-Seal: i=1; a=rsa-sha256; t=1683914287; cv=none; d=zohomail.com; s=zohoarc; b=bO6YuEqLOadRxBdp1Os+o6P6IKBACxuUPEZw2nzRLfzb/TzwDq5+cOPRL24PgS3oOSSlkk6E45LgZSYkSMcMO97BAZ1bkaBeVvVI+sDvtB6DM0rkOTRZYQs6vvQXtW+eZU4h27+VzAYzp/Bov2mKedm9+bcXYbIeP1EpOnh6C6U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683914287; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=ti0/prL1Q6CxZsCKEFn2YE2TILUYOJJPd72W30QD6OY=; b=h2pIBNcLOK8RLpaHxyu4LX+T7amDLWsePv4FV/cGuFBbAwd7k3pOCmnByLT7w+994wALvglqP7ADRJPKg0LoI0Buzl/h5wivaN0rheJdlt6DE6DlgUYDhox5X7ID/w3mFJShlCO9xyqxuPkAiUi0fiS5+JWFfNskLJ4GcXjCOLU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+104808+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683914287681413.77741012842046; Fri, 12 May 2023 10:58:07 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ZbtLYY1788612x8rKklKFTLI; Fri, 12 May 2023 10:58:07 -0700 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web10.31577.1683914286493800719 for ; Fri, 12 May 2023 10:58:06 -0700 X-Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34CDlkQr017619; Fri, 12 May 2023 17:58:05 GMT X-Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qhes21ntq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 May 2023 17:58:05 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 34CHw4s1023867 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 May 2023 17:58:04 GMT X-Received: from qc-i7.qualcomm.com (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Fri, 12 May 2023 10:58:02 -0700 From: "Leif Lindholm" To: CC: Ard Biesheuvel , Graeme Gregory , Radoslaw Biernacki , Marcin Juszkiewicz Subject: [edk2-devel] [PATCH edk2-platforms 1/2] Silicon/Qemu: use 64-bit Pcds for SbsaQemu GIC addresses Date: Fri, 12 May 2023 18:57:52 +0100 Message-ID: <20230512175753.13318-2-quic_llindhol@quicinc.com> In-Reply-To: <20230512175753.13318-1-quic_llindhol@quicinc.com> References: <20230512175753.13318-1-quic_llindhol@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: rfkr1VeMx5qWHZg9tR3HCn32iXLo_uFM X-Proofpoint-GUID: rfkr1VeMx5qWHZg9tR3HCn32iXLo_uFM Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com X-Gm-Message-State: jwzfnDeUGtK5CxqtIQW4bjEyx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683914287; bh=2hbsOg9mDK63BRjF7s6JC4e39qBUSjaXJL3H8scq6Hg=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=XkXUc3fvqvPWkOIXZ/KVImu0B1C1lTI5uCk2yyWgI2CqyrIwgzzLnuE5bkDNS8HxM95 YnBwbEBoIsXZ4vOlDuCvfn/jTwRaSUst3oL0eDwRRFhDUZhFjnFOYDzwAHNSR1mygd7VB wJXpOrzmA0+qmQWICoAN/ly6jJ9mJ4ForKs= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683914288648100007 Content-Type: text/plain; charset="utf-8" gArmTokenSpaceGuid.PcdGicDistributorBase and gArmTokenSpaceGuid.PcdGicRedistributorsBase are both defined as UINT64 in ArmPkg.dec, but SbsaQemuAcpiDxe and its exported header file use PcdGet32. While this currently works, it will break once these Pcds are made dynamic - so fix. Signed-off-by: Leif Lindholm Cc: Ard Biesheuvel Cc: Graeme Gregory Cc: Radoslaw Biernacki Cc: Marcin Juszkiewicz Reviewed-by: Sami Mujawar --- Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h | 2 +- Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h = b/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h index 4d5b05ba17c6..dcafcbca5a48 100644 --- a/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h +++ b/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h @@ -33,7 +33,7 @@ EFI_ACPI_6_0_GICR, /* Type */ = \ sizeof (EFI_ACPI_6_0_GICR_STRUCTURE), /* Length */ = \ EFI_ACPI_RESERVED_WORD, /* Reserved */ = \ - FixedPcdGet32 (PcdGicRedistributorsBase), /* DiscoveryRangeBaseAddress = */ \ + FixedPcdGet64 (PcdGicRedistributorsBase), /* DiscoveryRangeBaseAddress = */ \ SBSAQEMU_MADT_GICR_SIZE /* DiscoveryRangeLength */ = \ } =20 diff --git a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.= c b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c index 7ba9e8e9deeb..58330a3e7005 100644 --- a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c +++ b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c @@ -83,7 +83,7 @@ AddMadtTable ( EFI_ACPI_6_0_GIC_DISTRIBUTOR_STRUCTURE Gicd =3D EFI_ACPI_6_0_GIC_DISTRIBUTOR_INIT ( 0, - FixedPcdGet32 (PcdGicDistributorBase), + FixedPcdGet64 (PcdGicDistributorBase), 0, 3 /* GicVersion */ ); --=20 2.30.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104808): https://edk2.groups.io/g/devel/message/104808 Mute This Topic: https://groups.io/mt/98854531/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076= /xyzzy [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-