From nobody Sat Jul 27 08:38:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+104803+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+104803+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1683901399; cv=none; d=zohomail.com; s=zohoarc; b=EhX3pNC7EFZ0oN8ImWAaSors3D27Hyk7cQNuhHa+LM5hYjvF/Z0wsfOOn+fEx4Zx0idSaN1QLCT8WjNrJ9fnOC1Jx0dLO0Lok5Y9jbI+FUjKnd4x4zdHsFR1GVirUo9xAn0vwbtkwCR4oOLqcNCjZGvTtwdnsEvCZYcpNIUUkII= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683901399; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=FcxSgIOh5C1ouQOdjFz9Lr4boD7x8cvpXpqB4li1XMw=; b=JYzNSDNFumWrlgHUiXN76iVwxO24eizdvBnLhuh6W00sL8tupLUZ/RTI9YdyNrGA0dbxOZh4NyensYiwL2doWZ1aV7PajoGBiaBn1L86Sx3VH+w0FheSXMeBeSWQox2eB2r/EPRLD66gu6qzQu5lWBCXSv7zwAuaAbrpgE0lXPc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+104803+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683901399192919.3031321603727; Fri, 12 May 2023 07:23:19 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id wYi4YY1788612xPmslHVni8r; Fri, 12 May 2023 07:23:18 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.26252.1683901398046317543 for ; Fri, 12 May 2023 07:23:18 -0700 X-Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-117-4xrceypKM4GGB9HUiuF9QQ-1; Fri, 12 May 2023 10:23:14 -0400 X-MC-Unique: 4xrceypKM4GGB9HUiuF9QQ-1 X-Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6DDE13C0CD56; Fri, 12 May 2023 14:23:13 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1AAF163F8A; Fri, 12 May 2023 14:23:13 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id BD41D1800917; Fri, 12 May 2023 16:23:06 +0200 (CEST) From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: Gerd Hoffmann , Jiewen Yao , Jordan Justen , Leif Lindholm , Pawel Polawski , Sami Mujawar , Oliver Steffen , Ard Biesheuvel Subject: [edk2-devel] [PATCH 5/5] OvmfPkg/VirtioSerialDxe: use TPL_NOTIFY Date: Fri, 12 May 2023 16:23:06 +0200 Message-Id: <20230512142306.1323983-6-kraxel@redhat.com> In-Reply-To: <20230512142306.1323983-1-kraxel@redhat.com> References: <20230512142306.1323983-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com X-Gm-Message-State: 0AqzFBPtzyYLL3z3Y9J2evkBx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683901398; bh=IBP7rTKiIRLFgtotlzQ9nFEqVUqe++KoQIFdz5VPE4c=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=bOPm4bz89xIGtB5ezjYuMgnNwyaHc8R57xHmO7JAhg25VN0lu6yBcNMEKAIVjznPdQV WYvxeG6vrmr6tUVSvLsrBcYLjK9QLadfhpRuT/zdny0fCllGF8kv10tkbvC4JPQ03Wt2r cHnNm8rW2PBtcvXMCfhHzhKOKOLa2HvxM0k= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683901400171100004 Content-Type: text/plain; charset="utf-8"; x-default="true" Apparently TPL_CALLBACK is too low, code runs into an ASSERT complaining the new TPL is lower than the old TPL. Signed-off-by: Gerd Hoffmann Acked-by: Ard Biesheuvel --- OvmfPkg/VirtioSerialDxe/VirtioSerialPort.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/VirtioSerialDxe/VirtioSerialPort.c b/OvmfPkg/VirtioSer= ialDxe/VirtioSerialPort.c index 522b25e9698c..e4a58deff162 100644 --- a/OvmfPkg/VirtioSerialDxe/VirtioSerialPort.c +++ b/OvmfPkg/VirtioSerialDxe/VirtioSerialPort.c @@ -158,7 +158,7 @@ VirtioSerialIoWrite ( =20 VirtioSerialRingClearTx (SerialIo->Dev, PortTx (SerialIo->PortId)); =20 - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); if (SerialIo->WriteOffset && (SerialIo->WriteOffset + *BufferSize > PORT_TX_BUFSIZE)) { @@ -201,7 +201,7 @@ VirtioSerialIoRead ( goto NoData; } =20 - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); if (SerialIo->WriteOffset) { DEBUG ((DEBUG_VERBOSE, "%a:%d: WriteFlush %d\n", __func__, __LINE__, S= erialIo->WriteOffset)); VirtioSerialRingSendBuffer ( --=20 2.40.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104803): https://edk2.groups.io/g/devel/message/104803 Mute This Topic: https://groups.io/mt/98850082/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-