From nobody Wed Feb 11 03:03:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+104408+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+104408+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1683649950; cv=none; d=zohomail.com; s=zohoarc; b=aWSMcyp4caLMgjwgm84yZN9TTGBnTtfBT/jYot6tx1XmYnLD3WK/oLsMLgD6WfGWSqDro8qdx7Jm8vbqra9OM6xudpgyzHidSLyNu7DuSI+FHqldSan70xXlYu7AzxcKaD39AFWyGdnTZtVaYG8HwAcvcTHHGp9HO0jE6PyYEVA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683649950; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=axS2ON52VkKja7huuuXOv17O/EB8aH7dBLVzuj2f484=; b=fppJWqA99t9nBAKi6ClOTkaZo1dGhHv4JKyuisqOxkBjtRGy/NSbjZk/+HnZYC18QsCvURALI/fDaC8zVzLhJOIEpMlsGCIVn/Wgg1+A1ymJmOTj8EYcO9M7f9k0GlQGKavkFFpX4kvBbv/pTyQp4sWbef7by8mA5JdjvMQIw0c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+104408+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683649950250832.7832150719252; Tue, 9 May 2023 09:32:30 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 66jmYY1788612xNdys6klBlu; Tue, 09 May 2023 09:32:29 -0700 X-Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mx.groups.io with SMTP id smtpd.web10.37759.1683649949016839880 for ; Tue, 09 May 2023 09:32:29 -0700 X-Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-3f420618d5bso22612985e9.1 for ; Tue, 09 May 2023 09:32:28 -0700 (PDT) X-Gm-Message-State: LMb5yUkBlF8VjkBLkiBGIysGx1787277AA= X-Google-Smtp-Source: ACHHUZ7cFtCqVZzIqFdHzSDJbuVSaECffh/ssEi9dD0E/xj4AUyLzJCf4APITu+aHEyF7NH2Mtoxvw== X-Received: by 2002:a1c:7c0f:0:b0:3f4:219f:5b7a with SMTP id x15-20020a1c7c0f000000b003f4219f5b7amr6080677wmc.30.1683649946965; Tue, 09 May 2023 09:32:26 -0700 (PDT) X-Received: from PC-PEDRO-ARCH.lan ([2001:8a0:7280:5801:9441:3dce:686c:bfc7]) by smtp.gmail.com with ESMTPSA id p1-20020a05600c204100b003f0a6a1f969sm20363938wmg.46.2023.05.09.09.32.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 May 2023 09:32:26 -0700 (PDT) From: "Pedro Falcato" To: devel@edk2.groups.io Cc: Laszlo Ersek , Pedro Falcato , Jian J Wang , Liming Gao , Hao A Wu , Ray Ni , Mike Maslenkin Subject: [edk2-devel] [PATCH v2 03/12] MdeModulePkg/SataControllerDxe: Remove useless null check Date: Tue, 9 May 2023 17:32:03 +0100 Message-Id: <20230509163212.291333-4-pedro.falcato@gmail.com> In-Reply-To: <20230509163212.291333-1-pedro.falcato@gmail.com> References: <20230509163212.291333-1-pedro.falcato@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683649949; bh=BMeSlTtrkiRtAPqq89EkcOShhOnvf77CZAtQcvq4md4=; h=Cc:Date:From:Reply-To:Subject:To; b=qbXkMYOrh6EF98rgGIk1S5LyD9MRAoVhiUeKl2lD6tOGXey88+qEobpxCfaOB3juup6 vcbATbKXHl8iRywKFgegc+1hpVkmI0CYcykAXhYc6uo1FOdepmG9SxJDlAMrDtFwkSxGj Y1TaQfC1EIXTkPJo7yXyU4qZQAaSCvYtAWA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683649951126100015 Content-Type: text/plain; charset="utf-8" ASSERT (Private !=3D NULL) already covers this check. See commit 81310a6. Cc: Jian J Wang Cc: Liming Gao Cc: Hao A Wu Cc: Ray Ni Cc: Laszlo Ersek Cc: Mike Maslenkin Signed-off-by: Pedro Falcato Reviewed-by: Hao A Wu Reviewed-by: Laszlo Ersek --- .../Pci/SataControllerDxe/SataController.c | 44 +++++++++---------- 1 file changed, 21 insertions(+), 23 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c b/MdeM= odulePkg/Bus/Pci/SataControllerDxe/SataController.c index 277bc6182db6..f0ffd311d7b9 100644 --- a/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c +++ b/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c @@ -626,34 +626,32 @@ SataControllerStop ( return Status; } =20 - if (Private !=3D NULL) { - if (Private->DisqualifiedModes !=3D NULL) { - FreePool (Private->DisqualifiedModes); - } - - if (Private->IdentifyData !=3D NULL) { - FreePool (Private->IdentifyData); - } + if (Private->DisqualifiedModes !=3D NULL) { + FreePool (Private->DisqualifiedModes); + } =20 - if (Private->IdentifyValid !=3D NULL) { - FreePool (Private->IdentifyValid); - } + if (Private->IdentifyData !=3D NULL) { + FreePool (Private->IdentifyData); + } =20 - if (Private->PciAttributesChanged) { - // - // Restore original PCI attributes - // - Private->PciIo->Attributes ( - Private->PciIo, - EfiPciIoAttributeOperationSet, - Private->OriginalPciAttributes, - NULL - ); - } + if (Private->IdentifyValid !=3D NULL) { + FreePool (Private->IdentifyValid); + } =20 - FreePool (Private); + if (Private->PciAttributesChanged) { + // + // Restore original PCI attributes + // + Private->PciIo->Attributes ( + Private->PciIo, + EfiPciIoAttributeOperationSet, + Private->OriginalPciAttributes, + NULL + ); } =20 + FreePool (Private); + // // Close protocols opened by Sata Controller driver // --=20 2.40.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104408): https://edk2.groups.io/g/devel/message/104408 Mute This Topic: https://groups.io/mt/98787856/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-