From nobody Tue Feb 10 14:33:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+104141+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+104141+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683306761336893.9083337853049; Fri, 5 May 2023 10:12:41 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id R4CRYY1788612xAgvoLsltsj; Fri, 05 May 2023 10:12:41 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.122]) by mx.groups.io with SMTP id smtpd.web10.19539.1683259141613765369 for ; Thu, 04 May 2023 20:59:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LHgXZsZD911ljb8Vd0ikQKuJTmo+YyDDFnnhzFWfFwBnE91S7eYS03rh2BZqMb7hTXmqKFSqxyZIKQfhPHhKlTc8UQ68wqPJL5aZDPpicEw8hIlQnjapWSZFhMdutOnRyFcUNeKdtxl5jeYWo2AV33BqzxSxUvHDRumKVS/x63tFogWsihu8p8wi9NKWvDeooeMpiaIIY+q6yahdZ0IU08R5j29brwZoDBlpO5ondQKOIWhfvo3NXHtwFoYD88Puufbp7hZbidUFf7LmFtjXgvJM79WfMzUtriF1bGh0421EpUQXaHJehzX91BN30DqCQ0Q8mgZBM7PD/hOkJ/7/7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w80a17SRG4H/FjuGHnGCwj+eO40Z/rPedQ/qh1QZR5o=; b=JLvckXSuu3YrRBdGOt46jEVtU85BIiTU8JqDnMrlxx4TM0cqhYdFeBAPXuUH5AyxhNZokx+t4vxSswD/oaeBOrAJoy7mlOluGjdiFrY0+Zn0f0FU/xVspZCqGQWTuXwXRLrPo3bKGIpIZF72zigt8HS2ys58iMo6Xr17w4CHYfY3Bf6GfFLSF9S4y78poUB9gEqUNn+5XdDuYer6s6VNT2tbaeElWImbdGImIWY4W27EUAVOgN+nkc4a76/TAnrUOTYAWjc1YLmiRwExMA71PdJ44AEc1Z92SEHurofK5Of5XMdRApcq5fKK3C6udT4t/X0iuWtGjz+dbQ20SW7rLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) by PH7PR01MB7725.prod.exchangelabs.com (2603:10b6:510:1d5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Fri, 5 May 2023 03:58:59 +0000 X-Received: from PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1]) by PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1%7]) with mapi id 15.20.6363.026; Fri, 5 May 2023 03:58:59 +0000 From: "Minh Nguyen via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com, Vu Nguyen , Minh Nguyen , Nick Ramirez Subject: [edk2-devel] [PATCH V3 2/5] RedfishPkg: Fix condition checking of error status Date: Fri, 5 May 2023 10:58:21 +0700 Message-ID: <20230505035824.1466954-3-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230505035824.1466954-1-minhnguyen1@os.amperecomputing.com> References: <20230505035824.1466954-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG2PR02CA0107.apcprd02.prod.outlook.com (2603:1096:4:92::23) To PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB8048:EE_|PH7PR01MB7725:EE_ X-MS-Office365-Filtering-Correlation-Id: 0d69b4c8-be4a-4580-452e-08db4d1d0e39 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: EZtn5NQdZUSdQXxAIVu740kV0BZnAOrUUHgvd3gFkrJMq6+FnfFsnzyHsFi4/vZoerIKx6YhTdVOb07puv4EB9Zy0AnrSzfMWin+Xxe5ejLbKJQxXTNYcI22KikMte51EHnvHL5VdPC3apA/oOfKAXs7blrSrleV6QjiZpF1ShYgilgieY3Dtx6hUpVhZjROy9q8CEQATkxITMxe5LGag9hmq17+75l3TNx3kdc7HklDJ+hRAeSb00wZUATvsgT+e/C0oqaeESE+h48AFPZu2hVQk0Md7jZ6X1hU8RdimPGXM66RF/1o6iEHkUZN+jx5XzMksqwRxFBbtKTc9DXtgsydc08N/aU7RcuN+H6BX+SUekJV/Dte2vwQpuKNfGjWowXFvNzXFdw5eyGAvhyhI7h6uxLQZ+IC/I4IjMtSl3J/A19F+GsjHCSPvPcA09n95RG1qFo/ZfTgu3OR1RAfY3+na1mOIciMLsdn+kayg5zDrn1vldZtEJXajkPofr8I76kXxsPzUCgOkjWBfzG94f/oEFfNBh60/V24tIvcaOL32cvY0vuZdxqr1tGhhjcpiVS5+b/b+jYZMoB5YaK3t/U4cMhHJxtYNptxK3y8RUmCRpOH8x2JqbEWmvkWOpnl X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PRpxeVhXUntlEvLeDABLj0U/ouxl7ixx2fqWJndvG54+IjGmBnDaSaquEtCt?= =?us-ascii?Q?MLfLgiBwkmbRbhpxRodJpatNefyKNs+vrWTyPZz8B72BOvNyLzcRWxe+gwk/?= =?us-ascii?Q?ckweSkRGiVzWKVrJsnu1AyBjYCrPDuOdp5PjhvMMuckVzG5sSWxPV2Zb5+9r?= =?us-ascii?Q?2fRaIcvwYzDRp95slm37zJH5eOIshx7zlThhe8f+3ulN9Zgv+2bfVmNY/aS9?= =?us-ascii?Q?fT0oJ4l+keZkeMHbIYMQNgh/TcCcauTV5jdZxAewudPLFTzvbfGhsWiXgWj5?= =?us-ascii?Q?tTUUjt5oJRnmTc11kXmMMDKDunly/d/xSk342cRNjAYhuC5Oa9zYDVukEmO3?= =?us-ascii?Q?tsq0N2ulPTn7Yvry/Ogy28hylE1pYT+4CDVhQEdlH/GQ+JuR8IGiiX4bPPBE?= =?us-ascii?Q?yMi+fr6QE3fDDCmM8w/hHvan9BZnI/yk0i2LkW19h2IiAOUYpaWLJK2QuzKq?= =?us-ascii?Q?I69fM6xA1Mk/9n6orKh1WGgdtCSnEnDWmjlJSa+qmYf7YIBmYEP9qUSwq/Hy?= =?us-ascii?Q?SOBUkrAweT5Sob+P0xgTegHd1AgfKLBOHNXA1AZhDSbLqW3d7SgCZmVY4Eyk?= =?us-ascii?Q?jWBCHu0LmjZEMh5SxPwT1v+1RV9el0uczZaHXlmLX+s0XZ2OlLR3o8XNuINz?= =?us-ascii?Q?Yn+M9cGA3tbzSwgCEENO6FhUGNQoV7VOMGRSv2FoQ53P2IcYWWYfXfqgydIY?= =?us-ascii?Q?Y1Vyxkzp2vuuqRQphvcisRz6g4lK1XQLnHg4Cjvc7HX9tEZQ61AVxcU5z//H?= =?us-ascii?Q?nwhS1WAOyhup2iWCty51YrcdLKY1N6761r/+UmQbtNQI66KMhqWuHWYxYl2V?= =?us-ascii?Q?fTDcSdUxDElHIiEY2TA65zUAeHWJNcYQCE+hOZpn/difB11uf14d8zyNi0uL?= =?us-ascii?Q?WZ/Tx/AAFwfUeWKm8OS77yOQ/NgQQNFMr6vZJ7+FiDZTjX4Dx4LxI16eziLe?= =?us-ascii?Q?PS0l/yqwRs6BoNcN6fp+QgR2afl+ktziMmC+tXvt8Z1wDwlphM9r3CtF8JEZ?= =?us-ascii?Q?dCj/Hk71vdnJEOfzyvBdJqAONYI4cmo41NYuzeobvPf30TtHt73B2b1YZ2vB?= =?us-ascii?Q?pr9d+OTmjCC4pMeRf2+E1D4ogToEyCz6/qBO1uJrf7ocYcZz+oam402NIBFe?= =?us-ascii?Q?XoWTa0RjpLJfks5WfqCLGAIx2ZxFyuILWtBtaAOzAZIwl0OIGbSqjc3svkyp?= =?us-ascii?Q?PCeQGxltKcyUEgMS3EdYQhB22b+g1+dMuvxzic7HNzcTNs1uImGQqu4vTxQG?= =?us-ascii?Q?3gXEhwRBvCBjLkHcqV1ifavYNxGJBQWWKbnh5FGQeag/MRUmbxt2uRVz15vm?= =?us-ascii?Q?0PU+MXVyHXhbpqEvKogrROSF9IiumGGd205QrhNoDpD9cxPEtqsoeBWTilIe?= =?us-ascii?Q?fA5TdxrmBptDTs1LOcY+qC+uaAbC4YgceFXumRymSVspNA0ikd+mDv0/z9p0?= =?us-ascii?Q?TMLJI84mz7+uXpQNRon76S+OraAH6iUxjBaXi7o2JulQHeR0BHRKUtamtJaZ?= =?us-ascii?Q?CuyCgrTIoBblRwQeTlMn7IHlIoQuHya1rB9BbSSAauSHXjnGEFurPeY6gJt/?= =?us-ascii?Q?2eNkgQBGpZT1tC4jxBtWEewrRoVN/ONUS/jV+AzHWpK0+JZF5J9+u74t0LoX?= =?us-ascii?Q?v4kxl1ZTeVzKDV/T3t1S16Auj8uUUoEPAjDaoTv8P0Ym?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d69b4c8-be4a-4580-452e-08db4d1d0e39 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB8048.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 03:58:59.2715 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XOxcQam8fXKFeWmiUsbMpI1NpIF9/aQtHIukAh3GUad2blwAdtaxnylkh7llr+kHorEzNrP6AzbDHtkCL5MQ9i9ETCvqUXHf2PbUbEXAB2dtc6mE8W7GnkXSW/bGvE0l X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR01MB7725 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen1@os.amperecomputing.com X-Gm-Message-State: ikrEzAh4Wby89Ca6T9QC81X5x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683306761; bh=Reemh6S7Fi2xwv9UVDB/Cnk2RjEWiKnPZib/jg3kG6Y=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=DgEdcfBa5E629CVv6tris9POzWVvhWKYpEAaJjmJCC6QDaDjwxevbJFIU+eiTZc9Ck3 q+iLHXa1b7/66N+oJJ63gg/v/ulEoL0/8u/0V5aoIjA3oK/TBSAAvtC7FnMgug42/gSLu cJzFLtQM8UqPWdgFfhaAYGnIrlzfcT8Ya+c= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683306763446100010 Content-Type: text/plain; charset="utf-8" From: Vu Nguyen This change fixes condition checking of error status, the condition should be compared with TRUE status to be identical with an error message. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Nickle Wang --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index 583c6f78e19c..a247bfed9e34 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -5,6 +5,7 @@ (C) Copyright 2021 Hewlett Packard Enterprise Development LP
Copyright (c) 2022, AMD Incorporated. All rights reserved. Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -926,7 +927,7 @@ AddAndSignalNewRedfishService ( } =20 Status =3D gBS->SignalEvent (Instance->DiscoverToken->Event); - if (!EFI_ERROR (Status)) { + if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "%a:No event to signal!\n", __func__)); } } --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104141): https://edk2.groups.io/g/devel/message/104141 Mute This Topic: https://groups.io/mt/98710275/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-