From nobody Wed May 1 22:25:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+104140+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+104140+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683306763103565.3290439736469; Fri, 5 May 2023 10:12:43 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id DiZxYY1788612xoWrXaHhHWH; Fri, 05 May 2023 10:12:42 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.100]) by mx.groups.io with SMTP id smtpd.web11.19399.1683259138164138580 for ; Thu, 04 May 2023 20:58:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OqY7CMEPBv5cNKqgbV5byWBVhau/J+u6PNl61kLXrFZI56LvMCCkwwfTn+fQQd5rJ/WNJoVnbqX4HvPhRiqbcf3gWQeicrnSkZSZKi3fKRzIKT5Z4DATGHBGXT+Wa4pRGM/p35R6EyVONnX4RGXgAdoHgpGg82PECfwNyITSLEjN6OLoN15mYfQBH3vI+GyVbqSCJ1mXvmvN4skS+9xaalFG++3NbvtUEe3+qhozEDgDlOtPYIQCRLyCQR02w6NPvvJoipa2xnKhXAoYbzspCVrxWXqyOdnMV/nyU9PXMpggGoqwxKmuhdxr4NmiREqco3OqqsimBU4XhySZaejV0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=35uvj5Ksz/2/Lk61WIfbLpSL01av76B96OAsKjjzYps=; b=I8x0Pe/ym/RulitlzkTrHqQIrqJFDahlb84ciGXcBMgUoxasnSTorvPPkn9zNwXhmoF/tw2ei0KMvtroXhKa9fBA16cdY4jzZzdZjMQvL1keWkWuBJRkYcLgaao7/Bt3X31SO+pD4dK8v1tUlOk8n3UairFH2574TFrKFkEE3QJLjy/EVYSNRHob55DwT4bndRj4uqK0t6AqrOV6c4vUoT2EG7Mrb2o7y9+0kPCkzeb8ytEnSgMXBvN/Cj2REITjdi/cMEe1iBkcAmpY6/TSaxtQnUE8odLthIVEUue9Y/mDOzwUfMnq9IVVapR/XWDiVL7lQ7RMpzKC1zVW0GW/1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) by PH7PR01MB7725.prod.exchangelabs.com (2603:10b6:510:1d5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Fri, 5 May 2023 03:58:56 +0000 X-Received: from PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1]) by PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1%7]) with mapi id 15.20.6363.026; Fri, 5 May 2023 03:58:56 +0000 From: "Minh Nguyen via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com, Vu Nguyen , Minh Nguyen , Nick Ramirez Subject: [edk2-devel] [PATCH V3 1/5] RedfishPkg: Correct variable type to prevent memory corruption Date: Fri, 5 May 2023 10:58:20 +0700 Message-ID: <20230505035824.1466954-2-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230505035824.1466954-1-minhnguyen1@os.amperecomputing.com> References: <20230505035824.1466954-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG2PR02CA0107.apcprd02.prod.outlook.com (2603:1096:4:92::23) To PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB8048:EE_|PH7PR01MB7725:EE_ X-MS-Office365-Filtering-Correlation-Id: e2c785cd-06fb-44d4-eb18-08db4d1d0c3f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: HhGY2QipvwVfpXALlVEV1wt0OcCBBEEx76wVZWeVul1HPpQrak/swoAHwfg1BudlTTJbyy91Eob25XDDIpI8RaOigQnHt/R+3sJiSXqkTUAKiVzv6p8A1w4GzXc6sAmK+HqbY+htLxPzmQgmjoaUkHmbL1I8x9ZaZFvfKI8PPIKnFwmPi9CdlrSlU+R/31tr9lx88eLpAfEK1GU+nmumRR3n/fyda3/1SHGOqT30Nt3ANLkXjaTivCDSokWkCsvZwxi0sSZecmHukrRzPxJ1XIrwO8tQ2JauW1Yoqgkm0+y++GXXs36w/Kad98MaC3FP5RonhS3Yj7prnlc34psZi5Zg8kkqunqLzJazCF6P+JlZTk/OioFmqHcVhNnDXnfYgiXRY0OFb801K4wmDUSB94YmNSfV617NzcxCD9FnVtj07aoToXmu3sMxR2kru+mXDiaT/9P8XtFQdVdIx2EdmLaEGyUUy5gy+OuIiLwRsNZA3q+nN7Xrn3/Ki7XRbfDsPvEBaZ6NyozDpdBHkTX2oPRw8QHENU+LOVfHH1XV++Fv49uoORpUnS7nXNWDlBkpNBumhQzZ9S66WZLZ6+LdJ7NwZ5zxvjr49qmeWrmQUnUQXV5fLBhfDh757JnBGRwS X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vfktyQ69hqTTKQWHbEsM5Ls6H4aKdGifxHWDY6Xnl4bJIK66Hx1teMop0ycz?= =?us-ascii?Q?B34pDE+/Fj9iynqWGA9Q0LYUzqCtTmSxBCod+5iOrFdC757yy6+KO3aXku51?= =?us-ascii?Q?QZziVFgCh/hMAdcTvRy+9z8SZrEEYaeUfngMo+qNwc7Qbp7Dj7xN7kYXUer0?= =?us-ascii?Q?3ccCHcFyv5YdL+yTQrnd6a1FdDdmiTgmIEAiiRZxWZGExv9ZwD7q/ehLwwNk?= =?us-ascii?Q?KODf+UDNClrgzVyEKBZwXuUBpKxknjDGq4hXvuQIB02XJlTRTEEiWjmK/pxc?= =?us-ascii?Q?PdCdEHuxBztH42R6VOl2s1oDTxEi1weTYb/RAsszqm0H4xy0exrtn2OAdZnf?= =?us-ascii?Q?CxyYLZVz+HDu82vNJWEfOS3pSUqFkVnWdXGi6t8SYfEty6imRTJp7MCfpl8t?= =?us-ascii?Q?8Ww4+H27eiYBvtK269oRwS4chZto//Ke0/VJ3Hvzf9PpElvHtj/qdmlLvUJU?= =?us-ascii?Q?ESqdzhAuQ1dQCMRBHd9KwpFU0CHrR88TJ86VFBAnmUlxVw5aQ+iT2eGgiW+k?= =?us-ascii?Q?LDiKJmQFjiRi362iwFB5h0TJiKETd0mBhebuH2OkcCOUiXU/rg9q0yrk7WFc?= =?us-ascii?Q?tOMhb0PK64DJZs4iYz9QkUKn7gPNoaxgI33csL1nA0FsWhibHairGXQf8S4T?= =?us-ascii?Q?oo+pUnzBETjoZ24D36ZvDA6PZhodkeeyqQ+mFFoVtBS74Tnd3ZWJiCzQUI4A?= =?us-ascii?Q?Y8yJZ6n2WB7K65GVu7rbZcU30qTXxNDyzGE83WgkdKM+bh9+Ckdl1+18QF+c?= =?us-ascii?Q?RToPiZ5NLTVbvvc/1pGdw7zwkinn8LAB+2se3AI4NnPtZPbGpegb2sw//lUJ?= =?us-ascii?Q?OL7GZrcPF48HxyLjrVyAAwwqcUsEcS4imYtE1x/9C0LL9XXX6J2iRI6wyOKZ?= =?us-ascii?Q?rFs8PE2CRTqoUg3aFvIG3y5Mf0a/fkISKvf8pU1l1fVP9tXkJWkB2Vgi2J2U?= =?us-ascii?Q?HtU83VxGjLqkdUWvUAnNrSNx8lvK6DztxwK+Mg0IWdC08e1PbZW/GeC/JeB1?= =?us-ascii?Q?PBlLl9OJ3Hf9sH55Ih46QLE55Lo+V6PKMl3eDwN5AY7L9OYYY+Ft58Rj4ijt?= =?us-ascii?Q?HxFhqQNtk6Ue88eVK9RmbTS+XES/iqeskql4kP+LNixGbm8AMkH3Yowv6MF5?= =?us-ascii?Q?sNiGID8NeRjAr6KWuZLJsYGosmi5tlWOZviC+T2LAqRiZoZIJdQbXuPEIK7p?= =?us-ascii?Q?/GXpKPgsM8qegh28vhWstzxYPFohj82Gp2Vssz85o0Nwk2Jpep7DResGexK1?= =?us-ascii?Q?Ns6ElIvciDobiZKH636o1R3Db37ljeko4A4fjH4qu8y+VVWA2o7Zv5n5FHJ3?= =?us-ascii?Q?T4P6LSC4eGblVXxXqaPTYkM2fkvPyTPs7o0Rz+oexr+HB0RXYV6jIvc8ekLQ?= =?us-ascii?Q?oL4ovim1/6QEUfqxW3O968bk6DnI2XnmDSXI19o4vwjn1KUfkjq0/h0h9ybx?= =?us-ascii?Q?rH441l59Rc86uyb1sYCNOBiZxH10uhybWnR7eENe3A9fkjDkWrqepv4NCCHb?= =?us-ascii?Q?LjEHSYO8mubbK/y2DU1K1ummXjG3/mfY8QO92XGqUjfjUy9topoBTof6uEpT?= =?us-ascii?Q?S9nhc4wfskTFbGgxEe/HVuqwlBy39mS3bjiZhO9I7CcINeQo4nNlB3XEhIG4?= =?us-ascii?Q?sIoPXZbOguI0C7HJARaWO3CPcqRHLyGgI12FSADqTN3g?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2c785cd-06fb-44d4-eb18-08db4d1d0c3f X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB8048.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 03:58:56.1746 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xwG8MPewQM/l67aaD4ON57T4zZpvYtpVaVTsUPZFOIaFNEir6ge607d0mfVqVZgrgd4XfaDp145rNcX6m1lT8OammrYEIzfGgLzvgU8nTzizBHoQ2UEbc845s3E1hHXP X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR01MB7725 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen1@os.amperecomputing.com X-Gm-Message-State: CAYrfdQiQA94t4114oRXTlnrx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683306762; bh=VRbrYvxQgn8/PULhoebxVqyGXcrEm09+QgpfO7wICCo=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=ig0TyAaGZdEcdrNRk3svuOsBiQAnOdgsaCi1ppclcJ0IRtqx3yYZB2cKRfOs08h/Vt3 +RgiUIY0MdSOdHAdIfNkjNrcu1NtdgWJDw7uWWkmoW3CZnpeGmOf+p2X3oDjh/b62MCMv lPovAHCzKPbcl1fpc4GDf7f9+nNikOapMaM= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683306763442100009 Content-Type: text/plain; charset="utf-8" From: Vu Nguyen Id will be casted by CoreOpenProtocol, declare this variable with a wrong type might result in the corruption of other local variables. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Nickle Wang --- RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h b/RedfishPkg= /RedfishRestExDxe/RedfishRestExDriver.h index 4a9e9f7b81a4..6b94e5814c43 100644 --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h @@ -3,6 +3,7 @@ =20 Copyright (c) 2019, Intel Corporation. All rights reserved.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -84,7 +85,7 @@ struct _RESTEX_SERVICE { // EFI_HANDLE HttpChildHandle; =20 - UINT32 Id; + UINT32 *Id; =20 EFI_REST_EX_SERVICE_INFO RestExServiceInfo; }; --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104140): https://edk2.groups.io/g/devel/message/104140 Mute This Topic: https://groups.io/mt/98710274/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 1 22:25:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+104141+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+104141+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683306761336893.9083337853049; Fri, 5 May 2023 10:12:41 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id R4CRYY1788612xAgvoLsltsj; Fri, 05 May 2023 10:12:41 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.122]) by mx.groups.io with SMTP id smtpd.web10.19539.1683259141613765369 for ; Thu, 04 May 2023 20:59:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LHgXZsZD911ljb8Vd0ikQKuJTmo+YyDDFnnhzFWfFwBnE91S7eYS03rh2BZqMb7hTXmqKFSqxyZIKQfhPHhKlTc8UQ68wqPJL5aZDPpicEw8hIlQnjapWSZFhMdutOnRyFcUNeKdtxl5jeYWo2AV33BqzxSxUvHDRumKVS/x63tFogWsihu8p8wi9NKWvDeooeMpiaIIY+q6yahdZ0IU08R5j29brwZoDBlpO5ondQKOIWhfvo3NXHtwFoYD88Puufbp7hZbidUFf7LmFtjXgvJM79WfMzUtriF1bGh0421EpUQXaHJehzX91BN30DqCQ0Q8mgZBM7PD/hOkJ/7/7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w80a17SRG4H/FjuGHnGCwj+eO40Z/rPedQ/qh1QZR5o=; b=JLvckXSuu3YrRBdGOt46jEVtU85BIiTU8JqDnMrlxx4TM0cqhYdFeBAPXuUH5AyxhNZokx+t4vxSswD/oaeBOrAJoy7mlOluGjdiFrY0+Zn0f0FU/xVspZCqGQWTuXwXRLrPo3bKGIpIZF72zigt8HS2ys58iMo6Xr17w4CHYfY3Bf6GfFLSF9S4y78poUB9gEqUNn+5XdDuYer6s6VNT2tbaeElWImbdGImIWY4W27EUAVOgN+nkc4a76/TAnrUOTYAWjc1YLmiRwExMA71PdJ44AEc1Z92SEHurofK5Of5XMdRApcq5fKK3C6udT4t/X0iuWtGjz+dbQ20SW7rLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) by PH7PR01MB7725.prod.exchangelabs.com (2603:10b6:510:1d5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Fri, 5 May 2023 03:58:59 +0000 X-Received: from PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1]) by PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1%7]) with mapi id 15.20.6363.026; Fri, 5 May 2023 03:58:59 +0000 From: "Minh Nguyen via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com, Vu Nguyen , Minh Nguyen , Nick Ramirez Subject: [edk2-devel] [PATCH V3 2/5] RedfishPkg: Fix condition checking of error status Date: Fri, 5 May 2023 10:58:21 +0700 Message-ID: <20230505035824.1466954-3-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230505035824.1466954-1-minhnguyen1@os.amperecomputing.com> References: <20230505035824.1466954-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG2PR02CA0107.apcprd02.prod.outlook.com (2603:1096:4:92::23) To PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB8048:EE_|PH7PR01MB7725:EE_ X-MS-Office365-Filtering-Correlation-Id: 0d69b4c8-be4a-4580-452e-08db4d1d0e39 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: EZtn5NQdZUSdQXxAIVu740kV0BZnAOrUUHgvd3gFkrJMq6+FnfFsnzyHsFi4/vZoerIKx6YhTdVOb07puv4EB9Zy0AnrSzfMWin+Xxe5ejLbKJQxXTNYcI22KikMte51EHnvHL5VdPC3apA/oOfKAXs7blrSrleV6QjiZpF1ShYgilgieY3Dtx6hUpVhZjROy9q8CEQATkxITMxe5LGag9hmq17+75l3TNx3kdc7HklDJ+hRAeSb00wZUATvsgT+e/C0oqaeESE+h48AFPZu2hVQk0Md7jZ6X1hU8RdimPGXM66RF/1o6iEHkUZN+jx5XzMksqwRxFBbtKTc9DXtgsydc08N/aU7RcuN+H6BX+SUekJV/Dte2vwQpuKNfGjWowXFvNzXFdw5eyGAvhyhI7h6uxLQZ+IC/I4IjMtSl3J/A19F+GsjHCSPvPcA09n95RG1qFo/ZfTgu3OR1RAfY3+na1mOIciMLsdn+kayg5zDrn1vldZtEJXajkPofr8I76kXxsPzUCgOkjWBfzG94f/oEFfNBh60/V24tIvcaOL32cvY0vuZdxqr1tGhhjcpiVS5+b/b+jYZMoB5YaK3t/U4cMhHJxtYNptxK3y8RUmCRpOH8x2JqbEWmvkWOpnl X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PRpxeVhXUntlEvLeDABLj0U/ouxl7ixx2fqWJndvG54+IjGmBnDaSaquEtCt?= =?us-ascii?Q?MLfLgiBwkmbRbhpxRodJpatNefyKNs+vrWTyPZz8B72BOvNyLzcRWxe+gwk/?= =?us-ascii?Q?ckweSkRGiVzWKVrJsnu1AyBjYCrPDuOdp5PjhvMMuckVzG5sSWxPV2Zb5+9r?= =?us-ascii?Q?2fRaIcvwYzDRp95slm37zJH5eOIshx7zlThhe8f+3ulN9Zgv+2bfVmNY/aS9?= =?us-ascii?Q?fT0oJ4l+keZkeMHbIYMQNgh/TcCcauTV5jdZxAewudPLFTzvbfGhsWiXgWj5?= =?us-ascii?Q?tTUUjt5oJRnmTc11kXmMMDKDunly/d/xSk342cRNjAYhuC5Oa9zYDVukEmO3?= =?us-ascii?Q?tsq0N2ulPTn7Yvry/Ogy28hylE1pYT+4CDVhQEdlH/GQ+JuR8IGiiX4bPPBE?= =?us-ascii?Q?yMi+fr6QE3fDDCmM8w/hHvan9BZnI/yk0i2LkW19h2IiAOUYpaWLJK2QuzKq?= =?us-ascii?Q?I69fM6xA1Mk/9n6orKh1WGgdtCSnEnDWmjlJSa+qmYf7YIBmYEP9qUSwq/Hy?= =?us-ascii?Q?SOBUkrAweT5Sob+P0xgTegHd1AgfKLBOHNXA1AZhDSbLqW3d7SgCZmVY4Eyk?= =?us-ascii?Q?jWBCHu0LmjZEMh5SxPwT1v+1RV9el0uczZaHXlmLX+s0XZ2OlLR3o8XNuINz?= =?us-ascii?Q?Yn+M9cGA3tbzSwgCEENO6FhUGNQoV7VOMGRSv2FoQ53P2IcYWWYfXfqgydIY?= =?us-ascii?Q?Y1Vyxkzp2vuuqRQphvcisRz6g4lK1XQLnHg4Cjvc7HX9tEZQ61AVxcU5z//H?= =?us-ascii?Q?nwhS1WAOyhup2iWCty51YrcdLKY1N6761r/+UmQbtNQI66KMhqWuHWYxYl2V?= =?us-ascii?Q?fTDcSdUxDElHIiEY2TA65zUAeHWJNcYQCE+hOZpn/difB11uf14d8zyNi0uL?= =?us-ascii?Q?WZ/Tx/AAFwfUeWKm8OS77yOQ/NgQQNFMr6vZJ7+FiDZTjX4Dx4LxI16eziLe?= =?us-ascii?Q?PS0l/yqwRs6BoNcN6fp+QgR2afl+ktziMmC+tXvt8Z1wDwlphM9r3CtF8JEZ?= =?us-ascii?Q?dCj/Hk71vdnJEOfzyvBdJqAONYI4cmo41NYuzeobvPf30TtHt73B2b1YZ2vB?= =?us-ascii?Q?pr9d+OTmjCC4pMeRf2+E1D4ogToEyCz6/qBO1uJrf7ocYcZz+oam402NIBFe?= =?us-ascii?Q?XoWTa0RjpLJfks5WfqCLGAIx2ZxFyuILWtBtaAOzAZIwl0OIGbSqjc3svkyp?= =?us-ascii?Q?PCeQGxltKcyUEgMS3EdYQhB22b+g1+dMuvxzic7HNzcTNs1uImGQqu4vTxQG?= =?us-ascii?Q?3gXEhwRBvCBjLkHcqV1ifavYNxGJBQWWKbnh5FGQeag/MRUmbxt2uRVz15vm?= =?us-ascii?Q?0PU+MXVyHXhbpqEvKogrROSF9IiumGGd205QrhNoDpD9cxPEtqsoeBWTilIe?= =?us-ascii?Q?fA5TdxrmBptDTs1LOcY+qC+uaAbC4YgceFXumRymSVspNA0ikd+mDv0/z9p0?= =?us-ascii?Q?TMLJI84mz7+uXpQNRon76S+OraAH6iUxjBaXi7o2JulQHeR0BHRKUtamtJaZ?= =?us-ascii?Q?CuyCgrTIoBblRwQeTlMn7IHlIoQuHya1rB9BbSSAauSHXjnGEFurPeY6gJt/?= =?us-ascii?Q?2eNkgQBGpZT1tC4jxBtWEewrRoVN/ONUS/jV+AzHWpK0+JZF5J9+u74t0LoX?= =?us-ascii?Q?v4kxl1ZTeVzKDV/T3t1S16Auj8uUUoEPAjDaoTv8P0Ym?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d69b4c8-be4a-4580-452e-08db4d1d0e39 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB8048.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 03:58:59.2715 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XOxcQam8fXKFeWmiUsbMpI1NpIF9/aQtHIukAh3GUad2blwAdtaxnylkh7llr+kHorEzNrP6AzbDHtkCL5MQ9i9ETCvqUXHf2PbUbEXAB2dtc6mE8W7GnkXSW/bGvE0l X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR01MB7725 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen1@os.amperecomputing.com X-Gm-Message-State: ikrEzAh4Wby89Ca6T9QC81X5x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683306761; bh=Reemh6S7Fi2xwv9UVDB/Cnk2RjEWiKnPZib/jg3kG6Y=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=DgEdcfBa5E629CVv6tris9POzWVvhWKYpEAaJjmJCC6QDaDjwxevbJFIU+eiTZc9Ck3 q+iLHXa1b7/66N+oJJ63gg/v/ulEoL0/8u/0V5aoIjA3oK/TBSAAvtC7FnMgug42/gSLu cJzFLtQM8UqPWdgFfhaAYGnIrlzfcT8Ya+c= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683306763446100010 Content-Type: text/plain; charset="utf-8" From: Vu Nguyen This change fixes condition checking of error status, the condition should be compared with TRUE status to be identical with an error message. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Nickle Wang --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index 583c6f78e19c..a247bfed9e34 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -5,6 +5,7 @@ (C) Copyright 2021 Hewlett Packard Enterprise Development LP
Copyright (c) 2022, AMD Incorporated. All rights reserved. Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -926,7 +927,7 @@ AddAndSignalNewRedfishService ( } =20 Status =3D gBS->SignalEvent (Instance->DiscoverToken->Event); - if (!EFI_ERROR (Status)) { + if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "%a:No event to signal!\n", __func__)); } } --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104141): https://edk2.groups.io/g/devel/message/104141 Mute This Topic: https://groups.io/mt/98710275/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 1 22:25:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+104142+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+104142+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 168330676441181.014606169579; Fri, 5 May 2023 10:12:44 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id mch5YY1788612xcR91ot9fsp; Fri, 05 May 2023 10:12:44 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.97]) by mx.groups.io with SMTP id smtpd.web10.19541.1683259144589964501 for ; Thu, 04 May 2023 20:59:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UYCay+cZIRUKbSEc6uWfotJgs8kBIByuh6DxyNW8wst9/qBuyElsb3sFoo4PQmW8ivGTfWHyJLygsWl3GYgJ5x7EPNAqpLoLOgquzCCWWjanCxmhwpvwcB7+Q4gbW39XNogmuXbczgo2T5CpSelpMO3lQpvfTHGiY/UrxysjskAFJu+AqyJ2ChrZoc3eqqALB6iJM8ROEgdgFF5eqlBfOYKlTl02Sgf+BWGE7ZoQS/MYGpVfUEdETkMqF5k2Be8FxPasT7wws/4gxsoUguquUyuqF/u2JAQdKp3SoHKmSMcSsg+otws9Y4DFnEIVmVw0Shxkc5xyKsdGfdcuzZZVVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2ARwueO6LovcTmgWZCK7GfIpZB5hCddqlNdt2DGaykw=; b=HhbSMr/x5dsMJn6w3ov+SsbQIi1Lx3+Ar3mnt9jHRljJJ8dXbK0J3r7wM6qrPKPI9s9vBwaRKnjp6wR5hSj5MTwPu5li49nzlhitwXivUTFSBXoV1LITWPEapMz9ZRurHBfVBDLibHC9fo4CL3mZnnBX09sjmftDVzGWusCHMRwtYRth8jL7jgvfB0+44kI+ziGeF1AIrCOgYwVfd1yb6kdaT1LUzy8DkO/XcOH8+azHfMhDPxxz1VR/9lJVxdKFyxzq1/fBBVRyFa0pCOeCGGRKwqpyhX1VWfiMHK3DtCznqIrpI9FaEabJOI+lIZyOehL9ywRDbevoJFNF+Y8zEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) by PH7PR01MB7725.prod.exchangelabs.com (2603:10b6:510:1d5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Fri, 5 May 2023 03:59:02 +0000 X-Received: from PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1]) by PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1%7]) with mapi id 15.20.6363.026; Fri, 5 May 2023 03:59:02 +0000 From: "Minh Nguyen via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com, Vu Nguyen , Minh Nguyen , Nick Ramirez Subject: [edk2-devel] [PATCH V3 3/5] RedfishPkg: Create RestEx child on selected interface Date: Fri, 5 May 2023 10:58:22 +0700 Message-ID: <20230505035824.1466954-4-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230505035824.1466954-1-minhnguyen1@os.amperecomputing.com> References: <20230505035824.1466954-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG2PR02CA0107.apcprd02.prod.outlook.com (2603:1096:4:92::23) To PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB8048:EE_|PH7PR01MB7725:EE_ X-MS-Office365-Filtering-Correlation-Id: f14fca3d-338b-432e-9330-08db4d1d0fe1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: b9Bx0CtjvFfs+xGO7VgtjId3cov81/gcAXrqFZxFtrLzO1KR+kRxxQTMPNZl4eDTjeszYUIYrk72SfCwmmsOD8WCCmP9UrR1rPhzKCvI53ZPOqTLdzbbBnlwYbC7jQzHrJJ5m0CRKBpoqK8PKkD4MAanc14hOxvWSkUepi7q5JX7UZ20hRNhR1bN5ib8NpE6/3TbhsH+yme7gXOkKsA02EvRQO4nzhLvCgkEmy+2XXeCWZevwaY9NkYNFgMkABKQcMnQGH7vlIf8A9gvetYXZoDlO7z6XisZGzye4vF/K55IGozaPfdHF7gX7FpmCDP/49JzNpYVt1n0RITHb2RqFhHfjq7IcuKCdPUHvmTxL2X4qlWqpeOLclsufIgHSDcNPnz0jBLE50oUZpaW4Tn9iC20QBuQ6z4znr5auveODN1kMl1fcY638xvcu3xhdlH85tgm++FQiPCBtjiyoHlJJ+M6LdzA59MEPt4AJsTMk/hq+VsRydJxoxNqnE2BS6AX+FlJnIr5VN/W2G0rYuQK0Xq/7Y8dTF7CHE4eyZng6+rPfTeD928TGmDfpybFT1FJVjHn2X+tB4hmOG1mxXdkAeZwssDZjXzC0SzEu/6CR3/m1Gu8wvKjNt2aLyOdHKWx X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?chyYr55FbjSJOYyk44hnvrJLBYIy+hTHE4CHtlTufBsQgkHqhi7C9BVGaIcR?= =?us-ascii?Q?8HFt0Zw6jA/jXhOikUmOT9fYqqjzIpCeCU64/u1elEMftwau//inED+zwkvI?= =?us-ascii?Q?F8+u7O3oq1lf6lxKEN+2EJtJFxck94KmlvQdwG+VftcXI8ik7uB5PtccVRAu?= =?us-ascii?Q?QBVisNprGCEGh33NnOaeicZnQwQK5diaKtYlPR0lmtP3u1BWM3GHYjx7GyfH?= =?us-ascii?Q?7aL3rF8kz5CTa5Z/+QB8CGYh1X/sc1EXnIGdxl4C+rMMQfFsKkiRzbOKr/bb?= =?us-ascii?Q?QsYavzTcBcyQqePbwx1pqBHpBSzyn7w5ElAVEfrq3VN78wuPyILVRi/oLJsD?= =?us-ascii?Q?F/Y5Uok6DcUkPb3G/HpW2JdCl6cva7HJjrmOsVZne5Bgf5EHzGrcdu1IbwlY?= =?us-ascii?Q?2UKK9sem6gsekflz8q4HqMl7S1FdEkYC0bPLIz9CnFcC6AY6SoVWlU+yCxWd?= =?us-ascii?Q?r8PE2U+WJ5ntU0qmm3kGNd3PwJfVoOHb9Bj12jSXkEmKJWBFV7B0O6O3P52m?= =?us-ascii?Q?V0zBQmQJDD3SRk34UhZkSZmx5nZHjl+IWZhRbCqn178mJ+WPgk+qeCqicHSr?= =?us-ascii?Q?DinhV3bdOYyyiYUFTeyYlLmrzxcu0cdRh0XBEsumB5Hr6snW8U3S1GlDWuLx?= =?us-ascii?Q?fu26UUS0cbt6z02sjq9UTVq+uFfi0MJGTzMHp8O0r4FTU2jP4vJ+dxW5Wnkw?= =?us-ascii?Q?xe1DPB9++0Ie7IY+tckArmIchExMc3kpdcsgisyOsiff7Ac20d6Xl27gKEzx?= =?us-ascii?Q?A+Dz/m2D7Fx3shxYbp67Wd7USGgw0IiwlkdQ8YC3WXwlkvTuivK6z9t8sKLy?= =?us-ascii?Q?b6pZDy/6JiPITmOaKc8AMF9uacbbtkE4RZBxz9DzgggTU8fFoX60iDX5xbm8?= =?us-ascii?Q?SzksUCHM1i39xHfO/1RnCVmp1IgmmHq3Adj4OJMS6MGwQOQ7L7Zt5IdimMtu?= =?us-ascii?Q?Kx/KpWJIaPFb4dSqMOEskSSH7+pVSXj62VvYgQVk3LXShwn/4dxiNP6/nnvk?= =?us-ascii?Q?oPhcgZB4rHD4W6DC0XFdI48n9ZLU+9FLG9tcXBfbj+nP5HFjSNrGYsRGd/VK?= =?us-ascii?Q?RfQTw7/Q/yM8RZ+wXMcsnd3zuL8+zVntk/7t1KZ4YxEMoPXK5NcWRzQfK6F3?= =?us-ascii?Q?GegNw050CJWPixBWhDXWOVY/gnUx3cPk4/d2plAEsOSh+sJF3457lOHLepxa?= =?us-ascii?Q?30Bkw0OrQzsXrK0G7xwb0gPNUGsBzWjBIPcqsQso2gw9Z6boj02HyHxSdaRR?= =?us-ascii?Q?NqsEM/81iSAWdfyCLdPC5jom4yDsvaKkZYoSWAdGtiwh9vC2aQ2udasKyCWq?= =?us-ascii?Q?3Z3apJequ412yJXcpXLT2eoqEQWLZPdOjoaBRsAJucgykUGZ0eB8QcgQEYTI?= =?us-ascii?Q?WeDMRyO9MdGAsxK9/CXWCHb/Nz5gJr0WK4xIorRarYvLOZ39oD+6q0JSdOhy?= =?us-ascii?Q?HUrRAKurEGJVK+Gs0aIAlB1J9qgOP1v/Q6FKzdhbMpTl8mFzI33K6jJiMyaq?= =?us-ascii?Q?xDcRSJkc3i2zaFiblE8wKpIxhjU1QsjHlRGWkwHbz3PsnIKL/W8z42fMVlWH?= =?us-ascii?Q?VE6KvKrXlpjWXQr+fH+5csiXWAQmju+TZRd6a7LDQI0tyc2n7D7I0zkZyQa2?= =?us-ascii?Q?PlxqnIh29o/g51+PCLJ+6W/8LLB4r03nWAoJMwTOryud?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: f14fca3d-338b-432e-9330-08db4d1d0fe1 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB8048.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 03:59:02.1199 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6wVgxhWKAKr+F2rzoA3xLIXWlHsUWWuK3+wDRiZdVF2p7g6Pr5Dg/S2griBcUBUwfYbQcwZtoTiZXXXyUALNa7UlaGqyW7d01uQ0WSSvaMJE6TrPxFh7R2hlGQYnSJKO X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR01MB7725 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen1@os.amperecomputing.com X-Gm-Message-State: zA4xrNvk0eqd9fsrv4ZgiA77x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683306764; bh=GlWKWoCaQIktXKuCo+spzf1u3vhKFqN3xgNZofAhlx8=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=Xr2zX+CT7rKuqFX58gU2ZzR9oMy5at7EhaXNTarz1Ksj6Go/gSfZVC6xGQokXaKsGsT Wads4tC/tA9Cp45uyHcPlW8heMx2j3qi3x/rRV1urSH4Qd0y+qS63oktcH059RRXsXpAm ejbM+SdHuS/KTe6VOivGhsnQBdzbVvGpC2s= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683306766548100038 Content-Type: text/plain; charset="utf-8" From: Vu Nguyen When a MAC address matching interface is found, a RestEx child will be created to provide the Redfish communication on that interface. Currently, It will try to locate all RestEx binding services and choose the first satisfied instance without taking care about current selected interface. This might raise an issue on the system with multiple network devices that the RestEx child was installed on wrong interface. Siigned-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/Include/Library/RestExLib.h | 3 + RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c | 153 ++++++++---------= --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 1 + 3 files changed, 63 insertions(+), 94 deletions(-) diff --git a/RedfishPkg/Include/Library/RestExLib.h b/RedfishPkg/Include/Li= brary/RestExLib.h index bc4e4ca6caa7..2c32c3684cf4 100644 --- a/RedfishPkg/Include/Library/RestExLib.h +++ b/RedfishPkg/Include/Library/RestExLib.h @@ -2,6 +2,7 @@ This library provides help functions for REST EX Protocol. =20 (C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -20,6 +21,7 @@ This function allows the caller to create child handle for specific REST server. =20 + @param[in] Controller The controller handle used of selected = interface. @param[in] Image The image handle used to open service. @param[in] AccessMode Access mode of REST server. @param[in] ConfigType Underlying configuration to communicate= with REST server. @@ -32,6 +34,7 @@ **/ EFI_STATUS RestExLibCreateChild ( + IN EFI_HANDLE Controller, IN EFI_HANDLE Image, IN EFI_REST_EX_SERVICE_ACCESS_MODE AccessMode, IN EFI_REST_EX_CONFIG_TYPE ConfigType, diff --git a/RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c b/RedfishPkg/Li= brary/DxeRestExLib/DxeRestExLib.c index d9acad24dec1..0b3ae2755e86 100644 --- a/RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c +++ b/RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c @@ -2,6 +2,7 @@ This library provides help functions for REST EX Protocol. =20 (C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -9,6 +10,7 @@ =20 #include #include +#include #include #include #include @@ -21,6 +23,7 @@ This function allows the caller to create child handle for specific REST server. =20 + @param[in] Controller The controller handle used of selected = interface. @param[in] Image The image handle used to open service. @param[in] AccessMode Access mode of REST server. @param[in] ConfigType Underlying configuration to communicate= with REST server. @@ -33,6 +36,7 @@ **/ EFI_STATUS RestExLibCreateChild ( + IN EFI_HANDLE Controller, IN EFI_HANDLE Image, IN EFI_REST_EX_SERVICE_ACCESS_MODE AccessMode, IN EFI_REST_EX_CONFIG_TYPE ConfigType, @@ -41,8 +45,6 @@ RestExLibCreateChild ( ) { EFI_STATUS Status; - UINTN NoBuffer; - EFI_HANDLE *Handle; EFI_HANDLE ChildHandle; EFI_REST_EX_PROTOCOL *RestEx; EFI_REST_EX_SERVICE_INFO *RestExServiceInfo; @@ -59,116 +61,79 @@ RestExLibCreateChild ( } =20 *ChildInstanceHandle =3D NULL; - // - // Locate all REST EX binding service. - // - Handle =3D NULL; - NoBuffer =3D 0; - Status =3D gBS->LocateHandleBuffer ( - ByProtocol, - &gEfiRestExServiceBindingProtocolGuid, - NULL, - &NoBuffer, - &Handle - ); - if (EFI_ERROR (Status) && (Status !=3D EFI_BUFFER_TOO_SMALL)) { + + ChildHandle =3D NULL; + Status =3D NetLibCreateServiceChild ( + Controller, + Image, + &gEfiRestExServiceBindingProtocolGuid, + &ChildHandle + ); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "%a: Failed to create service child - %r \n", + __func__, + Status + )); return Status; } - - Handle =3D (EFI_HANDLE *)AllocateZeroPool (sizeof (EFI_HANDLE) * NoBuffe= r); - if (Handle =3D=3D NULL) { - return EFI_OUT_OF_RESOURCES; - } - - Status =3D gBS->LocateHandleBuffer ( - ByProtocol, - &gEfiRestExServiceBindingProtocolGuid, + Status =3D gBS->OpenProtocol ( + ChildHandle, + &gEfiRestExProtocolGuid, + (VOID **)&RestEx, + Image, NULL, - &NoBuffer, - &Handle + EFI_OPEN_PROTOCOL_GET_PROTOCOL ); if (EFI_ERROR (Status)) { - FreePool (Handle); - return Status; + goto ON_ERROR; } =20 // - // Search for the proper REST EX instance. + // Get the information of REST service provided by this EFI REST EX driv= er // - while (NoBuffer !=3D 0) { - ChildHandle =3D NULL; - Status =3D NetLibCreateServiceChild ( - *(Handle + (NoBuffer - 1)), - Image, - &gEfiRestExServiceBindingProtocolGuid, - &ChildHandle - ); - if (!EFI_ERROR (Status)) { - Status =3D gBS->OpenProtocol ( - ChildHandle, - &gEfiRestExProtocolGuid, - (VOID **)&RestEx, - Image, - NULL, - EFI_OPEN_PROTOCOL_GET_PROTOCOL - ); - if (EFI_ERROR (Status)) { - goto ON_ERROR; - } - - // - // Get the information of REST service provided by this EFI REST EX = driver - // - Status =3D RestEx->GetService ( - RestEx, - &RestExServiceInfo - ); - if (EFI_ERROR (Status)) { - goto ON_ERROR; - } - - // - // Check REST EX property. - // - switch (ConfigType) { - case EfiRestExConfigHttp: - LenOfConfig =3D sizeof (EFI_REST_EX_HTTP_CONFIG_DATA); - break; - - case EfiRestExConfigUnspecific: - LenOfConfig =3D REST_EX_CONFIG_DATA_LEN_UNKNOWN; - break; + Status =3D RestEx->GetService ( + RestEx, + &RestExServiceInfo + ); + if (EFI_ERROR (Status)) { + goto ON_ERROR; + } + // + // Check REST EX property. + // + switch (ConfigType) { + case EfiRestExConfigHttp: + LenOfConfig =3D sizeof (EFI_REST_EX_HTTP_CONFIG_DATA); + break; =20 - default: - goto ON_ERROR; - } + case EfiRestExConfigUnspecific: + LenOfConfig =3D REST_EX_CONFIG_DATA_LEN_UNKNOWN; + break; =20 - if ((RestExServiceInfo->EfiRestExServiceInfoV10.RestServiceAccessMod= e !=3D AccessMode) || - (RestExServiceInfo->EfiRestExServiceInfoV10.RestServiceType !=3D= ServiceType) || - (RestExServiceInfo->EfiRestExServiceInfoV10.RestExConfigType != =3D ConfigType) || - ((LenOfConfig !=3D REST_EX_CONFIG_DATA_LEN_UNKNOWN) && (RestExSe= rviceInfo->EfiRestExServiceInfoV10.RestExConfigDataLength !=3D LenOfConfig)= )) - { - goto ON_ERROR; - } - } + default: + goto ON_ERROR; + } + if (RestExServiceInfo->EfiRestExServiceInfoV10.RestServiceAccessMode != =3D AccessMode || + RestExServiceInfo->EfiRestExServiceInfoV10.RestServiceType !=3D Serv= iceType || + RestExServiceInfo->EfiRestExServiceInfoV10.RestExConfigType !=3D Con= figType || + ((LenOfConfig !=3D REST_EX_CONFIG_DATA_LEN_UNKNOWN) && (RestExServic= eInfo->EfiRestExServiceInfoV10.RestExConfigDataLength !=3D LenOfConfig))) { + goto ON_ERROR; + } =20 - // - // This is proper REST EX instance. - // - *ChildInstanceHandle =3D ChildHandle; - FreePool (Handle); - return EFI_SUCCESS; + // + // This is proper REST EX instance. + // + *ChildInstanceHandle =3D ChildHandle; + return EFI_SUCCESS; =20 ON_ERROR:; NetLibDestroyServiceChild ( - *(Handle + (NoBuffer - 1)), + Controller, Image, &gEfiRestExServiceBindingProtocolGuid, ChildHandle ); - NoBuffer--; - } - - FreePool (Handle); return EFI_NOT_FOUND; } diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index a247bfed9e34..dd5bdbb377e9 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -87,6 +87,7 @@ CreateRestExInstance ( EFI_STATUS Status; =20 Status =3D RestExLibCreateChild ( + Instance->NetworkInterface->OpenDriverControllerHandle, Instance->Owner, FixedPcdGetBool (PcdRedfishDiscoverAccessModeInBand) ? EfiRes= tExServiceInBandAccess : EfiRestExServiceOutOfBandAccess, EfiRestExConfigHttp, --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104142): https://edk2.groups.io/g/devel/message/104142 Mute This Topic: https://groups.io/mt/98710276/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 1 22:25:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+104143+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+104143+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683306761953107.5668006573178; Fri, 5 May 2023 10:12:41 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id M2r2YY1788612x0NElbV4hry; Fri, 05 May 2023 10:12:41 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.126]) by mx.groups.io with SMTP id smtpd.web11.19401.1683259147051208156 for ; Thu, 04 May 2023 20:59:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NQ8GCNlNs2eNatApRxmIGK/Do7G6lVWdfhQ3S+1JUO6vuy+UP+1d/c8iHY4IFjvG/IVjYPCzd5LBKyonUmxpVpO4bUCCTBzR/OOxuIVzlVHf3POgLhq2vxNxx4SEut9Um7l+JnIw38yBFOEKlJvsgbZv5f2gkdUOprH7vbKAXYrRqzj0qXDQQWN5WVGtOPTDhkJ9i8VfIBw9ZgUV7E8EoXYgsWDFI2E8wVJKKEJl7jmid1posjEL0eBIJ5A0oJkogemllRz1cpnFulUrXhx+BzcdTLJbmUZlY44SjYIc1cGyiwar6Z1ssi3CoG+fQphbYJHtYgauXksyPrBh6O4FDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zu8dl9fFUkyQ/+iKDqKCwJB7RvMIgqN/Q+9zIOazTmc=; b=LKECi028hyjC3dWpt6CRjb4aZzULhqUpCJZQGzeg0ojPQcoDZ9GTpFnoVozaQyHPyAv81d+iQslg9H0KFMqXeh1xKc2znZHgU/RqEJM7QKZA92q6aEfnN0NBO6UJg4USKmkfmdDb43X7FPd+zPWjV39NLmSfuGu7RcJkue+o39eT5C7qwlVNKbkg7IPeZ/n1lWomXxpA4bA7nEDx4T7oAlbI3variqSLUzVRl5plXx5epVibGdPnPjviS91BEOVhITEvoz0UX3SNZdqoW7XMmfr041xia8EfGL3oHVsnYuhMR4jrlm1lIJJB833ouCtrrv3lssfqudD+UUfy3o1zVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) by PH7PR01MB7725.prod.exchangelabs.com (2603:10b6:510:1d5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Fri, 5 May 2023 03:59:04 +0000 X-Received: from PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1]) by PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1%7]) with mapi id 15.20.6363.026; Fri, 5 May 2023 03:59:04 +0000 From: "Minh Nguyen via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com, Minh Nguyen , Nick Ramirez Subject: [edk2-devel] [PATCH V3 4/5] RedfishPkg: Add missing newline character Date: Fri, 5 May 2023 10:58:23 +0700 Message-ID: <20230505035824.1466954-5-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230505035824.1466954-1-minhnguyen1@os.amperecomputing.com> References: <20230505035824.1466954-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG2PR02CA0107.apcprd02.prod.outlook.com (2603:1096:4:92::23) To PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB8048:EE_|PH7PR01MB7725:EE_ X-MS-Office365-Filtering-Correlation-Id: 04fb6f64-74f0-4b8f-cf63-08db4d1d1176 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: u4D+fM59FGqi1wkoKd0IQoP9AlsJuEJBqMDXdw8ikJSHgIDQ5ifBFKcgPknovfOy3W6CyQyYN+QbHb6cZt1U1VDTwx1/KWKtbJimw3wFKJvNKeIZWZAg+UNh8Q2YTGxn6fUljfyGWKtKUnibb+B3yRtzQUpQTv8UN7v6BC5V1813+mkoIH0KLxmcsFJ7cZYqm9wX+a9qWrHpIf8zPdLxpADKsb+4fPoHF9vE1S88Jy5SOfrKxNi0eb6pbLSJxE9OUot2gQRsLX0BDkd43V3wLGhqvwROKo2md+QwVbOUUGz1K7SpN+ZEmjZRscvGNJPh3ry4GrxLzPFWYMcTdPn+0VqbJRf41pbbffz/sxO0LL6P1AaSBw94oj6ged7o3/Zj5VhiEeVHJ811MFj42XYvYGK/HruqB/pFLZJd+U52+H0TzGsiDU0CjhHjU690o/SVG53sh0GnpDOtRk77quXucNSFFaMg/Gw3yFqfpRRzmAlGm+eY72ne/leHgeVNqbXmTxSAWOdURt+VEZlJW3dziGDgERyIZL26l9+966TiCB/h+qNnzuejzMd6FBZMPFlV2Htmza9ba47e787ZQeiZKtEw7uVu5Tpd9jeIlFS8TOBHhOyU1x7Ep/+uKYR3afcK X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?deYiTKjwrXc5/esD4RI8TgF3FCbEhynW5ucsT/P/bCXXZiPztstwmasRHMrf?= =?us-ascii?Q?p9DI+To2cAftIxrI/UEhoENPPvlAgjEbfgph0wiaZxBVHfE4h8Y43fyyLRbQ?= =?us-ascii?Q?utPwH17UhsDEFFApv05smI535OGj2E9sUIn7HBxbTL9xguZi73hov4FqmPEe?= =?us-ascii?Q?cYZ3DQHWyVRuXRnnunbu0nNtpMjtBPXjYlK8Zv05hG266YexZLs7Wt28iip9?= =?us-ascii?Q?6bVFeqELy4AATlJEQ3K0Yb4lXX9ZQtwWO+BnEh4x+wEk/FwDvkDw4ImKwDj5?= =?us-ascii?Q?5a4HNEPCL33J3fnowuw+bye9rvWaNASLsbRXkIo68Fpk7Q18HWw/YcTFxPzj?= =?us-ascii?Q?Gz/PassgHhcTEbWSciwgxi3Pw/mr9qWRJ6VBd2F0OQiDGIZpCHCHCMg7eaF9?= =?us-ascii?Q?gKgwheV/DxTafaYQhQNgp0mk/MC8Xher8Yitj3CzLaQq8A1YcGl6ZztNEV6l?= =?us-ascii?Q?4yP757WYF8jr4ZVqcAzZD09RaiJBvfaVul34NX0ydnF31wIrWuiDNWlXUqvH?= =?us-ascii?Q?LMdRW8PdrFW8Ob5bRR49uvLiqhj2wTvByWTOaxXolPSDZ+MXmrzVojQVQke9?= =?us-ascii?Q?rQ1Pj/W2g7zMkL2wjD8L8WJJIFdIKO5wQ0cbu+Zc8/J/agvAE+6hmOEQiTvM?= =?us-ascii?Q?zszEmsnVt8OHM3+hNMDl7i+4n6erEM0rvFFjMtR7cmquR9t1aX4zblOP5Vev?= =?us-ascii?Q?2G39Qfo6mm4vu4ViIyNQbrgHjOwa8nKiWOBlVyFKOop5hCCXPF0WT5tnwEXr?= =?us-ascii?Q?pxbOBgNFt3kyUmcdTcFdbXaKgh/w6sxTA/VcnoHKxPmENfqu0w4Fpu3gvA3R?= =?us-ascii?Q?UbYEJHH8vgxR5bwoHYt+iQIAspaxzwEatBFLgtc6Xha7VcFnJxVzDIseg0aO?= =?us-ascii?Q?urmMLAswS3qaNk5wnrJvw8TH4c9atkLg+YF+rK+xgg3rNNjGhUr7MlFFjou1?= =?us-ascii?Q?OqO81un2TIF59K8JvNZMoHq8Gx80KGLXktz86Czo1cD3YH1gQbw41kbuhChd?= =?us-ascii?Q?fxJ6SqMAzimDBhiB1mXupAmJbj6OOejWHO5T3J6NqjefhdAiBGbJCCkhCRIi?= =?us-ascii?Q?c5F+fzxlyB7gGLnRf/PzZvhTb8auMLkYLhcYyeWDotNTEhg19UZ7QgduB+Vg?= =?us-ascii?Q?BcScQQrHPTrctp+ySLeQMw3CRXCZzoxoukM24JK/mDhupW4O0Y06IUzlQEZN?= =?us-ascii?Q?BbxU0mWm4Lvxnu8V+Z3qUKVM/xcukHZmakV79+/T8tyjF9/7L8SYK0FCDPy6?= =?us-ascii?Q?bjQmNR6282CkJZihXQ2DBh/KnUkqCNkTMWqiSVZRkyuRzcf3mOkZHZGmjZBG?= =?us-ascii?Q?h5LyvUThXRQAsXVsZoIn5Jx28d1VSh0i+NAqpQcAF8JQfe45vYRCKlGBCmIJ?= =?us-ascii?Q?e/WIvmKCJXJ1DZce3u6j6P/K/FC7s8Fq0MiDS1R0avID3DWZL2CSm2uaY5ks?= =?us-ascii?Q?Ix5l/DPUy8jluoWieGB43Db+5NWoBJWljZ9X2XKFqi1r6KJ7Cy1F5TKKf5Pt?= =?us-ascii?Q?4P7JyXXCjbAjrJ0z1bbGzhmhMJFiQ26woHoUBi0E7RV3H1b1UMbQTOMs96wG?= =?us-ascii?Q?SkBBj1ygrJLgQsjEoLV3EBb8Dq8ON4b30nfgf6GBmzpgskMQbW0B3rQZQ2T5?= =?us-ascii?Q?iK0oWw67fqZQVrh2QKyTtYkQq5Uib++8bdDQVJGxQX54?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04fb6f64-74f0-4b8f-cf63-08db4d1d1176 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB8048.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 03:59:04.7221 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aG/hVWTeOd+7JqG+IElvG3fJd+sp4+GMTet0IjvIFPIYXbUmUGxYUCmK1+EPZb6N36n7FuL+rmFqoUnJM0XX7yrSbXe1eM4S69tcbJKv3NvHKn4Ozv+2D9f0CTrvzymM X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR01MB7725 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen1@os.amperecomputing.com X-Gm-Message-State: BlUlaM7nmkevgtpm4JnLUzVPx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683306761; bh=wJ8yJRAtNAkzFANHpFWYWmEc/c5MuCOD2p+n0zD/5LM=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=PA/XtYUAc86h5itLQ2ZjYkXYZFZ2a6d2BlXRdaNS++NgcHaW4Y2u7ZyECRXBYGBtFZO d/eF5Vyc6Cd5rQfBqup7w8t/8MoITvXqaqOFBTJDSHct4iRNyBIuPHKJvdhid03d49hNa wqYC/iK4Ku4N4Dh7jxtUUtL3bLEc2+/499E= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683306762604100006 Content-Type: text/plain; charset="utf-8" From: Nhi Pham This adds a missing newline character to make the error log readable in case the module is failed. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Nickle Wang --- RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c b= /RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c index 45fc6e2182bc..c4fa59193a2f 100644 --- a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c +++ b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c @@ -8,6 +8,7 @@ (C) Copyright 2020 Hewlett Packard Enterprise Development LP
Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved.
Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -59,7 +60,7 @@ RedfishCreateSmbiosTable42 ( Status =3D RedfishPlatformHostInterfaceDeviceDescriptor (&DeviceType, &D= eviceDescriptor); if (EFI_ERROR (Status)) { if (Status =3D=3D EFI_NOT_FOUND) { - DEBUG ((DEBUG_ERROR, "%a: No Redfish host interface descriptor is pr= ovided on this platform.", __func__)); + DEBUG ((DEBUG_ERROR, "%a: No Redfish host interface descriptor is pr= ovided on this platform.\n", __func__)); return EFI_NOT_FOUND; } =20 --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104143): https://edk2.groups.io/g/devel/message/104143 Mute This Topic: https://groups.io/mt/98710277/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 1 22:25:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+104144+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+104144+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683306762772698.7234576363837; Fri, 5 May 2023 10:12:42 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id GBcHYY1788612x5HRaJt6iUs; Fri, 05 May 2023 10:12:42 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.136]) by mx.groups.io with SMTP id smtpd.web11.19403.1683259150155122814 for ; Thu, 04 May 2023 20:59:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MHHUN5WSCDc/lPkgGVSeJxYnuEzB69HXQTOrlljvVvdYxBrj0N2/WeCfVEbprbXBfnamP+0DJFiDtZZzHx07GRQ8gb3vRv6mnNoH30hHrlPYWojI1RPspajnJ++Sxp56iteH/CXxp7ggmX46F6ZEHomUQsFAttjyojtESt0esMFrO0Wnf1cLtZw9a1CXWmsJzx5h2QibJ47u2BsIwWF9LVyIwmz7oFeBfWalhA6clvoCvdTaPNh3FmD29dZUj9jzsKBP3ARb5WkHtUcgRWlrEztpkejnGWb800i4bf/ZU0AB+5kIWnRkmvb3sXdTMxlyAvWBMCY1TvvjFeL8B/6tBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jh4UCFi3rgn5dNgMwlvoJsaOGmXOGa8O9eQW0uYisHY=; b=OEseXcx4lkqMWjVqv4Stka86GzrdbbBQlYUh4OJyDychKkXQ7xahcfD0y1jgWSZJGw+9E58n4+Kq+snTCU0j/9bldKBWyw2gvxc0wbZ/mfmRcKR3OyCdc/e1pd6WMfegSPKmW49IPi3nJjzeDtLbqHSuiBl7WELZC4/6eMsUVGXSHzv38P5eaN+45UZbnmFgwgcDTKT5fK/sGjrGMyebmBpMgG/H57MwWhEUMs50U1YBkQE5bozV9Q+OBiGxTh1JPbHMNlL7PrVWHN5b9on9/0voC9WecFvabweqIFFXr/TR9P78BKkg4+nklUvidIRYyOp4ND5ZQ3105k3S2Ph7Rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) by PH7PR01MB7725.prod.exchangelabs.com (2603:10b6:510:1d5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Fri, 5 May 2023 03:59:08 +0000 X-Received: from PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1]) by PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1%7]) with mapi id 15.20.6363.026; Fri, 5 May 2023 03:59:08 +0000 From: "Minh Nguyen via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com, Vu Nguyen , Minh Nguyen , Nick Ramirez , Abner Chang Subject: [edk2-devel] [PATCH V3 5/5] RedfishPkg: Fix compile issue on Linux Date: Fri, 5 May 2023 10:58:24 +0700 Message-ID: <20230505035824.1466954-6-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230505035824.1466954-1-minhnguyen1@os.amperecomputing.com> References: <20230505035824.1466954-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG2PR02CA0107.apcprd02.prod.outlook.com (2603:1096:4:92::23) To PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB8048:EE_|PH7PR01MB7725:EE_ X-MS-Office365-Filtering-Correlation-Id: fd779065-7747-4ed4-c8cc-08db4d1d136d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: BEn+xMgpU/Yi5n++j34khykLmR2u6i9f3E6ANT13iMgK61gprMVA395FMirrGIUZ45s1ocLBmWlPku2I9OVTuKi7Y/A9/miig9cx0c1LkqacWmzzTseDfnxfmXrvKug6R6P2b4/M4le3AyjcZDhgamrrdq6aSIab25eDwxUAkU4PjRBhk3vueF5qoAppzUv5adPxqNItr81rUZxfMKsN60HpppZXN0bbY5oB511jxFmMwdGdsmhRrset0IdzFPmTurK03qtdPOg/QKlAnNaruZaq2CN0iLIas9yNlES+vI/c9IU4pUOiGtsHOWZcBaTbQ9rD0xUHxDYmqS2dPxH4+XbnyVhEVo0Cuxx9cDrnDW7dsU3uk1MjRMirA2aY8PPjlWwCVdf2aWenybAFHd48LWHnxZCMILNmdzWKI84I0stwUcEQy8y+H27mrPzYvUDoT7Rl5Uq6AMud0FlhfNGtUKJFZfB2aI/9EU2LWKRrqGYm27xfsTtp4rnQAZUqw1bG9FK2MMbsdxWOQF1whegx+FIo6rm7QCRZAr8I5g0wfCoQV+FartZ1xcRVoXLlr4RvB0qenmi/JF7NU87I/ZZ79Zf41RrD0GxCsbmGt3exdVAZtbaH/qVxDLWc8CrXSv3J X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ax2H7odppeJTFOnUE0MxDdcoZMbxXC1tmYEP4xND1cHwfpqekC7doZt7WOhL?= =?us-ascii?Q?lR56u4rBUy/BXmn/xo1ucq7n76at+aeuvYNZ38e3nhO1m6cUsHzjkwLmwvKC?= =?us-ascii?Q?jgxLlvlHBJ489PIevxWCv/Ar+4xHKQ/KLODrQsA2fJb+/JkVvtixEmrZFujx?= =?us-ascii?Q?7b+2ylA4ZrAw4pv4td2mIxdnb+xrc7XineoIyjbzLNWfruzrH+VAR2IYygKr?= =?us-ascii?Q?SE7aAYyq+vKDs+a7ZKV8Triu7h6CM2gQ0emYjrz/siQBU+/BclR9cE7Ml/6M?= =?us-ascii?Q?A4l1knNL4/yU9mEH6ZHrgxw81IiYG0NECTvz3VF15foQwMBsT9HNhpmMOKdj?= =?us-ascii?Q?/x22O2YI/EmgQcWAO8Dtp205YX0Y35EfoPp1gyQeR0hUPwlcnteKBwvWJ12i?= =?us-ascii?Q?Ykav1te0W2sbDw8CmtmfsGXRFnZNKB1g3rOqb9P39VZ+pGAWzWrmGjEQaOhA?= =?us-ascii?Q?iCLCGDNRtlMud3advP5afuaJy4iNyPSUGuxHpzUyUPkkwhJh3ubaPX6xffEq?= =?us-ascii?Q?NzVgFE6tSzp2y0RFy0mGnb7A9mFJiIU9O0buzw5ozRbTHrqy/PJfbKu6fRuU?= =?us-ascii?Q?kmpKDa+toUWkMYlrpUZcc+BJs/WLPUtOQ7jIVrhw27Cr1uLsawb8CZhzO5bA?= =?us-ascii?Q?o+uBvdWGu3Lxrh76/GfIwxib7UOGRxpc0ryJBfjemk63q0C3/3XcWmlruzGV?= =?us-ascii?Q?tVx8DgMDyI9YWwXp6B0tp2L/5zWJrtkG80H8z0bQnuWtJyP5cUKkxxhTM+yA?= =?us-ascii?Q?XhzpFgVrY/BiUtwB1kbAjclA6Aztlk7jcqeIYy5VrWjQ0LUs2OdRDP7bjV2L?= =?us-ascii?Q?Vfl9wdx2/wWbwu05Z3yj6R/DnFPiKNCGnsQPfql4o4ASKLDo556N7BU5ZWkc?= =?us-ascii?Q?rhi9yZ/QnLV7gF2C6qAQi/8ZX01QalOiJub03A8vjljPDBS8a3Apq4VgSETk?= =?us-ascii?Q?xm00RKK9dLk0jwdwu1+OFXr9xYChYyt+j/7nka9lffDY/nOzaVb1ft11FeLE?= =?us-ascii?Q?yWZFtOL53r3anJEKPSzJsl779pivs9xP7tJELgKznKF77AnUNcfDXJ5YUbju?= =?us-ascii?Q?XV4CAsmNAiXr6GWkBkW+vhY5HzsyEeV5gcfof6LGeCa7Ory+eLYMV6RjpUzI?= =?us-ascii?Q?jvOGLJqo6lWEBZdK8hP6F/ZKZdaV4of6Hd0nVEBf0dxAGYOfm+ag1DC2aQ2L?= =?us-ascii?Q?LsqxrSut/5a+9Q/1pGosFAvt/Jdd/pTVYzmjqJiFZROTaxl3NVZrbdNF90FN?= =?us-ascii?Q?KVXx+6G/i/UY0mlDj6/x+Tt4ztPBsL6S1zXfUhpdJ9GBTE1xeWgPHTS2MWyr?= =?us-ascii?Q?fmDHdb/QRU/pCecig10eABHfkn6rk7cNRHBBuRPHjvNGrE/yhUXoWFBVrY5m?= =?us-ascii?Q?STi06aIUGoudTsAJHdmAZ1OWbnzoz7pGEseeamq0QhwMCbY2X4NwlfRusBk6?= =?us-ascii?Q?bWM+QHBH3vDwzvLb/NXLadU3ofJs+LXSe3JmPty26VxTAuhotgFrM6lmhF1P?= =?us-ascii?Q?ODHCUnjh7PQwMkfxyGZUC612yqRQIjTZUx42KPGRe48YScjRP8O1N4EuofwG?= =?us-ascii?Q?vaQGzPznj5DFA1lAnQ9WhoSocR3bRU3R0TvJTufLdWnkMs3Fv2pbtJGGfn6I?= =?us-ascii?Q?B++F1Jt0/HKAfjGNgrOiXJTmz4J8D0OJE+uWrLUF/mFW?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd779065-7747-4ed4-c8cc-08db4d1d136d X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB8048.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 03:59:08.0238 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 61hY71JClqzR9z1xXsjHlKo6O6nMdoStazKdnSmz2zIjHUCYKGLxtf6EpCmVVyKo9wa3WsO8ZB+PwIIlFSBV1VLe0B4OByjvUhVZWxmEai9od4xQ4jAyCWWYgSEcS/M2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR01MB7725 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen1@os.amperecomputing.com X-Gm-Message-State: zJuYFgPtkpiSOu0GEs1m3F3Ux1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683306762; bh=CWtvhcppeLSXWXlFKuWb6lEjgGEYikTQTI377ziYGv0=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=WShnzPYhD34unHS5N/EjAb+CeeF9bv1ojBe3WdS6wlyCia26X+Ig8iwcfvMNbeagLQU DFAalX3xluWVO+FbDxJNWFUPu0cuJHHv1mZTs4RnjVKZZJZ3S06I0rG674bCoHD8BAqjL 5T61nk14YHX0fpL5shdoXZvXO9BklQ3nqk4= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683306764499100020 Content-Type: text/plain; charset="utf-8" From: Vu Nguyen It requires a fixed size array to store the content of device path PCD. Add the array size to solve this issue. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang --- RedfishPkg/Include/Pcd/RestExServiceDevicePath.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/Include/Pcd/RestExServiceDevicePath.h b/RedfishPkg/= Include/Pcd/RestExServiceDevicePath.h index 91b1198297c2..57fc199f61f2 100644 --- a/RedfishPkg/Include/Pcd/RestExServiceDevicePath.h +++ b/RedfishPkg/Include/Pcd/RestExServiceDevicePath.h @@ -4,6 +4,7 @@ =20 Copyright (c) 2019, Intel Corporation. All rights reserved.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -14,6 +15,8 @@ =20 #include =20 +#define MAX_DEVICE_PATH_NODE 40 + typedef enum { DEVICE_PATH_MATCH_MAC_NODE =3D 1, DEVICE_PATH_MATCH_PCI_NODE =3D 2, @@ -32,7 +35,7 @@ typedef struct { // 0x03,0x0b,0x25,0x00,0x00,0x50,0x56,0xc0,0x00,0x02,0x00,0x00,0x00,0= x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0= x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x01, // 0x7f,0xff,0x04,0x00} // - EFI_DEVICE_PATH_PROTOCOL DevicePath[]; + EFI_DEVICE_PATH_PROTOCOL DevicePath[MAX_DEVICE_PATH_NODE]; } REST_EX_SERVICE_DEVICE_PATH_DATA; =20 #endif --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104144): https://edk2.groups.io/g/devel/message/104144 Mute This Topic: https://groups.io/mt/98710278/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-