From nobody Mon Apr 29 02:40:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103949+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103949+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683174631282878.7202905471704; Wed, 3 May 2023 21:30:31 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 6HAjYY1788612xBRcYdGldgL; Wed, 03 May 2023 21:30:30 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.132]) by mx.groups.io with SMTP id smtpd.web10.42406.1683174043788836756 for ; Wed, 03 May 2023 21:20:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g4sVG7kVx9coiN00evKn4L0Kl+6sPXLzvTJbQZNZcuoJApVMH2WE25pQjh9ID8xjxhrL2DrUXEcP7a8+sLikLkXYZ2IEnLONqsVGYLTSI4FalbTxi1pZYXMPoHeKZ5IeGjJcbimhHrW+bTRI5sBpAy5bJ5DOI/7ZD7U1xXS3l276VfmtPyAlYTr1YjolXB3NlTMMszQKY4vFMG/zSYB2bhV00TK1nMDG1Y9TeGao347FNisSuWX/F0lbYFe4Ty/OS92yBCK2YeM8EGOjRAp+E2DKzXXHouCHA3bbR7UG+HfeP2mGlXTnQ1fi0fYr+2bWW4/Mw3Q3/5PP6OVkfpMtIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=35uvj5Ksz/2/Lk61WIfbLpSL01av76B96OAsKjjzYps=; b=obOGJOLbbxn5rOpC58ni/bTch498WNO5JYpx+h5JUwOflvV5qnjenZFeuTQ8Efrsltww45QGQO+Qh6VrkjGsKxWEskcj7i1SVzNh4PUbt47xn6PSA92BnkroNNiS1DPj0yPqcnN6AGS/2TG9Y43TwhQJDbIof6jvaIoDGVa8/9pckgtq7lBMjHkOU2/9cuLCmrr5MnXXtd8yOqe6k3hp2y6vscYaLyS/pGPo/6h4+5/4LUbF8EApBUCQ3YlRNGdt4D9g2Y2lhoSSzU2BORsetsBa/hl7659THt5n3BawdP6bARFVOYNWcSZNiXxQfKLXbWs1LJqD51C7WxlKCTUSqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) by SN7PR01MB8044.prod.exchangelabs.com (2603:10b6:806:347::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Thu, 4 May 2023 04:20:41 +0000 X-Received: from PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1]) by PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1%7]) with mapi id 15.20.6363.026; Thu, 4 May 2023 04:20:41 +0000 From: "Minh Nguyen via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, Vu Nguyen , Minh Nguyen , Nick Ramirez Subject: [edk2-devel] [PATCH V2 1/5] RedfishPkg: Correct variable type to prevent memory corruption Date: Thu, 4 May 2023 11:19:41 +0700 Message-ID: <20230504041945.1377457-2-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230504041945.1377457-1-minhnguyen1@os.amperecomputing.com> References: <20230504041945.1377457-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG2PR01CA0124.apcprd01.prod.exchangelabs.com (2603:1096:4:40::28) To PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB8048:EE_|SN7PR01MB8044:EE_ X-MS-Office365-Filtering-Correlation-Id: 2d26c612-0f59-4319-5381-08db4c56ebc3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: YJY5u6CVRHf3JPsvSBnB6+0rtvIYlLnEoRZGNEtk+sU+FNLtGOlOxk8LS4nHtEF5odfB1A+e2pUWReBcpUF9QeNKDmRr6/TPOsbYEfXohvOWkbL4J/CKGt8EDFghfh7ygePfBlAnjJvm2sr9XUYC288cgt3sDvm4HhdX/8LRYTATI/HmlRf0DfafS3J2Jh0Wpmq5CfvqcH6SUTLfUHG3A2bjcVfL0yVxkRwA40CWnBIRYXspAb6s9+Jga60pizHL8Q5kwT2eaqWjv8e/nEb/sE0oFeD5LS7pJNpB4HfW+XrCaGYhbT/K3W5HPeVZJe9kdvwiNQBwzeX/8/iCG2znAw5RLo2OYumNxbv4oRB8joGO3UhMwF4brcC/eM8DN9GqqT1go50/lwQmhFs3/a2OFpxzes8fcGSGeAkoyd1XSk0tmPPJpwH42bcZqqRLStMoLsaY3MC+YIbPFYx4Zd/gS3aIdTeVjRMBdTMA9ubNtWKf8jWUcnD/3o2Dg2zPd8nowccAXI0YS6RIikBtVfEVCG6pqQGO18ANPVyOXQ+A3EVySYPcB1v0z89E+y9fq1R02SHLDKkuHnuEpve5HxaZLXgsdsqv/r16Rhau1iuaKZOJnMk5K8fsXzlpb0jRyYKu X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xdYWxPNQNeBAhx7Lp2CYd1WyDuhGgfDi+Oqaa1HlA3IQgzRzvpezZEd7rXgv?= =?us-ascii?Q?PYKrXWcC3OKdoFBIDGTat50wWkz10VN6Bra/e8VyT663GUJy7ov8lranIMQU?= =?us-ascii?Q?EZ2LtEqrhH6/OevTYszSLji+yX5apqBxOAwCieMMacQ8pUU+/64zM2BITDdS?= =?us-ascii?Q?nkis//4Sf4db+zwMDAzAR5nhDNZeP5NaPAu5wSYdBO4/3U8NOTx5vqk+fgTC?= =?us-ascii?Q?LycNinn/yGZbxUoZAmURJx39uldSpzB+hcObYC9hESGbeDJkfoTRzkn558rr?= =?us-ascii?Q?7utKdauA0pGez+7vGN991dZegYBL771ETukwRMUIFHoKjyBUAG/NzW2o56uI?= =?us-ascii?Q?HW/NICMj7aWmZ1fenqMM/cvQUht9piEv+6gfL0LsMOhzWMs0qiD7ZX50yca/?= =?us-ascii?Q?vToNK+u+OJb3agl57nGtUChSzAoViHy1JV6Dxf9+MV4qtHa6DSw9DdipXEss?= =?us-ascii?Q?nsp4XUiuCbEfYKC8+WGB8ZXlK2wcMhEKnuwKniq1m3s/5yUHXmWrKaBqLkik?= =?us-ascii?Q?3XBN64d2qg6f16LhqutMBKL09prWEJwGd8nk5p6jRJQcgpAT89SqNt+zNquJ?= =?us-ascii?Q?CiGgGx4Re3Tz3Ae2g+7+O8j7eS1RC5uUJ3hOms8WtAAIW8psNZNqSNfms6HX?= =?us-ascii?Q?AyNW4Z7NXd0Mbo3RR/KxTXm14CdYjwCcepoaqq22QvUkBGfHiQlxet92oJrZ?= =?us-ascii?Q?+ge6q0axw71f181lIuJVWhaW3ADljh+LvMu6SMMtYfI/F8cb7MqRFFkkIisq?= =?us-ascii?Q?44xXWdUKDcQ2X8AX8uF8drLTb+IwfpE3zvI2MhjRjH1Ynd/NkJyYR890G3MS?= =?us-ascii?Q?lMGbhdvGZduN7gc46/hrZdecmZ3A67aoNxyloUgfLQkXi/9iy56cYta5jVOz?= =?us-ascii?Q?Tl7I31k8SUdxp30EkSxEpucewDtzXNzl7lgpFlqnvuBigBeUPDk7q/M3zdxz?= =?us-ascii?Q?PkpinXn2bSC05YsYcZ53JNOzU5MByF018UKAW5X9X9oMjUWLwOsOEroPwctG?= =?us-ascii?Q?yCzcsHWGWNAvjK147bTI5xXhWoNWuZsjYg0vF5BYhdFpLD16G6PV5gLC4Hz3?= =?us-ascii?Q?Bg3X2DMReY1KeLeiGYY8RyN1C0f7GjzSJN3sY/wvLAH7yFI9hqFzpcPWkGB8?= =?us-ascii?Q?epnOxkXFVJPKFsqXWskhFwtcYG2VnN+rG7TeJE7VNpVR31oulwpbA77BVpIj?= =?us-ascii?Q?UxrWL93dokIoL3CelfaEtpjEOhBpOABQGZ1S+jI/j7TyrAdYf57edYONX73w?= =?us-ascii?Q?xQio3qS6eTiyCbKYKG7LxMVNxzC59quEDdAA6RrKWDzY2LWlmP6TSpOe2bng?= =?us-ascii?Q?kBEjKkwNCjM+x/PLAU5eb5bJaTaW5hNor9M511rAZZqiRj5D223aoLulgWo6?= =?us-ascii?Q?2L+n6U+ujOfqm6pIywCfJ3i5dutdd81VY1Dw4n67V15xovDHDM+mz9GYFL0C?= =?us-ascii?Q?nYZ4uWnopg4+HIB5r9ynEIIkqTYQy6gkXjWHhI5mE3IayRlqyIUdnVLeM1EI?= =?us-ascii?Q?+2e0VhTzJmll4VF2mgFH/sIUTa1i5FyE7FwEaSBuTDk85Q7BH02cNcuVKNt9?= =?us-ascii?Q?288jnD3q4FrP8S53RwrDmFt4cAT8BmqX+oFUIMMWnXn4AXvQDqDKsyysL+3J?= =?us-ascii?Q?5+uqM1NpjZgGIaIqEZd9JkRTpga0Xfp9v5PAVgXlc5lP?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2d26c612-0f59-4319-5381-08db4c56ebc3 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB8048.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 04:20:41.3342 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EKW/kfvqLg+cwiDw6XJkmBbbZifqpCxGAhWzXL3eZ6DhyWFBY9Wpt9UUVLJkBvopAmPof6r6ralv6u29+FRgKYl2ifYFhu7KZOA34fh7MaIAO8yfDf9NxPGJduv0CcmX X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR01MB8044 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen1@os.amperecomputing.com X-Gm-Message-State: 4a1lJrqgPjBPdlubnEM8UaYbx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683174630; bh=R4ZPL56zoKD5KEkiNtRYxqLL37bswRu52bVPqZ2vA/8=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=fNwiPBfJVoRnrGw/8vFtZ+qPnNqLDuUvGbj3vNHZEM3mg6jiI/4ZdxUvPSQuZtEuTOC TILP/zYex9nMV8ttJZL+OuUnOXvXYHeHxiqE9aSW4YzXirBS+30eDsbnePWLhj3vhTwGO HzyxQzfftvLMTyv2EN54w5bD0pbVsm7QHZo= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683174633244100017 Content-Type: text/plain; charset="utf-8" From: Vu Nguyen Id will be casted by CoreOpenProtocol, declare this variable with a wrong type might result in the corruption of other local variables. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Nickle Wang --- RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h b/RedfishPkg= /RedfishRestExDxe/RedfishRestExDriver.h index 4a9e9f7b81a4..6b94e5814c43 100644 --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h @@ -3,6 +3,7 @@ =20 Copyright (c) 2019, Intel Corporation. All rights reserved.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -84,7 +85,7 @@ struct _RESTEX_SERVICE { // EFI_HANDLE HttpChildHandle; =20 - UINT32 Id; + UINT32 *Id; =20 EFI_REST_EX_SERVICE_INFO RestExServiceInfo; }; --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103949): https://edk2.groups.io/g/devel/message/103949 Mute This Topic: https://groups.io/mt/98678063/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 02:40:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103950+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103950+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683174630517896.9188442545062; Wed, 3 May 2023 21:30:30 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id X2b5YY1788612xYSnavz5j9b; Wed, 03 May 2023 21:30:30 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.92]) by mx.groups.io with SMTP id smtpd.web10.42407.1683174046202163837 for ; Wed, 03 May 2023 21:20:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lQsA5mWRVn2bUVBAfasInoGr8HEuu5UNLm0ORW2uMPjky6qWf521sPhyKeTJ+LnltEQygRxYHlyB49B/fTKHiyK13pAVjfE3x2rdSI/4T4pAhz/mWliQwBUpZQW1djmMvIi+utx0s3SnoQwSzqmjRXuCGEjP1GoI1EQTbOk+cRNIryAgMcDmMc7p9DBmUxdpmpQf8KGlpft1Fvb/2cKMtbRRHB7kNHArnZg6fNmAsss76uLc+ltO/dkOb0DpTJcPjVfzp/6zd4dCfID0kFlEUyD4noSJ3EUia/y4grTX/QK2PbB8wqd6vGlg01n2A3DMRRCpuhU5sRQCEfJT7QgMWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wXLsIi0E2eEgdrc5SEk52QFthNqon5EEOwwBnMvZS9Q=; b=gKNblA/rweYkObcS3PAPqJTL9tDBOCZPwEXjcnIU7GhwM3EuvmajA7oadYFp9TWBZXTFNSXTphuUqPFQiTkHDIqdqG+BUprv0kr/GTSxZULtjXm2Jio++6Z+Q1rApVilPozXlMi222T8SEKwtXM9/r7DY03duvJdErBjQSLKkVA5QPXNSOf43Pj8jy+suzpnCxfkIc+uyqVuhtvn9AEUQP49sgBLjsEkp06JORYnQX3As9ay7TvwvaXwiFdtLzLHZuaEO/0ahjC2BJoz7Si8PtNycC0IwaVryfn2uJMDKEy6ZXTPxUXffDR1wwjZ0dcl2hVrBmiiEzSF06t5xeRlPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) by SN7PR01MB8044.prod.exchangelabs.com (2603:10b6:806:347::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Thu, 4 May 2023 04:20:44 +0000 X-Received: from PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1]) by PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1%7]) with mapi id 15.20.6363.026; Thu, 4 May 2023 04:20:44 +0000 From: "Minh Nguyen via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, Vu Nguyen , Minh Nguyen , Nick Ramirez Subject: [edk2-devel] [PATCH V2 2/5] RedfishPkg: Fix condition checking of error status Date: Thu, 4 May 2023 11:19:42 +0700 Message-ID: <20230504041945.1377457-3-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230504041945.1377457-1-minhnguyen1@os.amperecomputing.com> References: <20230504041945.1377457-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG2PR01CA0124.apcprd01.prod.exchangelabs.com (2603:1096:4:40::28) To PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB8048:EE_|SN7PR01MB8044:EE_ X-MS-Office365-Filtering-Correlation-Id: 47565df7-bf7d-4e12-ef5e-08db4c56ed79 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: MSS+x4F15LGWjpgJG9iDTnyUnUn4rQmkdQce1et3rsBnuag4mMcSgp00RfiCd+Ln8QVqCMDcGvBg0QGYx7DxgPmtlJgmKHIfj30FDhmKTXL/nxiUi/5ACc7EwSPhA0PQ6uBkgrapVT8natvRAiQ2dJjUkgH6Whdp3Y6qP4xDvBjbmPa9WGhmc+XdG/40YXIsvjHniiJOBOGrKCxStmns0NObrrxa0yaZeAaNNjBs73qpZyNcY3zw/si2AW6tt5P2wzbyEJYId9xkCJ6Uu9HvtiE8uNgDnQSU9D+6PbEnox8zMIxEqqJJ20DfAQbd8XVgAEO7PqXxt6mEDbQpBBtuZ8pvS5riuXLE5XuCAwwlbGDbarx7qIqDxhBMnlYHdoiz8OyAM8ehQaACVkgjZ7p2BNah6w4GSbwfHzmpXKRd2HZTOWaWyoNRwYLhtRlTNLogD/d9n7lPV3qDiR8jymueiCn6AeGCDd1GEHLxnourj1sAI2khMFJcMbF8tgZUkH7EpFsvsyE3keBFLtBJNNoXOnUxnJyf5R1HCqgJcuoRaW37XPN3a6q7ahGytmq3SqGGlN4F9TeHdPh2xNXmtO/rvADW37HmKgf76KwHcAY9pxWoP0jTAXm6dwdn/EzVSVov X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TsO9GWzPAyQ0KBtANvQ5rwXgp///0CBiwMVTL49h72ri5E8rIA8iqIEXUk1T?= =?us-ascii?Q?xOnGVOQb5mPjZQV3RoQRyWwMMsaTlEDooQ0DagDQcgYEH4qoVL3kVteil+y1?= =?us-ascii?Q?IngqPI7CCN7Z9CGij9I7uiHr0+DHBDwcGiBCFSV77AnyNpr1it2sXv35YnIo?= =?us-ascii?Q?nIzfChISNx648DsmJTlvCDyQW1FEdIDviEk0Mxyf5ahjR1yFV+EJ/7LHuyi5?= =?us-ascii?Q?dc0h/CbfHLA5A0EWCXdvBaYIH+vg2SjDEjDIC1fxdThaxofyCiUE5/8Du+LL?= =?us-ascii?Q?xMU9GGTA82IU97+oeAPHabm5Ri95hLcHEZg4mY0HD1loOnomch1oBFvUks83?= =?us-ascii?Q?q1zkCO9O9iempkFSMpq/DDX7M3j87b2ElKRcjLTPiCXXI83ozRh6Afs51oid?= =?us-ascii?Q?BK+Qs8nXLba9UwFNMCA/VDz1X/4PNpV6Zxk3vXCds6JMR4HmSRpfc9pRu+RT?= =?us-ascii?Q?UpUbmyrDhfnB828tTYqmzI1Nfm8UPIm1ck765R39Bch0JmxupKaLpRF/IvQW?= =?us-ascii?Q?vBUe4HL4hwnRYKZPdVQgYJLPiMgB4rcGN6nMljiCAOjHS2TJ0W6/K2CrE+CK?= =?us-ascii?Q?Ym7KkYhcv1DqcSQs0G3qv/jbUJCCFOmeNRxU9Y8lmA3DLpSbIL8QZqZepxGW?= =?us-ascii?Q?uar5igZ6q7AhUnNIoiwYPJdNxUFMHqub/p4wZiP7ILUi+anLdrv5virVR+3j?= =?us-ascii?Q?e515WdPkAawPMQthDnUa7VWMFchoNqn+R71TSklXHzL2Pymx22qRJyARTs5Q?= =?us-ascii?Q?jRSmgZTbtPDefAHNEauAA/ueER+5rvdqxV2iMaA6bXmlymh98klXwHy0VzxO?= =?us-ascii?Q?M5uM9qFDxTi/hK8XRm+NDgkRIu4QNWLUcQ7wrCjayNJ1U1I5KHbnmZY0NAHO?= =?us-ascii?Q?68kF9GPeRIIicTLsqdGZxRVGAxM3BhfZOfHPyT/bb04IlMR8tmIm8NM7QP7P?= =?us-ascii?Q?Y2xMz3CuIeRCy8/mhlNy2PwMvjhY9kL82rOOs1nLr2jlLeaEDAcHEWyFeK5S?= =?us-ascii?Q?tGXLRaPjbPtwmfxsVQSTAoHzxrdP4IRtOk4MW5//PgoLLgEHguvFkRHkdWOW?= =?us-ascii?Q?RTCwOJOrB6PFCA66ljdPW4IbCpF2KXTL41sxzTvaR6/5QbLwJitVxNxXVnTs?= =?us-ascii?Q?o/4O2qSl3DXcl4cR+1nYITQJlVMVPiv7dXR76D6f1XI1V06aeBs3ezeL7R75?= =?us-ascii?Q?7M3g7U8o7P85HpPcfuw8eAYhtBYkgJu7UOILes69IS9raToFY4jEFtwVYjYy?= =?us-ascii?Q?bx9ChxzV0NFdhPYKPi27J2eEAQ6Kzq2HfY3axcEGsobbkygsfXFwEkaBF6lg?= =?us-ascii?Q?SuB94jUc9KzdrIDzIJlHs9YzXlZfJVad0LZQ+tcKl7B8X1lt7GMWdk4IvAok?= =?us-ascii?Q?+t5RM5tyZpMZsLDjAZmTrHYI94dQpINVzc+eBALosNWu7OAGH9HhRFxhVP+N?= =?us-ascii?Q?zgfNzOo8Lzozz2kENemCgl5faUsCPQc58UirExcHuXA03/XZm/S5jf8M9rCh?= =?us-ascii?Q?Lyk6qSb1ds60zFKTSAKCe3vi/xyuRbcHecIli/ogvvAYW4fwjKyQf4pixrws?= =?us-ascii?Q?8EFEgVHe54jJ4U+R9cI32HuKZbBdW+nO/NwbTrkovh4ZoqpmvwwYW3kyVyBw?= =?us-ascii?Q?csQfUrwdW1FyH2/+sVlo/EWQ7fPkMocoli8d7xf0KLeA?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47565df7-bf7d-4e12-ef5e-08db4c56ed79 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB8048.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 04:20:44.0206 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: s9+PLUYzJHeui//Uicap/hM6h6JO65JuEGdia04cjnmMIi4tHMOksvwAld4wIJWNDUs2MxX4/2bqFBwp+VfTX/Fe+GTm96doYzp2/HkrwsW+0DZs2FHV5AI5QepJvm3+ X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR01MB8044 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen1@os.amperecomputing.com X-Gm-Message-State: mmFGqwct3TBzSSvDGn1QS9vgx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683174630; bh=XLgpWkvxVFpELBV2TQTO/eCsjRC7YI4RItRvyv2ucGw=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=bnzTgJLzetT9YJ/wj9sJAdawEqWAkYrqlwu1mQsie+EdaIYS9WttHxpqpo5kaBWLWp4 3GY5pFGToZiO28xXKkuCwN9iPyGrgoTdiobGzfvQxliATc6+7Nz61AzIo0wFcZb2aeoeQ vgQwWZSiR3FCa2m2Vf6druV+cg6Op2nAtnU= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683174632207100010 Content-Type: text/plain; charset="utf-8" From: Vu Nguyen This change fixes condition checking of error status, the condition should be compared with TRUE status to be identical with an error message. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Nickle Wang --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index 583c6f78e19c..a247bfed9e34 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -5,6 +5,7 @@ (C) Copyright 2021 Hewlett Packard Enterprise Development LP
Copyright (c) 2022, AMD Incorporated. All rights reserved. Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -926,7 +927,7 @@ AddAndSignalNewRedfishService ( } =20 Status =3D gBS->SignalEvent (Instance->DiscoverToken->Event); - if (!EFI_ERROR (Status)) { + if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "%a:No event to signal!\n", __func__)); } } --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103950): https://edk2.groups.io/g/devel/message/103950 Mute This Topic: https://groups.io/mt/98678064/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 02:40:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103951+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103951+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683174631894683.1387865494152; Wed, 3 May 2023 21:30:31 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id J9z6YY1788612x3VuQSG3Gwp; Wed, 03 May 2023 21:30:31 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.105]) by mx.groups.io with SMTP id smtpd.web10.42409.1683174049028151375 for ; Wed, 03 May 2023 21:20:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kQ+UyQ81v0ivO4bhRIYDZMDsi4yRp8TBDn8V+HyNg2V+5iwrbhfXOXsmDxYK8WQvxvmOPe1EmneUeOVd+i0LG9xgLLtkPErZ6duePigi2OAfGNbmVOTjIz0CZzEx4qWH/2VRpfdMcLFOQbSr7KnvFFnN7v7ylNLatXrKn/X49YguNATcg/Li8r3XQVvz0XgZ9Swh4fq+gkDxc0GxGSyYK79y7L1PDEk8bzMREslOLv8fTbaycuS2Lc/vFM55RM6NCMCyYHycMh9eAoUFq35ravS6MZ31aKEOAXtHZEzIcmFoS4G/nCLEZx5EcW4u5v4S3ZvJA6Ez2pXb5vUd1yHwlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+L/uwMCQi2j3kJFOHb1lBW0YAKEM56ptv+uyM6dhW0c=; b=KGWyyYM4zfbEu29hdnw4i9zdlnYoKPjVJ+IdJejLHe7wu1GuiU/RknKwBlnhRq3mY5vQtahPtKkJycf3BWx6hLgOu3eHNHKoxSEf6rHBWmznvWH+G0Oz/zXmYjyyFSt+rLB59gvMuUDCfkmZ7inl2q05BiHx00v5WTbB0IYZ/ECQsLuT4hQnS3Rp309LhhdNyDlbyq+NgAZhsN/6tOwDUgYJwt7FxLR1VeZEO62/y37DxJ804KpxpvFGEqzTTe4LlSqINH4r3LPuTnziOREalxeHz28Ty2npNC3orp2zu9Mypt6TeEVEB7c4HEUSOkk22ZFVHqJ61snPDMkTbUd/hQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) by SN7PR01MB8044.prod.exchangelabs.com (2603:10b6:806:347::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Thu, 4 May 2023 04:20:46 +0000 X-Received: from PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1]) by PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1%7]) with mapi id 15.20.6363.026; Thu, 4 May 2023 04:20:46 +0000 From: "Minh Nguyen via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, Vu Nguyen , Minh Nguyen , Nick Ramirez Subject: [edk2-devel] [PATCH V2 3/5] RedfishPkg: Create RestEx child on selected interface Date: Thu, 4 May 2023 11:19:43 +0700 Message-ID: <20230504041945.1377457-4-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230504041945.1377457-1-minhnguyen1@os.amperecomputing.com> References: <20230504041945.1377457-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG2PR01CA0124.apcprd01.prod.exchangelabs.com (2603:1096:4:40::28) To PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB8048:EE_|SN7PR01MB8044:EE_ X-MS-Office365-Filtering-Correlation-Id: 41f87726-88b1-4563-f062-08db4c56ef13 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 8TX4G4PfLIKRBCKdlYeshft0jtNrfeLjxFelPZqDyR7hyXbunY514hdSStZXgPnvptTWsOcpiWZNO32n+cgWdosJ2t+AYqMHT76HCeBA/DFyR9kOa4Tutytwc/EbJnyJy0ah1W6YFHYFWdkLJTsFUwA5I+HIh0TmC4L89+3IHpzorYzLIh7pKdvdrxlRdPcOfJaNu9EmSqx71Gq+JcTdR8NfdKmF/2ti2YN7S4MXDUvIOJbjoNacjwIlYWA1ey2w2dXmteiZgBtAUK/RQdFYWY478nzWHgtNNhXaG9L5cG/hKkLxnrGONqxz/a74OMKxwU1WFFGHBvJQUR85+uWItYiADXuPIOBSvXXyN1QZmNZMBsUKurmx14OQbka0Srodagl/S6A5A68/XlMdh8jM2PgMF+N8MwO7W+N4cl2O/CULvISFDPrjlL+HGgVSErzAVYKy1f/3RDvzaayrFQnvgbLv1tfBpoOfM+0T71pK4fW4uGTnsumGceKSAFNScIlDni+T2XCvrAAPay/FvCstXjisnegbFEdjSjL+m6MgNdppiukORiKY/jYC7g4MTs/0J8r/I7tYYQE332GfG9L32dnepHcF8O/+dIu1MFd5rFXohP36gz2lwfW9birpaUKX X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+VtLLsaZlXuFESHAIyOqgGS3+dqvf7A4jxbNpiBBrVd8yG/QMpuchkERzXLc?= =?us-ascii?Q?WhWLah/Wl1372440UrFFeLZLuOLeWX52ywA6xeISJ5BHZWbmNWS+Hzg539mT?= =?us-ascii?Q?RQOCkcY+pC/Buwu4LDeth5z+x4CsDVHvlXILO6pDRjJqL8dhupaM+qtbnTQf?= =?us-ascii?Q?WKuht4mmhUVDDR+f8LSL1v7sqWQ35MUoO2RM4go4XD2Z8/Usc8CQEEgUaQ/G?= =?us-ascii?Q?KU0iHtHpnzs1FtXfQwFSnTo0Or8OWJvSm0a+NNu9J+Gg1ZgTAyqx5scSchLJ?= =?us-ascii?Q?2XgkPULga/blSfDveIn20N0MH0VSWBW8kXBsoBWTPlGzZeXTwXrdTQv5vVWz?= =?us-ascii?Q?biRPu82Cal4T0OjVz3ZAhLXc+i6m3pRyNM90nRBjCYpbuPlBSVJnqJ1bMFfT?= =?us-ascii?Q?Mvu9/YEJ+UeYmdUlpZEWz/eb4jD1Fj7mIFR2fYrFGY7IW0UQtRU/VLCzKVX5?= =?us-ascii?Q?VdOXevD3dtQU92XXY2VlpnFueEvkhOnt1u+P8QvvyC4/5aMNuEJwL8OCH/d0?= =?us-ascii?Q?izsDUEBWpm/YyV8YkQvX2AS3CN4PzHTM6Sq0MLKlIjQevr8kTnxq7cz/Fs6E?= =?us-ascii?Q?SVk+7hbQ3zk+eJViNP9xkLvnVvI2nNUUVRkdD0gRYMo5xtBf3yyN5t1Q87HW?= =?us-ascii?Q?UMpKU8N1w83y0vABe87mJG7bSVRWr4PAe8JUCEOGAynrGe7L1NaOswiqUenl?= =?us-ascii?Q?yJ9INvOCG4Z9vqkVhvoN/HYz7ekC+OuYjGfLI39WI4EJfK7/JvaWjAZloAIX?= =?us-ascii?Q?N4e2WdRfjmyVIQgWEtsy1PMkCoElmBJSrMTBAr6/r5gdi/izWnOutu4s1uKA?= =?us-ascii?Q?rdmtcIjI/y0f3fvPsfWzA/0ZZg22iyw5vOwcJIzumICn9vs3K2cog++xbjIV?= =?us-ascii?Q?b09bigJkG+gxpFRQIXYKUaF2pX04oXmj/5r2uQ/vQeahZ3gz5CyfliSuTSjQ?= =?us-ascii?Q?M/641Rl5q+7dzOfpTT/qknMZT4o6HJaVSBGpYKksA9edDoKm9csu0m183Du8?= =?us-ascii?Q?cAI1zJM4Em8pAESf3JGd5V2nZI8HmYbAQBHMgYI8/2T5zhXv5iVN0IVX8/gZ?= =?us-ascii?Q?AIy8yLAgsEYLJs4JR6mqbLLPx+iEnw2lyjNjGlwK1NkOTzWDxxwMOjcaDJwS?= =?us-ascii?Q?3yaPOE8diwi24014P+AViOZ4Tg2AKgD34D5cO3MkDBYoqyEKk58wABWEzsTy?= =?us-ascii?Q?v+n3+TVMLACBiVFCN0pln3+YLcHrU93On0VJHa4KlENV7xDtcH8ZO6gtkMfI?= =?us-ascii?Q?R4Zhi4LUtQdbueUTNV+pQYb6o6nWTaEUZ4lOvkICRZtxwNqBOaF95ULnkaf1?= =?us-ascii?Q?OOgIMsvWTMEs1cw6GrtPynIUinxlYTr09MsGVGWWcyM4tFFPiDYc7rdrgf6W?= =?us-ascii?Q?JvbxFmkNQ2SDrueERlWJWQ1gjDGpQy21FVYLY3VxEcXUOnLuHt1qM0A6VzoR?= =?us-ascii?Q?GqXF3Nzd8Sy+9jfcqF7Z34IO+TM6t7FBGi07ZI1nPz8Yv5kvVEZIKLZFyeCR?= =?us-ascii?Q?clwygPZaP32mi0xDjHQviUylEQBa5xoeyFroIVmpqVf5C1EPx0CycdttDQnj?= =?us-ascii?Q?p6g7IppMQib480ElNtNEjtkpu1d9J4tWBy2xytmdw2vUDaTqGDlICrmPiVWP?= =?us-ascii?Q?FLnYgiLPM9z20huNlhMf/whcJKIrAr93iuTVhioLPzgh?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41f87726-88b1-4563-f062-08db4c56ef13 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB8048.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 04:20:46.7148 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PRGxWlAAGjAAipG9Mb54k2hGy2BbjMFLbfqqtLPEzfS/XRLV0BrGalzTlz7a/LaEMsymnXW6vqcZiegUB1HcfeifqOpDNZQaw1hSwL467eHYO0aSCDskrJAK+5g+2Ygq X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR01MB8044 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen1@os.amperecomputing.com X-Gm-Message-State: g0ZiqUNFd7imZE1KsUS3Qvbqx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683174631; bh=6L2xRE0woC3tD6yS8KReA7r4e51crFtCKo2DHWqVXpQ=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=Vlt5IkHAIoJ2cLJFFQC4MMGXrKvrRavRVVl6ig4Je/QOteqfWMlqfNshF3lCzvaDiVU VfS3OrLd8O6VSS0+gCAwGWhpv7MnmSA59CJeDh1Z9VArY7t9foUqu4tUKqA9V+TEtT33l oSo5+rncXrjW9CFt31ErIlRbe0tWWeUfMrs= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683174633957100023 Content-Type: text/plain; charset="utf-8" From: Vu Nguyen When a MAC address matching interface is found, a RestEx child will be created to provide the Redfish communication on that interface. Currently, It will try to locate all RestEx binding services and choose the first satisfied instance without taking care about current selected interface. This might raise an issue on the system with multiple network devices that the RestEx child was installed on wrong interface. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/Include/Library/RestExLib.h | 3 + RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c | 153 ++++++++---------= --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 1 + 3 files changed, 63 insertions(+), 94 deletions(-) diff --git a/RedfishPkg/Include/Library/RestExLib.h b/RedfishPkg/Include/Li= brary/RestExLib.h index bc4e4ca6caa7..2c32c3684cf4 100644 --- a/RedfishPkg/Include/Library/RestExLib.h +++ b/RedfishPkg/Include/Library/RestExLib.h @@ -2,6 +2,7 @@ This library provides help functions for REST EX Protocol. =20 (C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -20,6 +21,7 @@ This function allows the caller to create child handle for specific REST server. =20 + @param[in] Controller The controller handle used of selected = interface. @param[in] Image The image handle used to open service. @param[in] AccessMode Access mode of REST server. @param[in] ConfigType Underlying configuration to communicate= with REST server. @@ -32,6 +34,7 @@ **/ EFI_STATUS RestExLibCreateChild ( + IN EFI_HANDLE Controller, IN EFI_HANDLE Image, IN EFI_REST_EX_SERVICE_ACCESS_MODE AccessMode, IN EFI_REST_EX_CONFIG_TYPE ConfigType, diff --git a/RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c b/RedfishPkg/Li= brary/DxeRestExLib/DxeRestExLib.c index d9acad24dec1..6002be93c54e 100644 --- a/RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c +++ b/RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c @@ -2,6 +2,7 @@ This library provides help functions for REST EX Protocol. =20 (C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -9,6 +10,7 @@ =20 #include #include +#include #include #include #include @@ -21,6 +23,7 @@ This function allows the caller to create child handle for specific REST server. =20 + @param[in] Controller The controller handle used of selected = interface. @param[in] Image The image handle used to open service. @param[in] AccessMode Access mode of REST server. @param[in] ConfigType Underlying configuration to communicate= with REST server. @@ -33,6 +36,7 @@ **/ EFI_STATUS RestExLibCreateChild ( + IN EFI_HANDLE Controller, IN EFI_HANDLE Image, IN EFI_REST_EX_SERVICE_ACCESS_MODE AccessMode, IN EFI_REST_EX_CONFIG_TYPE ConfigType, @@ -41,8 +45,6 @@ RestExLibCreateChild ( ) { EFI_STATUS Status; - UINTN NoBuffer; - EFI_HANDLE *Handle; EFI_HANDLE ChildHandle; EFI_REST_EX_PROTOCOL *RestEx; EFI_REST_EX_SERVICE_INFO *RestExServiceInfo; @@ -59,116 +61,79 @@ RestExLibCreateChild ( } =20 *ChildInstanceHandle =3D NULL; - // - // Locate all REST EX binding service. - // - Handle =3D NULL; - NoBuffer =3D 0; - Status =3D gBS->LocateHandleBuffer ( - ByProtocol, - &gEfiRestExServiceBindingProtocolGuid, - NULL, - &NoBuffer, - &Handle - ); - if (EFI_ERROR (Status) && (Status !=3D EFI_BUFFER_TOO_SMALL)) { + + ChildHandle =3D NULL; + Status =3D NetLibCreateServiceChild ( + Controller, + Image, + &gEfiRestExServiceBindingProtocolGuid, + &ChildHandle + ); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "%a: Failed to create service child - %r \n", + __FUNCTION__, + Status + )); return Status; } - - Handle =3D (EFI_HANDLE *)AllocateZeroPool (sizeof (EFI_HANDLE) * NoBuffe= r); - if (Handle =3D=3D NULL) { - return EFI_OUT_OF_RESOURCES; - } - - Status =3D gBS->LocateHandleBuffer ( - ByProtocol, - &gEfiRestExServiceBindingProtocolGuid, + Status =3D gBS->OpenProtocol ( + ChildHandle, + &gEfiRestExProtocolGuid, + (VOID **)&RestEx, + Image, NULL, - &NoBuffer, - &Handle + EFI_OPEN_PROTOCOL_GET_PROTOCOL ); if (EFI_ERROR (Status)) { - FreePool (Handle); - return Status; + goto ON_ERROR; } =20 // - // Search for the proper REST EX instance. + // Get the information of REST service provided by this EFI REST EX driv= er // - while (NoBuffer !=3D 0) { - ChildHandle =3D NULL; - Status =3D NetLibCreateServiceChild ( - *(Handle + (NoBuffer - 1)), - Image, - &gEfiRestExServiceBindingProtocolGuid, - &ChildHandle - ); - if (!EFI_ERROR (Status)) { - Status =3D gBS->OpenProtocol ( - ChildHandle, - &gEfiRestExProtocolGuid, - (VOID **)&RestEx, - Image, - NULL, - EFI_OPEN_PROTOCOL_GET_PROTOCOL - ); - if (EFI_ERROR (Status)) { - goto ON_ERROR; - } - - // - // Get the information of REST service provided by this EFI REST EX = driver - // - Status =3D RestEx->GetService ( - RestEx, - &RestExServiceInfo - ); - if (EFI_ERROR (Status)) { - goto ON_ERROR; - } - - // - // Check REST EX property. - // - switch (ConfigType) { - case EfiRestExConfigHttp: - LenOfConfig =3D sizeof (EFI_REST_EX_HTTP_CONFIG_DATA); - break; - - case EfiRestExConfigUnspecific: - LenOfConfig =3D REST_EX_CONFIG_DATA_LEN_UNKNOWN; - break; + Status =3D RestEx->GetService ( + RestEx, + &RestExServiceInfo + ); + if (EFI_ERROR (Status)) { + goto ON_ERROR; + } + // + // Check REST EX property. + // + switch (ConfigType) { + case EfiRestExConfigHttp: + LenOfConfig =3D sizeof (EFI_REST_EX_HTTP_CONFIG_DATA); + break; =20 - default: - goto ON_ERROR; - } + case EfiRestExConfigUnspecific: + LenOfConfig =3D REST_EX_CONFIG_DATA_LEN_UNKNOWN; + break; =20 - if ((RestExServiceInfo->EfiRestExServiceInfoV10.RestServiceAccessMod= e !=3D AccessMode) || - (RestExServiceInfo->EfiRestExServiceInfoV10.RestServiceType !=3D= ServiceType) || - (RestExServiceInfo->EfiRestExServiceInfoV10.RestExConfigType != =3D ConfigType) || - ((LenOfConfig !=3D REST_EX_CONFIG_DATA_LEN_UNKNOWN) && (RestExSe= rviceInfo->EfiRestExServiceInfoV10.RestExConfigDataLength !=3D LenOfConfig)= )) - { - goto ON_ERROR; - } - } + default: + goto ON_ERROR; + } + if (RestExServiceInfo->EfiRestExServiceInfoV10.RestServiceAccessMode != =3D AccessMode || + RestExServiceInfo->EfiRestExServiceInfoV10.RestServiceType !=3D Serv= iceType || + RestExServiceInfo->EfiRestExServiceInfoV10.RestExConfigType !=3D Con= figType || + ((LenOfConfig !=3D REST_EX_CONFIG_DATA_LEN_UNKNOWN) && (RestExServic= eInfo->EfiRestExServiceInfoV10.RestExConfigDataLength !=3D LenOfConfig))) { + goto ON_ERROR; + } =20 - // - // This is proper REST EX instance. - // - *ChildInstanceHandle =3D ChildHandle; - FreePool (Handle); - return EFI_SUCCESS; + // + // This is proper REST EX instance. + // + *ChildInstanceHandle =3D ChildHandle; + return EFI_SUCCESS; =20 ON_ERROR:; NetLibDestroyServiceChild ( - *(Handle + (NoBuffer - 1)), + Controller, Image, &gEfiRestExServiceBindingProtocolGuid, ChildHandle ); - NoBuffer--; - } - - FreePool (Handle); return EFI_NOT_FOUND; } diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index a247bfed9e34..dd5bdbb377e9 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -87,6 +87,7 @@ CreateRestExInstance ( EFI_STATUS Status; =20 Status =3D RestExLibCreateChild ( + Instance->NetworkInterface->OpenDriverControllerHandle, Instance->Owner, FixedPcdGetBool (PcdRedfishDiscoverAccessModeInBand) ? EfiRes= tExServiceInBandAccess : EfiRestExServiceOutOfBandAccess, EfiRestExConfigHttp, --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103951): https://edk2.groups.io/g/devel/message/103951 Mute This Topic: https://groups.io/mt/98678065/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 02:40:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103952+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103952+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683174631021268.45391970012804; Wed, 3 May 2023 21:30:31 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id EtElYY1788612xb741xy8oYb; Wed, 03 May 2023 21:30:30 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.123]) by mx.groups.io with SMTP id smtpd.web10.42412.1683174051345581392 for ; Wed, 03 May 2023 21:20:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aAWJqopntSAUywNCaax6UCZSpUsE5A1Wj5BHTyYp6ww0plDxHJ6KlZQq3zZgjAA7H/XUfogdvpiLNaqNTwKicLtrEsYAj/I2BAerecjnhfmcUVEyz/Bo14MI2X4TYA9mPvAFNsBBrD40TOBF9vw290VnEGgd5sr8zDHxMDO/bRDhfkp7qn2vwcGuF2757qqpmcWr3KuT/tdRyDWnxnl9sRSr8jfqRLHKALH4G/9n9NCdvv00nGLi2VncRAolbFrN08paFNheoSpPl+jgwfHBiNmYBnWaJMq4vdA0m6mwarQRDvZRQeI0D2aXrkoYxxelDJ8EhQGrlYarpBP1H/mK2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zu8dl9fFUkyQ/+iKDqKCwJB7RvMIgqN/Q+9zIOazTmc=; b=cS3rljWpH3yMaOz1YYw7f8ZxwcX6h2dKaO7FZc3CN5R7NiBpk39fBXm5uG1qobpl6e1q8tM5fu01ONzBL/6TB/66j5d984kPw3EM95y/Zje5yj2iyv2NDG+xedQeD7/5AN40XsyOKu0jlk6SVGdOhMc5GpkoilrVULPJoeZ4AzQq6AGKi5gt3+/IYdvZzzQH65AWMEj8pG5to/QjcPmJoJIMvmjUN5xB4fd8A4UW2TPZnJJ9dw9ZruIgPmLCqxP5wBr96LKOO/003FKK15cVDm7vE4slsU/y6Tgz9tGYJmK6bHTw73g62VRi2fVT+JNUqSOgRMvlyRqUhGFDMPMKYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) by SN7PR01MB8044.prod.exchangelabs.com (2603:10b6:806:347::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Thu, 4 May 2023 04:20:49 +0000 X-Received: from PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1]) by PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1%7]) with mapi id 15.20.6363.026; Thu, 4 May 2023 04:20:49 +0000 From: "Minh Nguyen via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, Minh Nguyen , Nick Ramirez Subject: [edk2-devel] [PATCH V2 4/5] RedfishPkg: Add missing newline character Date: Thu, 4 May 2023 11:19:44 +0700 Message-ID: <20230504041945.1377457-5-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230504041945.1377457-1-minhnguyen1@os.amperecomputing.com> References: <20230504041945.1377457-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG2PR01CA0124.apcprd01.prod.exchangelabs.com (2603:1096:4:40::28) To PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB8048:EE_|SN7PR01MB8044:EE_ X-MS-Office365-Filtering-Correlation-Id: 8af22f9b-c6e8-46ba-5687-08db4c56f091 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: /vWstls8SQIoeItPrLrpA07wwQTeqPkDpdE4+CE+gHBRJnqGY0zddLUq9eH4HT6uSOWbOmyXslVmk7fIHRQYGq2chKTUWi+gne6kyinx1FDsPlDzIlFOFy5dDZ7BkVU5tiPyQxxP1G+q+wpse5QC416AslcDftsR5382L6Zl/3+bgZfCCQGG0nk1uiUJBorO91dF0pc+dxNcvmzm7nt2vRycvhRgmfABrziue67vxaLusWUgbN+MYsL+nbqJRISWGZ/VOvtdz59cFKxM7/8rLhZoWwt7vXdxI8KgBwI6gUUAiBGW+bIaSqA+KYkiyZOWV2QNEcs0U+KSLd4cUp/MBmVq95c826U1x+bHcQpqg/826zra8vD5vqpWf29uGdTe0paWSoVJoXqM+g2VgYDMEkiZ34FbgTJbf4hmyEiIotycAm/zTtI13apsifoWx7nKfBLMgB0zC75vlpPy+/gxzs9L+VjzUgvnV1yaev6ZMg8uMxMLS5bEPbK4xEC4UAK6zfqVF+rEVQUzP63wGSBOT2C1nIw4zIrXc1U7NBTuf/s2++8OAq+IOn0vdG5xjwkV1nc0H29f5qnszGWmDI7HYPlhJSe/GZqqbmSxqtJc/Ep34MUFxKqite8oEpag1M1+ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?y+mUIk43RyjJkGAQTPvZ1Raie/x03/3izy4AFydmX+1Y+AD5g4k6avpoj8gE?= =?us-ascii?Q?hOAWpu6TDMAyIfM4hBc3JVA600paNIng+6B9VnRK4jVnXqIEr9G/MutQfeRR?= =?us-ascii?Q?JT/oCYTWpIIfrB/wYKz8m9I/2vnXMXMNc6Uz166kq5tjRBysmdY+ICBEtBo6?= =?us-ascii?Q?2JnRymm/J7BJvLfuZLmEp1CapSgfv+m9eo8ztrIGuxKZTqp9gtRiB3sHEkfp?= =?us-ascii?Q?IM5V1We9LqwXR4G8CiBHBe8cWWFH4Aw5F1t7miy+iJfuSOQG0q22O9ez8Zpa?= =?us-ascii?Q?mg/RJaT9hT3qd1I3e1Q0u/ZkH8mqlZf6Gdz6w7rXfJHQlFM2oBAjdMpoPrxt?= =?us-ascii?Q?Z0TiOPSLeDcQ+0Hvci+eM5PBbpwVvzv61rzDoBZoi+jFKC4mFZ2jrEYWQmgf?= =?us-ascii?Q?PddhNlJQNO7qv3P9XYHjeYqKtMC/A47AQpp67agG6LA1Kipx4PLAhMBEWq0b?= =?us-ascii?Q?jsA+fltKQPANBH37MVXhNbSW/x+2/PvSNUMVH+5n5qCJHy4pLaxYKOS2pP3p?= =?us-ascii?Q?Vt7V8zssxKbyaDYvI6fSGRWYuqw+jKQEhSRHeVl8cc/4wa6gkXk9faQO5f5a?= =?us-ascii?Q?/gWim1KAWRTTq/SsOPSf203D/WXYZWhH9KkxuuEeuBQtb74+mw3qzJOu1WUK?= =?us-ascii?Q?wYF0v1jV2K3O5eFbzjqH+HkKF3TNRjB53GdfvbahXJkT/HTzJFRQ7XJFIX/K?= =?us-ascii?Q?yl/S+6V5RbV1mjukfQIUD4aTwipUWbLav849Xy1KOG8XD48AUDfeFFcTc2Jo?= =?us-ascii?Q?keoQHIEUgZ3qRrnwv2qYSgeJCcPRJKXr85lMY2qypYwIcxfv0puWVnqJ3vW0?= =?us-ascii?Q?ASWLQGQFh88lu/xPdxJ/SFmwZIFelnbkRXSCou9vO7htKrOCMvrzpe3G68rx?= =?us-ascii?Q?4ka7A+LZUx7B+P+NzETUoMzps0XtnKaUWuvjwB/AtDfrSoEvXV9xGX25mKPQ?= =?us-ascii?Q?+crM214TUZIbyBxI/LxuC/YXESPDhvIWf0HNNaCXSmshz3ecCpuGrMgr+LEr?= =?us-ascii?Q?EqGxfbPh0sdPHcpjWpHVhyG/am6VoRxLq+qX+PNJKJJjKsSxeTzlwRojJnh4?= =?us-ascii?Q?O4GGhP3WyX1KuyQ9wws78QBUhzTBV7/Jm1nVopWK7JD9h5TSzn2yF5+RYQpw?= =?us-ascii?Q?GFVzt5KPIP2OjFcfUG3lq8/dVXptbzgIgRwaVxh4S031JzQb4hVww0l/vuWL?= =?us-ascii?Q?1G1kWBhLC+U1Aj/svWW5FPd37ZQFH1dxZ+3mpy8pTmNrSLGvoWCZTSuZL8JN?= =?us-ascii?Q?Bdg1etSlIwC1/v8b1m8ugm6Gq1tmEEUi3OToYuC7pb99psoBjjFLP6lWCb5l?= =?us-ascii?Q?hxL137zv9DXxTzPM/izB6MHzSUC4Bi1C0ijRl8XF1pQSmsVuNADTDj4GBAXn?= =?us-ascii?Q?CK5+csSi+CDH0bLqSeTw3y3axMEhMK2yFHqldNCrfrDdrEXMFuxx1ek7+cpw?= =?us-ascii?Q?8fCAUBIEe0TUL2nBjhr7PaKjeFCfnSZfjrBxJkSE080UDvyfiz8VsA7hLpEo?= =?us-ascii?Q?ZIDC6Ev15f5NjhqlkHEejlKSneAMaaGOSFVMRv21oBSLqnjTrnxR/CjV9H1R?= =?us-ascii?Q?b/aSCXQiLa7xA8QGTrVSG0v5Z5jpWb5D9dBfi4lrzzXYWG7svDjTiShDr8da?= =?us-ascii?Q?xzS4ck870mSjzFH/KTGGekOX3RZPM5sKUu51Y/DFhzeH?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8af22f9b-c6e8-46ba-5687-08db4c56f091 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB8048.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 04:20:49.1998 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: f2CjK9j7aU12dkV6aAnWbnV0gwIaro68OwAz19zsP5uzRDJHxJsvOvwAxHJI3xJ8uAzezJIuw5npccjvgxzOM7ojAZ6WH+RSV9j7xZrYCln0hIew7McurpoDsbifccSx X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR01MB8044 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen1@os.amperecomputing.com X-Gm-Message-State: rw0DywfIWKjZlvNmR0lWxej6x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683174630; bh=mv1Z+FM7UuHlPtVn/b6sk1unh2x2ILBBP8c/DXOf7VY=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=ZAotc3kkJ08b4ShmRMmOWEU8Me4DjLN/XXfqUwUdaRd36X42MhIcU+L/+UGpS+PqZPk iwZ5SHtvrYoeaaHRIIhP5MZxB1DmG5EjjvhOtOKYeBLpRscGSwP+tCrtue8bU3yEa6K/C J0IOzDXflNl6YkwFFRCxU8B0j6E6UBSnAJg= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683174632076100009 Content-Type: text/plain; charset="utf-8" From: Nhi Pham This adds a missing newline character to make the error log readable in case the module is failed. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Nickle Wang --- RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c b= /RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c index 45fc6e2182bc..c4fa59193a2f 100644 --- a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c +++ b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c @@ -8,6 +8,7 @@ (C) Copyright 2020 Hewlett Packard Enterprise Development LP
Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved.
Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -59,7 +60,7 @@ RedfishCreateSmbiosTable42 ( Status =3D RedfishPlatformHostInterfaceDeviceDescriptor (&DeviceType, &D= eviceDescriptor); if (EFI_ERROR (Status)) { if (Status =3D=3D EFI_NOT_FOUND) { - DEBUG ((DEBUG_ERROR, "%a: No Redfish host interface descriptor is pr= ovided on this platform.", __func__)); + DEBUG ((DEBUG_ERROR, "%a: No Redfish host interface descriptor is pr= ovided on this platform.\n", __func__)); return EFI_NOT_FOUND; } =20 --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103952): https://edk2.groups.io/g/devel/message/103952 Mute This Topic: https://groups.io/mt/98678066/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 02:40:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103953+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103953+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683174632159455.2000887703948; Wed, 3 May 2023 21:30:32 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id yo1bYY1788612x8SJu1YyJH1; Wed, 03 May 2023 21:30:31 -0700 X-Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.107]) by mx.groups.io with SMTP id smtpd.web11.42042.1683174054598906597 for ; Wed, 03 May 2023 21:20:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FqT2BK3PCxKEP7KddYY6G8lrMseC01ojJq7uWPWWNkOudeTx4/3MwvzKSKPs6Q8MReq5i3GrpaJSfduGvVhRKMTeaUTEnXagbFUTqomqJLwVnagasIMHCyxKeyCOWUV2Rcy8PWJSHXp/PRCPQ6FDp+eDUlOazn0f/oAvD8Ws9P4xf9T/zGtoha8qAiZ3xqBKjW3xmgzRTivzQy3y3bHDTsC9OTLzUi4C0/wLAm1Wh0pSiZoaLEIgPcGkhUOmhAdd7wIkfEALKi77dVhFFCqCtgMamtjaN9TSuYfPaubQWhnYyoB4bx3AabSaJh59FAgaabE4LPcltZv2BBz+uXNwJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jh4UCFi3rgn5dNgMwlvoJsaOGmXOGa8O9eQW0uYisHY=; b=VeUKwpcRprNpcCdl24N7BXN8BBoKokUU+wGnxAG/ed9qff5wrRsdGAuCNUYvP+WgrfTaJ2bI/lbbckz73qJUaMKVByXaNsFdv3zMrzpKJZl5P0XpiSV7Ph+LujZUiuiOQTaEqt1RosCcz7MJAYqPqeJ/LTpgWaSzbcwhN4qnImarKxtnFVNmvwtk7//eFM36u4fnj2QLQQ2uu9Y3Vn7O7qNENY6zGB14xL8UZsoqzf8K04ODI1tuJJNiVImqxtNj44YmnWWPB4WHUYrclZUCI2nAomKfRIKogJcdutsQhzhiNJKeFomGmTXspybWESgeO2Qt/wF4Muk8hBMmf32RJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) by SN7PR01MB8044.prod.exchangelabs.com (2603:10b6:806:347::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Thu, 4 May 2023 04:20:52 +0000 X-Received: from PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1]) by PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1%7]) with mapi id 15.20.6363.026; Thu, 4 May 2023 04:20:52 +0000 From: "Minh Nguyen via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, Vu Nguyen , Minh Nguyen , Nick Ramirez , Abner Chang Subject: [edk2-devel] [PATCH V2 5/5] RedfishPkg: Fix compile issue on Linux Date: Thu, 4 May 2023 11:19:45 +0700 Message-ID: <20230504041945.1377457-6-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230504041945.1377457-1-minhnguyen1@os.amperecomputing.com> References: <20230504041945.1377457-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG2PR01CA0124.apcprd01.prod.exchangelabs.com (2603:1096:4:40::28) To PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB8048:EE_|SN7PR01MB8044:EE_ X-MS-Office365-Filtering-Correlation-Id: 0aa20ceb-779b-47e6-f25c-08db4c56f247 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: T+suIsdRqlDPnhEju6apYS+OTZxYkc40KRsoszzFeZto6jNuj6qx+CEjOXUQvKIsvuN/Qu902QCA7qb1yiHdxlhwK7pKfEH+yWIJgu9fNl5lVIRXsqZCt36ylYKNd6S0E4iPC05dSjiciypfs9AGW29ZYxibn+LmQJOvY1115z3A4Bin4tuhFMRl4u3AuTm/eko9S6o8bM3RtjZO+jsmlvEGieQy6CdHJTk9TG1CHG+6IS9pikReJ5bKIJV418nHb9Vv8lVpIxrLLmbmcu9z0m9maA6EBrKYhhNDQZGKd2oDCovOfm7t7Ywm+ZU0KE2SxQmb9Y/hG4NQcGtldS1eujoxflOBFo32inLhCJ1Zf+VldS4fTCdevpiLnbniTBEViC+Rt613DpCPkI9RqpPX7QkTmkh8s4mxqHqyYPfFRWTL9UDU8k7znMd0ihQGSPtyrcpMwmVw/H/tsQoKQj+Ug7wzJ0BNsd4hlzYhsh4QjOMo8YY7AzLhmffAwH+H/dUvNzi721NZXkQQZHWp0/PaDMchQFQbm8nulpjziViTQSQ5OIdANqcQ5kAPBO2DXHyt4HLPrxEaivkxP/RFjZTG4zo6XTyN4gl7687JugWH59OxRc+PkA9nmX+21Ysmymqn X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xFqtqI2Z2p5BzqJ4Av5cEK+Tdhte+fVUGaAqkSF+4yMRCEFgWRxCQfLH1+r0?= =?us-ascii?Q?cKN52nk9F7L3ipuojp+e9ywfv/aZYpkx9nylWLPDHatdXyciC7UUHIsW6Gk+?= =?us-ascii?Q?4YoKWEHipu3afgAFDB+e21I8rYS96WNJrXmKcOa9whccKj6w/j+DIgsi9QyT?= =?us-ascii?Q?xluMiVwirPJd2PQ6cYKPaoe/wXbKceCL/FTkhk29OCaZeevCbKih4d6nJlFf?= =?us-ascii?Q?GgwUjnX7WIqmmsxIanguXKDPa/q77mPOCxph1fehUH/B9RopVogiI2RcLPSe?= =?us-ascii?Q?daWb508uQAJX2yK22TVNttANC5plclUgThRmVCo/NgaPyl2vXfsw345deBBP?= =?us-ascii?Q?FECUC9RwhQTtgE1zxaUMqJ6/tsGJa54IVbZRdm5IYLTYzqzZE0qajPBzOPbQ?= =?us-ascii?Q?A1BJlZv5qGoccnRlF+2vPu9CDQxxTsz2hS3A+Dk3A427dOpt6vCeJ2gd1p3j?= =?us-ascii?Q?ZJe2ezqm3fwkAaUQB8N6xvtyN4aOFBCAmupdaCThfCzdn+m8QSSkwNkBZ0SM?= =?us-ascii?Q?iFu1NLzqYJijbdm6vasaMU4/44OOATTOAfAFny/oLBTKgGJy0JL47GWvKvjj?= =?us-ascii?Q?PXG0Rf0zbMy4dTq0SdD40yVoIobh4/Lbq+Hh2IbKZBuEiHSg8D7uzp4KarBf?= =?us-ascii?Q?PS+1eBWeViTLcGvVnqNFITruPxQFrDsPmq/NnoofD07UC36SOV18yujlCx30?= =?us-ascii?Q?L3yfAP87oPLotPy7u17GWtrHPxoiS82Ay/OetzMtkN+0jSDR3to6d5gkd03s?= =?us-ascii?Q?4drmA54Pfx8LHEiEqMlvv5Xwtb5lKyDbRx3n1OAreG4W51lmoctyjYRJZty0?= =?us-ascii?Q?Cky6ACsBdOWMyGrlIXaNsAaYSqwTnmV8pLMWSaBcWRr2iR+MQHT/zcZ6++ih?= =?us-ascii?Q?GinB41nmbUalfG68l2zFy1qW2M3cmk+E/6lw1B1f/UErsiHngSMKJAT3ACGt?= =?us-ascii?Q?EyZko+39hTq4W8GzokiDqhZ9zd/BgADtH/pBrir1QYaieP+kaajnAF0BNoWf?= =?us-ascii?Q?rLyrNlzXe0AzEVXBbbH+dy6+8tUx6eglxwhqgEMEbnqyWsSo4LUegf24F/PM?= =?us-ascii?Q?1MBNiXBzt3sTNkLOuwIvUl7YI+1LUCX9+bZNxtemq2OHwRYNyAkMp8NCmPyr?= =?us-ascii?Q?K583CCbNaWbCissQOHMmj8XUEOelMahYoXtRp7pYI/hwxoP8dtD2eDjNhHvm?= =?us-ascii?Q?LpOBdeFC6Hy4eQIwthJ9ZiAVntVPOsrTIIuLGizH8iQboY7TNoIVn2IZ+ZTz?= =?us-ascii?Q?WvzmQTHeP4fWtTYVbp2fYUU04bz9b2B4m8IRImCIwPuCfo3knHebmZOSS9po?= =?us-ascii?Q?kE3N4xloxehz7V72AW9UmR+OtK4k/NcOyqHQWAd1F2OLokhbeVHy6hbGK3vl?= =?us-ascii?Q?w8WlyPja2fCSlUjmp5dE5lGW6f8wYDuonbK9hlnxvtQ8QUldqCvjb/4AoOLA?= =?us-ascii?Q?VVfMAZXbkhUu5nwYLQipjjmCQlsqv3rj7rKqFnRBgcYflx6yz0DwVPXCB+No?= =?us-ascii?Q?E38mswJ6z8qQVszmoMTDA1X1STCV/0ROuQc4wqLbhx0tBAx7KY5wCKemhE5x?= =?us-ascii?Q?MlNai1NCAqjcy15SoGF9z6rANqZpZy5iz+q0sntL0woC7Zs0cykVnT2Zc9jx?= =?us-ascii?Q?rAP7Tda4gn8SbCkaKOLLLQlohtw4bV7EnALGl2F202e3?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0aa20ceb-779b-47e6-f25c-08db4c56f247 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB8048.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 04:20:52.1221 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mhLMbOQjb7phfgjE7jSg7woNFhYbVkVygmaDMjR3F/WenueIlueAU0hGr9GgSZb6igXxY8L7EagGWyFCBRfJUdjXKMhEAZVWNFf9LxVv0n1SqOfLgkob3sTtrTfvhQrI X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR01MB8044 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen1@os.amperecomputing.com X-Gm-Message-State: wEIOv7xy7SPQXpCJZ7OAe9Bmx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683174631; bh=hCiuSy3aP1moTxeZdjjNdAihvu3yRsiUV//Fzdxd5ZU=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=Ww+DlPmwZiyiyh783PIua5SOwjBEA9VCzdgNcORI/y5LAyHHUnGM5Dy3SzLRDmIU6Vp fvpQyERAlxW9eS8c60SP/3MszySpGDHI9n3HuZVkMelu1aKgzmPlPzF5Rny7YdvyX15m0 jDCe+23bxHJIHLoO5G4cQ5+GQaBFAnkAQDs= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683174633846100020 Content-Type: text/plain; charset="utf-8" From: Vu Nguyen It requires a fixed size array to store the content of device path PCD. Add the array size to solve this issue. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang --- RedfishPkg/Include/Pcd/RestExServiceDevicePath.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/Include/Pcd/RestExServiceDevicePath.h b/RedfishPkg/= Include/Pcd/RestExServiceDevicePath.h index 91b1198297c2..57fc199f61f2 100644 --- a/RedfishPkg/Include/Pcd/RestExServiceDevicePath.h +++ b/RedfishPkg/Include/Pcd/RestExServiceDevicePath.h @@ -4,6 +4,7 @@ =20 Copyright (c) 2019, Intel Corporation. All rights reserved.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -14,6 +15,8 @@ =20 #include =20 +#define MAX_DEVICE_PATH_NODE 40 + typedef enum { DEVICE_PATH_MATCH_MAC_NODE =3D 1, DEVICE_PATH_MATCH_PCI_NODE =3D 2, @@ -32,7 +35,7 @@ typedef struct { // 0x03,0x0b,0x25,0x00,0x00,0x50,0x56,0xc0,0x00,0x02,0x00,0x00,0x00,0= x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0= x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x01, // 0x7f,0xff,0x04,0x00} // - EFI_DEVICE_PATH_PROTOCOL DevicePath[]; + EFI_DEVICE_PATH_PROTOCOL DevicePath[MAX_DEVICE_PATH_NODE]; } REST_EX_SERVICE_DEVICE_PATH_DATA; =20 #endif --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103953): https://edk2.groups.io/g/devel/message/103953 Mute This Topic: https://groups.io/mt/98678067/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-