From nobody Tue Feb 10 15:45:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103937+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103937+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683170087331904.2651840075321; Wed, 3 May 2023 20:14:47 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id kfszYY1788612xJTvvZiMkhc; Wed, 03 May 2023 20:14:47 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.100]) by mx.groups.io with SMTP id smtpd.web10.40198.1683165514015483678 for ; Wed, 03 May 2023 18:58:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JyAZH2ipkjMO3QtF4Vb2tXX59J3X6Ob8nuIKYpRAwDklXH7MJxjwzYSqBlydf9VpI4BQ4OoFvDYVTnY06BHZHm/aqzjpLYzpYJ7v8HiZBQbXLcIgB+BYTalBuXOphjjVYA6TDy7rpgQjECIVc8ZedhA4Ff8o4l2ZXzhQ9qd2c/RIpWmVDCCSU1x9AZZgOumgst23Y49bElD5FaHdWgplaAt7hNM311JISKppsNrdoQ8vKjBxlSPD+SlmbSlrSWK2GVClq1GgpNZ5sTHprRzRunjboGICy3cnX6el/Nk3yHa60ZOjIKY3444gBZL5zXAYpMPKyR6UQepy/0Bd4iedTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dSihEz/Jt8Y2iDBo4H0XhIU1PmahKSAz6K0TQX95Bhs=; b=dLM62W1micNU3Z/dV/9nNl/KLLy7ck6Uc9MT66I+E+HHbQDiv7u6CMXMLKLZnaTE9edyb1uwx2xVXinMEvjl4U8W3dgxBtTipGlX5E0CkpcOID8ir3Xe475rqtEiMDjgwSlxaobNLbaoPXPzFr/tX3ih8FXTHbllP6rd7k3/495M2kLkDkJabnPj7wgqsY/lsBi8RsDpS2Ow1lI2ka+HmrApgR5OWvz9IgFZ9292DWnBvWk1yCfN4il/+lyRe/3U2MwYzp87va3SoBHurWeLkV8Hgg6mxeVzKkPInvSr3F/HlA6X3lM+4q+fnM+SCrkXNl34VhBxwnjJ8K8Awczh9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from SJ2PR01MB8049.prod.exchangelabs.com (2603:10b6:a03:4ce::10) by DM6PR01MB5978.prod.exchangelabs.com (2603:10b6:5:1df::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 01:58:31 +0000 X-Received: from SJ2PR01MB8049.prod.exchangelabs.com ([fe80::b8:5d56:7d04:223a]) by SJ2PR01MB8049.prod.exchangelabs.com ([fe80::b8:5d56:7d04:223a%3]) with mapi id 15.20.6340.030; Thu, 4 May 2023 01:58:31 +0000 From: "Minh Nguyen via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, Vu Nguyen , Minh Nguyen Subject: [edk2-devel] [v1 PATCH 1/5] RedfishPkg: Correct variable type to prevent memory corruption Date: Thu, 4 May 2023 08:57:50 +0700 Message-ID: <20230504015754.1352305-2-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230504015754.1352305-1-minhnguyen1@os.amperecomputing.com> References: <20230504015754.1352305-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG2P153CA0037.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::6) To SJ2PR01MB8049.prod.exchangelabs.com (2603:10b6:a03:4ce::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR01MB8049:EE_|DM6PR01MB5978:EE_ X-MS-Office365-Filtering-Correlation-Id: 5df5009c-c25c-4648-e004-08db4c430f8b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: OE/5IYeJLh3dsKpCgWJSOqN5IVzkwuOnr5ts7FFtVA4rc+xopeI8wVpxvXlcpViCkt/Ldj34ft8b2m91JoIKilr+i+RjPlE/hwymYUv91u94Aw5sD7urpTWBumYNCHKb1BhRn5tgVgITNFo6s/TsKCSV8Y+DA48A9W6kt6nCbmWZYFZlIiJ9KaJmxg5hzpKNRxUe4U5jl8MDTyeKMymJjX7s5sV0woktfhlu7qbYZsUikF7Ek9x7tftYwXo+L5Kf5mCJBE6q5EAsAskPtVi2yr+VDXiuqSLaoTuELholDaZln2byhwlxjQJfgt5RHjhRGA56Iim+L/c61FxxIhlL2RbLjDbGPMcCifhAoHfdDzLAg+Ef8J4UzbaFg2tcW1lfBtC9T1bMBY102FTX/sjgxwIQGgn8fQuLE0kf7JcxI/Jg9ek+plNKvuPdouPCFYUGnyNvXpmWb+oDEOlMXKaYcJ5Vx1TVlbUWt2P9VjB0yPhS5Vhoj88o6wWgANkFyix/BKGVieFEm7OKr5F1X3dJFy1VHi8DXIuvfxe4OlS1lWrrQK6l1nW1F0vB11wFCBz3X8kz6vxOZfL/CbricKMze6iU7nX+S5cQWhZ4SeegpR/8mpfqhXCR0yCgUTnMvQza X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WVgRdpzN2XPBct5Pn72tNFlq0KVSwvjEOlt89B2yzWu/agKObEU3AU5uV6FP?= =?us-ascii?Q?jdLY//GLdBHeUNqzRalk3f90CscaT2nm586eYQ64twcTpU2pZ5LCvcBe5ymY?= =?us-ascii?Q?97/adJnfvK3rMm4KwESppmpA7SUpvwgrLRJIrhFUKjznwHYnIe8Ysr5hqr+c?= =?us-ascii?Q?Q6WzuALNoqGePhksWNaDlvwoHrgHdUxT1Rx4RuO7ZEzxOzwgQVadnk7Dm1kl?= =?us-ascii?Q?AuUBl32pfvBvimECJxK0Db4j7SD0MZKy42bHRpTJ+H15sh1aYrICW6En/8Ia?= =?us-ascii?Q?TNXA0zgZxWjimvC1VZ8R3V9LOAoGai9R8d+oy5enxhZO0XLRAAUqTImPwYWJ?= =?us-ascii?Q?8lNdl4lm7vnYBg5gaqJM/zYJ9UxilwTGnS9xDSb46Q3QTyvJQ8fdLErz/V6z?= =?us-ascii?Q?GOeS//C8bbQYCVTbzP5wZqbleUGfbYkWBLBuW6uf8+WT08z+iNMT2kbLI7Ci?= =?us-ascii?Q?qRyibJuTL1581xgaO1hrtmzZnsiyquxsB/cYP68Zo+E/3phVl5WWoawGGCQs?= =?us-ascii?Q?1HnTYTpGGy97dBWTCmaB3YRi1GWm0PkL4vZWTM39obBH2mpgRYMl2uJLw51t?= =?us-ascii?Q?hEGPzKk2ZjxBfUi1CGudlqHs9jidUzaUv1B6vaPujlcmbyr0r0wl+VVkcNsW?= =?us-ascii?Q?A0/mO+qHNdmZyNdcaomAxL5K86hBfVny7GixxvkbNqjszFRK6oDGlu4Zmkfe?= =?us-ascii?Q?m5W9rJeS0WcluLwuHInTF8x130FmDQa/DZOgeeCkBvXwLs39ZywE1fRxcJdZ?= =?us-ascii?Q?hHUq4dC3ZA++ivcD/k0VYL2yP1H1UFyEDcCWhdfuCkd0Rp+8sN9+H4lQAy7C?= =?us-ascii?Q?J7OC+aDxcalPaouMfUYObgI4WW/v96MB3ugeQDAmNZJ5DQcDtycpu8KhT22l?= =?us-ascii?Q?30iMnuWfw3wb8/6Wix4O0WckLf14esOjHuZnwgixlmUxCQq6FVhxLnCyiRak?= =?us-ascii?Q?2npv2bU9JNwxcioPU22uEdRhOErl/nBjqlDQNGIM/RZPOw64TuuHYCI0j3Ge?= =?us-ascii?Q?GA+Ni4B6szsTez9Blx6XYE7bStTlXc81pokz5IUlMnNwQwkUMD/1p32IWZqg?= =?us-ascii?Q?sed5uZ1qQwN1hczgjcPTIFMMtBAjRWoVmIe+r0hM/TdkRe2rYg4EzCa9l1BC?= =?us-ascii?Q?zsUlBgQ/hComoD1yX2jftdsykk8poXqovmGfZqTfsLrmjDOh6in40vIDsnE4?= =?us-ascii?Q?rz26BG+IxCh7aYq4TWbceHlIGOMIoafzikV1VV6a4SZ4EgbQ89osxnuaYsby?= =?us-ascii?Q?f5nJZ+Mf1Pn7cefB6x/a4e+hVx4WH24iaE3LEpDqMQlX66IZV2ZH1ceCkH7R?= =?us-ascii?Q?012LAkii7+N+jpmZilgwmm0qNWMt7xQMfmqpm2Qp0NZ5QqaioDl+NPwwwsJ0?= =?us-ascii?Q?c/2fHEYi+JbeePRnbaIcBCxhZXv4DUAgyBBvi4+XOtWgGwXjVSbrYXzekPLE?= =?us-ascii?Q?ixX3SEFjofl84xyuwOKgZFswx4dd/0b8HIiN9ulVl6onxyzxA4JQJyrYe0uq?= =?us-ascii?Q?e6Yx/d9VqLw4oDX/5JMPtmZX+4psl4O2CRuVtULogUJhy6DGwtYmZvyWySSA?= =?us-ascii?Q?P2l3Hez8VxDIV/LpC5d4aS3cIpxjwm43dMdxJTvOy9IgFDUc0/SZYC1aiKfU?= =?us-ascii?Q?TsHIwYU1x8TKzvG1S6EmT/0+VVJlUZiKfM2EASR0U4G5?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5df5009c-c25c-4648-e004-08db4c430f8b X-MS-Exchange-CrossTenant-AuthSource: SJ2PR01MB8049.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 01:58:31.4279 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ghBN+YaSEhhHxD80PsxNSOXJ3uyLEptuZMIPv5f8tfb5Yq/j0vd4dX0/doVTdYrUeFRVS33QfhAXRCXYgLkh+GYr/R5lTmsi/llyGEU77DZHtxDZ4Tv+a7bwJ8sJW2x9 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR01MB5978 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen1@os.amperecomputing.com X-Gm-Message-State: mdgOUg13xnBq8IJaQsxsXrakx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683170087; bh=l7tE/+MvEdStaqsmCWq22gVb680Dkv3g3GGuqGKgZZs=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=SxYc6KtAgR+sOHqATUvFrDntLXYmZAacaIiEZ6MqbpwwAF06bHEStRZHPoqYwUCmgnG olOxKEcfPwNqTwSJ2qSc8YCM0Af1A9hD1qQd1acqPWl/t04dV9NE9btuoJAxRVX0wDl+F MeeXfvqVRoU6UrDkTZShfxImKhICEedQmho= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683170088530100015 Content-Type: text/plain; charset="utf-8" From: Vu Nguyen Id will be casted by CoreOpenProtocol, declare this variable with a wrong type might result in the corruption of other local variables. Signed-off-by: Minh Nguyen Reviewed-by: Nickle Wang --- RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h b/RedfishPkg= /RedfishRestExDxe/RedfishRestExDriver.h index 4a9e9f7b81a4..6b94e5814c43 100644 --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h @@ -3,6 +3,7 @@ =20 Copyright (c) 2019, Intel Corporation. All rights reserved.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -84,7 +85,7 @@ struct _RESTEX_SERVICE { // EFI_HANDLE HttpChildHandle; =20 - UINT32 Id; + UINT32 *Id; =20 EFI_REST_EX_SERVICE_INFO RestExServiceInfo; }; --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103937): https://edk2.groups.io/g/devel/message/103937 Mute This Topic: https://groups.io/mt/98677247/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-