From nobody Sun Apr 28 12:06:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103854+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103854+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1683016364; cv=none; d=zohomail.com; s=zohoarc; b=l9eM1XoFJVT0X5QCf5LDJIvjT4rONpx+g9MYZIo1h385PsUeeoWSh1XBwlG2s/7YA+SpuV9Uaj1bCYyxq5RV5Bbr+wksRQB4kYeuschpyjVxmb5LAEPDRVRNdjh+gD6COFWulr3uKexwwJuJY2K4uX+X84VYr47IsTLnU48EnIU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683016364; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=vWzIjrAHt2VbEqiv7zPlOUjejp9ydsvasGjTJ5OVjA0=; b=LQOFwBieDHDPtpUMKoH7KWAwWmOhweA2S94PRPsawF6f4JBxrYXU0/BI+S0mdnY4/iY8R8NzXiZF1HTjyNk99Oxj9NVKPGljxUcQ3rAGHCqEpU5wBgaRf1ZsMT0wzJLLppRrIdg0WC17+rnl7WBrnZOK8Ir05eDJGHXJb3sJvCw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103854+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683016364212694.0100088604488; Tue, 2 May 2023 01:32:44 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 0kcOYY1788612xdDUgd60h12; Tue, 02 May 2023 01:32:43 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.123881.1683016363153368195 for ; Tue, 02 May 2023 01:32:43 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 81818C14; Tue, 2 May 2023 01:33:26 -0700 (PDT) X-Received: from usa.arm.com (a077434.blr.arm.com [10.162.17.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 544873F5A1; Tue, 2 May 2023 01:32:40 -0700 (PDT) From: "sahil" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Thomas Panakamattam Abraham , Sahil Subject: [edk2-devel] [edk2-platforms][PATCH V2 1/2] Platform/ARM/N1Sdp: Fix RemoteDdrSize cast Date: Tue, 2 May 2023 14:02:26 +0530 Message-Id: <20230502083227.3038317-2-sahil@arm.com> In-Reply-To: <20230502083227.3038317-1-sahil@arm.com> References: <20230502083227.3038317-1-sahil@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sahil@arm.com X-Gm-Message-State: Jd3KllnV6q3uv12Hx7RQBKPXx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683016363; bh=zdIIWZ3ujizW9JCEk8wbFk5FSjW9pxlTcDkHNR/hUEo=; h=Cc:Date:From:Reply-To:Subject:To; b=eF+F07dFT4Mzr7NaFHX5cvEvlifpoEutB4MS7zy8D9DPOpcn5Y8QRj+PSQlQ+WEcZnn EPQt4220JDA8NQ3PjVLGZXMQ9Cq5//9SKUPjCb7xhpJYf5OF+SS2EEfLSIlUz+i8hkvVX SxZWB2ypuAfH23PVTYq/MO/ldSxFtEv6G2Q= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683016364789100006 Content-Type: text/plain; charset="utf-8" RemoteDdrSize calculation wraps around when booting N1Sdp in multichip mode. Casting it to UINT64 to fix the issue. Signed-off-by: sahil Change-Id: Ic51269a8d67669684a5f056701cfbef6beb23da2 Reviewed-by: Sami Mujawar --- Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/Configurat= ionManager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDx= e/ConfigurationManager.c b/Platform/ARM/N1Sdp/ConfigurationManager/Configur= ationManagerDxe/ConfigurationManager.c index a6b4cb0ef482..fa6408a7dd1e 100644 --- a/Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/Confi= gurationManager.c +++ b/Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/Confi= gurationManager.c @@ -1254,7 +1254,7 @@ InitializePlatformRepository ( PlatRepoInfo->MemAffInfo[LOCAL_DDR_REGION2].Length =3D Dram2Size; =20 if (PlatInfo->MultichipMode =3D=3D 1) { - RemoteDdrSize =3D ((PlatInfo->RemoteDdrSize - 2) * SIZE_1GB); + RemoteDdrSize =3D ((UINT64)(PlatInfo->RemoteDdrSize - 2) * SIZE_1GB); =20 // Update Remote DDR Region1 PlatRepoInfo->MemAffInfo[REMOTE_DDR_REGION1].ProximityDomain =3D 1; --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103854): https://edk2.groups.io/g/devel/message/103854 Mute This Topic: https://groups.io/mt/98634523/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun Apr 28 12:06:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103855+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103855+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1683016366; cv=none; d=zohomail.com; s=zohoarc; b=L8NKJoX3JOkYnpSstX+AIiKk8oHXqQwLtrEJqMIGMI3wCwLassJdcS7citeizNhAz+sAIGSvUEZmYlTwE9CQDxUmlPQ/yZ8aKtWrQkmBZyCK3K6zfCfk5+Kmuq3gvmhcSEFfxcZP6l8bt7gqZEqigLRbUUi9m/pp7ZrmlNPGHP0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683016366; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=d/ei+Ot5Nhgt5qeC8ThZvI2vA40+jH+L7cebu9glsj8=; b=f8Gxyjprpdv6dItELoEea94mA5JJJw8BXQkYleje2SoftOQlUH1pf3smLsp4gTfO6sTfpQzIgKybKskuL6LcTwHLESqTe0RNk0W2GU5hie+VJT1hmU9tOkLfodN1P2Wh52P8WQPXq7iMpmMxNRCeJG15CvUnE8M/DcALDiGUVZE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103855+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683016366050599.349352636982; Tue, 2 May 2023 01:32:46 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id r8UoYY1788612xN8rBPDngij; Tue, 02 May 2023 01:32:45 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.123298.1683016365121906322 for ; Tue, 02 May 2023 01:32:45 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F10C1150C; Tue, 2 May 2023 01:33:28 -0700 (PDT) X-Received: from usa.arm.com (a077434.blr.arm.com [10.162.17.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C47273F5A1; Tue, 2 May 2023 01:32:42 -0700 (PDT) From: "sahil" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Thomas Panakamattam Abraham , Sahil Subject: [edk2-devel] [edk2-platforms][PATCH V2 2/2] Silicon/ARM/NeoverseN1Soc: Fix RemoteDdrSize cast Date: Tue, 2 May 2023 14:02:27 +0530 Message-Id: <20230502083227.3038317-3-sahil@arm.com> In-Reply-To: <20230502083227.3038317-1-sahil@arm.com> References: <20230502083227.3038317-1-sahil@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sahil@arm.com X-Gm-Message-State: fe9D28IrGf0ATbJI9CoX15aUx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683016365; bh=ul3CGyB1I9scbNF1OV/sY+MdvwVZMW9cyCUPkX+bNiU=; h=Cc:Date:From:Reply-To:Subject:To; b=ZeT3olqJW3UwgGSARxZCTi+pzpywyGqCVWOoxpfCFU7L3Ok+TvtEOqzRmQFYgss/f88 Bwrvr5TSx/Kb740hzy9WgycnzPwZEjfLcjm3c9s+uY1ah7Eq2nemE1QKKmsY8S6/D37fd jREvqi1IDDcviX3H65cfHE1eTzGAxDDvgbU= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683016366849100011 Content-Type: text/plain; charset="utf-8" RemoteDdrSize calculation wraps around when booting N1Sdp in multichip mode. Casting it to UINT64 to fix the issue. Signed-off-by: sahil Reviewed-by: Sami Mujawar --- Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c= b/Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c index 339fa07b3217..9e8a1efc557d 100644 --- a/Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c +++ b/Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c @@ -58,7 +58,7 @@ ArmPlatformGetVirtualMemoryMap ( DramBlock2Size); =20 if (PlatInfo->MultichipMode =3D=3D 1) { - RemoteDdrSize =3D ((PlatInfo->RemoteDdrSize - 2) * SIZE_1GB); + RemoteDdrSize =3D ((UINT64)(PlatInfo->RemoteDdrSize - 2) * SIZE_1GB); =20 BuildResourceDescriptorHob ( EFI_RESOURCE_SYSTEM_MEMORY, --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103855): https://edk2.groups.io/g/devel/message/103855 Mute This Topic: https://groups.io/mt/98634524/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-