From nobody Mon Feb 9 14:00:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103615+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103615+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1682489792; cv=none; d=zohomail.com; s=zohoarc; b=T+vmt27t6fJRokOFyUZKI280X8ErSxwUCNCyMi+VfcYHL0N/6kXLJV9mRhMi+c151Dw4Rt9ZEYbJflXE1wsLXZ7EWp58d3tmxi9ZkUPWLoNWSS/w0O21h6bWBhVt7l1fS45DW+Q1aoU5qaX1FquWSL85Mn6Tk15/w/ssPa/R2mg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682489792; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=2gqXLLnVYnAlFIbxTbbbmLcQE4CFr/gJtAEgVIgK69Q=; b=laqb8WtWcIWrYctic3Y4NoJmusiRARRiF8cA7AF5Y9yKGe0MlFQFoJm/FT04PMLLgFxCKjMMSLjwEoEFebE4r1H4nIAHyCZbT5EpfXUqbPJYrHfHlQh86vaocF9aYTRAJdz+jY8169w+V02t63UxazlMDou6SUvdf+o2uKV28Bw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103615+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1682489792677329.0321324942589; Tue, 25 Apr 2023 23:16:32 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id s2JbYY1788612xU5joszB4EY; Tue, 25 Apr 2023 23:16:32 -0700 X-Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.1740.1682489774480026272 for ; Tue, 25 Apr 2023 23:16:18 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="331235195" X-IronPort-AV: E=Sophos;i="5.99,227,1677571200"; d="scan'208";a="331235195" X-Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2023 23:16:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="644125254" X-IronPort-AV: E=Sophos;i="5.99,227,1677571200"; d="scan'208";a="644125254" X-Received: from shwdesfp01.ccr.corp.intel.com ([10.239.158.151]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2023 23:16:16 -0700 From: "Zhiguang Liu" To: devel@edk2.groups.io Cc: Zhiguang Liu , Nate DeSimone , Ray Ni Subject: [edk2-devel] [PATCH v2 4/5] SimicsOpenBoardPkg: Use another SmmAccess Driver Date: Wed, 26 Apr 2023 14:15:48 +0800 Message-Id: <20230426061549.1254-5-zhiguang.liu@intel.com> In-Reply-To: <20230426061549.1254-1-zhiguang.liu@intel.com> References: <20230426061549.1254-1-zhiguang.liu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhiguang.liu@intel.com X-Gm-Message-State: McfwmeSqmnyN2r2N06d1q1iRx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1682489792; bh=Vk9t32lAWEVPMt5dLJTBdVnCe2l7tPkIVmP+POANKP0=; h=Cc:Date:From:Reply-To:Subject:To; b=wWwvjK7x+u8SSYT4cJOvzzi4pvlf5A9OG4m7l/+CyeOlbJu5O7P5lWOTVYrKOAVcBjt lSJXYfDbOShnROyiI0hyYMW0CjMychxDGu6w2fBRaup3b76xj+GwNQHCR8nJtQBYq9JgY xLwrMBf6k/SmulAzvLG2Fn/Umy0td1EGc0s= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1682489794759100003 Content-Type: text/plain; charset="utf-8" Because of the similar reason I mentioned in last commit, the SmmAccess2Dxe.inf driver should be deleted and the replacement will avoid hard-code and use gEfiSmmSmramMemoryGuid Hob to get Smm Range information. This can fix an existing bug. In pei phase, some module may use some SMM range, and mark this range as allocated in gEfiSmmSmramMemoryGuid Hob. In DXE phase, when loading SMM core, we should avoid using the allocated SMM range. However, because the GetCapabilities by this driver return a hard-code SMM range information, the allocated buffer is treated as free buffer and used to load SMM core. Cc: Nate DeSimone Cc: Ray Ni Signed-off-by: Zhiguang Liu --- .../Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 2 +- Silicon/Intel/SimicsX58SktPkg/SktUefiBootInclude.fdf | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.d= sc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc index ae6f980a68..f15c088d9e 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc @@ -278,7 +278,7 @@ !if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly =3D=3D FALSE $(PCH_PKG)/SmmControl/RuntimeDxe/SmmControl2Dxe.inf $(PCH_PKG)/Spi/Smm/PchSpiSmm.inf - $(SKT_PKG)/Smm/Access/SmmAccess2Dxe.inf + IntelSiliconPkg/Feature/SmmAccess/SmmAccessDxe/SmmAccess.inf IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSmm.inf !endif =20 diff --git a/Silicon/Intel/SimicsX58SktPkg/SktUefiBootInclude.fdf b/Silicon= /Intel/SimicsX58SktPkg/SktUefiBootInclude.fdf index fdcb4fb9a7..42c8408c05 100644 --- a/Silicon/Intel/SimicsX58SktPkg/SktUefiBootInclude.fdf +++ b/Silicon/Intel/SimicsX58SktPkg/SktUefiBootInclude.fdf @@ -1,14 +1,14 @@ ## @file # Component description file for the Simics X58 SiPkg DXE drivers. # -# Copyright (c) 2019 Intel Corporation. All rights reserved.
+# Copyright (c) 2019 - 2023 Intel Corporation. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # ## =20 !if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly =3D=3D FALSE - INF $(SKT_PKG)/Smm/Access/SmmAccess2Dxe.inf + INF IntelSiliconPkg/Feature/SmmAccess/SmmAccessDxe/SmmAccess.inf INF UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf !endif INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103615): https://edk2.groups.io/g/devel/message/103615 Mute This Topic: https://groups.io/mt/98509467/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-