From nobody Tue Feb 10 02:42:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103521+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103521+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1682404817; cv=none; d=zohomail.com; s=zohoarc; b=MVi+UrRi7FyJckHk2GZH3lQSd5CNTHRcoP7UoX3bS/0kD7MRqdlyLWFjgw6b8p8eFprynQyJhk0o4YvJ15HlBOVbj5p+7AabOGljggMF1zcyt7li2ZBqH3bW4legKHlP2PdNdFo0a50RWJCzhHWkbRq50Bh1zpF/ZHO/XVjZRR0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682404817; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=STbecCEYrQvC4J9kqts7xJEjlV6hMaRxyPj8YhawtXY=; b=VZFC3K+Ylr94EdvMUZrAqBkN8u3Hin0N26uG2Z3cz3WvyTC7ADtATGy/Dk3K1BILlVpAzT6sl4LlOrERnpVgCdcCpkn0D9Fkq2H+xL2+3P8L/goXRTXdxGcODYii58L2puduhbxDr5tC8Sz75QoBVAQ5uiKVrFJpr4r0zzyIjO4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103521+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1682404817846350.76963142254226; Mon, 24 Apr 2023 23:40:17 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id CpmiYY1788612xkpa7mxBthR; Mon, 24 Apr 2023 23:40:17 -0700 X-Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.73019.1682404812454075052 for ; Mon, 24 Apr 2023 23:40:17 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="326982933" X-IronPort-AV: E=Sophos;i="5.99,224,1677571200"; d="scan'208";a="326982933" X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2023 23:40:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="817558212" X-IronPort-AV: E=Sophos;i="5.99,224,1677571200"; d="scan'208";a="817558212" X-Received: from shwdesfp01.ccr.corp.intel.com ([10.239.158.151]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2023 23:40:15 -0700 From: "Zhiguang Liu" To: devel@edk2.groups.io Cc: Zhiguang Liu , Nate DeSimone , Ray Ni Subject: [edk2-devel] [PATCH 3/3] SimicsOpenBoardPkg: Remove unused PCD PcdSimicsSecPageTablesBase Date: Tue, 25 Apr 2023 14:40:03 +0800 Message-Id: <20230425064003.2037-4-zhiguang.liu@intel.com> In-Reply-To: <20230425064003.2037-1-zhiguang.liu@intel.com> References: <20230425064003.2037-1-zhiguang.liu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhiguang.liu@intel.com X-Gm-Message-State: OOzYcxc1elczSVGe1pcyXmaBx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1682404817; bh=h0yPewDxkCisiJzIIjYHmYjTf/4yQdAC8ek7Qcqblj0=; h=Cc:Date:From:Reply-To:Subject:To; b=Mjw01ON152bFw+tHnQgFgfCnSYJsqjyjrVLmvvRvMrZNRjlkvQXSy4Q19KbD91o9oJW 3FpPAC0AoHfpiBdkGbLXhg4aJuM9B6i0b86RoMX3ImzKhGti+t1+VEL5Jgksk11hfFpsT gcMqrCmHHf7i0to+od9TBMPn1fGEqTVXyko= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1682404819566100019 Content-Type: text/plain; charset="utf-8" Currently, for 64-bit PEI, pagetable is created in reset vector and stored in SPI flash. No need this PCD now Cc: Nate DeSimone Cc: Ray Ni Signed-off-by: Zhiguang Liu Reviewed-by: Ray Ni --- .../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf | 3 --- Platform/Intel/SimicsOpenBoardPkg/OpenBoardPkg.dec | 1 - Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c | 8 -------- Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf | 1 - Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf | 1 - 5 files changed, 14 deletions(-) diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.f= df b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf index ccb7fe7e59..a74c355e09 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf @@ -79,9 +79,6 @@ ErasePolarity =3D 1 BlockSize =3D 0x10000 NumBlocks =3D 0xB0 =20 -0x000000|0x006000 -gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPageTablesBase|gSimicsOpenBo= ardPkgTokenSpaceGuid.PcdSimicsSecPageTablesSize - 0x006000|0x001000 gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsLockBoxStorageBase|gSimicsOpenB= oardPkgTokenSpaceGuid.PcdSimicsLockBoxStorageSize =20 diff --git a/Platform/Intel/SimicsOpenBoardPkg/OpenBoardPkg.dec b/Platform/= Intel/SimicsOpenBoardPkg/OpenBoardPkg.dec index 421c464023..e8aefdd893 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/OpenBoardPkg.dec +++ b/Platform/Intel/SimicsOpenBoardPkg/OpenBoardPkg.dec @@ -38,7 +38,6 @@ gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsFlashNvStorageFtwSpareBase|0x= 0|UINT32|0xd gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsFlashNvStorageFtwWorkingBase|= 0x0|UINT32|0xe gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsFdBaseAddress|0x0|UINT32|0xf - gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPageTablesBase|0x0|UINT32|= 0x11 gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPageTablesSize|0x0|UINT32|= 0x12 gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPeiTempRamBase|0x0|UINT32|= 0x13 gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPeiTempRamSize|0x0|UINT32|= 0x14 diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c b/Platform= /Intel/SimicsOpenBoardPkg/SecCore/SecMain.c index 6b572b38a8..39e879e922 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c @@ -759,14 +759,6 @@ SecCoreStartupWithStack ( =20 AsmWriteIdtr (&IdtDescriptor); =20 -#if defined (MDE_CPU_X64) - // - // ASSERT that the Page Tables were set by the reset vector code to - // the address we expect. - // - ASSERT (AsmReadCr3 () =3D=3D (UINTN) PcdGet32 (PcdSimicsSecPageTablesBas= e)); -#endif - // // |-------------| <-- TopOfCurrentStack // | Stack | 32k diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf b/Platfo= rm/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf index 1de3d012a7..af1c0f2b55 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf @@ -62,7 +62,6 @@ gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsPeiMemFvSize gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsDxeMemFvBase gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsDxeMemFvSize - gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPageTablesBase gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPeiTempRamBase gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPeiTempRamSize gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHandlerTableAddress diff --git a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf b/Pl= atform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf index cdc30ad582..49f441fe9d 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf +++ b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf @@ -65,7 +65,6 @@ gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsDxeMemFvSize gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsLockBoxStorageBase gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsLockBoxStorageSize - gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPageTablesBase gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPeiTempRamBase gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPeiTempRamSize gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHandlerTableAddress --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103521): https://edk2.groups.io/g/devel/message/103521 Mute This Topic: https://groups.io/mt/98488023/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-