From nobody Sun Feb 8 17:21:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103020+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103020+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1681498723; cv=none; d=zohomail.com; s=zohoarc; b=RzWAo7MhUtOmdM4VHxDjfsG3x4JIRUgAsCTZgvv89/qdWak5yaS5T4+jau8CfB+6vQycZEYsiFQp/CDd6mMGy3CadLd6sB7fjk7OZjwKhrWycOdzG5oSlcIN7KpHR2z6KehefNR8uAp2z4v8ziqowWL5XlCxKv+0FWYFnsGBer0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1681498723; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=5/XU/lZkk1DnSBz3Dt9DBUWBePwm4oXZyukDbVc+Iy0=; b=cJ+r6Hf7nEwo0FrtcK/EYquA82MYI/UuRTjyVd5W6CJAyFqzRMBN6oTV6fqkZ5HBKOlqheRHjMZk+hAc1FbsMFUbaOHcHGcSOTXyeMBOO1zcbr8uwlGNkyeVG+QuBuPwb0iWE/4UA1CC4BpEK1qjcGj8231TJ9zGueqbq66Pi9I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103020+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1681498723897430.04104179499006; Fri, 14 Apr 2023 11:58:43 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id qjn0YY1788612xbO519AYdfT; Fri, 14 Apr 2023 11:58:43 -0700 X-Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mx.groups.io with SMTP id smtpd.web11.19132.1681498720289713627 for ; Fri, 14 Apr 2023 11:58:43 -0700 X-Received: by mail-pl1-f181.google.com with SMTP id y6so18156924plp.2 for ; Fri, 14 Apr 2023 11:58:42 -0700 (PDT) X-Gm-Message-State: NXfTH1RfUKBefSS0XXLaH173x1787277AA= X-Google-Smtp-Source: AKy350YnEqrC+F6J01gxAFs3WiHIYZKgDlh8flaPXKg/rkeqoljRR+cIie/K2HCFDJqSQ2aT9ThhgQ== X-Received: by 2002:a17:902:f707:b0:1a2:296:9355 with SMTP id h7-20020a170902f70700b001a202969355mr3818131plo.16.1681498722198; Fri, 14 Apr 2023 11:58:42 -0700 (PDT) X-Received: from localhost.localdomain (c-174-50-177-95.hsd1.ca.comcast.net. [174.50.177.95]) by smtp.gmail.com with ESMTPSA id g20-20020a170902869400b001a681d123a0sm3329760plo.297.2023.04.14.11.58.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Apr 2023 11:58:41 -0700 (PDT) From: "Tuan Phan" To: devel@edk2.groups.io Cc: michael.d.kinney@intel.com, gaoliming@byosoft.com.cn, zhiguang.liu@intel.com, sunilvl@ventanamicro.com, git@danielschaefer.me, andrei.warkentin@intel.com, Tuan Phan Subject: [edk2-devel] [PATCH v2 5/6] OvmfPkg/VirtNorFlashDxe: Not add memory space if it exists Date: Fri, 14 Apr 2023 11:58:14 -0700 Message-Id: <20230414185815.2994-6-tphan@ventanamicro.com> In-Reply-To: <20230414185815.2994-1-tphan@ventanamicro.com> References: <20230414185815.2994-1-tphan@ventanamicro.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,tphan@ventanamicro.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1681498723; bh=DOn36mgWmy7dt/jlcNeAOmVC7+2f9X8+nXuvBdedQq8=; h=Cc:Date:From:Reply-To:Subject:To; b=Qesmc7Ism1MmjyJjgVbwsVgu4ScPUKmZ7LmzWukUSPcCKJg4bPr34LgAUyTesKBek/y SIkqM9yFVQCl9QwEg16fd908mEhML3Dr7daaWflXXMxicuFAYOc3NwOejO6woAVLyQcGe YcxIWj3szaTUnuWcOf0Pm3+YSZuDYZl7bxM= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1681498725421100025 Content-Type: text/plain; charset="utf-8" The flash base address can be added to GCD before this driver run. So only add it if it has not been done. Signed-off-by: Tuan Phan --- OvmfPkg/VirtNorFlashDxe/VirtNorFlashDxe.c | 25 +++++++++++++++-------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/OvmfPkg/VirtNorFlashDxe/VirtNorFlashDxe.c b/OvmfPkg/VirtNorFla= shDxe/VirtNorFlashDxe.c index 6b9ef261335e..bbd1697a51dd 100644 --- a/OvmfPkg/VirtNorFlashDxe/VirtNorFlashDxe.c +++ b/OvmfPkg/VirtNorFlashDxe/VirtNorFlashDxe.c @@ -372,10 +372,11 @@ NorFlashFvbInitialize ( IN NOR_FLASH_INSTANCE *Instance ) { - EFI_STATUS Status; - UINT32 FvbNumLba; - EFI_BOOT_MODE BootMode; - UINTN RuntimeMmioRegionSize; + EFI_STATUS Status; + UINT32 FvbNumLba; + EFI_BOOT_MODE BootMode; + UINTN RuntimeMmioRegionSize; + EFI_GCD_MEMORY_SPACE_DESCRIPTOR Desc; =20 DEBUG ((DEBUG_BLKIO, "NorFlashFvbInitialize\n")); ASSERT ((Instance !=3D NULL)); @@ -390,13 +391,19 @@ NorFlashFvbInitialize ( // is written as the base of the flash region (ie: Instance->Devic= eBaseAddress) RuntimeMmioRegionSize =3D (Instance->RegionBaseAddress - Instance->Devic= eBaseAddress) + Instance->Size; =20 - Status =3D gDS->AddMemorySpace ( - EfiGcdMemoryTypeMemoryMappedIo, + Status =3D gDS->GetMemorySpaceDescriptor ( Instance->DeviceBaseAddress, - RuntimeMmioRegionSize, - EFI_MEMORY_UC | EFI_MEMORY_RUNTIME + &Desc ); - ASSERT_EFI_ERROR (Status); + if (Status =3D=3D EFI_NOT_FOUND) { + Status =3D gDS->AddMemorySpace ( + EfiGcdMemoryTypeMemoryMappedIo, + Instance->DeviceBaseAddress, + RuntimeMmioRegionSize, + EFI_MEMORY_UC | EFI_MEMORY_RUNTIME + ); + ASSERT_EFI_ERROR (Status); + } =20 Status =3D gDS->SetMemorySpaceAttributes ( Instance->DeviceBaseAddress, --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103020): https://edk2.groups.io/g/devel/message/103020 Mute This Topic: https://groups.io/mt/98269078/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-