From nobody Tue Feb 10 12:42:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+102645+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+102645+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1680819870; cv=none; d=zohomail.com; s=zohoarc; b=F4ljx1eUNpYRp66zrj32Gs/gAjhlVrq58o5ms64KqwaBYW5Re8+qZVaSfp8YNadg9g9moYvfzMcqyMRTtvyT6XBNf85UHa2gWMdhtEiNsOmBdyGpvrrzDwISa9FvcEd/yI7+2Qc4BHLff4cEugJx6Gnd7XOjqUzjfmTSaNZpuGA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680819870; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=2db7VhyM6k31hduWcQgzMiDxmsx/5IriUIVS3/jkcug=; b=jBmETKIHrAMrBiwNvzI81D01lMRQbSthjYm9bXWnpLTr/E07N9nW4zD7Jm3pIGhSo3O1gPiEqTVzGZ5J4Hz1KXWMyntrCcmHxJv703fpQpEucXcq80pMWCWUv0c6I9CXdpASLHg4zAY2FjZLnTHo8YPNCUXsuMPaGSiRUFhiPs0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+102645+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1680819870603440.8447434319406; Thu, 6 Apr 2023 15:24:30 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id inM4YY1788612xlGYAPciBxY; Thu, 06 Apr 2023 15:24:30 -0700 X-Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mx.groups.io with SMTP id smtpd.web11.171757.1680819869645128276 for ; Thu, 06 Apr 2023 15:24:29 -0700 X-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id EF2F45C0107; Thu, 6 Apr 2023 18:24:28 -0400 (EDT) X-Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 06 Apr 2023 18:24:28 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdejgedgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomheptfgvsggv tggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrfgrth htvghrnhepgeffueeuledvgefgvddvgfetvdduhfefkedukeeikedtudekfeetteeifedv leefnecuvehluhhsthgvrhfuihiivgepfeenucfrrghrrghmpehmrghilhhfrhhomheprh gvsggvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail X-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 6 Apr 2023 18:24:25 -0400 (EDT) From: "Rebecca Cran" To: devel@edk2.groups.io, Liming Gao , Michael D Kinney , Guomin Jiang , Wei6 Xu , Guo Dong , Ray Ni , Sean Rhodes , James Lu , Gua Guo , Andrew Fish , Hao A Wu , Maciej Rabeda , Siyuan Fu , Jiewen Yao , Jian J Wang , Xiaoyu Lu , Ard Biesheuvel , Sami Mujawar , Supreeth Venkatesh , Michael Kubacki , Nate DeSimone , Sean Brogan Cc: Rebecca Cran , Leif Lindholm , Abner Chang , Nickle Wang , Igor Kulchytskyy , Daniel Schaefer , Min Xu , Jordan Justen , Gerd Hoffmann , Peter Grehan , Erdem Aktas , James Bottomley , Tom Lendacky , Michael Roth , Sunil V L , Andrei Warkentin Subject: [edk2-devel] [PATCH 15/18] SourceLevelDebugPkg: Update code to be more C11 compliant by using __func__ Date: Thu, 6 Apr 2023 16:23:16 -0600 Message-Id: <20230406222319.2281263-16-rebecca@bsdio.com> In-Reply-To: <20230406222319.2281263-1-rebecca@bsdio.com> References: <20230406222319.2281263-1-rebecca@bsdio.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@bsdio.com X-Gm-Message-State: OwgAzHnR8hy6XKJyhUvWHeDbx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1680819870; bh=psgPFLi9wvL/dnu0v7IQTMoNia3waRcnqEV6rPCp6IA=; h=Cc:Date:From:Reply-To:Subject:To; b=EqnRcYcZwgFw0V4X5W4c64aNO2vdR041kcwgwCD6BUJIzTBHpOzYm4PVEppUdI3Prdn X7Vv/5i78J9JEMrbbDjz3Y8mI7b6KjjkZLkORkFENQ2HLOzDrJo92XuRcyMrXhRRH58En Ezl2W874E7lTGCvWqEVDKaeKhVvQuepCy+Y= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1680819871333100001 Content-Type: text/plain; charset="utf-8" __FUNCTION__ is a pre-standard extension that gcc and Visual C++ among others support, while __func__ was standardized in C99. Since it's more standard, replace __FUNCTION__ with __func__ throughout SourceLevelDebugPkg. Visual Studio versions before VS 2015 don't support __func__ and so will fail to compile. A workaround is to define __func__ as __FUNCTION__ : #define __func__ __FUNCTION__ Signed-off-by: Rebecca Cran Reviewed-by: Ray Ni --- SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLi= bUsb3Dxe.c | 4 ++-- SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLi= bUsb3Pei.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom= municationLibUsb3Dxe.c b/SourceLevelDebugPkg/Library/DebugCommunicationLibU= sb3/DebugCommunicationLibUsb3Dxe.c index 4490526273c9..d37fb991f1f2 100644 --- a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicat= ionLibUsb3Dxe.c +++ b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicat= ionLibUsb3Dxe.c @@ -186,7 +186,7 @@ Usb3DxeSmmReadyToLockNotify ( { USB3_DEBUG_PORT_HANDLE *Instance; =20 - DEBUG ((DEBUG_INFO, "%a()\n", __FUNCTION__)); + DEBUG ((DEBUG_INFO, "%a()\n", __func__)); =20 Instance =3D GetUsb3DebugPortInstance (); ASSERT (Instance !=3D NULL); @@ -290,7 +290,7 @@ Usb3PciIoNotify ( // // Found the PciIo for USB3 debug port. // - DEBUG ((DEBUG_INFO, "%a()\n", __FUNCTION__)); + DEBUG ((DEBUG_INFO, "%a()\n", __func__)); if (Usb3GetIoMmu () !=3D NULL) { Instance =3D GetUsb3DebugPortInstance (); ASSERT (Instance !=3D NULL); diff --git a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom= municationLibUsb3Pei.c b/SourceLevelDebugPkg/Library/DebugCommunicationLibU= sb3/DebugCommunicationLibUsb3Pei.c index 15842a317ef0..aa04442918d2 100644 --- a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicat= ionLibUsb3Pei.c +++ b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicat= ionLibUsb3Pei.c @@ -35,7 +35,7 @@ Usb3IoMmuPpiNotify ( { USB3_DEBUG_PORT_HANDLE *Instance; =20 - DEBUG ((DEBUG_INFO, "%a()\n", __FUNCTION__)); + DEBUG ((DEBUG_INFO, "%a()\n", __func__)); =20 Instance =3D GetUsb3DebugPortInstance (); ASSERT (Instance !=3D NULL); --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102645): https://edk2.groups.io/g/devel/message/102645 Mute This Topic: https://groups.io/mt/98115253/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-