From nobody Sun Feb 8 17:48:17 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+102417+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1680534328803206.07710018655143; Mon, 3 Apr 2023 08:05:28 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id jd8tYY1788612x01vWjrr1fp; Mon, 03 Apr 2023 08:05:28 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.66]) by mx.groups.io with SMTP id smtpd.web11.73092.1680534327632874928 for ; Mon, 03 Apr 2023 08:05:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ExUA5juiVlCD2Go+nMrC4ckooS4da/40nj6nN9JzB8I4Zc7e/O/bwsXsBZNel1rKH8fhNlPzDYp5yyFYjn1IhDBk1oPBdmCGOrOyrZpy4XngN5HdnBAxVLWRIBrILR9xbvzD6C9sqfA3H/QZX/A1K5EMGOVACeMh+PZPx3SFcTigXPhbnbvrzwt9yh1gLWrPbs33hXIrux5HzI7iY6iF7i5I+whq4kLGQGJbe5sDQ2MvJYzIaQ4+V9K6oj4HZvgfKQtZSGq5NGzIWCsqcmsyZmzEEmSU5GLoCtHejHQJDtWDX2OKIlcqTLvA4Gb4St7K6VbQJld1F0HmEMj1zskkkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qZWKFSfyjVjghezohYozI7gB676aHTgZTU4rz4q9bDM=; b=WbrBEMs+YUWkqDfVBFVNxyen4d22GRtag7qb4U4s8Mz8j3vvx87Ag2LtSDucqtW3YACvvEoyw0KxJmBnCApcxjrLfBfoCCt55Ofm84ojVuMrPmAFz3K9EaDpuwD1b+uo8B2uMUcJzEDzPjTfnz84KGhZnU/f10FcDoSy3TcwXvRowDmakgugO/V4Cfvwz6DUH3X9Ibg2DlJdVHxHQVPegfAYrUObGfmYB84b5I3UW0KWIsl7h7RsfNx5XHo86hQYdh/13b7/i32k/5o7XMveoT2ciOnn5kiWY1Lso685QRcZCs+ygp0/wvoUzY3gUjtkBzxFcLP3wCwrdyopAwPuJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none X-Received: from DM6PR07CA0074.namprd07.prod.outlook.com (2603:10b6:5:337::7) by PH7PR12MB5734.namprd12.prod.outlook.com (2603:10b6:510:1e1::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 15:05:25 +0000 X-Received: from DM6NAM11FT068.eop-nam11.prod.protection.outlook.com (2603:10b6:5:337::4) by DM6PR07CA0074.outlook.office365.com (2603:10b6:5:337::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.22 via Frontend Transport; Mon, 3 Apr 2023 15:05:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+102417+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT068.mail.protection.outlook.com (10.13.173.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6277.16 via Frontend Transport; Mon, 3 Apr 2023 15:05:24 +0000 X-Received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 3 Apr 2023 10:05:22 -0500 From: "Chang, Abner via groups.io" To: CC: Isaac Oram , Abdul Lateef Attar , Nickle Wang , Igor Kulchytskyy Subject: [edk2-devel] [edk2-platforms][PATCH 03/14] ManageabilityPkg: Fix Uncrustify errors Date: Mon, 3 Apr 2023 23:04:48 +0800 Message-ID: <20230403150459.925-4-abner.chang@amd.com> In-Reply-To: <20230403150459.925-1-abner.chang@amd.com> References: <20230403150459.925-1-abner.chang@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT068:EE_|PH7PR12MB5734:EE_ X-MS-Office365-Filtering-Correlation-Id: 15ba87e3-595b-4de3-b816-08db3454da51 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: dQikYvHsYLEh0OlCnWA5acFW0D5VmIhYy+NDLBd/czJOHAtpklJHV+9JhhZiX3xpT2eK1zNL/Mk1N/pzaT9kLV2aUVC7Ytkyk7POydwDhNHZfsxAKaX4Ju0B0Xj3oXT6cW0ARoDUYysNzUWIgyNGXGmItfTZJFzLZ1SgZUxM5Xbavh8iG1z6w+QJ1VBVmeHGpDCgMqLmyAPqYvkOzVu0suOWWOcNZnQTcM8kniOp62TfMtyXKCDhBY+CqSuMgJWytxuH1uBOl4b1z3uzP3A8AFCj09nHNUNIxVri/ZCSH4l5w7x8B2Kh/TOeYHm//Jeyjeve1NEvz6nR0kg5VZeRLE9ABbn3wgb7GmKeGT4cThXNqTVo5j4ncjvLnfDPC37OS+pMmaf+Hz5HSpxf0Pvx+qieW7ig2+51u1a+dhyq7W5BVKYZkbt7OLRruqbT0s3SckAXrdsZXOYSAtMFBl/6PYijorO85cFmqQGOu6LmeIV9RA1akNmac/ylZ+Lw1xGYWib9HJXNQyt7R7gNdvNa4+LU2YfKJYgH2qaJOfAyFUgUY/85kHkPM+SUtkIqlP1z2vV/lomSESViVWFF3QsORQVK9/QY66BFUFV1EUzTH0P3QQ2QDJGXQSVU2n+/p6r2Ek4o34qgKlKNspTREXQHrDXLAX4ys9koKSxH8pPICUsPKl1fR7YNGlawX6aXMAjX6fCf0MqoVfQMNdn2wBoLSEygryIUYAOzp4+07F5/UJFmXEjMzxg+D0Q0XWiYEgiYD6oe1kTLUQiS2V2fE1C+6A== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 15:05:24.7118 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 15ba87e3-595b-4de3-b816-08db3454da51 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT068.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5734 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com X-Gm-Message-State: oo02NVS7sQfflvZuOQQtQXAbx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1680534328; bh=Bvr2r0T+cjcNIcAEncrUTFmK80yFG90/TNosIHwy5wM=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=MHD7R8cvvJ2cm+Xm/YoSwtpBPGlXroqICy9ZiBtJd+8U9s61Nhkx3Jz4KnPQJxMN7d0 QFPBfFxeHxAZwsttXeKxal6s9exMMMABqptWrRU39Lb6JYbOBYumAh/RR917ch458oAvf 7RS6a7c8fXCFwZyaNzDs2+ogiFtjYZ9bdi0= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1680534330099100005 Content-Type: text/plain; charset="utf-8" From: Abner Chang Fix Uncrustify errors of IPMI protocol and KCS manageability transport library. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../Library/ManageabilityTransportLib.h | 8 ++-- .../IpmiProtocol/Pei/IpmiPpiInternal.h | 10 ++--- .../Dxe/ManageabilityTransportKcs.c | 6 ++- .../Universal/IpmiProtocol/Dxe/IpmiProtocol.c | 4 +- .../Universal/IpmiProtocol/Pei/IpmiPpi.c | 40 ++++++++++--------- .../Universal/IpmiProtocol/Smm/IpmiProtocol.c | 7 ++-- 6 files changed, 41 insertions(+), 34 deletions(-) diff --git a/Features/ManageabilityPkg/Include/Library/ManageabilityTranspo= rtLib.h b/Features/ManageabilityPkg/Include/Library/ManageabilityTransportL= ib.h index ad6cd1a464..d86d0d87d5 100644 --- a/Features/ManageabilityPkg/Include/Library/ManageabilityTransportLib.h +++ b/Features/ManageabilityPkg/Include/Library/ManageabilityTransportLib.h @@ -74,13 +74,13 @@ typedef UINT32 MANAGEABILITY_TRANSPORT_CAPABILITY; /// Bit 0 #define MANAGEABILITY_TRANSPORT_CAPABILITY_MULTIPLE_TRANSFER_TOKENS 0x000= 00001 /// Bit 1 -#define MANAGEABILITY_TRANSPORT_CAPABILITY_ASYNCHRONOUS_TRANSFER 0x000= 00002 +#define MANAGEABILITY_TRANSPORT_CAPABILITY_ASYNCHRONOUS_TRANSFER 0x000000= 02 /// Bit 2 - Reserved /// Bit 7:3 - Transport interface maximum payload size, which is (2 ^ bit[= 7:3] - 1) /// bit[7:3] means no maximum payload. -#define MANAGEABILITY_TRANSPORT_CAPABILITY_MAXIMUM_PAYLOAD_MASK 0= x000000f8 -#define MANAGEABILITY_TRANSPORT_CAPABILITY_MAXIMUM_PAYLOAD_BIT_POSITION 3 - #define MANAGEABILITY_TRANSPORT_CAPABILITY_MAXIMUM_PAYLOAD_NOT_AVAILABLE= 0x00 +#define MANAGEABILITY_TRANSPORT_CAPABILITY_MAXIMUM_PAYLOAD_MASK = 0x000000f8 +#define MANAGEABILITY_TRANSPORT_CAPABILITY_MAXIMUM_PAYLOAD_BIT_POSITION 3 +#define MANAGEABILITY_TRANSPORT_CAPABILITY_MAXIMUM_PAYLOAD_NOT_AVAILABLE = 0x00 /// Bit 8:31 - Reserved =20 /// diff --git a/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiIn= ternal.h b/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiInte= rnal.h index 7b6ab0f529..4b6bdc97a9 100644 --- a/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiInternal.h +++ b/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiInternal.h @@ -17,11 +17,11 @@ #define MANAGEABILITY_IPMI_PPI_INTERNAL_FROM_LINK(a) CR (a, PEI_IPMI_PPI_= INTERNAL, PeiIpmiPpi, MANAGEABILITY_IPMI_PPI_INTERNAL_SIGNATURE) =20 typedef struct { - UINT32 Signature; - MANAGEABILITY_TRANSPORT_TOKEN *TransportToken; - MANAGEABILITY_TRANSPORT_CAPABILITY TransportCapability; - UINT32 TransportMaximumPayload; - PEI_IPMI_PPI PeiIpmiPpi; + UINT32 Signature; + MANAGEABILITY_TRANSPORT_TOKEN *TransportToken; + MANAGEABILITY_TRANSPORT_CAPABILITY TransportCapability; + UINT32 TransportMaximumPayload; + PEI_IPMI_PPI PeiIpmiPpi; } PEI_IPMI_PPI_INTERNAL; =20 #endif // MANAGEABILITY_IPMI_PPI_INTERNAL_H_ diff --git a/Features/ManageabilityPkg/Library/ManageabilityTransportKcsLib= /Dxe/ManageabilityTransportKcs.c b/Features/ManageabilityPkg/Library/Manage= abilityTransportKcsLib/Dxe/ManageabilityTransportKcs.c index 25d6e49886..91d3517bdb 100644 --- a/Features/ManageabilityPkg/Library/ManageabilityTransportKcsLib/Dxe/Ma= nageabilityTransportKcs.c +++ b/Features/ManageabilityPkg/Library/ManageabilityTransportKcsLib/Dxe/Ma= nageabilityTransportKcs.c @@ -221,7 +221,7 @@ KcsTransportTransmitReceive ( EFI_STATUS Status; MANAGEABILITY_IPMI_TRANSPORT_HEADER *TransmitHeader; =20 - if (TransportToken =3D=3D NULL || TransferToken =3D=3D NULL) { + if ((TransportToken =3D=3D NULL) || (TransferToken =3D=3D NULL)) { DEBUG ((DEBUG_ERROR, "%a: Invalid transport token or transfer token.\n= ", __FUNCTION__)); return; } @@ -298,6 +298,7 @@ AcquireTransportSession ( DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for MANAGEABILITY_TR= ANSPORT_KCS\n", __FUNCTION__)); return EFI_OUT_OF_RESOURCES; } + KcsTransportToken->Token.Transport =3D AllocateZeroPool (sizeof (MANAGEA= BILITY_TRANSPORT)); if (KcsTransportToken->Token.Transport =3D=3D NULL) { FreePool (KcsTransportToken); @@ -346,9 +347,10 @@ GetTransportCapability ( OUT MANAGEABILITY_TRANSPORT_CAPABILITY *TransportCapability ) { - if (TransportToken =3D=3D NULL || TransportCapability =3D=3D NULL) { + if ((TransportToken =3D=3D NULL) || (TransportCapability =3D=3D NULL)) { return EFI_INVALID_PARAMETER; } + *TransportCapability =3D 0; return EFI_SUCCESS; } diff --git a/Features/ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProto= col.c b/Features/ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocol.c index c30132419d..40587a07af 100644 --- a/Features/ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocol.c +++ b/Features/ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocol.c @@ -100,12 +100,14 @@ DxeIpmiEntry ( DEBUG ((DEBUG_ERROR, "%a: Failed to acquire transport interface for IP= MI protocol - %r\n", __FUNCTION__, Status)); return Status; } + Status =3D GetTransportCapability (mTransportToken, &TransportCapability= ); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "%a: Failed to GetTransportCapability().\n", __FU= NCTION__)); return Status; } - TransportMaximumPayload =3D MANAGEABILITY_TRANSPORT_PAYLOAD_SIZE_FROM_CA= PABILITY(TransportCapability); + + TransportMaximumPayload =3D MANAGEABILITY_TRANSPORT_PAYLOAD_SIZE_FROM_CA= PABILITY (TransportCapability); if (TransportMaximumPayload =3D=3D (1 << MANAGEABILITY_TRANSPORT_CAPABIL= ITY_MAXIMUM_PAYLOAD_NOT_AVAILABLE)) { DEBUG ((DEBUG_INFO, "%a: Transport interface maximum payload is undefi= ned.\n", __FUNCTION__)); } else { diff --git a/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpi.c= b/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpi.c index 0dda6d2d47..0a914e513c 100644 --- a/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpi.c +++ b/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpi.c @@ -51,19 +51,19 @@ PeiIpmiSubmitCommand ( IN OUT UINT32 *ResponseDataSize ) { - EFI_STATUS Status; - PEI_IPMI_PPI_INTERNAL *PeiIpmiPpiinternal; - - PeiIpmiPpiinternal =3D MANAGEABILITY_IPMI_PPI_INTERNAL_FROM_LINK(This); - Status =3D CommonIpmiSubmitCommand ( - PeiIpmiPpiinternal->TransportToken, - NetFunction, - Command, - RequestData, - RequestDataSize, - ResponseData, - ResponseDataSize - ); + EFI_STATUS Status; + PEI_IPMI_PPI_INTERNAL *PeiIpmiPpiinternal; + + PeiIpmiPpiinternal =3D MANAGEABILITY_IPMI_PPI_INTERNAL_FROM_LINK (This); + Status =3D CommonIpmiSubmitCommand ( + PeiIpmiPpiinternal->TransportToken, + NetFunction, + Command, + RequestData, + RequestDataSize, + ResponseData, + ResponseDataSize + ); return Status; } =20 @@ -90,18 +90,19 @@ PeiIpmiEntry ( MANAGEABILITY_TRANSPORT_ADDITIONAL_STATUS TransportAdditionalStatus; MANAGEABILITY_TRANSPORT_HARDWARE_INFORMATION HardwareInformation; =20 - PeiIpmiPpiinternal =3D (PEI_IPMI_PPI_INTERNAL *)AllocateZeroPool (sizeof= (PEI_IPMI_PPI_INTERNAL)); + PeiIpmiPpiinternal =3D (PEI_IPMI_PPI_INTERNAL *)AllocateZeroPool (sizeof= (PEI_IPMI_PPI_INTERNAL)); if (PeiIpmiPpiinternal =3D=3D NULL) { DEBUG ((DEBUG_ERROR, "%a: Not enough memory for PEI_IPMI_PPI_INTERNAL.= \n", __FUNCTION__)); return EFI_OUT_OF_RESOURCES; } - PpiDescriptor =3D (EFI_PEI_PPI_DESCRIPTOR *)AllocateZeroPool (sizeof(EFI= _PEI_PPI_DESCRIPTOR)); + + PpiDescriptor =3D (EFI_PEI_PPI_DESCRIPTOR *)AllocateZeroPool (sizeof (EF= I_PEI_PPI_DESCRIPTOR)); if (PpiDescriptor =3D=3D NULL) { DEBUG ((DEBUG_ERROR, "%a: Not enough memory for EFI_PEI_PPI_DESCRIPTOR= .\n", __FUNCTION__)); return EFI_OUT_OF_RESOURCES; } =20 - PeiIpmiPpiinternal->Signature =3D MANAGEABILITY_IPMI_PPI_INTERNAL_SIGNAT= URE; + PeiIpmiPpiinternal->Signature =3D MANAGEABILITY_IPMI_= PPI_INTERNAL_SIGNATURE; PeiIpmiPpiinternal->PeiIpmiPpi.IpmiSubmitCommand =3D PeiIpmiSubmitComman= d; =20 PpiDescriptor->Flags =3D EFI_PEI_PPI_DESCRIPTOR_PPI | EFI_PEI_PPI_DESCRI= PTOR_TERMINATE_LIST; @@ -116,18 +117,19 @@ PeiIpmiEntry ( DEBUG ((DEBUG_ERROR, "%a: Failed to acquire transport interface for IP= MI protocol - %r\n", __FUNCTION__, Status)); return Status; } + Status =3D GetTransportCapability (PeiIpmiPpiinternal->TransportToken, &= PeiIpmiPpiinternal->TransportCapability); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "%a: Failed to GetTransportCapability().\n", __FU= NCTION__)); return Status; } =20 - PeiIpmiPpiinternal->TransportMaximumPayload =3D MANAGEABILITY_TRANSPORT_= PAYLOAD_SIZE_FROM_CAPABILITY(PeiIpmiPpiinternal->TransportCapability); + PeiIpmiPpiinternal->TransportMaximumPayload =3D MANAGEABILITY_TRANSPORT_= PAYLOAD_SIZE_FROM_CAPABILITY (PeiIpmiPpiinternal->TransportCapability); if (PeiIpmiPpiinternal->TransportMaximumPayload =3D=3D (1 << MANAGEABIL= ITY_TRANSPORT_CAPABILITY_MAXIMUM_PAYLOAD_NOT_AVAILABLE)) { - DEBUG((DEBUG_INFO, "%a: Transport interface maximum payload is undefin= ed.\n", __FUNCTION__)); + DEBUG ((DEBUG_INFO, "%a: Transport interface maximum payload is undefi= ned.\n", __FUNCTION__)); } else { PeiIpmiPpiinternal->TransportMaximumPayload -=3D 1; - DEBUG((DEBUG_INFO, "%a: Transport interface for IPMI protocol has maxi= mum payload 0x%x.\n", __FUNCTION__, PeiIpmiPpiinternal->TransportMaximumPay= load)); + DEBUG ((DEBUG_INFO, "%a: Transport interface for IPMI protocol has max= imum payload 0x%x.\n", __FUNCTION__, PeiIpmiPpiinternal->TransportMaximumPa= yload)); } =20 TransportName =3D HelperManageabilitySpecName (PeiIpmiPpiinternal->Trans= portToken->Transport->ManageabilityTransportSpecification); diff --git a/Features/ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProto= col.c b/Features/ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocol.c index 86dee2fa24..41b9a10453 100644 --- a/Features/ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocol.c +++ b/Features/ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocol.c @@ -107,12 +107,13 @@ SmmIpmiEntry ( DEBUG ((DEBUG_ERROR, "%a: Failed to GetTransportCapability().\n", __FU= NCTION__)); return Status; } - TransportMaximumPayload =3D MANAGEABILITY_TRANSPORT_PAYLOAD_SIZE_FROM_CA= PABILITY(TransportCapability); + + TransportMaximumPayload =3D MANAGEABILITY_TRANSPORT_PAYLOAD_SIZE_FROM_CA= PABILITY (TransportCapability); if (TransportMaximumPayload =3D=3D (1 << MANAGEABILITY_TRANSPORT_CAPABIL= ITY_MAXIMUM_PAYLOAD_NOT_AVAILABLE)) { - DEBUG((DEBUG_INFO, "%a: Transport interface maximum payload is undefin= ed.\n", __FUNCTION__)); + DEBUG ((DEBUG_INFO, "%a: Transport interface maximum payload is undefi= ned.\n", __FUNCTION__)); } else { TransportMaximumPayload -=3D 1; - DEBUG((DEBUG_INFO, "%a: Transport interface for IPMI protocol has maxi= mum payload 0x%x.\n", __FUNCTION__, TransportMaximumPayload)); + DEBUG ((DEBUG_INFO, "%a: Transport interface for IPMI protocol has max= imum payload 0x%x.\n", __FUNCTION__, TransportMaximumPayload)); } =20 mTransportName =3D HelperManageabilitySpecName (mTransportToken->Transpo= rt->ManageabilityTransportSpecification); --=20 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102417): https://edk2.groups.io/g/devel/message/102417 Mute This Topic: https://groups.io/mt/98037367/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-