From nobody Mon Feb 9 01:20:46 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+102260+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+102260+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1680254107; cv=none; d=zohomail.com; s=zohoarc; b=j28tSaT2g4gWZzPFERzUsk6l90BVBMs4NHQKmWXQipGIdS0ytzyVymgBaPPZBLMdsShfK5DZGQr4Lrk4DNazS12ef98qUo7qpyUlZQlHZjrj/boQioYrBcFQu53vFR9hfAVcArEvx2XJdpPPxGrXwpLeF1ZzplJZOqOJP5eHpU0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680254107; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=fLTvmF6hdMW6s5iBuRZgxmdIz6B96BVrx7o6rFGppi0=; b=nM2GPN9syFAn1dbkI090EWkODJ16xfBG30es4xqooeUAmFs3y4OHzmlnXmgmhIwH3fjpqDp+hO4hcCrwU8kEaIWFgCAQJb/wxgvI3L8lPYCSYxAQ/pY8HwZw2BMEjI1HMc7Oz3FH81pmsZ2tyRIhHtWa3kT4nG8+Iv+NyMzzwgE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+102260+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1680254107719308.98084111989726; Fri, 31 Mar 2023 02:15:07 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id xE1hYY1788612xIXyPtPJ9gA; Fri, 31 Mar 2023 02:15:07 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.50324.1680254101544201612 for ; Fri, 31 Mar 2023 02:15:01 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 11CF562581; Fri, 31 Mar 2023 09:15:01 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88148C4339C; Fri, 31 Mar 2023 09:14:58 +0000 (UTC) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: Ard Biesheuvel , "Ni, Ray" , Andrew Fish , "Kinney, Michael D" , "Liu, Zhiguang" , Rebecca Cran , Tom Lendacky , =?UTF-8?q?Marvin=20H=C3=A4user?= Subject: [edk2-devel] [RFT PATCH v3 5/5] UefiCpuPkg/CpuExceptionHandlerLib: Drop special XCODE5 version Date: Fri, 31 Mar 2023 11:14:37 +0200 Message-Id: <20230331091437.1593337-6-ardb@kernel.org> In-Reply-To: <20230331091437.1593337-1-ardb@kernel.org> References: <20230331091437.1593337-1-ardb@kernel.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org X-Gm-Message-State: NYa5RXInD7bOZraf4p2Amvhux1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1680254107; bh=FWVjwL69lK/nu4Van3E3+iHQ+3zMgREv+lQAX1AB3A4=; h=Cc:Date:From:Reply-To:Subject:To; b=wNFqt2cu0KZkZkbcPYS1Pel/Ku9Na0QDrQbgc8NKABV1GiHcMEmkZ4Zurpjl2YmAkLc Aj9V5BlmLRdFhCzbNuqbQUExFfw6VLYlwZEmDjNthL3zSlU3717xaRJn2CW0QiXvd7yZm rzFcGuwKtGMfVshtFuK0DutodZDFe+Q/TaU= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1680254109050100001 Content-Type: text/plain; charset="utf-8" This library is no longer used or needed, so let's remove it. Signed-off-by: Ard Biesheuvel Reviewed-by: Ray Ni --- UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandlerL= ib.inf | 67 -------------------- UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandlerL= ib.uni | 18 ------ UefiCpuPkg/UefiCpuPkg.dsc = | 7 -- 3 files changed, 92 deletions(-) diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExcep= tionHandlerLib.inf b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPei= CpuExceptionHandlerLib.inf deleted file mode 100644 index 17f872bb15eb0ff7..0000000000000000 --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHan= dlerLib.inf +++ /dev/null @@ -1,67 +0,0 @@ -## @file -# CPU Exception Handler library instance for SEC/PEI modules. -# -# Copyright (C) 2020, Advanced Micro Devices, Inc. All rights reserved. -# Copyright (c) 2012 - 2022, Intel Corporation. All rights reserved.
-# SPDX-License-Identifier: BSD-2-Clause-Patent -# -# This is the XCODE5 variant of the SEC/PEI CpuExceptionHandlerLib. This -# variant performs binary patching to fix up addresses that allow the -# XCODE5 toolchain to be used. -# -## - -[Defines] - INF_VERSION =3D 0x00010005 - BASE_NAME =3D Xcode5SecPeiCpuExceptionHandlerLib - MODULE_UNI_FILE =3D Xcode5SecPeiCpuExceptionHandlerLib.uni - FILE_GUID =3D 49C481AF-1621-42F3-8FA1-27C64143E304 - MODULE_TYPE =3D PEIM - VERSION_STRING =3D 1.1 - LIBRARY_CLASS =3D CpuExceptionHandlerLib|SEC PEI_CORE P= EIM - -# -# The following information is for reference only and not required by the = build tools. -# -# VALID_ARCHITECTURES =3D IA32 X64 -# - -[Sources.Ia32] - Ia32/ExceptionHandlerAsm.nasm - Ia32/ExceptionTssEntryAsm.nasm - Ia32/ArchExceptionHandler.c - Ia32/ArchInterruptDefs.h - -[Sources.X64] - X64/SecPeiExceptionHandlerAsm.nasm - X64/ArchExceptionHandler.c - X64/ArchInterruptDefs.h - -[Sources.common] - CpuExceptionCommon.h - CpuExceptionCommon.c - SecPeiCpuException.c - -[Packages] - MdePkg/MdePkg.dec - MdeModulePkg/MdeModulePkg.dec - UefiCpuPkg/UefiCpuPkg.dec - -[LibraryClasses] - BaseLib - SerialPortLib - PrintLib - LocalApicLib - PeCoffGetEntryPointLib - CcExitLib - -[Pcd] - gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard - gUefiCpuPkgTokenSpaceGuid.PcdCpuStackSwitchExceptionList - gUefiCpuPkgTokenSpaceGuid.PcdCpuKnownGoodStackSize - -[FeaturePcd] - gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmStackGuard ## CONS= UMES - -[BuildOptions] - XCODE:*_*_X64_PP_FLAGS =3D -DNO_ABSOLUTE_RELOCS_IN_TEXT diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExcep= tionHandlerLib.uni b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPei= CpuExceptionHandlerLib.uni deleted file mode 100644 index a63b25f39d992775..0000000000000000 --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHan= dlerLib.uni +++ /dev/null @@ -1,18 +0,0 @@ -// /** @file -// XCODE5 CPU Exception Handler library instance for SEC/PEI modules. -// -// CPU Exception Handler library instance for SEC/PEI modules when built -// using the XCODE5 toolchain. -// -// Copyright (C) 2020, Advanced Micro Devices, Inc. All rights reserved. -// Copyright (c) 2012 - 2014, Intel Corporation. All rights reserved.
-// -// SPDX-License-Identifier: BSD-2-Clause-Patent -// -// **/ - - -#string STR_MODULE_ABSTRACT #language en-US "CPU Exception Han= dler library instance for SEC/PEI modules with the XCODE5 toolchain." - -#string STR_MODULE_DESCRIPTION #language en-US "CPU Exception Han= dler library instance for SEC/PEI modules with the XCODE5 toolchain." - diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc index a7318d3fe9db0ec4..d85d56916f2cdbce 100644 --- a/UefiCpuPkg/UefiCpuPkg.dsc +++ b/UefiCpuPkg/UefiCpuPkg.dsc @@ -69,11 +69,7 @@ [LibraryClasses] =20 [LibraryClasses.common.SEC] PlatformSecLib|UefiCpuPkg/Library/PlatformSecLibNull/PlatformSecLibNull.= inf -!if $(TOOL_CHAIN_TAG) =3D=3D "XCODE5" - CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5S= ecPeiCpuExceptionHandlerLib.inf -!else CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiC= puExceptionHandlerLib.inf -!endif HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/= PeiServicesTablePointerLibIdt.inf MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAlloc= ationLib.inf @@ -145,12 +141,9 @@ [Components.IA32, Components.X64] UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandlerLib.inf -!if $(TOOL_CHAIN_TAG) !=3D "XCODE5" UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLib.i= nf -!endif UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.inf UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandlerLib.inf - UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandle= rLib.inf UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.inf --=20 2.39.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102260): https://edk2.groups.io/g/devel/message/102260 Mute This Topic: https://groups.io/mt/97969653/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-