From nobody Wed Dec 17 05:44:49 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+101998+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+101998+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1679971460; cv=none; d=zohomail.com; s=zohoarc; b=HCGA/JQZdjdOzmpwO+2dYWkooJ5oIvq7Fmq202Oc81bHBkBi1MsiUw3gYzCscHHSsAPvmhr8BP6nH8rHTT8VrO2emioY5D+3gFCaOWQy5IDAmxvDz6Gg5wOtgAfy02f2Pzft+9ZIrYNt8Yq21j3fP2VoKQbF06eAE5zzsTzvD7A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679971460; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=IhjMEyM6nB1zFDm8ramjBWdUDpE9QgfX6SxyMdHYlPM=; b=gq94hGIjibm/o3l6gUUtjaHloqIpFC9UCQgjNR4A4WxV4aE4KXYnzL01AlzwoVDIbQJ9rqy17NoaBAY6ZuidPJWnIuDNq/JEwB4vRjh/aViXEg9PwU1feoJLgr6ELkFlkmK/n/2+hrhcgum5/PncaU/Zu1ip6FaHmXU5k+kyc9E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+101998+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1679971460612945.1417273348764; Mon, 27 Mar 2023 19:44:20 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id Gk4mYY1788612xfMgtpSiCSA; Mon, 27 Mar 2023 19:44:20 -0700 X-Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.57515.1679971455383645096 for ; Mon, 27 Mar 2023 19:44:19 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10662"; a="320852729" X-IronPort-AV: E=Sophos;i="5.98,296,1673942400"; d="scan'208";a="320852729" X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2023 19:44:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10662"; a="807700390" X-IronPort-AV: E=Sophos;i="5.98,296,1673942400"; d="scan'208";a="807700390" X-Received: from shwdeopenlab702.ccr.corp.intel.com ([10.239.55.92]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2023 19:44:18 -0700 From: "duntan" To: devel@edk2.groups.io Cc: Dandan Bi , Liming Gao , Ray Ni , Jian J Wang Subject: [edk2-devel] [PATCH 8/9] MdeModulePkg/DxeIpl: Remove duplicated code to enable NX Date: Tue, 28 Mar 2023 10:43:01 +0800 Message-Id: <20230328024302.2085-9-dun.tan@intel.com> In-Reply-To: <20230328024302.2085-1-dun.tan@intel.com> References: <20230328024302.2085-1-dun.tan@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,dun.tan@intel.com X-Gm-Message-State: NXDK5S2UuzpPiywu3eF7Y1QFx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1679971460; bh=G4XKx2+FVvS4Mro22yXQIpQa09iP7KkboWAHCqab8Hk=; h=Cc:Date:From:Reply-To:Subject:To; b=rXkEFanxZKZ8OMFDJ3Vu+y8j6v9FQaJmLCp0HiDmiZLbQ1ctAZD3/mOHDp1QQ6551xu BNbN4Xmdppn9nub3/Rs9oSHTCQemN2zD2cMFIzwX09VXIrRgWQNfFk9Jf4q1zasEfvU1L buPd/vndFz3bXtphoYDbGyCvJeCh/AqWQ8s= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1679971460968100030 Content-Type: text/plain; charset="utf-8" In IA32 code, remove the duplicated code to enable NX. In the previous patch, IA32 code also uses the new CreateIdentityMappingPageTables() to create PAE page table. This function calls EnableExecuteDisableBit if needed. Signed-off-by: Dun Tan Cc: Dandan Bi Cc: Liming Gao Cc: Ray Ni Cc: Jian J Wang Reviewed-by: Ray Ni --- MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c b/MdeModulePkg= /Core/DxeIplPeim/Ia32/DxeLoadFunc.c index e0e2601637..4b97e4ea80 100644 --- a/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c +++ b/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c @@ -322,9 +322,6 @@ HandOffToDxeCore ( BuildPageTablesIa32Pae =3D ToBuildPageTable (); if (BuildPageTablesIa32Pae) { PageTables =3D CreateIdentityMappingPageTables (TRUE, BaseOfStack, S= TACK_SIZE, 0, 0); - if (IsEnableNonExecNeeded ()) { - EnableExecuteDisableBit (); - } } =20 // --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101998): https://edk2.groups.io/g/devel/message/101998 Mute This Topic: https://groups.io/mt/97897986/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-