From nobody Fri Oct 18 06:15:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+101826+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+101826+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1679690989; cv=none; d=zohomail.com; s=zohoarc; b=EExtbIFP7L2th26jg/bks9jfFdHWyfE2eJjGxBIzp+BTO0zBkTBN+trwcWR6skTh4GtXL9/WapB8BCC49ZpFxGJdcx3QMEhKyUJpoE28JV4ZZDjaM2Kugj+1VJsoz1AL481BPa986dIn1GFUQmf2EWDL+ssmVeCP3XXiMUkof2g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679690989; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=3oaERa9Ixq2OorpH9eK7bE8UTLQOEA82BCL79HdGG7Y=; b=iVYeiWvlc3FxWYxZNir5rxFNZbfAb9aCuhaZVo5ianpeVHa2731p0RRI0NppqJzw9d+6PJyB7TTZongYrktExccHIQDoJ+kw6DwHWPnK4IdDICNtrhxdbAOulVGjdzSCbl3dFTnyqDNFa5DZJzZYxEqHKPH2EMzInoEZpccG9Go= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+101826+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1679690989558195.21245398258202; Fri, 24 Mar 2023 13:49:49 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id QkDRYY1788612xwTfKp5n7Kq; Fri, 24 Mar 2023 13:49:49 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.8288.1679690983446302671 for ; Fri, 24 Mar 2023 13:49:43 -0700 X-Received: from localhost.localdomain (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id 1A17520FC455; Fri, 24 Mar 2023 13:49:42 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1A17520FC455 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Bob Feng , Liming Gao , Michael D Kinney , Sean Brogan , Yuwei Chen Subject: [edk2-devel] [PATCH v6 02/12] BaseTools/PatchCheck.py: Add PCCTS to tab exemption list Date: Fri, 24 Mar 2023 16:48:28 -0400 Message-Id: <20230324204838.1485-3-mikuback@linux.microsoft.com> In-Reply-To: <20230324204838.1485-1-mikuback@linux.microsoft.com> References: <20230324204838.1485-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: GCAzfiopTbpkl1ClmwhtXMybx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1679690989; bh=uax9j4dk45QnIpd3ppd/V4Z0Xm0ZJ2u3bUUHeiFJhIc=; h=Cc:Date:From:Reply-To:Subject:To; b=hEWeJ3QqWxNsKjLtLJ23+l04KrF/e3/+PfmuIfFGEEttEUFurSDdQpgVxDBhFXwtYcp 8ypIJjYrI+klWVw+y53dcLX7fDka8Ftw9t3jhm821IIRaMmme4T8JhAxxz30bvZkv4SXH AQLkwLCIIRwORnVjJhj+laliMyY+TQihuFU= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1679690991398100005 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki Purdue Compiler Construction Tool Set (PCCTS) source code was copied/ pasted into BaseTools/Source/C/VfrCompile/Pccts/. The code contains tab characters instead of spaces. PatchCheck.py gives an error on modifications to files that contain tabs. This change adds that directory to the pre-existing list of directories in which tab checks are ignored in PatchCheck.py. The goal of my upcoming change there is not to mix tabs and spaces but to fix a bug while preserving its current formatting characters. Cc: Bob Feng Cc: Liming Gao Cc: Michael D Kinney Cc: Sean Brogan Cc: Yuwei Chen Signed-off-by: Michael Kubacki Reviewed-by: Liming Gao Reviewed-by: Michael D Kinney --- BaseTools/Scripts/PatchCheck.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck= .py index fcdabfc8acea..84d56b8c8b70 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -383,7 +383,9 @@ class GitDiffCheck: self.force_crlf =3D False self.force_notabs =3D False if os.path.basename(self.filename) =3D=3D 'GNUmakefile' or= \ - os.path.basename(self.filename) =3D=3D 'Makefile': + os.path.basename(self.filename) =3D=3D 'Makefile' or \ + self.filename.startswith( + 'BaseTools/Source/C/VfrCompile/Pccts/'): self.force_notabs =3D False elif len(line.rstrip()) !=3D 0: self.format_error("didn't find diff command") --=20 2.40.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101826): https://edk2.groups.io/g/devel/message/101826 Mute This Topic: https://groups.io/mt/97832892/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-