From nobody Tue Apr 16 12:47:00 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+101445+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1679321180379292.1637659581037; Mon, 20 Mar 2023 07:06:20 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id nTcaYY1788612xqC9WZuhqXz; Mon, 20 Mar 2023 07:06:20 -0700 X-Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.43]) by mx.groups.io with SMTP id smtpd.web10.14868.1679321179034094316 for ; Mon, 20 Mar 2023 07:06:19 -0700 X-Received: from DB6P192CA0007.EURP192.PROD.OUTLOOK.COM (2603:10a6:4:b8::17) by AM8PR08MB5649.eurprd08.prod.outlook.com (2603:10a6:20b:1dd::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Mon, 20 Mar 2023 14:06:11 +0000 X-Received: from DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:b8:cafe::ce) by DB6P192CA0007.outlook.office365.com (2603:10a6:4:b8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24 via Frontend Transport; Mon, 20 Mar 2023 14:06:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+101445+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT010.mail.protection.outlook.com (100.127.142.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.15 via Frontend Transport; Mon, 20 Mar 2023 14:06:11 +0000 X-Received: ("Tessian outbound cfb430c87a1e:v135"); Mon, 20 Mar 2023 14:06:11 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1ab9294df2e26119 X-CR-MTA-TID: 64aa7808 X-Received: from d432a181079b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7DF6DE3F-C82B-415C-B691-89CD99CA1698.1; Mon, 20 Mar 2023 14:06:04 +0000 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d432a181079b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 20 Mar 2023 14:06:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EH/tlTHmuuZF4EUgwc/lLQSqExQbgiDm89Pt7lVubDFrgkCP/8Bd5VPHWxeFvZDkl8uCr4IrcTSyoPl2gWSChrbB5kjuvizCLOkn+ke46Sk8faQh39cNVY/GC8qSLxCCIN+gcjpl4ePfxd0rM/jufNhCwXazuTProI7/JoBMAfbFzO7rSIEMMi5rdNL+SHecnhVcpjQUBTLUcl9jcKqieOTn+u9SePQeK4rzm8se+95UkZeB/eDkA0SXWMYltVRWEirfKc5e3EIELXbcOzRImL15umhKt/gT4d/+nJFTei1TyB5gE0Q+WJuLcoWA2zqlOM+QHbrIeIaIA8wUNxausQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oAbo7akdRtqoiPB55NeiDvQGeZ/58FjJN+OsYs9xVto=; b=SRtEWAVtcbN9umUIdXJxdiB7f4W/KBgEpoXcMJXOIbnQiNJcIOsebF7ztIH4EFoUcfRjsYGebXfrTL+597KpWI/SkE7jJo8Vb5Bubp3HHYjJlcVmR6XjESoctQ8mINWiV7YJ+RU+AVVLpMsUw9KTcDpF/W/ugKGWo3drEKiQz0KEB4Cy6JTCDuWGt2/NOLLy4KPsyhgeH1p6KFQgTdh40e2/QjRlGQpqoQ087eU4PQzWsW8uK1HJZtvtmaMD5v/SDamMpPp1mdPpSFG7K9/Quk63R6MZmzAy+NKBzuWVTCCATTH3kMYNe513lITD1eFa876NEAjWSnffGCek+G9PnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM6PR10CA0059.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::36) by DBBPR08MB6202.eurprd08.prod.outlook.com (2603:10a6:10:209::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Mon, 20 Mar 2023 14:06:01 +0000 X-Received: from AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:80:cafe::d1) by AM6PR10CA0059.outlook.office365.com (2603:10a6:209:80::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37 via Frontend Transport; Mon, 20 Mar 2023 14:06:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT032.mail.protection.outlook.com (100.127.140.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6222.15 via Frontend Transport; Mon, 20 Mar 2023 14:06:01 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Mon, 20 Mar 2023 14:05:59 +0000 X-Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.17 via Frontend Transport; Mon, 20 Mar 2023 14:05:58 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , Subject: [edk2-devel] [PATCH v1 1/4] DynamicTablesPkg: Reduce log output from TableHelperLib Date: Mon, 20 Mar 2023 14:05:54 +0000 Message-ID: <20230320140557.40348-2-sami.mujawar@arm.com> In-Reply-To: <20230320140557.40348-1-sami.mujawar@arm.com> References: <20230320140557.40348-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT032:EE_|DBBPR08MB6202:EE_|DBAEUR03FT010:EE_|AM8PR08MB5649:EE_ X-MS-Office365-Filtering-Correlation-Id: f4dfc1d3-180a-4b10-b67d-08db294c427d x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: YJcDEfsJwCEBQifjsl1UAoUuX2AYT5tyWKfxzOAJrZBvf31giM5xlTEdPjnwFIzq2ltbj2r/W2v3PbM0mNXutRKLHUFeAOcuXrYWC5H5fwH53ju1VzhLuSqlfwU0obaKBVhbvfFQij8ryDIjaVSdGafaWQ0KnU4Xs1+jMqBSEHPgLXJdPVexhTsiYaMZ2f+J+9gNcmCCLyJmcyi7YbV454GjRObJsEFHDwnNUnNKBgYbOYuV7w/Fgf5YReLhnuysQekww1M4RdM5zD/Ub2WUMVkbf3Xal5+CwmVTCvsL1eLV7TGUtEambUObQatFNzrgbouwyhZ+Lk4wTgNHK/AsoWu78iTGAMAFAyhbl99cjyooo90uTisBEHn1rKug/SnXuAE0Qj7/auFgvkHBh+IhNv/4A8QTES2fZrm1AIgdCjqfc8wlQpdtQsz4iYq782qOtgdZjC+qL81o0qUREIcSUOLtpknXWw1RU+bdlhl5QOgKXwwhCpwUrkth8WmKVEx6EKw6VKjP/CODzcwOMV+Spep3KfUXRzOdUIypkABX4gjou7+2NmWNlVa2/++DAF37BNla95v1k72MldIbVjw1pvwcRey/S82BvuFfOr+3YpPYvh3d83Ih2xTGt+ewUjo5uKNEYvdMOChhKgCNAIbtNBKku+yKEQIEXN4s9oE5ENRUOm+Ei05fnaNHzWa3NyDtMFcZvmu+QWtneG+aCUb0rODBsLRjt3Vqvid9J8Z5Vac= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(396003)(136003)(39860400002)(346002)(376002)(451199018)(36840700001)(40470700004)(46966006)(8936002)(5660300002)(44832011)(36860700001)(41300700001)(82310400005)(86362001)(356005)(40480700001)(36756003)(40460700003)(82740400003)(81166007)(2906002)(4326008)(47076005)(336012)(83380400001)(478600001)(6666004)(426003)(7696005)(2616005)(186003)(1076003)(26005)(54906003)(316002)(8676002)(70586007)(6916009)(70206006)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6202 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bc024961-c317-4b48-143f-08db294c3c8a X-Microsoft-Antispam-Message-Info: HiAap67jo2RnfHg5PsZLdFR4UZ1cnPdWUXfXW0JrNeyYdn5eSy2e1rQmXU5FHKmGGJS1HlSt4fNChMhjuLkrOP1e0qiGqpqE3cbiy09l4GHcqjRETvuqMgbSenQoESCE471fu1WZBiQyx+UcntezCdW/F05M6+Uj/UA+vO7m/iP3CBwq98jRFJBL3HvLyfcDn+RlZILn61wsOBHxxF+55gjJKFdGIPou8V4de2qkZsnqGmBGflR1MlYC/j9jpSh2G5TjiZt8ELshjYTUxnlCJIruQxuae0uH9zUTxJq1GA/Y66QPfj3/wIpnzA4775hR/oO2qlq/bbeICIeuC97miuUJv8cmvgJ3IkDdch7IUSgdoEylmnm3TvmJKRmHSQ+scCbFHG1GhMlm3VCaHDigR3/fc9BfCk5PspgiphqgP2vpNbwWN4HSZeBFcfmiAOq8GZJAz2MY5eKkS6vtTTWlzjjCW2tWh1ncFdeiSPuPoTfyE38dpPFj1nbYLAl2GdU7tYi7F0UEQ2m/VHaYpWNRk0uq+XWSHC1ijvgyhycqtuhaD2BLFNRZizWrS8H6WfkpYuih0yIpfVFtlvpqyCwDX4+QzjZ9LDvCUWzDXq+8H30WAerXwvOzAnqladAIjj5Y8v5hoovgESYwnwkyGGBPIP7r8QLSPGwMAHiql/eRa/gUmZdyHj1ZADHEY6jaQznyy5deFz7OUDo3+U+4CZyrsQ== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 14:06:11.2689 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f4dfc1d3-180a-4b10-b67d-08db294c427d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5649 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: g1EKzEFdyK5lPLHLux730aD5x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1679321180; bh=qiK4h0LAt4GcahjXtwwWIhZzdeX3UQqv+2leKZLWlVM=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=gQ2fm9qHxqcpO6pG5cM+2RRLXK955rFYlj00Eui0Ftr+M3eebGGCJZEzSuFlExePhGd N9ng1Jihfd7rScwDQVOZydy1N6tqc5IUyLQmYvCajRE86dXMjZN/uxPMNGU9smrauaHdH YEfmg0/5a5uNISWYORz6eZDJv0YsfdFOj5E= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1679321182424100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Reduce the log output from Configuration Manager Object Parser in TableHelperLib by enabling the logs only if DEBUG_INFO is enabled. Signed-off-by: Sami Mujawar Reviewed-by: Ard Biesheuvel Reviewed-by: Pierre Gondois --- DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectP= arser.c | 28 ++++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationMa= nagerObjectParser.c b/DynamicTablesPkg/Library/Common/TableHelperLib/Config= urationManagerObjectParser.c index 5e4b88e8cc754ea72157ea4a0c6d0f5b9eae2495..99d6032510a5e912c9189df82c4= d2b4398458d2d 100644 --- a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerOb= jectParser.c +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerOb= jectParser.c @@ -1,7 +1,7 @@ /** @file Configuration Manager Object parser. =20 - Copyright (c) 2021 - 2022, ARM Limited. All rights reserved.
+ Copyright (c) 2021 - 2023, ARM Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -787,7 +787,7 @@ PrintOemId ( ) { DEBUG (( - DEBUG_ERROR, + DEBUG_INFO, (Format !=3D NULL) ? Format : "%C%C%C%C%C%C", Ptr[0], Ptr[1], @@ -855,7 +855,7 @@ PrintCmObjDesc ( *RemainingSize -=3D Parser[Index].Length; if (*RemainingSize < 0) { DEBUG (( - DEBUG_ERROR, + DEBUG_INFO, "\nERROR: %a: Buffer overrun\n", Parser[Index].NameStr )); @@ -865,11 +865,11 @@ PrintCmObjDesc ( =20 // Indentation for (IndentIndex =3D 0; IndentIndex < IndentLevel; IndentIndex++) { - DEBUG ((DEBUG_ERROR, " ")); + DEBUG ((DEBUG_INFO, " ")); } =20 DEBUG (( - DEBUG_ERROR, + DEBUG_INFO, "%-*a :", OUTPUT_FIELD_COLUMN_WIDTH - 2 * IndentLevel, Parser[Index].NameStr @@ -879,20 +879,20 @@ PrintCmObjDesc ( } else if (Parser[Index].Format !=3D NULL) { switch (Parser[Index].Length) { case 1: - DEBUG ((DEBUG_ERROR, Parser[Index].Format, *(UINT8 *)Data)); + DEBUG ((DEBUG_INFO, Parser[Index].Format, *(UINT8 *)Data)); break; case 2: - DEBUG ((DEBUG_ERROR, Parser[Index].Format, *(UINT16 *)Data)); + DEBUG ((DEBUG_INFO, Parser[Index].Format, *(UINT16 *)Data)); break; case 4: - DEBUG ((DEBUG_ERROR, Parser[Index].Format, *(UINT32 *)Data)); + DEBUG ((DEBUG_INFO, Parser[Index].Format, *(UINT32 *)Data)); break; case 8: - DEBUG ((DEBUG_ERROR, Parser[Index].Format, ReadUnaligned64 (Data= ))); + DEBUG ((DEBUG_INFO, Parser[Index].Format, ReadUnaligned64 (Data)= )); break; default: DEBUG (( - DEBUG_ERROR, + DEBUG_INFO, "\nERROR: %a: CANNOT PARSE THIS FIELD, Field Length =3D %d\n", Parser[Index].NameStr, Parser[Index].Length @@ -901,7 +901,7 @@ PrintCmObjDesc ( } else if (Parser[Index].SubObjParser !=3D NULL) { SubStructSize =3D Parser[Index].Length; =20 - DEBUG ((DEBUG_ERROR, "\n")); + DEBUG ((DEBUG_INFO, "\n")); PrintCmObjDesc ( Data, Parser[Index].SubObjParser, @@ -912,14 +912,14 @@ PrintCmObjDesc ( } else { ASSERT (0); DEBUG (( - DEBUG_ERROR, + DEBUG_INFO, "\nERROR: %a: CANNOT PARSE THIS FIELD, Field Length =3D %d\n", Parser[Index].NameStr, Parser[Index].Length )); } =20 - DEBUG ((DEBUG_ERROR, "\n")); + DEBUG ((DEBUG_INFO, "\n")); Data =3D (UINT8 *)Data + Parser[Index].Length; } // for } @@ -978,7 +978,7 @@ ParseCmObjDesc ( =20 for (ObjIndex =3D 0; ObjIndex < ObjectCount; ObjIndex++) { DEBUG (( - DEBUG_ERROR, + DEBUG_INFO, "\n%-*a [%d/%d]:\n", OUTPUT_FIELD_COLUMN_WIDTH, ParserArray->ObjectName, --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101445): https://edk2.groups.io/g/devel/message/101445 Mute This Topic: https://groups.io/mt/97731605/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 16 12:47:00 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+101444+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1679321178759654.0082890283034; Mon, 20 Mar 2023 07:06:18 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 4VROYY1788612xv1T18cb1g9; Mon, 20 Mar 2023 07:06:18 -0700 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.48]) by mx.groups.io with SMTP id smtpd.web11.14924.1679321177143263334 for ; Mon, 20 Mar 2023 07:06:17 -0700 X-Received: from DU2PR04CA0056.eurprd04.prod.outlook.com (2603:10a6:10:234::31) by DB9PR08MB8625.eurprd08.prod.outlook.com (2603:10a6:10:3d3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.36; Mon, 20 Mar 2023 14:06:12 +0000 X-Received: from DBAEUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:234:cafe::20) by DU2PR04CA0056.outlook.office365.com (2603:10a6:10:234::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37 via Frontend Transport; Mon, 20 Mar 2023 14:06:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+101444+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT015.mail.protection.outlook.com (100.127.142.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.15 via Frontend Transport; Mon, 20 Mar 2023 14:06:12 +0000 X-Received: ("Tessian outbound b29c0599cbc9:v135"); Mon, 20 Mar 2023 14:06:12 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: a6542e2f8f3442bf X-CR-MTA-TID: 64aa7808 X-Received: from a38c4ea37dec.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5650A64C-687C-4D8A-B203-78C519D1E9D4.1; Mon, 20 Mar 2023 14:06:04 +0000 X-Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a38c4ea37dec.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 20 Mar 2023 14:06:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dy60x+xtlbh7WfFr9wnsf8uniOrU/JcYhYxddee7kpNhYsdth5YY93QV7CBJItXxnp8uqm3t3FUe0aNmWo4RLWlfaCg5+LuLkJct4kl7Q9qskhFmGdZy9a8VcXWxJwqMeQCljmiK957Y8KOE1J5iKhgfVI5/3OVq4jWZr6MH4spxCiHb0Hm/nhUD2RpNad8W8ohpE+b5QJoV8FGMWcBWqPNww0QudpTy9RcMJelBoOcqGQl23gKxpYmvJkPf6PNOig4D7KeQhXfKLoKaWZIuwsmq505TO44KaX/UMy7HuBYcO6X1XPXOagXVhoICY+K1JGkYH6xw4x5B58/mfGwZzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TROFG8ok0pN94vZiyw4yRqDJ6l/AGW6io+FJjUqgCd8=; b=Xr2h8BDePhnSO3cqwzuiWi+o//fnmi/MpJJsJ96cwNV5FU8ObWsnI7Dfwbx17C5C0guFmUOXRd+DC8ebenNVK7B5zu51SqzkHYMUrjckFI/oZHiJfb4Q7nH4VoiRSjevD1UBplK12g6wbyWLZmtB3v7RLgVTRqktxiwA4dfQrxto+Zw7sANtgmuDXUWql9y9THb8/+jY/f8f2dAKkCcRgnIb/ZQnFnJ6fRfGJepaDAcpXfXrilb07l9okd7JwVMVdM+3KUhQ7Vl+fZM6kuv/LARKR9BBod0CcJX7E95/pQqS2iQ2ZWtHK0x4rZYFIxpT2YdclOFeJjSBTGxlCzRG4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM6PR10CA0061.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::38) by PAVPR08MB9259.eurprd08.prod.outlook.com (2603:10a6:102:307::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Mon, 20 Mar 2023 14:06:02 +0000 X-Received: from AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:80:cafe::55) by AM6PR10CA0061.outlook.office365.com (2603:10a6:209:80::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37 via Frontend Transport; Mon, 20 Mar 2023 14:06:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT032.mail.protection.outlook.com (100.127.140.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6222.15 via Frontend Transport; Mon, 20 Mar 2023 14:06:02 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Mon, 20 Mar 2023 14:05:59 +0000 X-Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.17 via Frontend Transport; Mon, 20 Mar 2023 14:05:59 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , Subject: [edk2-devel] [PATCH v1 2/4] DynamicTablesPkg: Fix parsing of serial port node Date: Mon, 20 Mar 2023 14:05:55 +0000 Message-ID: <20230320140557.40348-3-sami.mujawar@arm.com> In-Reply-To: <20230320140557.40348-1-sami.mujawar@arm.com> References: <20230320140557.40348-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT032:EE_|PAVPR08MB9259:EE_|DBAEUR03FT015:EE_|DB9PR08MB8625:EE_ X-MS-Office365-Filtering-Correlation-Id: 4dc7478e-66be-4a19-03f4-08db294c4326 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: f4f/VFBkXiNWp7vtCFPY7imbQtNw3FfOTFW1shjGyl9Bk4xfWKdcGwEmreDhjJr0dXpU4g5KNw5nwJrXvDFcufFgbA4tM4NhG3EshD6YnzafsMQpiTwwJewmgL0DWiYEe26sb4zc0JM4c8bemppheZtmrrvLHt5B6aYP4z+3TocF5cgaTWiSwLvdBudpjrGfegDMy7jj7NsXSeEz1a9T/KzxJUezf26LtXBDAWeWEue7p2efTVHzlr7rD4aL1q0f+FNqq5f1wZEpRvakgvwKQbebyOb0OVwwfFAPeRAhu224aSTrE9X84md0OVmjWKIiwHWdYegObo0P7U2yAacgOnDZrD2KduogPWaRV1pleFtWWc5qg57RILElxkv4oRv4gQc3Px/ZdGks0BC8Iybdqo4SPbEgPZoAs/CG79ShkIcV8AJp9DMsUKbQNBSgDODcYpKH9LW+LEP6mSMlaLOPakTUyGHnQoLrXgRhnpmX1xeaB6Vg8OQl5TeUQj1E6+/G2rV7xoBOOGO4DybRLXHYOdfDnlyYU5jL8kQe7WTi0xpsAGL9qiINb+5n89iAwl75J4tcJj9FnPvV/MoYLTMX2NDjKyBm4Q+u0TElqOlCtBKp1ibK/JzhEnxYlvG65XGSAQEa2eTuokYBmfb9LX1V7Yfv2HpiV4oxjPQollTe/WkENTnoT24iNFWVyJYY006FNbLGbDhfdAHwkPHMYxaEkdqwYYazUwfoCPk3IXpEjPI= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(346002)(39860400002)(396003)(136003)(376002)(451199018)(40470700004)(36840700001)(46966006)(41300700001)(36860700001)(70586007)(70206006)(4326008)(8676002)(6916009)(8936002)(356005)(40480700001)(2906002)(81166007)(86362001)(82310400005)(36756003)(44832011)(5660300002)(40460700003)(82740400003)(7696005)(47076005)(426003)(186003)(1076003)(26005)(336012)(6666004)(316002)(478600001)(54906003)(2616005)(83380400001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9259 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 57a97419-163a-46fa-8f3e-08db294c3d6c X-Microsoft-Antispam-Message-Info: V0QprAXvh7BgJJHsQXWuDQ/0CDSqthvhSvLrQLSb+4ax8bG5dH9dyQt1ViD/PgNM0pEcJQJ7v+PACKGzUetI8+d0JB5l1aYoGIep+c7yDgPYGJkPy4CBxy1wyjh1rnZpTHcuXluZ7mGzgea864ssAjXW8jEcMd8cocSwXHbS5KyGcfUIKgKSS94MkouNz9eCOwVI4YxChLhIqhG6BIR22yKPZsnVFCrDt3E30YiXOClGD52WsAf8BWYaYXfhiDnUwbCCapH8ru7SDosq67cGznvGgD5BC757u25utfgBrd5OEfG/4Dn4wgkptdvkNhJpZ0uw1g6DB7xJxT0NpSe4VNCqYq7TwuhjeD/EJc0RGsw+kwMUqGL+To2saTGeVRN1u35fhp+cZAMWWgyuDoD4RXEtWhNo6qBQb2R2bn53Y8waZ4i5EjPj4QDjVzidUIJqgUaGHrigeciivjn5CsiuTq6mLpFIdueIi6JDkcBjDALuXxLAiaY8rIDFhfTnQYhuf1gV+kixf21JfeGFyR5GpFHdr5AfLwbuDsFa+98GwEi5LHOMPSOERftOjjwETvfHgLTWE97r48nloUFIejB3m7L4IYv/M2zCZ1geItD8nuyQUpBph8S2rC4duV9z63xZ6zUQI3FYH1AjHIGfGnY1DXxsoxI5wqcASogBCE0p/YPEqn5lVcFWMhXyJliD22xyiYUdBs7ka5BVh6rnOioDTA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 14:06:12.3719 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4dc7478e-66be-4a19-03f4-08db294c4326 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8625 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: 3QCpPMDQIpqU9ETb1OsqIC7Vx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1679321178; bh=ylgH6X3EFZzIp135DdIRyOv1mRBudl0IOqmd9lPwfv0=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=Ki6S0pmvz6A2+Qe4tmEN1AhSXJamTYrtkZh4+hvgxsq1II2t7iYPH/oU9YCcxExTmY2 bu47540toYDLIzCWseB1p0XWjsgBPKJYdzRF0DTpyzpSjsaS2Fjeo6VH1RNlPxbmei4Rn GIxKoTiZx7YLgcYSrXaw+r/E7kgdhwQt2eI= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1679321180370100002 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When scanning for the Serial Port in the device tree, the length and value parameters to ScanMem8() are not in the right order. This results in the serial port not being detected if the chosen node in the device tree has additional elements. Therefore, pass the parameters to ScanMem8() in the correct order to fix this issue. Signed-off-by: Sami Mujawar Reviewed-by: Ard Biesheuvel Reviewed-by: Pierre Gondois --- DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c |= 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPo= rtParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPo= rtParser.c index cfd032df4d746ad2a414a0258d99fe670f1928a2..732b482eebe3754543167e45737= e48242fddf065 100644 --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParse= r.c +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParse= r.c @@ -1,7 +1,7 @@ /** @file Arm Serial Port Parser. =20 - Copyright (c) 2021, ARM Limited. All rights reserved.
+ Copyright (c) 2021 - 2023, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 @par Reference(s): @@ -290,7 +290,7 @@ GetSerialConsoleNode ( } =20 // Determine the actual path length, as a colon terminates the path. - Path =3D ScanMem8 (Prop, ':', PropSize); + Path =3D ScanMem8 (Prop, PropSize, ':'); if (Path =3D=3D NULL) { PathLen =3D (UINT32)AsciiStrLen (Prop); } else { --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101444): https://edk2.groups.io/g/devel/message/101444 Mute This Topic: https://groups.io/mt/97731603/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 16 12:47:00 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+101448+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1679321188495262.4424825200771; Mon, 20 Mar 2023 07:06:28 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id l0l6YY1788612xqoIInu6IWq; Mon, 20 Mar 2023 07:06:28 -0700 X-Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.67]) by mx.groups.io with SMTP id smtpd.web10.14874.1679321187241735677 for ; Mon, 20 Mar 2023 07:06:27 -0700 X-Received: from DB6PR0202CA0018.eurprd02.prod.outlook.com (2603:10a6:4:29::28) by AM9PR08MB6642.eurprd08.prod.outlook.com (2603:10a6:20b:2ff::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Mon, 20 Mar 2023 14:06:14 +0000 X-Received: from DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:29:cafe::5) by DB6PR0202CA0018.outlook.office365.com (2603:10a6:4:29::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37 via Frontend Transport; Mon, 20 Mar 2023 14:06:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+101448+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT017.mail.protection.outlook.com (100.127.142.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.15 via Frontend Transport; Mon, 20 Mar 2023 14:06:14 +0000 X-Received: ("Tessian outbound cfb430c87a1e:v135"); Mon, 20 Mar 2023 14:06:14 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1cfbba2903aa2388 X-CR-MTA-TID: 64aa7808 X-Received: from 664f5b891a8f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D84EAE51-A542-4B29-9B13-50CCA5131A1F.1; Mon, 20 Mar 2023 14:06:08 +0000 X-Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 664f5b891a8f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 20 Mar 2023 14:06:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mN/tPeg6DORi8Casp4uF9PFwPAjhPjmmi+py6bYSoQUdtRHkH35XFHtf2VLSn0QgY7AoGFVGHVH9rjKfycrzFAvU7eZeu+cOynlpT0aeK+xVeuCqNmNSHALcT42paHYJj4KTXFdDjo95HwZlRe7P9Gt1mi0syurpz3NlplYjNbd282m3Ou5D46G2XlIwCktljwZ+6Gb9W2quikjm/VGBKE90D/Oo6TdbTomGdneHexO6eK/bfECjUqkzsAHdJVTkg2k16OvO3pLqoCeNw+W4lxST6zb+uBd0iMPNZ3v7HWG1iunW2SV9HJxMzGzZek2J1SM8XOQjL6lRHB6yOU7r6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dTdVq3wasCCtVEg6DzDKNjtdOCKGyMh+Q5UwEPWHULA=; b=OOLrHkd/idvzdY6opLUA0Wglg4o3QMR8U6FpIFQSjAwCsG6Uo/Db+5hEMkg9U16XswGQTNqT+1XH4QHSlqWDCp40qYF5NTY2b29jaOsj2WEBrYENlBPnzbGFl5GanOrfR4u9ZU34kzkkZyEGZ4xSDAzUeGZHi9gC5sTPknf1a1Jz0kbdspkTqUU3hxZVYr84k019CI/JnOL+c7351OLeU0RrsvtGVyEn6eomM/LYH+hBSuUqc1gLxws0gH0Do/HW0aal3qGBlcdu2PlxfaVARDs6J9Yg0mQWGTcTcHfVihqEI1fa/rdMWjx/mKLIGwu7L8NbljyaZO/Ina+y6H8Zog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM6PR10CA0072.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::49) by AS8PR08MB8468.eurprd08.prod.outlook.com (2603:10a6:20b:566::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Mon, 20 Mar 2023 14:06:03 +0000 X-Received: from AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:80:cafe::d1) by AM6PR10CA0072.outlook.office365.com (2603:10a6:209:80::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37 via Frontend Transport; Mon, 20 Mar 2023 14:06:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT032.mail.protection.outlook.com (100.127.140.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6222.15 via Frontend Transport; Mon, 20 Mar 2023 14:06:03 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Mon, 20 Mar 2023 14:06:00 +0000 X-Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.17 via Frontend Transport; Mon, 20 Mar 2023 14:06:00 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , Subject: [edk2-devel] [PATCH v1 3/4] ArmVirtPkg: Fix parsing of serial port node Date: Mon, 20 Mar 2023 14:05:56 +0000 Message-ID: <20230320140557.40348-4-sami.mujawar@arm.com> In-Reply-To: <20230320140557.40348-1-sami.mujawar@arm.com> References: <20230320140557.40348-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT032:EE_|AS8PR08MB8468:EE_|DBAEUR03FT017:EE_|AM9PR08MB6642:EE_ X-MS-Office365-Filtering-Correlation-Id: 2bfdfc52-f4ea-4a2c-930d-08db294c4453 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: e9xu3gW6W4gFvFL79pl41GFy7bDd51uWIkA4ieEYOkLTzfU4zBAd+J72mSPmWAiyvmRKN+lNLwaNtY0b26PjEPzfnJ+TA12JqiQlRkKVk3Yae1wrKxShMXajNWYVUcgFEPIJ9hg72adzsKe04UTSt28uqBSRPYdFmEqPklhcMwfVAK5bjnlHZsKajMdSEn6c5P0/qz5gK6fnWQbKcbZBKG80bSgSJp/SbbJ0am4cyUlVBduuD+3+qzZKrTJBStRl4HFslLH7SnRC7AamZPGbotDvbnh7mxT5AU4QLYT4Nb2GvGCmCoWouf2CBryMPXAZnqUGtSLRyC/+SuDqt9XhxCURDafB3cjt6ltXJ1GasU+9CRNSkz2SKuyxHJUpI88lCJXEb72vpBs2LmQK/oLuXhu02DVEtixc6liaMma+4bd96Zjo5L0rQCwkdzYXzZEZje4LhDxZqGRvE+y5HQHmQQtQX1eMBb0BI/JPhwCPQj7fYFVKjprF57pm2jDCLfOiSi0QRVcFTa7fHr6ztkNhkBptynWniDsf+CpWQpeVVlI44lYmGV90Xv6kI1s7whqRqrbnMKZxB6+7FRzfdb/E7I9s1COEVe5NalACszJhmZoBdb4A0tbPS38pV8TOmVKmOHiIK5MVINbkRMa73VexD60XNpQFD1rJtiUwjhDjK4ZWsJsMgftEh4MbL7c7m32yKG6O/ZFd6Mizp4q5xveNZnozAwyk0qQYdFJpO/Am588= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(396003)(346002)(376002)(136003)(39860400002)(451199018)(46966006)(36840700001)(40470700004)(44832011)(8936002)(41300700001)(5660300002)(4326008)(36860700001)(40480700001)(356005)(86362001)(82310400005)(36756003)(40460700003)(82740400003)(81166007)(2906002)(83380400001)(1076003)(478600001)(47076005)(6666004)(7696005)(426003)(186003)(336012)(26005)(8676002)(70586007)(70206006)(6916009)(2616005)(54906003)(316002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8468 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5f10a217-47ad-4f38-1267-08db294c3dd3 X-Microsoft-Antispam-Message-Info: 6qRJ1EO8i0qcdBOQrKh/+iEZy8Ukv26cjYRiSVTikGTXCSHTRL1cj0Z7DzCtZ4eKfFVn73UMtc8FCRG8WEnGMcQVGOagiT0NgLsSvpI4AyNIodsCIQc5Fu9qCaH3CYycpmC3hGh8jBkYvVt1EKSWGuAAVwIdd0CLtyddJSx2UDZidmGsB31yA4iVBdsa6RyVOjU9fTiGzNrqkQckX68xsdQU/Mk7zQ5m5UfYJ4N4R6e322cz3496Yh60IgQAhrBrs5SwTmKDOfScRIpt96b4+mwcQNM0gaG5prGuqsT3BniYsGFYOjfdV3igaJx0+9sjgv6xEg9rs3hwfg7yw+J83Njw+B/LLHoj0gagcgDrEA7N8U5IpJY6mI4ENLyitdox1KF257bMmEriLK1MSPRAhHc8ZgQ2SpjUoNEyqWr8UmG4H8RnRWDKrTTt6yCI3oL6vVKWlEjF+ApEDTnxdWaffQTaJZK3pzNbMMey7KS+3EpvXQsBppQmyFwZDRuEdl03/rieZ9FgiwXiWJus0YGvKQfNIDrge+YIkm8QF0Rae5Wh5PxO73sYYIcPyV1DdPZj+8JijdqFm6OXbdQk0Op4jokzxdpiTJjmFIKvAaMcbgKhhAHLlednkal6N+vNru9Cw+HhENRyO4jCy+RXuPCznNeib5Qde02a2U0Qn1FBZuzZyaY8+DCKr71mtrzXDPLiMS4m5cOXLAbzAtVidIxOgA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 14:06:14.3638 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2bfdfc52-f4ea-4a2c-930d-08db294c4453 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6642 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: O9Vt0iQ8Unw98Qu69zdw3fWSx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1679321188; bh=MkLSppTSDTw5uvNP/eXlL0dPqvZJ/60xTNs7XBd82Ks=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=FCAzD0h4kU2OJkI7XW+6DxYB5xOGAM0Y9QkIO/El9rigB1d/U8IalHkvABjTcofHIB5 JItiC6jp+aLquRkNNeum/9zzGnFn2IAaeQHW2DCTYxtah8nnDATXnhbWx99bVwClDke3v eK6F4Dcm73qerZRXCDANKm6pPmeLRy1sirY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1679321190425100002 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When scanning for the Serial Port in the device tree, the length and value parameters to ScanMem8() are not in the right order. This results in the serial port not being detected if the chosen node in the device tree has additional elements. Therefore, pass the parameters to ScanMem8() in the correct order to fix this issue. Signed-off-by: Sami Mujawar Reviewed-by: Ard Biesheuvel Reviewed-by: Pierre Gondois --- ArmVirtPkg/Library/Fdt16550SerialPortHookLib/EarlyFdt16550SerialPortHookLi= b.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmVirtPkg/Library/Fdt16550SerialPortHookLib/EarlyFdt16550Seri= alPortHookLib.c b/ArmVirtPkg/Library/Fdt16550SerialPortHookLib/EarlyFdt1655= 0SerialPortHookLib.c index fb1daf32769c20521e93de7af0f54a6a8e2c8369..c1b81920214b16137fd7c40b8ec= 897031e6fe9aa 100644 --- a/ArmVirtPkg/Library/Fdt16550SerialPortHookLib/EarlyFdt16550SerialPortH= ookLib.c +++ b/ArmVirtPkg/Library/Fdt16550SerialPortHookLib/EarlyFdt16550SerialPortH= ookLib.c @@ -1,7 +1,7 @@ /** @file Early Platform Hook Library instance for 16550 Uart. =20 - Copyright (c) 2020, ARM Ltd. All rights reserved.
+ Copyright (c) 2020 - 2023, Arm Ltd. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -67,7 +67,7 @@ GetSerialConsolePortAddress ( } =20 // Determine the actual path length, as a colon terminates the path. - Path =3D ScanMem8 (Prop, ':', PropSize); + Path =3D ScanMem8 (Prop, PropSize, ':'); if (Path =3D=3D NULL) { PathLen =3D AsciiStrLen (Prop); } else { --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101448): https://edk2.groups.io/g/devel/message/101448 Mute This Topic: https://groups.io/mt/97731610/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 16 12:47:00 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+101447+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1679321185234981.1150310701541; Mon, 20 Mar 2023 07:06:25 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id baufYY1788612x0jLIoNjbt3; Mon, 20 Mar 2023 07:06:24 -0700 X-Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.71]) by mx.groups.io with SMTP id smtpd.web10.14870.1679321183110790379 for ; Mon, 20 Mar 2023 07:06:23 -0700 X-Received: from DB7PR02CA0031.eurprd02.prod.outlook.com (2603:10a6:10:52::44) by GV1PR08MB8428.eurprd08.prod.outlook.com (2603:10a6:150:81::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Mon, 20 Mar 2023 14:06:12 +0000 X-Received: from DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:52:cafe::94) by DB7PR02CA0031.outlook.office365.com (2603:10a6:10:52::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37 via Frontend Transport; Mon, 20 Mar 2023 14:06:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+101447+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT018.mail.protection.outlook.com (100.127.142.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.15 via Frontend Transport; Mon, 20 Mar 2023 14:06:12 +0000 X-Received: ("Tessian outbound 0df938784972:v135"); Mon, 20 Mar 2023 14:06:12 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 0f2c6256a5e538e9 X-CR-MTA-TID: 64aa7808 X-Received: from 565ce9f5b697.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A7DCAF5D-00CC-47DC-B9FD-99C4CCBC4D4B.1; Mon, 20 Mar 2023 14:06:05 +0000 X-Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 565ce9f5b697.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 20 Mar 2023 14:06:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gk23BXyPHK83IIDCmCfMxIompew5s8SdueRzfCjIB5VW2LC8zCuM2sE2dlZxw9k0hkD+SLwFiAIsUKDzxfX3TD7JO8/sp00YfknLeHaFi49ct1cK4N4Muf7JKXkCuN6rVPRdQP6J7xtn4vRDUCRnXI4+UWwM7YT4te9R/wmqbW1EBo4o3jeupfq8rb5Ho8oB5hRa147hcJbXCcNQ7GZMdGrJ+9C/CmvDwdAcEhvoUJ+LLJ/BOos1IFLM2mrz8YgwB3xjYzzKjtdObzs/k3IjxqEwtdyXehui5814i60U6NWU4wkPNBgNHalEP+MDSKe7tPo7bJXJy8mUCrVuyQMdGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=713TpG/s0maCS3KQ0O/0j9Vqv8XC94aTmAJg2qn3C0M=; b=ArR0miokoFu/OgLw68xkHkKkmZaofS1SyQSYBrwsIu7LtWUGaFSPMwvTn2OrLRB6qUzwYFKZi32VYOoHqmL4yB6LXkLCy8oAVBK8s4q0LuighaoJDMcc5gqzm9EeaHcf34CLAQ3VfEBK37ugOFqxW93yckn9TX5+dvDvzzX3q11F4h6CddU1bzJ2eQpRpMty5l/y6NXWrYCu7QPTxh6Aq83JVn+Fl0tVvz1yLqMw8QMoft47R1Hjc06hmPFQWVhFfF0gLPh0JIwlq4/7IdiFK64XeRhaJptyJfRNJn7uge8xvcf00lDvsoU6SksZP79I1s/pqYHbjnXdRa6Vbrd1fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AS9PR06CA0640.eurprd06.prod.outlook.com (2603:10a6:20b:46f::8) by GV2PR08MB9253.eurprd08.prod.outlook.com (2603:10a6:150:e3::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Mon, 20 Mar 2023 14:05:57 +0000 X-Received: from AM7EUR03FT048.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46f:cafe::75) by AS9PR06CA0640.outlook.office365.com (2603:10a6:20b:46f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37 via Frontend Transport; Mon, 20 Mar 2023 14:06:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT048.mail.protection.outlook.com (100.127.140.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6222.15 via Frontend Transport; Mon, 20 Mar 2023 14:06:01 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Mon, 20 Mar 2023 14:06:00 +0000 X-Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.17 via Frontend Transport; Mon, 20 Mar 2023 14:06:00 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , Subject: [edk2-devel] [PATCH v1 4/4] ArmVirtPkg: Fix depex in kvmtool guest Rtc library Date: Mon, 20 Mar 2023 14:05:57 +0000 Message-ID: <20230320140557.40348-5-sami.mujawar@arm.com> In-Reply-To: <20230320140557.40348-1-sami.mujawar@arm.com> References: <20230320140557.40348-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT048:EE_|GV2PR08MB9253:EE_|DBAEUR03FT018:EE_|GV1PR08MB8428:EE_ X-MS-Office365-Filtering-Correlation-Id: 58eb7efc-7eaa-4b08-048b-08db294c42fb x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: HM1Fn0VF7drB1ziUTAtlXF7cqmghMf+P2/UEQrabRYyFxG3TA8scL+jFw/QTAE8hFH2Fkn0DVno8F/BvC9Dxt8roJIkBmi0WhyNxfTlSI59t8YKCp2tC2DLqb0q7iqjP8XG/sC1eoah2+OWoKdDBFey1XRBnsu85diywc8BCoxbOoV4Cick4pT+2TLZBtNdKGfVokGMwK1PKv/wTExbNkY/SbkhqNKQeOTJpz/b5Xr+mAGQOO9Iue0M99i/HFaYRktd+cgqwrGkGogx+FzZygvV82cSe/ScYUiykDMWOVUvCskEsbeC/yTNeJmZdjCAumktU7TDzJFYKZ8V6AlvAlhuB0D+3CGj2LmMF1/jXAdPxZotvoiE7FmyOFwBwPgzuU9X5mb9Vz1zWVThQXp40FgXqPYmCfdCoyS2KIzE34lu2I29fzOoMxpYn8v8a8y24kQfsiC1WPC7EeVO2dqEpFU4cPbWAVRO4bLdNKDHtmZoRQimMEL2RdyVHnhc82AfKAXM6zEBR6MBzex+e7t8scMKpMBGKbwDBZicqHcc0Su87iyUxaDvtQV+NAyvQ3BnA44ZheeFIeYr2O43eghMJRBI8hYKIo4a+3F48c7Q3sP8YV7MaDhX54meFKx4xlJ6VnzWXlTA65QpfeVMEHtIdD2Dbxterdv6boQH1nfqM0BfnfxHQ74Z1NHKZZT3sZJo8J3wzHz660POmdiwKgU4brS7sHmxPVCk+MiI8VXWPL4E= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(136003)(376002)(346002)(396003)(451199018)(40470700004)(46966006)(36840700001)(86362001)(356005)(36860700001)(1076003)(82740400003)(81166007)(4326008)(36756003)(26005)(5660300002)(8676002)(44832011)(2906002)(70586007)(70206006)(8936002)(82310400005)(41300700001)(47076005)(336012)(40460700003)(2616005)(186003)(426003)(83380400001)(54906003)(478600001)(316002)(6916009)(40480700001)(6666004)(7696005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9253 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1e3fbef1-f779-4d6f-ee9f-08db294c3cc1 X-Microsoft-Antispam-Message-Info: mOlVHaM1pHSGtxzgfQp54O+1Q0NMwklHpBlSLDCjTAQrGZIP+VKCfC+VVxp59WAjEDrEAVayDcMgOELYKj3E1bhmJECU8FvXg5OVD7oTV9tywX9xaYs6YxkCFLLbyoF8bLQ3Av/z/TdDrkY+NiDkCq1hwWvzgKuJG6QaMjTQ5cPL0BWSMtz89gvgxJy8jyZEF1LOsH1mGy5K2TS2xmkk4PWmNGJYKjEC2iKc10LfdbvXBLai9BZmyL1X2TZG5YcSPs399SI1ai7+pPDALCztDHwrhqjF3vnBOmImFb8iJ/W1d3jxmb3KwMww4xg87Gp5uJq4A+tpqyJHqoeqWtcdhqFSJ1HCsLJLhPb3iZLRmFBSDCDUKNENKWAFfuT0LiInF9u4ICUc0y9zXUBCvwIy1vhFADWdLPY/6vBm+FM5/nNWPxp59VX+DKbcmvmMqWUIHxGLDFLrf3S/yBE8p68L1kDrctPBis0O7/zsBKjtG6OqHDkS2nQY1+7+bxE5LWrvMOzdw1tb31g/8dMSVWKVMPl+0LVPCLVydsrTPqLvtjE4ADx4+8g3z/iA4mayih+laXfd9X9fILhJ25SnyGJCpumpw6N9HZQPV4B8gPPVvAzEnJ/4+QfdKz5ZY6wwqZ0d7CSBcPsc+VbKp2SIGMdKp/BXg7RMC8K4w+fnolT7bZiTABbs5rK3V+jd4T5eRy1YgWs0K184MCis2NfoDILZVg== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 14:06:12.1057 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 58eb7efc-7eaa-4b08-048b-08db294c42fb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8428 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: o3cS95sozAbRpD9UzSNWju6xx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1679321184; bh=Ewb+KNOxWo4jx4czxzldfrnx6X7symp1jGi2ODiTKsE=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=X6tgPaXo62jxosTg6IafJjNzy6u3GBMzeaHXtdqqzJzpd54P126Hr7oJ7aDsbY00bKA 5fSgPrBNjjekc05EqEFMLwanf0SfzIOi2P9PPYzWZRVHezePamrvvhmYaafeGQKL+LIPR LO0cYIKafQZBinipgAKoIr0tVyoAmLfkRUQ= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1679321186420100004 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Rtc library for the kvmtool guest firmware configures the RTC controller address range as runtime memory by calling the gDS->SetMemorySpaceAttributes(). The SetMemorySpaceAttributes() function has a dependency on the CPU Arch Protocol. If the CPU Arch Protocol is not installed the call to set the memory attributes fails with error code EFI_NOT_AVAILABLE_YET. Therefore, set the library dependency on the CPU Arch protocol. Signed-off-by: Sami Mujawar Reviewed-by: Ard Biesheuvel Reviewed-by: Pierre Gondois --- ArmVirtPkg/Library/KvmtoolRtcFdtClientLib/KvmtoolRtcFdtClientLib.inf | 4 += +-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmVirtPkg/Library/KvmtoolRtcFdtClientLib/KvmtoolRtcFdtClientL= ib.inf b/ArmVirtPkg/Library/KvmtoolRtcFdtClientLib/KvmtoolRtcFdtClientLib.i= nf index f0a7c19ca5f4b5a8eeab08af64175ae6f3526b12..c10a6737a0736b11a8f45b661f8= ac38948cb40b0 100644 --- a/ArmVirtPkg/Library/KvmtoolRtcFdtClientLib/KvmtoolRtcFdtClientLib.inf +++ b/ArmVirtPkg/Library/KvmtoolRtcFdtClientLib/KvmtoolRtcFdtClientLib.inf @@ -1,7 +1,7 @@ ## @file # FDT client library for motorola,mc146818 RTC driver # -# Copyright (c) 2020, ARM Limited. All rights reserved.
+# Copyright (c) 2020 - 2023, ARM Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -40,4 +40,4 @@ [Pcd] gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister64 =20 [Depex] - gFdtClientProtocolGuid + gFdtClientProtocolGuid AND gEfiCpuArchProtocolGuid --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101447): https://edk2.groups.io/g/devel/message/101447 Mute This Topic: https://groups.io/mt/97731607/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-