From nobody Fri Apr 19 04:33:57 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+101356+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+101356+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1679073669; cv=none; d=zohomail.com; s=zohoarc; b=FOAjyUef4rAs4zWzPvNy7V0SiENzfLO7R6z3zFHN/TPLoM+3/LJjHc5ijx0oRn5Fe6JyKl+10kg0G7JWu9S6HhTIgurbS4RgLsQGE7L/C2v0+LxAc3RnXyvn3ee8TAkZzs6YWGhliP7ZDBtfB7pNj9onSBbfvzFd85YmC+HufQc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679073669; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=jOaqvzdklvz2XmRvYQBJP5XHKZoMYpEf5qbZhY0JAm4=; b=IhnzD25YXW06WmjXV80+kR85sL4kmkbj2VQubts56WA+kiw6JVqK1zi/OnrJtN+ejEH+cqRA/F6ED0h0re3tAMPt5wifb7CIyoQajuF7oDqlqmwZVzNB+ioZm7pbRrabRf2prXimJlluK2BcXcy1YXgZTj9IJyNLglGtkeSDz1o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+101356+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1679073669546387.84915223604025; Fri, 17 Mar 2023 10:21:09 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 88gXYY1788612xB7sBIVB9qF; Fri, 17 Mar 2023 10:21:09 -0700 X-Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web11.25557.1679073665728174314 for ; Fri, 17 Mar 2023 10:21:06 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10652"; a="337019654" X-IronPort-AV: E=Sophos;i="5.98,268,1673942400"; d="scan'208";a="337019654" X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2023 10:21:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10652"; a="744618402" X-IronPort-AV: E=Sophos;i="5.98,268,1673942400"; d="scan'208";a="744618402" X-Received: from cchiu4-mobl.gar.corp.intel.com ([10.252.136.175]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2023 10:21:02 -0700 From: "Chiu, Chasel" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Star Zeng Subject: [edk2-devel] [PATCH v2] IntelFsp2Pkg: Fix NASM X64 build warnings. Date: Fri, 17 Mar 2023 10:20:50 -0700 Message-Id: <20230317172050.1228-1-chasel.chiu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,chasel.chiu@intel.com X-Gm-Message-State: UcqVikQn3ZM9Z6nNyenIxXTLx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1679073669; bh=yd6IVVfhj7h5Xy0Xk2AQahwJGZbgN8Tjl67rCoubMTo=; h=Cc:Date:From:Reply-To:Subject:To; b=YN+XeoKVZtu7+kgw6OKgkxYIlQi8dn+jyq8hezskLwZoQ0ZPFNXnLqd+AvfLTn/nj05 tewQXpktoVnK5V93z0eo2lJU43kfC/E20Tvu9P//O452Gdesy/4CNQqYkRF2unk2XAl/n eOhKnH5FPIBCXkotQivnGfC5qhSuUxBjKyw= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1679073670371100001 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4377 Fix below warnings generated by NASM X64 build: /X64/FspHelper.iii:26: warning: signed dword value exceeds bounds /X64/FspHelper.iii:35: warning: signed dword value exceeds bounds /X64/FspApiEntryT.iii:320: warning: dword data exceeds bounds Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu --- IntelFsp2Pkg/FspSecCore/X64/FspApiEntryT.nasm | 4 ++-- IntelFsp2Pkg/FspSecCore/X64/FspHelper.nasm | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/IntelFsp2Pkg/FspSecCore/X64/FspApiEntryT.nasm b/IntelFsp2Pkg/F= spSecCore/X64/FspApiEntryT.nasm index cdebe90fab..56d6abaea6 100644 --- a/IntelFsp2Pkg/FspSecCore/X64/FspApiEntryT.nasm +++ b/IntelFsp2Pkg/FspSecCore/X64/FspApiEntryT.nasm @@ -317,7 +317,7 @@ Done: xor eax, eax cmp edx, 0 jnz Exit2 - mov eax, 0800000000000000Eh + mov rax, 0800000000000000Eh =20 Exit2: jmp rbp @@ -464,7 +464,7 @@ ParamValid: ; Sec Platform Init ; CALL_YMM ASM_PFX(SecPlatformInit) - cmp eax, 0 + cmp rax, 0 jnz TempRamInitExit =20 ; Load microcode diff --git a/IntelFsp2Pkg/FspSecCore/X64/FspHelper.nasm b/IntelFsp2Pkg/FspS= ecCore/X64/FspHelper.nasm index 71624a3aad..ec9140b73c 100644 --- a/IntelFsp2Pkg/FspSecCore/X64/FspHelper.nasm +++ b/IntelFsp2Pkg/FspSecCore/X64/FspHelper.nasm @@ -23,7 +23,7 @@ ASM_PFX(AsmGetFspInfoHeader): global ASM_PFX(FspInfoHeaderRelativeOff) ASM_PFX(FspInfoHeaderRelativeOff): DD 0x12345678 ; This value must be patched by the buil= d script - and rax, 0xffffffff + mov eax, eax ; equal to and rax, 0xFFFFFFFF ret =20 global ASM_PFX(AsmGetFspInfoHeaderNoStack) @@ -32,5 +32,5 @@ ASM_PFX(AsmGetFspInfoHeaderNoStack): lea rcx, [ASM_PFX(FspInfoHeaderRelativeOff)] mov ecx, [rcx] sub rax, rcx - and rax, 0xffffffff + mov eax, eax ; equal to and rax, 0xFFFFFFFF jmp rdi --=20 2.35.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101356): https://edk2.groups.io/g/devel/message/101356 Mute This Topic: https://groups.io/mt/97678369/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-