From nobody Mon Sep 16 19:29:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+101231+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+101231+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1678882761; cv=none; d=zohomail.com; s=zohoarc; b=eloXwP1RKZkLfd2UAObNS+4xw19OwdxkeKES5p5GmSRw39BvVGBIZ8qSfUl/dLhoyxps6JxCg0bDUSy6U/CMHge/CvQ2yPFwPPERZBSWMBTUADeENqihpCJrxUGw/uSm1dgAu3Bf/tgsqzy2jqvlMwWYnvT5LEtPx3C1kZkVjKg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1678882761; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=ZEvqPsjjj3x/icdMWxRtTYq3CAFxfZ/NfZqXQNyFJUU=; b=jaf3Kt9EQzudeYhMd2t47nFvS3nvw9M0kApZyFZLR4ls5Neca3odjJ0tOzTC/xnKN8PWZujqV30ofzFw3cNXCB19C6HjMilXmi0CLDF+yi3jZjGNkzyvsHmGxOqSeLZHXI6gSUXPtjl2j9Q1tKBNmGAjp1UDHOURZcSfzQ+LgGI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+101231+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1678882761324312.9118851038163; Wed, 15 Mar 2023 05:19:21 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id MgxjYY1788612x73rEzXvU9Q; Wed, 15 Mar 2023 05:19:20 -0700 X-Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mx.groups.io with SMTP id smtpd.web10.6316.1678882760274514769 for ; Wed, 15 Mar 2023 05:19:20 -0700 X-Received: by mail-pf1-f180.google.com with SMTP id z11so11579737pfh.4 for ; Wed, 15 Mar 2023 05:19:20 -0700 (PDT) X-Gm-Message-State: 1wbN2hLzwsf6mS9Ybj7RUsLOx1787277AA= X-Google-Smtp-Source: AK7set+9ibG/4QL1+BxeIFiMEtxp7d1k3Lo2Q0APHUTZ198lbtKNUIt+bDLuJ8OBNlAW+GwAC7TldA== X-Received: by 2002:aa7:9a02:0:b0:625:d515:58f3 with SMTP id w2-20020aa79a02000000b00625d51558f3mr134426pfj.17.1678882759553; Wed, 15 Mar 2023 05:19:19 -0700 (PDT) X-Received: from dhaval.ba.rivosinc.com ([171.76.81.12]) by smtp.gmail.com with ESMTPSA id d13-20020aa7814d000000b005dd98927cc5sm3382239pfn.76.2023.03.15.05.19.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 05:19:19 -0700 (PDT) From: "Dhaval Sharma" To: devel@edk2.groups.io Cc: Guo Dong , Ray Ni , Sean Rhodes , James Lu , Gua Guo Subject: [edk2-devel] [PATCH v4 1/2] UefiPayloadPkg: Remove FP Init from UPL entry Date: Wed, 15 Mar 2023 17:49:12 +0530 Message-Id: <20230315121913.119025-2-dhaval@rivosinc.com> In-Reply-To: <20230315121913.119025-1-dhaval@rivosinc.com> References: <20230315121913.119025-1-dhaval@rivosinc.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,dhaval@rivosinc.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1678882760; bh=Z6A+0fe7MLRlFIXMAnPMAv8IpFXzF7JjajDAYDvSd6s=; h=Cc:Date:From:Reply-To:Subject:To; b=aLuzX2AjiDJbPq5ouauW5USyTgGn1yJcCmXTdgaXKlLz/3HJ0uZsVI49xVNLnb534MX eoOB/uyZNVUReNkabHC2TS5UKPErT90sblmxbeKMP0Mu6ycAcOKkLp/VTpQhynNzpRawL 3DclC0jjc2NB/RkXG8dxSQRPDV5awwsTHzo= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1678882762590100006 Content-Type: text/plain; charset="utf-8" According to UPL spec BL should initialize FP init meaning UPL does not need to initialize it. Besides this is arch specific init and needs to be moved out of UPL common flow. In order to not break current BL implementations, for now just moving the init to later point of time but for both x32 and x64 eventually this should be removed once BL impelement this logic. Test: Verified booting UEFI shell on coreboot on qemu. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: Dhaval Sharma Reviewed-by: Gua Guo Reviewed-by: James Lu --- Notes: v3: - Added FP initialization to X64 path as well v4: - Updated reviewed-by tag UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c | 3 +++ UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 3 --- UefiPayloadPkg/UefiPayloadEntry/X64/DxeLoadFunc.c | 3 +++ 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c b/UefiPaylo= adPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c index c66e56aee15a..9d2bfb2fa654 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c +++ b/UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c @@ -268,6 +268,9 @@ HandOffToDxeCore ( UINT32 Index; X64_IDT_TABLE *IdtTableForX64; =20 + // Initialize floating point operating environment to be compliant with = UEFI spec. + InitializeFloatingPointUnits (); + // // Clear page 0 and mark it as allocated if NULL pointer detection is en= abled. // diff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c b/Uefi= PayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c index 46ee27c905e9..07f4c1d29686 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c +++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c @@ -470,9 +470,6 @@ _ModuleEntryPoint ( PrintHob (mHobList); ); =20 - // Initialize floating point operating environment to be compliant with = UEFI spec. - InitializeFloatingPointUnits (); - // Build HOB based on information from Bootloader Status =3D BuildHobs (BootloaderParameter, &DxeFv); ASSERT_EFI_ERROR (Status); diff --git a/UefiPayloadPkg/UefiPayloadEntry/X64/DxeLoadFunc.c b/UefiPayloa= dPkg/UefiPayloadEntry/X64/DxeLoadFunc.c index 346e3feb0459..84a6112ce64a 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/X64/DxeLoadFunc.c +++ b/UefiPayloadPkg/UefiPayloadEntry/X64/DxeLoadFunc.c @@ -40,6 +40,9 @@ HandOffToDxeCore ( VOID *GhcbBase; UINTN GhcbSize; =20 + // Initialize floating point operating environment to be compliant with = UEFI spec. + InitializeFloatingPointUnits (); + // // Clear page 0 and mark it as allocated if NULL pointer detection is en= abled. // --=20 2.40.0.rc0.57.g454dfcbddf -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101231): https://edk2.groups.io/g/devel/message/101231 Mute This Topic: https://groups.io/mt/97625906/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-