From nobody Mon Sep 16 19:25:31 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+101135+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+101135+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1678727939; cv=none; d=zohomail.com; s=zohoarc; b=WW0h/KLa4WDlp846+bp1I9v7n4Zv6cI6DSAl0uzgygq7Azyt9Q2Rrzh8mVDZYbf3ba5Yg2UbbSSmNBfhGxz8RilK5I80tBStidxjUxfMii+FvYGuD84ZIVVc5bNzvJ8gX3otqQ0tqiGe6j1K4N4zyZFBH6YKMiFazJ4KtlVeHeE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1678727939; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=uxT6lhLbtapEVfO2QwNZghxQbfWXgvt5uQo5x4QAGoU=; b=I5o+r0MHxjII8TQfnaeKTcAjN5eD0cIFDOr2nBRCkM9RbdM4vXGA+1RroiLXdBEmSpke/a6YAG9gELX4jmcNIGN86jlmth5vUkdLcKgyuzyiEtxw4DQPJ9B5smPL2FpeM85aerAq05C2JxqeTA+01QuG3IA0+NSD7+fjBCKulcg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+101135+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1678727939355546.3787307878492; Mon, 13 Mar 2023 10:18:59 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id QbzEYY1788612xoeRu9g4C7M; Mon, 13 Mar 2023 10:18:59 -0700 X-Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web11.26515.1678727938310544216 for ; Mon, 13 Mar 2023 10:18:58 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B7E25B811B3; Mon, 13 Mar 2023 17:18:56 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5451BC433A1; Mon, 13 Mar 2023 17:18:53 +0000 (UTC) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Michael Kinney , Liming Gao , Jiewen Yao , Michael Kubacki , Sean Brogan , Rebecca Cran , Leif Lindholm , Sami Mujawar , Taylor Beebe Subject: [edk2-devel] [PATCH v5 31/38] MdeModulePkg/DxeCore: Remove redundant DEBUG statements Date: Mon, 13 Mar 2023 18:17:07 +0100 Message-Id: <20230313171714.3866151-32-ardb@kernel.org> In-Reply-To: <20230313171714.3866151-1-ardb@kernel.org> References: <20230313171714.3866151-1-ardb@kernel.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org X-Gm-Message-State: F5GQXI1HHyJgrcopnN7jCmbxx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1678727939; bh=qBRF4AgB+337fW5Qrvk1d530xOAQkPBv4x85IToY7sA=; h=Cc:Date:From:Reply-To:Subject:To; b=frkAh20dRG4FrpuqU3eIGhyQwXgrf+7hoVVhMmHrVTBtHPnAHCbyPD5VwNxZmFjAF1Y wruzx+YUYLw86S786rVqN8Mpwoxy4e0XWuYv6b1H3GqhXarlwV3fe00PgllE/3boePZLv qXms7b0Dw+qS1IJxbu/oIeZLTv+Cofc+/NA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1678727940405100005 Content-Type: text/plain; charset="utf-8" The image name is printed at DEBUG_VERBOSE level already when entering the routine that enables the memory protections, so printing it again after issuing a warning is unnecessary - let's remove it. Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c b/MdeModulePkg/C= ore/Dxe/Misc/MemoryProtection.c index 8df3e881c5c4..85c5a6a7c758 100644 --- a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c +++ b/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c @@ -477,11 +477,6 @@ ProtectUefiImage ( "!!!!!!!! ProtectUefiImageCommon - Section Alignment(0x%x) is incor= rect !!!!!!!!\n", SectionAlignment )); - PdbPointer =3D PeCoffLoaderGetPdbPointer ((VOID *)(UINTN)ImageAddress); - if (PdbPointer !=3D NULL) { - DEBUG ((DEBUG_VERBOSE, "!!!!!!!! Image - %a !!!!!!!!\n", PdbPointe= r)); - } - goto Finish; } =20 @@ -558,11 +553,6 @@ ProtectUefiImage ( // of course). // DEBUG ((DEBUG_WARN, "!!!!!!!! ProtectUefiImageCommon - CodeSegmentCou= nt is 0 !!!!!!!!\n")); - PdbPointer =3D PeCoffLoaderGetPdbPointer ((VOID *)(UINTN)ImageAddress); - if (PdbPointer !=3D NULL) { - DEBUG ((DEBUG_WARN, "!!!!!!!! Image - %a !!!!!!!!\n", PdbPointer)); - } - goto Finish; } =20 --=20 2.39.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101135): https://edk2.groups.io/g/devel/message/101135 Mute This Topic: https://groups.io/mt/97586049/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-